Hyperlink's text field needs to be a multiline but that doesn't
look right on 90% of the case. So better to style it as if it was
an input field but keep it as a text area so multiline text selection
doesn't get pasted back as one super long line
Ideally: if the user selects multiple lines and the Ctrl + k it should
concatenate it only for the purpose of presenting it in the dialog but
then the text in the document should retain the multilinear aspect and
be clickable . < - this is impossible to have currently without
over engineering so probably best simply style it differently
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I640f148ffd5bd76592fb30dde5545e2c26eda016
There is an element displayed as a column before ratio
and we then hide it which is fine but, when ratio label
becomes to lengthly (Seitenverhältnis beibehalten) it then
gets cropped due to lack of space.
- Make it span across columns
- Do not align to the end
- Remove left margin from checkbox
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I02ec7a608c0b330a52fa70db3b453fe04fefa805
In some languages (de) some labels were being shifted and ultimately
cropped due to their length. Example: Using German; selecting an image
-> the 'Seitenverhältnis beibehalten' was being cropped
Remove padding for those labels when on the sidebar
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4097268682a1890543c9d2a8107e621ea15335c9
Before this commit, on chrome/mium, menus such as
image or save as in the tabbed view (and with the browser zoom
set to bellow 80%) were being displayed with scrollbars.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id32e86229fe5d7aad293d24a20c9bfa555fbe78b
Primary buttons, secondary buttons and others are getting styled
differently for the same 'disabled' status. Plus, they are react
on hover which can lead the user to wrongly think they are active.
- Fix inconsistencies and make it clear that they are all disabled
Example dialog: Find and replace
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I45be52ecda264d0af9a53a70c222d1047a3cdf73
Before this commit, the text in a dropdown could be overlapped by the
triangle (arrow). Example: Insert > Page number dialog
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I770acb10b89239bce280cf44ad56b9ec2c3a8264
Merge downloadas-pdf and exportpdf actions to have same functionality
on desktop and mobile view. Now we can see setup dialog on mobile view.
On mobide view Download as -> PDF should show PDF download
settings dialog before downloading the document same like
desktop view.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ib0dd3877973dae025e7a6d4f15f2fa26351ea369
Merge downloadas-epub and exportepub actions to have same functionality
on desktop and mobile view. Now we can see setup dialog on mobile view.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Iebe05e65f331de6737be88288fac34244cfcde18
with the introduction of showModal:
https://github.com/CollaboraOnline/online/pull/5518 we now have
a type of a dialog that, without this commit, can grow without
limits and can be as small as its content which is not ideal.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8768925377606924fd70fab8be40b0b755d802ac
While avoiding to add extra space to first elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia4102a783525e801e3adcd7dd8b621bb10ff2eb3
On Windows firefox auto setting is not handled properly. Scrollbar
flows on the sidebar elements. We use thin instead.
Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ife27f461639e6b034ac9071624d628cd35709191
Before this table columns were getting "glued" (content of one
col would end and immediately would start content of another col).
Plus, we were having table content normally aligned to th start
while headers were being centered aligned
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie0908c26d1e7bedc37b3c5d768d941b091946524
These have no effect on the ui-expander-content since they
are set to display: block somewhere else (jsdialogs.css)
plus, (and even testing with flex) this does not seem to improve
or fix anything
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0260f44413ff46f79b9ea6a15e154ee62fb1e53f
This commit was initially intended to affect sidebar but it is
affecting every toolbox (dialogs, formula bar) causing regression
in the formula bar buttons
This reverts commit c0302a8d93c183b90079e3c2cbe9c90220e93cdb.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie872d26ec7dcfb396c7ccba13dcbf6142655be7a
Before this commit, browsers such as chrome (without enabling
experimental features) were not supporting those float values
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2530e7bf46d161ac980559c181a4e03947edbeee
Remove citation search label and instead use placeholder
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0eef0cd9321babd7239b18b4fd5a422cc4d09831
Do not set sub container with a margin. This was resulting in
some elements (that are inside of that container) to be properly
contained but all the rest were being set without any surrounding
margins -> leading to misalignment
- Main jsdialog container shouldn't inherit lokdialog padding 0
- We do not need to specifically set `padding: .5em 1 em` because it
- has been already set and inherit from jquery ui CSS rules
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I957c93c099692a5bd202248731b16bc6bf358234
Fixes the misalignment, before this commit: the safe margin
present in every button was correct but for the cases where
the button is placed to the further left or further right
edge of the dialog -> it looked misaligned
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibadeaf6cf736b07229d60f99b5af72865f26e23f
some style may differ in languages
i.e: in APA style a citation may appears as (Abrikosov, n.d.) like "no date". When I switch language to Hungarian, it becomes (Abrikosov, é. n.) like "évszám nélkül".
language can be selected in document preference dialog
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ida1cd91b189fc468e0205e9f1e332238f3ebbe7b
add zotero UI only if user is logged in
when zotero citation edit button is clicked,
fetch the library with zotero API.
Let user select what to insert
at this stage its not a complete solution but just first stage
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id67d8409bcd6416994713acd9ace495b24823fb0
This also allow for one single shared place to have that
"margin"
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac46810ac4ef219a4103bc315722dbd95e6fd169
We can set those so, the total size is 28px (same as the
grid cell) while keeping svg 16px size this in turn centers
the icon within its parent
Also we can then use the same 5px (that we use for normal button
margin) for the column-gap so everything aligns well
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib13a376fe71e308f9146c291acfbe3a941a4ef57
We now use CSS grid and this rule is now not needed
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I65f5a1d05d0ac748c328c669e99be307c8721f3c
complete new structure of the jssidebar.css file
file is structured into sections
1. general
for general sidebar settings
2. expander section header
ui-expander classes
3. section content
biggest section
define the sidebar gap elements
first column justify-content: start
last column justify-content: end
4. widgets
general staff
4.1 widget width
defined widths
4.2 widget selected
style for
- selected,
- non-selected,
- hover
5. fixes
specific fixes
5.1 writer fixes
5.2 calc fixes
5.3 charts fixes
5.4 not available commands
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ia449544a671134abebdd4bebd347d20b119c964d
