Jenkins sometimes does not work properly and core
installation is not accessible for online build.
In this case the test build was passing without
actually run the tests. Fail on this instead to
avoid getting untested patches in the code repo.
Change-Id: I35c49562dfeaeda5f6c8aa4bd3a746b1f04de3ea
Let's check the canvas to exist and wait until the
first tile arrives and so the canvas is not fully
white.
Change-Id: I7102298a406d61246fc40a0842bafb2cd124d81e
Fixes problems particularly with the new Chrome where the original
approach to tiles can be causing blurry text.
Change-Id: Icf598df0e997d493b111fad1c59e7dcb5f376801
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103681
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
This use case is crashing now, so let's disable it
for now.
Change-Id: Ie63af52eed39c6235f628687f93372ef526319c6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103555
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
I reported the issue. Let's have a workaround until,
the bug fix is released.
Change-Id: I7d7719d311e0c0584b7d6e710286f28962d00a96
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103038
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Newly close button does not actually close the document,
but steps back to read only mode. So we need to push it
twice.
Change-Id: Ic38f1e658396d9afe49496cfb75aa68df1c4623f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102997
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's more effective, since it reruns only the failing test,
not the whole test suite. Also it has a nicer output.
Change-Id: I8a50a20366b76a5cedb4e9383220c53f367c5a68
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102995
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* Fixes random failures in interactive test runner.
* Introduces test retries, what we did with an own script so far.
Change-Id: Iab5c32e854618a694e7d10d3c92c1c6c32465983
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102991
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The application freezes with tables, beacuse of an
invalidate tiles loop. With php-proxy the lot of invalidate
tile messages blocks the execution.
Change-Id: Ife08b7cb335afc69108d970a8f0147be1ae9d90e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102892
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
For some reasion cypress image loading mechnism is not
working with php-proxy. Without cypress image insertion
works. So now I disable this test, later we can fix-up
cypress test to handle this scenario.
Change-Id: Id1b62f28b3f0cdfe9e26cc96dbafcbacbf472be8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102889
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Instead of selecting a column. Selecting a column means
1048576 cells, which makes things slow. While selecting a
row means only 1024 cells, which won't slow down the
execution. This issue becomes more visible with php-proxy
since it's even slower.
Change-Id: I67828dcba250b2d04053cd44c6f8c83e7a466792
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102749
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It could fail without php-proy too, but php-proxy
slows things down and makes this issue more visible.
Change-Id: I6bda9bfd195b28c797b0690e05cddf3f0ee98e12
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102750
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In NC environment we don't handle cy.document() and
cy.window() well. Disable related tests for now.
Change-Id: Ibb9a9783bf1718a030d10fc69f8b7653fb12bc15
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102471
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
'1033' means en-US here, but we don't need to test this,
so it won't be a problem to have a different local settings
inside NC.
Change-Id: Ifcd3798b7356b7d80a994f9d00280a6039cea5a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102470
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We could not remove the existing test file, if there are
a lots of files in the NC storage, because in this case
not all files were displayed on the screen and so we could
not know whether the file was there or not.
So instead we remove all files, what we can do easily.
Change-Id: Iae7a8ee5c2064ecd94c29d990b7507001827b0dc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102469
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To run mobile test with php-proxy simulation.
It's an initial command, should be improved later,
after php proxy simulation nicely works with the
tests.
Change-Id: Id9d2bacfbf09ca34a2c84e0d32808749df4c1909
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102321
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use hash to identify download and pass that to the client.
This allows us to reduce parameters for download requests.
DocBroker maps download ids to URL in the file system.
Change-Id: I254d4f0ccaf3cff9f038a817c8162510ae228bc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101992
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Instead of using a click() and a dblclick() method, do
click() repeatedly, until selection is actually removed.
For example, it takes ony click when the shape is selected,
but no text is selected inside it. It takes two clicks when
a text also selected and sometimes when selection stucks it
takes even more click.
Change-Id: Ic017d0f5b623de29343cf171a8f4d64988fdb721
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100756
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Sometimes double clicking inside the shape does
not makes the shape to step into text editing mode.
To avoid this kind of issue, we can click more times
until we get the cursor.
Change-Id: I4a9671c299144bd8ca250b575665538ab14758ad
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100755
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
A bug occures when we remove a column selcetion.
The document freezes for seconds before it is
updated. Let's workaround it in cypress tests,
until it's fixed.
Change-Id: I5436c969655260d377d4ce47c86270ef15a15c2f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100740
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It seems there is a bug in sidebar showing code,
that it's not always shown by opening a document.
So instead of checking the visibility of sidebar,
just wait some time to finish document load.
Change-Id: I9d94b7fe085f4dfcf366789e27ab1bb388bf13b1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100675
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
First grab the focus to the textarea, otherwise
the force: true flag leads to unexpected behavior.
Change-Id: Ic99bb1b22734733d7bb40b895173e5382c2ba5f4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100605
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Searching '-8px,' is not stable, because sometimes it's
'-9px,'.
Change-Id: I6226a1ec3086b84540d74cb1c7691cf355752337
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100600
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It was not consistent what we used to type into the
document (e.g. 'body', 'textarea.clipboard' or
'#document-container'). Also we need to use force
parameter because 'textarea.clipboard' has no actual area
which makes cypress fail with: '`cy.type()` failed because
the center of this element is hidden from view'.
Change-Id: I04e0a82ed8450d583e407715fde1855197cae109
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100574
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
A known issue is that when the sidebar is updated
the focus is grabbed from the search field.
Change-Id: I762de7c6498f5b015465af325a24996719caeae1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100477
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The sidebar is opened after the document is opened.
Opening the sidebar affects the whole layout, so better
to wait until it's finished before we start to interact
with the document.
Change-Id: I15537e8823d1c6c80fb586eb3560103b9173f37c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100442
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The related issue was fixed upstream.
Change-Id: I8b1191d3c0d5543233ace9322a7d768b3424d62d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100435
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This is a bug in the code, that after reopening the mobile
wizard it shows bad options.
Change-Id: I587c0181ac3e8f67b8cf27c190b9f4dad6f748d5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100276
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To run multi-user tests in interactive test runner.
It has two non-optional parameter. 'spec' defines the
test file and 'user' defines which user is run in the
interactive test runner. The other user is run in the
background.
Change-Id: I8612c201d7d3aeb2bdadd9d3786fb8eb0b60ab55
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100167
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We use file copying to create a clean test document
in the working directory. We don't need to do this twice,
the first user will do it first, then the second user
will open the same document.
Change-Id: Ide01b162b0c6a2b3a694706848c3ce93758f3f22
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100125
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We don't need an explicit parameter indicating the platform
type (e.g. mobile, desktop). We can check the userAgent to
get that information.
Change-Id: Ibbc041c4a389cff92203d245f55268ec4e93b0a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99889
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Fix 'detached from DOM' error. In Calc we have a small
flickering of the bottom toolbar, because we have also
the formula bar appearing after editing is enabled.
Change-Id: If642d6ae0aae0fcc761382567a2d2e37ad3bf486
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99888
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Test less which might make this test more stable.
Change-Id: Icf11af96bc5d21a14f0a74a641ffed3f91b6e482
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99783
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We can enable video recording with this flag,
during a headless test run, so we can see what
happend on the UI.
Change-Id: I4558563a3de71742d8d6b1ca67f0c518d543afc7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99787
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We need to introduce separate rules to dump
the log and to dump out the error message.
Otherwise GNU make evaluation breaks the workflow.
It evaluates $(wildcard $(ERROR_LOG)) before the
test were actually executed. So first run the tests,
then dump the error output and then go into error state.
Change-Id: I0f8e5de6800f0691cca14019819972437a741382
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99781
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Sometimes this text contains an additional end line character.
Change-Id: Id58eab9ea3b082781cdd8ec341fa2b058ba3b17e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99770
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
To run multi-user tests only.
- make check-multi runs all multi-user tests.
- make check-multi spec=sidebar_visibility runs
only the test pair with the specified name.
Change-Id: Idada04960a6a2d33c7f36ef57bc1d6a1d1cffa99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99682
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Before we used the GNU make implicit parallelization
which triggered by recipe structure.
Instead of that we use linux's bakcground process
feature and run one client in the background and
the other one in the foreground.
Change-Id: I9de899686ae67b47eee005f157b6622ae4c5fe33
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99484
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We used to grep for error messages in the output, but
it can change what is written out. Better to catch if
the command fails directly.
Change-Id: I8c3cba212b262227551876bfb23629a243424c39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99365
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Adding a comment was not stable. Let's just change
some paragraph properties to check multi-user interaction.
Change-Id: If923312de2c85b8897bc7a0af1f8e3f560576cc0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99376
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It causes issues when passing this string as a
command line argument.
Change-Id: I9af569c8ab941f392800c3c678085c384bec2908
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99374
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
With the ENABLE_LOGGING flag we get all errors coming from
the browser, which is a lot. So I introduce ENABLE_CONSOLE_LOG
flag now, which dumps only console.error() messages, so we
can debug the client code easier when we run a test in headless mode.
It will be useful for multi-user tests, where we can't use the
interactive test runner, because we need to run more users at
the same time.
Change-Id: Icfa62412b83e37398c54e9ac7b4120d76a87fb92
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99071
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We use the same pattern in the make file for parallel build,
let's us the same here in cypress config.
It also allows us to use different name for helper files.
Change-Id: I6718cd5221d4c35a259c61a70d7685327a16400c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98940
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Use smaller time intervals to check how long the item is
idle. Use a smaller (e.g. 1000) time for making a decision
about the item's idle state to make tests faster.
We can increase this time for those use cases where this
time is not enough.
Change-Id: Ibf03197c7bccc3cd718b67b73d52d9b9b54e875e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98733
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
The height input field is sometimes just disabled.
Might be a bug in the code.
Change-Id: I1d8dd5dabb1dee33606cab764b05657f4ce9df23
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98438
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
* Don't show selection resize markers for single cell
selection on desktop
* Use smaller autofill marker on desktop, for single cell
show it in the corner like in the core
Change-Id: Ic36c16213532ec8b615ee808f836b939f35245fd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98420
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
This method waits until the item is idle,
e.g. not detached for a while. Using this we can
workaround false failures caused by GUI flickering.
For example, mobile wizard is updated all the time
which makes hard to test it reliably. We can use
this clickOnIdle() method, which is slower than the
simple click(), but is more reliable.
Change-Id: I2f970eb0cf400382c8384c91ab7c84b1e02e63af
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98373
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Newly jails folder is cleaned up after a run.
Change-Id: Ia4f3eb26f61c5f14304e9ae6a3d5b5f60a0ee592
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98204
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It's a global cache. Calling make clean on one branch
can break the build on a different because the
shared cache is removed.
Change-Id: Id03fb6b6fd69e899276abc93c3d907538576d8bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97841
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
