Remove most calls to cy.wait(), reduce and comment the rest.
Stub waitUntilIdle and clickOnIdle
Fix many failing tests
Reduce total cypress runtime by 45%
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I62ddfdcbc3ab107654459ebece2d325eca0c6156
problem:
drag selection starting from the first row or column would result in first col or row being unselected.
It was caused by index being 0 resulting in condition being false
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I3619f52ccc7fdb2883af547f1c907c07ef27ddf9
It seems when users are unknown we can get a different JSON bject:
Object { ViewId: "8", UserName: "Unknown", Color: 13013504, … }
This is then flagged and set as a different (from the identified
avatars) html element in createAvatar from Control.UserList.js
Better to fix the alignment via CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I94fee62ae14bb47c6f989b4e0bb147f8ffc9ff39
This button does nothing (Sidebar: Style: dialog button [square with arrow])
- There is no paragraph style dialog in calc
- The style sidebar pane visible on core side is not implemented in
online
Better to hide it for now.
Fixes https://github.com/CollaboraOnline/online/issues/8135
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I62db3ec6466782a9dc2cb89deffec8023851de2d
To avoid the following warning in C++20:
error: implicit capture of ‘this’ via ‘[=]’ is deprecated in C++20 [-Werror=deprecated]
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I8b195d675ddc87fa6b16f7240a046fac9a7769e1
Avoid using LOG_TRC etc. during static initializers before logging
is setup:
#0 0x00007ffff7362183 in std::string::size() const () from /lib64/libstdc++.so.6
#1 0x00000000007d1acc in std::operator==<char> (__lhs="", __rhs=<error reading variable: Cannot access memory at address 0xffffffffffffffe8>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/basic_string.h:3586
#2 0x00000000008fdc04 in Poco::Logger::unsafeGet (name="") at src/Logger.cpp:289
#3 0x00000000008fdb81 in Poco::Logger::get (name="") at src/Logger.cpp:280
#4 0x000000000066a30f in Log::logger () at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/new_allocator.h:90
#5 0x0000000000692f8e in Util::rng::getBytes (length=16) at ../common/Util.cpp:122
#6 0x0000000000693312 in Util::rng::getSeed () at ../common/Util.cpp:91
#7 0x000000000044f987 in __static_initialization_and_destruction_0 (__initialize_p=1, __priority=65535) at ../common/Log.hpp:87
Change-Id: I6a32a0d3f50a8e769994737d4c09befe11599b4e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
And improve quality of low-grade random numbers significantly.
_rd.entropy() ? is not your friend.
Change-Id: I477557245949334bec517cdeae653c7452ed2049
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Helps us to catch un-necessary invalidations more precisely.
Change-Id: If5d681c025252e9e860e744945b33b68047524d9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
and how to sudo it, and tweak PATH to use the suggested info
automatically when sudoed
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I977f04bd38ad76393203c06d21f4a27abd0705ef
This setting is obsoleted by https://gerrit.libreoffice.org/c/core/+/161667
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ibd8dd96b4f5d1c0bd2dc0e227d51f714b330596a
If a cell is edited and suddenly press ESC key,
followed by Shitf + Arrow down to select more cells,
so the "uno:InsertMode" state arrives late and
it cannot update the row header selection.
Change-Id: Ib0e4e0699336e07d96efd96559f7b47caa285921
Signed-off-by: Henry Castro <hcastro@collabora.com>
In 24.04 we activated dialog which informs about idle dialog.
It covers full screen so some tests fail on that.
Add {force: true} to ignore that in failing case.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I11a183deb91ca35a2ddecc63b62bcb82b8ad1d0f
With "notebookbar: simplify structure with css grid" (Change id
I21421da5395fb9a7e4063a40f85e6af64e267ada) there is no more the need
to apply float rules as the grid layout should be responsible for alignment.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie57ffc819f460178eceb03c6796e02a8bc2297e7
Zoom reset button ("#zoomreset") was targeted by its ID:
- We shouldn't do this better to instead inherit css class if needed
- With "notebookbar: simplify structure with css grid" (Change id
I21421da5395fb9a7e4063a40f85e6af64e267ada) this becomes more
problematic:
- Zoom reset button now is align to the top while occupying 2
rows (hover effect display huge rectangle)
- To do: This button should be a big button instead
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaf93a648b10e380b1b8fd5a1cc12e2a88a2accf5
use toolbar from notebookbar_online.ui in the core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibeba3acfdae69248ed4de5d6a2df43cb7d1bb47a
Probably went wrong with bf8b9945ab304c3c4604ff296ff33b3f127accf7 (Warn
on non-async dialog usage when in debug mode., 2024-01-26).
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ifb92e0d9431f252cdf26ac92dd428b87e5d6e8e0
Fails when we don't check for '<img' in Clipboard.js
_navigatorClipboardGetTypeCallback().
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Idde76a7da26bac624c15c316be8cac638032c848
This is the case when the HTML has no own marker and we actually parse
the HTML data.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I8b1690faccbc9ebc6c67557cde8897eccf641fdc
If tests are invoked in parallel, then interacting with the real
browser/system clipboard would lead to unreliable tests.
In practice this is already problematic, because we don't want to ask
for browser permissions when running tests.
Solve the problem by creating a dummy clipboard that can be overwritten
by a test in cypress_test/.
The actual test is not yet added here, this is just the infrastructure.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Icc9e3900dee7fb4b53454152e5cda13439569bdb
Resolved an issue in Impress's 'Present in Window' feature where the snackbar would persist even after closing the presentation window or pressing the escape key. Now, the snackbar properly disappears as intended, ensuring a cleaner and more intuitive user interface experience.
Signed-off-by: codewithvk <vivek.javiya@collabora.com>
Change-Id: Id491e39d88b433993b5ff83e10c3ca2b1eb8ab40
