Commit graph

7249 commits

Author SHA1 Message Date
Andras Timar
ddafb573ed Font size dropdown placeholder string 'Size' and its translations were too long and did not fit
Change-Id: I7950f2411f5f148043390277566b0ecd15961085
Reviewed-on: https://gerrit.libreoffice.org/62719
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-01 10:29:34 +01:00
Aron Budea
c77fa94634 Force width for font size dropdown 2nd attempt.
Change-Id: I89b84970841eaab656df40219f35b9541e9caa95
Reviewed-on: https://gerrit.libreoffice.org/62704
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-11-01 05:56:23 +01:00
Tor Lillqvist
224bdad365 Use faster PNG compression in mobile app
Also, log the average time taken for PNG compression of tiles.

Change-Id: I720f55dc44bd6729dce710e3b781a7239a8bf585
2018-11-01 02:32:56 +02:00
Tor Lillqvist
f7563519bb Bin some temporary mobile app debug messages 2018-11-01 01:59:41 +02:00
Tor Lillqvist
ee316b6f20 Make the inserting of an image just a no-op for now in a mobile app
Bypass the XMLHttpRequest stuff that would be pointless and wrong.

Making inserting an image from the device's photo library (or taken
right then with the camera even) actually work is not high priority.
2018-10-31 19:55:42 +02:00
Tor Lillqvist
ab9962ac78 Correct spelling of window.ThisIsAMobileApp
Weirdly enough, hasn't seemed to have any ill effect, though? Maybe
checking ThisIsAMobileApp here is unnecessary after all?
2018-10-31 19:25:56 +02:00
Aron Budea
db60111676 Force width for font size dropdown.
Change-Id: Ied2392c814dcda75cfcc0aa27c588e9255d3f960
Reviewed-on: https://gerrit.libreoffice.org/62702
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-10-31 18:12:07 +01:00
Henry Castro
2c265a05c0 loleaflet: wopi: add EnableShare
Change-Id: I1a2a86e671f97891855cc2bd8d8047829e819508
2018-10-31 18:12:07 +01:00
Henry Castro
665863b50a wsd: wopi: introduce a "EnableShare" entry in the CheckFileInfo
Change-Id: Ia47d7e8f5c8cd8ae1eb314467c664b27b50e7fd3
2018-10-31 18:12:07 +01:00
Henry Castro
f9a660e3cc loleaflet: wopi: add EnableInsertRemoteImage
Change-Id: I806c3a79813e77cba85e837aa188453a5b63cacc
2018-10-31 18:12:07 +01:00
Henry Castro
8643128180 wsd: wopi: introduce a "EnableInsertRemoteImage" entry in the CheckFileInfo
Change-Id: I66e5f12fbd49509ce8e82ea07ae7a2cc75ddc665
2018-10-31 18:12:07 +01:00
Jan Holesovsky
8c9e126a23 Insert graphic: Pass the remote url to the core for download & insertion.
Change-Id: I871de173c255dcb7b184582e486328d7f66a2fae
2018-10-31 18:12:07 +01:00
Henry Castro
984a6df156 loleaflet: add action to insert graphic
Change-Id: If3ab2de89625f44c4178da1146ca3834702a62ec
2018-10-31 18:12:07 +01:00
Andras Timar
05a183319e loleaflet: hide 'Conditional Formatting Menu' for Writer, Impress and Draw
Change-Id: I31d9f7b2b974213ea27af8aee6a752c61eb911cf
Reviewed-on: https://gerrit.libreoffice.org/56527
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-10-31 18:12:07 +01:00
Andras Timar
548a02dce1 loleaflet: l10n of 'Conditional Formatting Menu' tooltip
Change-Id: I6f5060b3932221df382d77e9e68536788ed8df6e
Reviewed-on: https://gerrit.libreoffice.org/56526
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2018-10-31 18:12:07 +01:00
Jan Holesovsky
aa20e6c956 Conditional formatting: Add toolbar button for the icon sets.
Change-Id: Ifa07f357d490de8b92e50d34d4124f90b1d9e304
Reviewed-on: https://gerrit.libreoffice.org/56505
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31 18:12:07 +01:00
Tor Lillqvist
ac18a7cd9d Add NSCameraUsageDescription so that the taking/using a photo doesn't crash
(Such a crash is intentionally caused by the system, in case an app
attempts to access the photo library or the camera without explicitly
declaring that intent in the Info.plist.)

The photo doesn't show up in the document, though, in fact the UI
kinda freezes... but that is another problem.

Change-Id: Ib998bdc2c2c3708f69f066522ade54c36dd5f551
2018-10-31 18:35:59 +02:00
Tor Lillqvist
772a5a0c90 Add the empty Image.imageset
Change-Id: Idf35f40260d9b6490f9ee693606bfd5b8c4b4cbb
2018-10-31 13:17:12 +02:00
Tor Lillqvist
14d72bdf3b Drop the debug=true parameter
Change-Id: I945b9610f4bb8158217517adfb48d6fe84c43e94
2018-10-31 13:17:12 +02:00
Miklos Vajna
4c423fad84 CallbackDescriptor: make members private 2018-10-31 09:02:15 +01:00
Andras Timar
4e5528e5f8 /etc/resolv.conf can be a symlink
Change-Id: I23396e598306b7c8ab1498962ab5c09150c6795b
Reviewed-on: https://gerrit.libreoffice.org/62674
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-10-30 21:33:03 +01:00
Tor Lillqvist
dd3d50c1b3 Reduce MOBILEAPP ifdef clutter a little bit
This means some no-op UnitWSD functions will get called, but so what.

Change-Id: Ibdce82d9933699fe15947daea221ad67148dfddd
2018-10-30 22:09:52 +02:00
Tor Lillqvist
ffe66b3efc Avoid 'Unused variable' warnings in the MOBILEAPP casse
Change-Id: I30d631559379da4baa5a73712f002435b1a36360
2018-10-30 22:03:04 +02:00
Tor Lillqvist
888b529ffc For MOBILEAPP, call SocketPoll::wakeupWorld() when lokit_main() is dying
This wakes up the mainWait poll in LOOLWSD::innerMain(), causing the
process to get back to the clean idle state right away, without having
to wait for the mainWait poll to get a timeout.

Change-Id: Ifbe586d41661737be2864bedaddf9a40d23501f4
2018-10-30 21:09:43 +02:00
Tor Lillqvist
f29be2442d In ChildProcess::isAlive(), check _pid also in the MOBILEAPP case
... instead of returing always true.

The close() member function sets _pid to -1. We should just trust
that.

This helps a bit in making the app reach the the fully idle state
faster after closing a document. Tbere were two clear pointless delays
visible in log output: A long one followed by a shorter one. This gets
rif of the latter delay. Still need to find the root cause for the
former one.

Change-Id: I6d890e9eb59d076fde5aa93c55c44acc452b8124
2018-10-30 19:34:04 +02:00
Tor Lillqvist
141f0a15fd Don't use 1 as a fake pid, as real pid 1 is special
Change-Id: I8f2031c462734372a01884a6b30de67964854d1e
2018-10-30 19:20:00 +02:00
Tor Lillqvist
11de5ff75d Look in ios first, for the pre-canned config.h there
Change-Id: I416dd41fcdb5cb8d6344d80bccb0fc3ca3cf0457
2018-10-30 13:08:22 +02:00
Tor Lillqvist
d5c5a17750 We can't use shell conditionals to decide whether to run m4 code or not
Put the definition of the PKG_CHECK_MODULES m4 macro (as empty, for
macOS) inside a m4_if that checks uname, not inside a shell if
statement.
2018-10-30 12:49:59 +02:00
Tor Lillqvist
143527b4c8 Delete this file that is now created by the configure script
Change-Id: Idfec149bd5f7c5b7fb24659d185b322190e7935a
2018-10-30 12:18:47 +02:00
Tor Lillqvist
03e2c6c54e Avoid automake warning about ETAGS 2018-10-30 12:13:35 +02:00
Tor Lillqvist
f7130f6d9c Fix shell if test syntax
Change-Id: I158befbd7d29e31be81e3d1b158fea574d72a2e5
2018-10-30 12:10:31 +02:00
Tor Lillqvist
0b49485383 Require running configure also in tree where you will build the iOS app
Take the user-visible name of the iOS app as a configure parameter
--with-iosapp-name. The only purpose of running the configure script
in this case is to get that expanded into the Info.plist file.

You need autofoo to build LibreOffice core for iOS anyway, so this
doesn't really add any new hurdles for a potential developer who wants
to build the iOS app

Bypass some checks that aren't relevant (and would fail) in this case.
Could bypass a lot more of configure.ac in the ENABLE_IOSAPP case.

Change-Id: Ia0cb82ad552da1bb597411748f0cd74f825774fa
2018-10-30 12:10:31 +02:00
Miklos Vajna
54d788e69b UserInfo: make members private 2018-10-30 08:41:52 +01:00
Tor Lillqvist
4ce96fb8ff Don't access nonexistent vector element in the EOF case 2018-10-30 00:47:26 +02:00
Tor Lillqvist
9fec3b0e27 Handle EOF case (when fakeSocketAvailableDataLength() returns 0) 2018-10-30 00:47:21 +02:00
Tor Lillqvist
15bd148f26 Add source files from vcl/headless for easier breakpointing
Change-Id: Iae08ef264ba8e03f478c16ea60a5dd46d06e4930
2018-10-30 00:22:45 +02:00
Tor Lillqvist
19361772c1 Change the user visible name of the "Mobile" app to "Collabora Office Mobile"
Change-Id: I3a80caaefcb601df80b89d63786c0f19c4471e32
2018-10-30 00:22:45 +02:00
Tor Lillqvist
6bb5353d33 Add iCloud entitlements that probably will be needed
Change-Id: I19e82484a53622a836bba70877ff52203d6b6866
2018-10-30 00:22:22 +02:00
Tor Lillqvist
050d9699e5 Use debug build of Poco libs also in Release configuration for now
Using an optimised build of Poco seems to cause some code to work
incorrectly, sigh. No time to investigate deeper now.

Change-Id: I47e1809d380226d489db35bf4fc97d0f731fd887
2018-10-30 00:22:22 +02:00
Tor Lillqvist
c6d2c9c26a Add a newline to make the file match the one in core.git
Change-Id: Icb4b285a1d1510af550f1a3d98276546a4dc6aad
2018-10-29 14:23:16 +02:00
Tomaž Vajngerl
c730ce1d2c lokit: add funct. to insert, sign and verify signature
A lot of signing code paths trigger a GUI dialog (to select the
certificate for example) which aren't acceptable when triggering
through the LOKit. This code paths needed to be duplicated and
reworked to not trigger any GUI action.

Change-Id: I2f0d6038fb1bcd00adcdf86e432f9df8858cc21c
Reviewed-on: https://gerrit.libreoffice.org/61780
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-29 14:23:16 +02:00
Tor Lillqvist
4ea29914eb Avoid gcc: "specified bound depends on the length of the source argument"
Just use memcpy().

Change-Id: Icb705acb6c12baf28684c763a77da7abc514ea6d
Reviewed-on: https://gerrit.libreoffice.org/57714
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-29 14:23:16 +02:00
Caolán McNamara
3b2bc20502 Related: rhbz#1602589 add comments to coverity annotations
Change-Id: I88c941832a0d682ea4b6028c28edd48cf5df38f7
Reviewed-on: https://gerrit.libreoffice.org/58093
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-29 14:23:16 +02:00
Michael Meeks
aac7ec8bea lok: export preinit helper, and share code variously.
Change-Id: I09f2992c4ba45ce91190a9f61dd0fedd0eb8a581
Reviewed-on: https://gerrit.libreoffice.org/57145
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-10-29 14:23:16 +02:00
Andrea Gelmini
c5b67a8985 Fix typo: s/an other/another/g
Change-Id: Ifd83affcb16209f4134c725640fbd95077c8ab0f
Reviewed-on: https://gerrit.libreoffice.org/59099
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-29 14:23:16 +02:00
Andras Timar
fb1b7d6b44 remove obsolete comment
Change-Id: I69168335c479b94ad4352a64631c1605e4314abe
2018-10-29 13:10:29 +01:00
Tor Lillqvist
790f3aa5c5 Verify that we are actually passed a URL, not a pathname
Sure, the test could be even more strict and actually do a
case-insensitive check for an initial "file:" or
"vnd.sun.star.pathname:".

Change-Id: Ic252aeccdec708138530075d1f38fa348d1e469e
2018-10-29 11:49:11 +02:00
Miklos Vajna
d1e183f20d SocketPoll: make members private
All these protected members are unused by child classes, except read
access to a single member.
2018-10-29 09:06:33 +01:00
Victor Walker
082ea34913 Made grab handles larger and circles.
Change-Id: I50decb47495aa62407d19509aec8053def970311
Reviewed-on: https://gerrit.libreoffice.org/59333
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2018-10-27 14:51:35 +02:00
Andras Timar
c599fcdb66 add webserver config snippets to distribution tarball
Change-Id: Id8b782ab534f9534cde28b4c9a26dcbfddf8f835
2018-10-27 14:47:45 +02:00