now we dont need to click on the collapsed comment
because now after insert comment they will be selected
already.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ica69e5a092f29896c1d872deb384d31b867dddc6
No need to specify if it's first or second button as there is always
only one primary button. On top of that this avoids maintenance work
whenever for some reason the button is not the first in line.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd3ef60023e88d1a9a8fd6f465dc4c63c068debd
Follow the same order as anywhere else such as annotations, JSdialog or
even tunneled dialogs:
primary action aligned to the left
Also update cypress test: Do not target button position related classes
instead, rely solely on main classes
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac209aa343f22ddfdbd5662eba43d7adaa3f0892
- use .unoXXX class instead of id
- check only if height was changed on Optimal Row Height command
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibfa93076237b15e16ae1851e3a66b4b239c42a2d
- add possibility to specify UNO command alias for newer
version of core so we will call all the versions for
compatibility of online with many versions of core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I380fb1d2fd7f63bac297745401fa9d619f693348
Google chrome doesn't render white spaces correctly
This is a set of tests for the core fix
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I7edb0490f1b56ac2c5ab2d60fa5cf25ab7946745
With --unattended, do not wait for a debugger
upon seg-faulting. This avoids the unnecessary wait
that prolongs failed unit-tests in automated runs.
Now run_unit.sh and Cypress Makefile set this flag.
Note that the wait only happens when in debug
builds, or when envar COOL_DEBUG is set. This
prevents us from waiting when running a debug
build where we can't see the output, or indeed
the run is on a CI build machine.
This flag can also be used by devs when reproducing
failures where there is no interest in attaching
a debugger. The logs are shorter and more
readable, too. At least in trace level.
Change-Id: Ice15482c6724abc47f5955402295198eb7f671ee
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
*waitUntilIdle make sure that element remains attached to the DOM
*removed a specific configuration for multiuser tests in makefile and
now it follows cypress.json config
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I2bfd22ef0b4d8306b944d772e3536206a207e00c
for desktop:
added split cell test in table_operation_spec.js for writer, impress
added Image Resize test for writer, impress, calc
added Page break test in top_toolbar_spec.js
added NB support to the image_operation_spec.js
for mobile:
added merge row/column test in impress/table_operation_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9b3ccf124f49a2c33f2c1ca3c7c9106d09710bb4
PDFs are view_comment type documents where
editing is not supported, but adding comments
are. This means that we do get ModifiedStatus=true
but we never get ModifiedStatus=false after
.uno:Save. This is because the save command is
handled in a special way in Core by invoking
save-as instead, which doesn't reset the
ModifiedStatus.
The issue with this was that DocBroker was
stuck on trying to save the document
before unloading, thinking it was modified
due to the stuck ModifiedStatus. Here,
we change the definition of isPossiblyModified()
to ignore the ModifiedStatus for such documents.
Instead, we rely on the last save being successful
and that no new user input exists past the last
save request.
In addition, we now have a new Cypress test
that reproduced the failure without the fix
and now passes with the fix.
Change-Id: Ida9d486ac93a588b9007c5e4583d8bf3c090a62d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
removed unnecessary 'retries' parameters from the tests we already
have default global value for retries no need for specific tests
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Idc78831ce240d4d840f3dbc785e66165c6e07d3d
We copy each test document into the work-dir
and now we also give them a random prefix.
This is critical to ensure that parallel runs
do not re-use the same document.
Also, when closing a document, we wait for the
document-name to disappear from the admin
console. Sharing the same document, or even the
name, means we are likely to see random results.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit d998f2c1c8a163c3ef870bbe8581a364df3905bb)
Change-Id: I2f41566952c49c9c63ee206bcba6a4dd49cdd6d0
The test document wasn't properly closed before
reopening. This went unnoticed until the 'unload'
phase grew longer such that the new load command
basically added a view on the existing document,
instead of create a new instance altogether.
This clearly was an issue that caused timing-based
instabilities. Now we properly close and wait
until we confirm the document is closed before
opening a new instance.
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 54999291e95d75626426e2f306afa55b7a4f6fa3)
Change-Id: Icda6d7870c1352cc90002ced3c74e692fa849444
now all uno buttons with the same command will share class not id:
.unoXXX not #XXX
this is needed for a11y
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4dc75854bdb396fa9214f7cae5e7fffaef035e56
Related to:
https://github.com/CollaboraOnline/online/issues/3645
When we select text with multiple lines - line break
is ignered in the result. Paragraphs will be concatenated.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia7545bbee334a44517c416260f3dd911e0ae8eec
