Commit graph

3094 commits

Author SHA1 Message Date
Gökay Şatır
7d0f7d7378 writer insert tab keys are added.
Replaced id based checks with uno command ones.
Removed unnecessary function from notebookbaraccessibility. We don't use automatic id assignments any more.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3ad69916dea72d0e7e37430e629d74763c79005c
2023-08-14 14:24:46 +03:00
Gökay Şatır
1a2500c8d3 Merge accessibility definitions with notebookbar definitions.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I752eb0a2f44a892ed2cb7b2fd770c4d3ab997830
2023-08-14 14:24:46 +03:00
Gökay Şatır
939a7a0301 Simplify notebookbarwriter and tab page containers.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: If923c06ffd6b7bca77d25008497c390b8f3dcac8
2023-08-14 14:24:46 +03:00
Gökay Şatır
2cc714705a Remove access key assignments from jsdialogs.
Tabs' access keys are defined by notebookbar accessibility definitions class.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ie04782aa5b747ea9f3b7bd3f84a33bf0554648dd
2023-08-14 14:24:46 +03:00
Gökay Şatır
f8e53bd851 Assign tab ids while defining tabs.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I51dbadb5d168f7b7f762a20a445773c6d53a511e
2023-08-14 14:24:46 +03:00
Szymon Kłos
4b9cbab33d jsdialog: fix spinfield precision detection
Use string based approach to avoid errors.
Eg. 36.37 was a problematic value when multiplied by 100.
This fixed indent spinfield in sidebar.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iae25acbf59cedfd20cbcb0677fd87e08d06c3f6d
2023-08-14 12:30:02 +02:00
Shehr Bano
e6a06eae1c FIX #7037: JSDialog: label vs textarea vs input field inconsistent paddings
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I53494733c47b35d59133979c456665b4174e393c
2023-08-11 12:15:19 +02:00
Rash419
47f4305050 fix: cursor jump when hyperlink popup clicked in mobileview
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4c5f1f2923f894156f5f05382b0f54476dea8a56
2023-08-10 17:38:22 +05:30
Caolán McNamara
912dfcd08e autofill onMouseDown doesn't generate working event position for hidpi
so the autofill handle in hidpi didn't work

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I718d9a8d3954a441705849eba174fe6b5b2983c4
2023-08-10 11:41:24 +01:00
Pedro Pinto Silva
c89cccfc7a Welcome: allow scroll bar
Otherwise content is not reachable.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibef06bd7ee18702674e41e8f942449ef49ffdd62
2023-08-10 11:48:36 +02:00
Marco Cecchetti
96a7cfb25e a11y: provide info about current table and cell to screen reader
When we get in one or more tables screen reader reports row and column
count.
When we get out one or more table screen report reports "out of table"
for each table.
When the fosused cell changes screen reader reports new row/col index.
Screen reader reports cell paragraph content, too.
Added also cypress tests for checking that the table/cell description
string is correct.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I078b29a2f76f91df479f75db76113c80405f7169
2023-08-10 09:29:09 +02:00
Darshan-upadhyay1110
7825f82ce1 Remove open_local_editor button in tablet view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I18908150ee537bfe7dd36b0b94f8baa11d2739ea
2023-08-10 12:51:40 +05:30
Rash419
5dcce1965e android: enable dark mode in documents
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I108601f78f4d7bbf704b5f5f89b20c8f8a597355
2023-08-09 17:37:16 +02:00
Pedro Pinto Silva
c2192b4a67 Screen reader doesn't properly report tab names in Tab View UI
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ebe938080fa0e6865d4bf18e5dd33b0eb6a1567
2023-08-09 17:21:58 +02:00
Henry Castro
a2b924033d admin: rename ACCESS_TOKEN -> JWT_TOKEN
To avoid confusion with the WOPI access token.
.

Change-Id: Ie38e0f11d0655e89eb1c7f1e20b73a9b8756ba21
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-08 08:27:30 -04:00
Gökay Şatır
441d064b7a Make insert shapes menu accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I7421cbf8e745b0dd973c7f99b985e8bf98b4859f
2023-08-08 10:07:09 +03:00
Rash419
340bbb0328 admin: increase font-size of y-axis
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0439d79d487329bea8162762854430bac0b51448
2023-08-08 10:10:53 +05:30
Pedro Pinto Silva
3f0c9d5c55 admin: imprv ui sizes of adminClusterOverview.html
- Graph axis text is too small (10px) better to set it to 1em based on
parent div (16px). Good to also set any group within svg to 1em to
avoid any surprises
- Currently tablets from one card is spilling over to the next card
when there is not enough space. Better to allow scrolling.
- The left pane should be hidden even before reaching the mobile
size. This will fix the lack of space for cards and avoid everything
being so small

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58c88385875469b56542703663e570ab4d63fbdc
2023-08-08 10:10:53 +05:30
Gökay Şatır
c12885c6ec Make insert table popup accessible.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I8dfa71208e22bd26257f2133a85a407afb2fd364
2023-08-07 15:19:00 +03:00
Gökay Şatır
345c8c7d48 Fix js error - notebookbar accessibility.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ic17054cf6e195d8d1d6acb8b5c2a92112084e0de
2023-08-07 15:19:00 +03:00
Paris Oplopoios
d0c5321aaf Fix getting canonical view id of 1000
Also tilecombine request now uses the canonicalviewid

Signed-off-by: Paris Oplopoios <paris.oplopoios@collabora.com>
Change-Id: Ib386edcf78de17cb4fc3d8c3c6ce65f6b52c8b5f
2023-08-05 12:00:08 +03:00
Rash419
0ed983d7a3 admin: refactor adminClusterOverview.js
- refactored special case for templating
  adminClusterOverview.html
- removed useless variable
- format the code, fix indent

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib22cb481db7c7ef94b11f3044d0cd856e6d0eed5
2023-08-05 14:28:29 +05:30
Rash419
87bc8b10c4 admin: imprv ui of adminClusterOverview.html
- increased the sidebar length
- fixed html not covering fullscreen
- increase the number of card from 2->3
- remove unused property

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I86f6cf0225d4675bbd69dd0ebd7f77dbba6f9858
2023-08-05 14:28:29 +05:30
Rash419
8a879404ba admin: added podname to card
- if podname doesnot exist use serverId as title of card

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7c09b7a8943b8a6a19bc6937ff180a06d82d12a6
2023-08-05 14:28:29 +05:30
Rash419
944f269926 admin: added new cluster overview page
- added DlgLoading class to show loading modal dialog
- upgraded the d3

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8bd99bbadaa59a7de1e83bebde8db0dce920705d
2023-08-05 14:28:29 +05:30
Caolán McNamara
718992e30a cool#6911 don't show notes in hidden cells
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If29b9603b990479b538dcc62c1e0e924679a7275
2023-08-04 15:43:33 +02:00
Caolán McNamara
15422721b7 cool#6911 don't show off-screen notes from col/row 0
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ib8281304568f8376ba01e14e360d6f174859851b
2023-08-04 15:43:33 +02:00
Caolán McNamara
7b51f8c22e cool#6911 draw the note indicator browser-side
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I175a5dc8f553c7e0eafef3a5e4aedff4796352e9
2023-08-04 15:43:33 +02:00
Caolán McNamara
4d7f7d67d0 cool#6911 calc comment positions are now cell addresses
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0a70f1801f519df066ff5bc9dd57a5d485967b61
2023-08-04 14:15:06 +02:00
Caolán McNamara
aaa61e44e5 allow tileprocessed to accept multiple comma-seperated tileids
and bundle them together when emitted from the browser-side

// i.e. FIXME: new multi-tile-processed message.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I69916cbe30c26686fb44a2d8d229704c459b6601
2023-08-04 13:07:29 +01:00
Gökay Şatır
5485bea24e Add arrow key handlers for better accessibility support.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I3f6e81797c63dbe3cc5742ff39382a4052225541
2023-08-04 12:29:19 +03:00
Gökay Şatır
14c84ac453 Improve accessibility of w2ui drop down menus.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I9ff58eec19ccc7229c81b9d1f258bc8c4825634d
2023-08-04 12:29:19 +03:00
Henry Castro
c56ebcc06d browser: remove hyperlink pop-up
Unfortunately, we cannot show the hyperlink pop-up,
in client side based on cell formula, because the formula
had not been evaluated.

=HYPERLINK(A1,A1);

The server should fire event "hyperlinkclicked".

Change-Id: Ie2b743812493e1790b9e54f0050974c585e61e00
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-04 08:52:59 +01:00
Pranam Lashkari
cbeee7727e accessibilty: added accessibilty fields to the mobile edit button
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ifdb59ff3463a0354549316994f8e80b341e28133
2023-08-04 09:17:58 +02:00
Szymon Kłos
e8b2ea5ca1 Deduplicate onInitialize method in Column/Row Groups
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I404b9de7159b410f922dd1a66991aadc5dae1c91
2023-08-04 08:12:03 +02:00
Darshan-upadhyay1110
b38a91d1c5 Add check for Insert_buttons to display in tablet view
Added tablet check for Insert buttons to display on dom or not based on passed condition .
 - By default custom buttons will show up in tablet.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I103461b02405bc03d63671b885a31735668d4111
2023-08-03 18:45:50 +02:00
Shehr Bano
1428888afc Writer: Fix to issue #6977, extends vertical space of ui-treeview in Manage Changes
Signed-off-by: Shehr Bano <shehr.bano@collabora.com>
Change-Id: I8551242fc2b987f00c67088caa0ed07ee8526a72
2023-08-03 18:37:58 +02:00
Rash419
c9a9e5635d show copy/paste timeout warning
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I438ca03c8122c6c85acac7dda141f685a94fdc53
2023-08-03 09:43:18 -04:00
Henry Castro
b9a1254126 browser: admin: use access token
The GetCookie was removed due to sensitive
access data because the browser can block to
security concerns.

Change-Id: Ifaeb495202a53125bda9e3705b6e33b7e54e56df
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-02 20:23:42 +01:00
Henry Castro
47485adc3e admin: add access token
The access token will validate the session
when a websocket is connected to the server.

Change-Id: I008b04a499ab0d85fd6f95fc06a511f800c0bb2e
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-08-02 20:23:42 +01:00
Maks Wolkowinski
1f5919140d Collapse notebook bar from view tab
Signed-off-by: Maks Wolkowinski <m.wolkowinski@beebuzziness.com>
Change-Id: Ic15fb1723bff6861b1fc115ef161cf6caa1b70af
2023-08-02 18:25:37 +02:00
Marco Cecchetti
d99aece12f Improve a11y support for tabbed UI
Provided support for screen reader to report key accellerators
description.

When <alt> is pressed screen reader says something like: "tab control
Home tab selected".
When an accellerator is typed such as "N" screen reader says: "N
Insert tab selected".
When an accellerator for a tab item is typed the screen reader says
the typed letters and the item name as set in the 'alt' attrinute for
the button element.
For instance by typing accellerator for bold style ("1"), the screen
reader says: "1 Bold"

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I64b198f79cb9f7f13dcd1a4fe0890e4317e512dd
2023-08-02 16:43:21 +02:00
Gökay Şatır
7afe5dfe8b Remove tabIndex from container of color pickers.
Turn image buttons into actual buttons.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I51dc5c900bdcf2c06f9768526a9363f4539deb76
2023-08-02 15:18:30 +03:00
Gökay Şatır
e414ac3c86 Rename conflicting accelerator keys.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I926dc7145991b5cb3c251cdba43d2bbd67363482
2023-08-02 15:18:30 +03:00
Gökay Şatır
54b16ea222 Make color buttons interactable with keyboard.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ibf35d6304a717a5870998fb761ca6630db5df4b2
2023-08-02 15:18:30 +03:00
Gökay Şatır
fd7e041c90 Add focus loop to color control when keyboard is used.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ia860c055ac10b31d388bf159eb3dccc4ec101c7b
2023-08-02 15:18:30 +03:00
Gökay Şatır
a73ae5a1a5 Focus on the color input popup when keyboard is used.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ibf189aaa6029b3de1e1b4233d583f42e07be21d6
2023-08-02 15:18:30 +03:00
Maks Wolkowinski
3a8ff4ef3d feat: Add hide menu entry in compact mode
Signed-off-by: Maks Wolkowinski <m.wolkowinski@beebuzziness.com>
Change-Id: Id40312f6731cddaab110dc5e55ee7115ce08d6fc
2023-08-02 14:06:13 +02:00
Gökay Şatır
325ef1be01 Add functionality for setting access keys of buttons which are added via insertbutton post message.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I6c5746c36b89f4ad4d6c383a2ee5144aecefc1ed
2023-08-01 10:35:14 +02:00
Gökay Şatır
429f895bbf Allow notebookbar insertbutton post message to specify accessKey.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I0693cae17a71810a1c957b5c5600700073b1242d
2023-08-01 10:35:14 +02:00