Interestingly, we can have a 'this' that is not this object, that
means that this._clientVisibleArea is undefined, so page-up/down
don't work.
Fixes regression introduced by d1c8de9bf9
Change-Id: If83b3542f17c1856af18c5c302e9d566761aeb12
Otherwise, on firefox, when the dialog canvas has the focus, a caret
different from the one overlayed by LOK, is shown.
Change-Id: Ie38aae59f01a3811becca0bcf50c9d7d240bfa9b
This is a combination of 22 commits.
l10n: New script for collecting the used .uno: commands.
Change-Id: I9c6f3f03a4042f8e5ba1f258ce468fc0f4abd169
Reviewed-on: https://gerrit.libreoffice.org/45981
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 99161841dcee3b066153a7f7af0e98d6ef7f8a2c)
l10n: Don't repeat the strings in the menu definition, use the uno commands.
Change-Id: If8ccd753cd88056c64c10e3f9f7b951208fafdb8
Reviewed-on: https://gerrit.libreoffice.org/45983
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 5b87f2fca5d6f84d0ac637021e87e2dc41dd13c7)
l10n: "type: 'unocommand'" is implicit when there is "uno:" in the item.
Change-Id: I2fe50e4860848920f551cc6a3fda5ebe5f49b3f2
Reviewed-on: https://gerrit.libreoffice.org/46011
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit d38664c023f374dc66361d00be89c08a0e5bbc20)
l10n: Fix mis-typed .uno: commands.
Change-Id: Ia2d695d584d48b92def364c3936655909aabd076
Reviewed-on: https://gerrit.libreoffice.org/46012
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit e68789ac2c9c3bfa661ae815ff27cd4bb038bc2c)
l10n: Don't extract uno: when name: is provided for that entry.
Change-Id: I85619915cf66a71c7ab982c2949390bd82df9abb
Reviewed-on: https://gerrit.libreoffice.org/46013
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 293c5d45083823ae1c1f4e0519928c0b5d23dced)
l10n: Implement --check to notice not covered .uno: commands early.
Change-Id: I928f2cef8d9a869c10fa6c6370a7ce1c811631c8
Reviewed-on: https://gerrit.libreoffice.org/46014
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 457f929357adf7f52e0fc9281d41df3f29859467)
l10n: Further decrease the use of own Online strings...
...if those can be deducted from .uno: commands.
Change-Id: I9c2459a12ee95e936a7ec37f6270012d811cdf86
Reviewed-on: https://gerrit.libreoffice.org/46018
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 70ecee2bb6398aafdf6c71aeecf6e9eb6330fb70)
l10n: Let's avoid redirect, and write the unocommands.js directly.
Change-Id: Ifda0de27881ba415ff062368483524080dce5189
Reviewed-on: https://gerrit.libreoffice.org/46020
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit b6fa6f376c41d6787ab1cbb52218e7ff1064b83a)
l10n: Generate translations of the .uno: commands + update the current ones.
Change-Id: I77377412e4776a830f15973a35b83e8eca299f05
Reviewed-on: https://gerrit.libreoffice.org/46047
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit b2bfb2349ec2934a611bb4c1393e9f17aedb0ba2)
l10n: Translate also the right-click menu .uno: commands.
Change-Id: Ie5cedaaa10febe78ba319f9e9b03fdd44c94f468
Reviewed-on: https://gerrit.libreoffice.org/46048
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 861c252d5204dfac7b8f5fb4505efcc29eafeb3d)
l10n: len(sys.argv) is 1, when the command is invoked without options
Change-Id: Ie9a47955e9a031ee0484c0703f67bad7077bbd76
Reviewed-on: https://gerrit.libreoffice.org/46078
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit f096cf33977620f368ecc7c5b64164ab2303060b)
l10n: remove obsolete unocommandsl10n.sh
Change-Id: I4e9945407aff4a4fa1444079f8ecec1782a71c9c
Reviewed-on: https://gerrit.libreoffice.org/46079
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 4f0d5d7a2431bf5e132bdcd85285c10c0fd21322)
l10n: Make sure to distinct between apps + between main menu and context menu.
The strings can differ considerably, making some menu entries not
understandable at all.
Change-Id: I36ffa8b01df119a7655a711ec859391af16836c9
Reviewed-on: https://gerrit.libreoffice.org/46097
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit 53d9593edb32bbc5db3fe430ac5f20a1bdd4e127)
l10n: Fix the Table menu in Impress.
Change-Id: I2cb8b98ecc1a18174b26dfaa9c96ad3829ff5989
Reviewed-on: https://gerrit.libreoffice.org/46099
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit be100fe06abbeabed05b0c8a02c4f6067fcfc774)
l10n: first check for 'lang', then require unocommands
Change-Id: Ib8f94bbdd163a89bef4886d68816628e124e9ef8
(cherry picked from commit d94a53a0e363f6edf3a139d26c4b9603ef14389f)
l10n: get Language menu translations for free
Change-Id: I8b5628457cf713d8fdb0d4de6935b7e1d54ad093
Reviewed-on: https://gerrit.libreoffice.org/46158
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 53b8a60d5d85fc1a3909809ea51a23cb20453bea)
l10n: Calc and Impress should use _UNO('.uno:LanguageMenu') too.
Change-Id: I987821d9d9b0f40baea1879d28177e8e0c58a3a3
Reviewed-on: https://gerrit.libreoffice.org/46418
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit ba61ec9da2c073d2d728c5bb8df8912f5117fd5e)
l10n: Calc row, column and sheet tab context menu translations from LibreOffice
Change-Id: I1f566a71e5fdc66304e82bc2bcfb0f9ced2f5d2a
Reviewed-on: https://gerrit.libreoffice.org/46430
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit e8847b9ef174288b73650a4e63e8a6b0cfb43b4c)
l10n: Some toolbar button tooltip translations from LibreOffice
Change-Id: I4a8d050c7ae8efc7d1932f16dc35455f1a182d8a
Reviewed-on: https://gerrit.libreoffice.org/46444
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit d51a760957480ea412519f677dae7a2294c324cd)
l10n: localize 'Undo' and 'Redo' labels on Document Repair dialog
Change-Id: Ibd4236f85a6db92b7d6456f6f22115b35079da83
Reviewed-on: https://gerrit.libreoffice.org/47252
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit f8bf2c28608c139279aaa484603da8cc539ff948)
l10n: 5 more toolbar strings from LO core
Change-Id: I398a0d7c28a8295c3b8e5077903b5fa7d3d5c45c
Reviewed-on: https://gerrit.libreoffice.org/47310
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
Make the canvas contentEditable which prevents such actions from being
invoked. Other alternative would be to add a dummy text field but this
seems to do the work as well.
Change-Id: I8d39f06b02959459e0beeebad2eefcd8e9e00d9d
Not possible to use in all the cases while keeping the behavior same.
Need further investigation.
Also rearrange the API a bit in preparation to use the common
Map.Keyboard.js handler to handle key events for both dialog and the
document.
Change-Id: Ifd4ba2a9c1cdda50eb9c41ee43c7f883d71f65b1
While at it, move the title, width, height properties to this._dialogs
object as they are dialog specific.
Change-Id: Ibffcc57b0af210150690b2baf45d627baf5897fb
Reviewed-on: https://gerrit.libreoffice.org/46560
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 192a1f87024c97d4dda031a45cce4d4900416217)
two fixes:
- wrong data in firing of updaterowcolumnheaders event (messing up
pg-up/pg-down)
- console error message about invocation of a method for an undefined
object (annotation.mark)
Change-Id: I4e7d9de38ffe18b477c99147966fd91d7a460841
Reviewed-on: https://gerrit.libreoffice.org/46744
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
This patch fixes also a bug: when in edit mode the header for cell A1
are highlighted
Change-Id: If97d8d151f9d216362a9b1472c2b29fbec4f9b73
Reviewed-on: https://gerrit.libreoffice.org/46536
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Old behaviour: when a cell cursor message is handled the document is
always scrolled in order to make the cell cursor visible.
New behaviour: as the old one except when the position of the cell
cursor is unchanged: in that case no scroll occurs.
Change-Id: Iee9b8e2d9fc8cb72d0292fb48a20cadeedeb015b
Reviewed-on: https://gerrit.libreoffice.org/46535
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
When a tile has been invalidated, and the new tile content has not yet
been fetched and in the between a `canceltiles` message occurs, the
new tile content will never be fetched;
example: a tile is invalidated but a sudden scroll to the cell cursor
position causes to move the tile out of the visible area before the
new content is fetched, so when the tile is back inside the visible
area its content would be the old invalidated one;
Change-Id: Ib5f2605490cb9b15fba146e185f683cb7b8d31b6
Reviewed-on: https://gerrit.libreoffice.org/46534
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Comments and Redlines were mutually exclusive, but a document
can contain both.
Change-Id: Idb13f0c0e1216edc6bed3291c0c486b45ad74b56
Reviewed-on: https://gerrit.libreoffice.org/38235
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
- the very last col/row (CTRL+RIGHT/DOWN) had no header
- in some cases DataImpl.getNext() didn't catch that there was no more
header ranges
- parent group of a collapsed group spanning exactly the same range
was not drawn correctly
- removed some console.log code lines
- fixed some typos
Change-Id: I083171c09288081592477d889016910e416ab5b3
Reviewed-on: https://gerrit.libreoffice.org/45787
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Treat all commands as UNO commands only. I see no advantange of keeping
a separate 'dialog' type if all dialogs are opened by UNO Commands only.
There was a need earlier before we had a separate "created" callback,
but this is unnecessary now.
Change-Id: Ibea8cc1f24819597ddf2c49f3b8a47072e04e637
There is no exact menubar header as in calc, impress desktop version and
it doesn't look nice to create a new menubar header just for these
commands. So adjust them in most appropriate menubar headers for now.
Change-Id: Id52a2946904f0031168dcffcd0ab445f1a07a5bb
'font', 'border-width', 'border-color' are shortcut properties that
are available on Chrome but not on other browsers such as Firefox or
Edge.
Change-Id: I22d2a3db87b9d6f888bd345e06e605530358be51
Reviewed-on: https://gerrit.libreoffice.org/45665
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
use a specific message from the client for set the visibility state of
a group instead of hijacking the update row/column header message
Change-Id: I69d66b30db0b4d8a0082cbd2524120491d4f97cb
Reviewed-on: https://gerrit.libreoffice.org/45446
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
Ideally, we should get the bounds of the dialog from the backend and we
do but those bounds are not correct for some reason. Till it's fixed in
core, we better not mention any bounds.
Change-Id: I88928df624948f991656f37b1a7c4f0c3bdd46a6
I don't have much idea how the vex overlay's z-index is 1111. We don't
set it anywhere. Anyhow, the dialog still needs to be lower than vex.
Hence, the 1105.
Change-Id: Idbd9beeb84d626a80580a7f7ca75f73edb89f06b
Also don't perform the save as when the document name hasn't changed.
Change-Id: I4fb7e0abd73996e90107b301a09b8703b66e80f9
Reviewed-on: https://gerrit.libreoffice.org/44504
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
No need of dist-hook now to do the same. The good thing is that now
these images will also be available to a developer which was earlier not
possible without manually copying the files left & right. This means no
more annoying errors in developer's browser console.
Change-Id: Ie180720086feace00b61891f56ee3532f5f9df7b
This has an ugly side effect that when size is changed, the dialog is
centered in the document. With improvements in core.git, this should
work fine now without it.
Change-Id: I1bebc8a652cf6887028b6930363ae7ea137efc94
No idea yet why there still is a thin padding strip at the bottom of the
dialog.
Change-Id: Ia1347bafbf647385c1771f7af3e755cbf44dd666
Reviewed-on: https://gerrit.libreoffice.org/44517
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
Previously loading animation was shown if the user clicked below
the glyph.
Change-Id: Ic13eb06139a352e47db8db85ae2948e0fbab282c
Reviewed-on: https://gerrit.libreoffice.org/43895
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
This makes simple dialog like word count dialog, which do not require
any key/mouse interaction with the user, work correctly -
responding to invalidation callbacks and painting it again.
Change-Id: I3eee49751ec7815c8a26a687fc1f3915911d6cd4
The two test dialogs, Spelling dialog and word count dialog
appear on the screen when invoked from the menubar.
Interaction with dialogs is WIP.
Mouse/key events and floating window still needs to be worked upon.
Change-Id: I2d439465c7536d0b453c8ade503ec181a96c90d2
And keep the compatibility with older clients by adding 'Deprecated'
flag to the messages in PostMessage API. The clients must ignore such
messages marked with deprecated flag and should wait for the standard
non-deprecated post message.
Change-Id: Id203c44db5986303c574e66602d8f98b4c04ba50
Reviewed-on: https://gerrit.libreoffice.org/43093
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
We register the full names of the user with libreoffice core, not user
ids. Create a viewinfo map mapping usernames with viewinfo, not userids
with viewinfo.
This fixes the regression: the avatar URL doesn't work.
Change-Id: Ie4cc75168c7480fcb663414f3a082264b42c11d9
The way the parameter was interpreted changed with this
core commit: 7bc97db5b972f27693161beb9182f8a5850f5551
For now let's make single function work again.
Change-Id: I6e8ebb4cc7a272c53aa3e44066df7a62ab89d8ab
Reviewed-on: https://gerrit.libreoffice.org/43110
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
_onUpdateScrollOffset is triggered when the client window is resized or
when it is loading a new document. However, there are some cases when
the offset is 0, it means to update row and columns.
Change-Id: If4c4bb4f50335c642004ceb7723c8b5eb949cada
This regressed with 7c1e1120c6
Calling .initialize() on socket object is not enough anymore after above
mentioned commit; it doesn't re-establish the socket connection as
was the intent earlier in following cases.
Change-Id: Icd0a87a875eb275ed3c914474cdc502b460e2d16
Reviewed-on: https://gerrit.libreoffice.org/42431
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
total_mem can be confused with total system memory or total memory
availabe to loolwsd process. Change the API to say what it actually
returns.
Change-Id: I55c246b8a1d0c5c52767520150e55616266a6d4f
Though no harm as of now because we are calling resetAppLoaded whenever
we are emitting 'docloaded' with false status at the caller site, better
safe than sorry for future.
Change-Id: Id6d86ca2ae01a6eb32c8120df435d0535d906938
Now the Close_Session Post message command can be used to close the
documents while it is loading.
Change-Id: If60391834fedc90b3dcb63848aa72503eb43888d
The timer is cancelled right after 'statusindicator' is received, so a
document never really go to inactive mode after set inactivity time
period (unless user refocuses the document). Call _activate() to ensure
that timer is started after document is completely loaded.
Also timer shouldn't really start when the document is not yet loaded.
Change-Id: I58f5d7718c65cc37da9c3feb99ee6b16741a22a2
First, use the docloaded event to see whether we should be dimming the
document (make it inactive) or not. There is no point in inactivating a
document before document has completely loaded; so don't start the timer
until after the document is completely loaded.
It turns out that we were only emitting the WOPI's App_LoadingStatus
with DocumentLoaded for the first document load, but not for subsequent
reconnections. The problem here was that doclayerinit event is only
emitted during first document load (when TileLayer is -actually-
initialized), which was responsible for emitting this event. By
bifurcating the document load from document layer initialization, we
solve this problem.
Change-Id: I0b7b97fc6244ba9ebd6318d68d78d3abef2c0c08
Reply was added when clicking Cancel. This is a regression from
0760786392
Additionally, when focus was lost on an empty, initial commit,
an empty, defunct comment box remained until reload.
Change-Id: I49a5224ff70de65623496cfcba538acb6a8086f8
Reviewed-on: https://gerrit.libreoffice.org/40915
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
This is not required in any other browser, but Edge 40 requires it
otherwise the popup window upon clicking the combo box goes behind the
main #map element.
Change-Id: Ie95263f08c8af27b16a56ba2c3c7a9faa308400a
An `npm update` on my local tries to update all the modules to latest
version; surely we don't want it everytime only one module update is
required.
Change-Id: I2f79e77ae23edb9b8f8248ac7535e014b7b3218d
... because the Makefile did not work on SLED11SP4 (?!)
Change-Id: I4e7468149f1c5461aeeb05d3a68e62cda1e329e5
Reviewed-on: https://gerrit.libreoffice.org/39778
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Start killing documents when memory usage goes above threshold.
Also make it possible to close documents from admin instance.
In DocumentBroker::closeDocument, just set the _stop flag and wake
up the polling thread which will terminate the children, instead of
manually terminating the children.
Change-Id: Ie70e05b3fb6ea816a87b6dcfaed92cdddb94aa90
This is so because we require this also when document is opened in
readonly mode and we don't have any toolbar in the readonly mode.
Change-Id: I085d1640f52843e01370d528d6eea656b743d908
Changes protocol to use 'wid' instead of 'hash' everywhere. Wire-ids
are monotonically increasing integers that can be mapped to hash
values for all of the hash values and tiles we cache internally.
Change-Id: Ibcb25817bab0f453e93d52a6f99d3ff65059e47d
Since during an edit conflict the undo/redo
buttons are dissabled (for the user who can't
undo/redo anymore) disabling the repair button
robs them of the ability to repair the document
to an earlier state (i.e. before the conflict).
This enables the repair button as soon as either
the undo or redo is enabled, whereupon it remains
enabled for the duration of the session.
Change-Id: Ibaf257155f721e2cef596e965d8812d381ab3a5b
Reviewed-on: https://gerrit.libreoffice.org/38942
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
No WOPI doc can be loaded with this patch as the URL is all wrong
and the access_token missing.
This reverts commit ad8b437360cd0b7a95fd587f7b17d4cf1f385ca1.
Change-Id: Icced96564e61eb137c1620a7fb7e66c5ef8e5a5b
Reviewed-on: https://gerrit.libreoffice.org/38810
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 2fc7d50607b14df8ad8055e6d74a9c7970db1ae0)
Reviewed-on: https://gerrit.libreoffice.org/38822
Tested-by: Jan Holesovsky <kendy@collabora.com>
Seems to have no effect, so gone in
favor of RLIMIT_AS (virtual memeory).
Change-Id: I210879ec9285f420c9f9839cdabf45c42d865fb3
Reviewed-on: https://gerrit.libreoffice.org/38720
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
Using it this way looks very fragile to me; let's just avoid this.
Change-Id: I7459f3b215f5f9930287566a1bd946a94e9b343b
Reviewed-on: https://gerrit.libreoffice.org/38512
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
... with no functionality attached to it except notifying the WOPI host
that button was clicked. Host is supposed to do the action thereafter
itself.
Also, notify the host when a save succeeds or fails.
Change-Id: I0daa2690af2259233840ea7ab4326b9b80d5fa87
Moreover, its ideal to use the same URL to get this *-help.html file with
which loleaflet.html is loaded, and not the one with 'dist' in it.
Change-Id: I2e25f9a2ef41bb1d23fc09878b0726d6b4019cee
In richdocuments, it was added in aa0a8f666ada8f1d1edae17b906089cc03ba473d
and then removed in 87f7720d12e130bd1c3cd9306ad1b1f4d784f9e6
It was added firstly way before WOPI was even there. But now since we
have WOPI, we wouldn't need it.
Change-Id: I786a3f7b2103a43995a70b53438d88a829d13265
When saving while editing a cell, the
document is saved with the new cell contents
(as the cell editing is interrupted and applied),
but the modified status is not published to the
client (loleaflet).
This has the unfortunate side-effect that the
EverModified flag is not set in this scenario.
To avoid this, this patch sets the EverModified
upon successful saving. This is easier than
forcing LO Core to emit ModifiedStatus=true
in the scenario above. Though it suffers from
the false-positive result when the user forces
a save. Although this is probably defensible,
since technically the document changes upon
saving (though not the content if there was
nothing new to save). On the other hand,
it's less harmful to signal modification
due to save than to ignore genuine
modification to the document.
Change-Id: I7ccba62731f534b69819f7924eeb9231d874c111
Reviewed-on: https://gerrit.libreoffice.org/38398
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
