Commit graph

463 commits

Author SHA1 Message Date
Pedro Pinto Silva
765ea170df Disabled menu items are not clickable
Change cursor so to make that clear

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia448e639d98186c3e5eb5ef8ccc9236031ba3774
2022-10-18 12:49:08 +02:00
Pedro Pinto Silva
5a7ff0232d Allow top bar to be scroll-able when in tabbed view
Before this commit, some actions were unreachable on tablets,
small screen factor laptops. Basically  when the web browser window
is smaller then the top bar's content.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2e93540fa7b7d7bcf1a9f7e9f6697322528562f7
2022-10-18 09:12:27 +02:00
Pedro Pinto Silva
52f0c3dd0d Fix multiple line list within feature_lock dialog
Before this commit, list entries with multiple lines where not being
properly aligned.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0ca9861289f471285ace2dc1d39104d608eb8f15
2022-10-11 11:23:42 +02:00
Szymon Kłos
21c7958549 slidesorter: use correct styles for desktop & selection more visible
Mark as important so will not be overriden by the
mobile-wizard rules.

Use primary color for selection so it will be visible...

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7688f22c4da0121999b7f7675fcab0b0f59f8c11
2022-09-30 10:26:13 +02:00
Pedro Pinto Silva
d4c4774a57 Improve infobar's component contrast
Reduce inconsistencies by inherit component properties such as
shadow, border and bg.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia978b229cf4c9616d1d38ccac09644114972b39b
2022-09-29 10:28:18 +03:00
Rash419
d13d430b58 writer: introducing new mention feature
now you can insert a mention just by starting to type with @
integrator needs to implement UI_Mention postmessage api endpoint on which
online will send request of initial character what user is typing on the basis of
that integrator should send the list of user using Action_Mention postmessage api call
object where each object contains { username: '<username>', profile: '<username profile link> }
for example you can check framed.doc.html

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I38387cd05f1654b0bdb2b4f31cbac633eece5722
2022-09-27 14:43:16 +05:30
Pedro Pinto Silva
b42e916a97 Don't add border nor margin to widget if dialog is a onlyChild popup
When we are in presence of a dialog with just one treeview list
please do not add border around the widget. Container takes care
of it.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0c99f837ac6174fa60031e773c75fbfa1162762d
2022-09-26 16:01:21 +02:00
Pedro Pinto Silva
0d7dfa92dd Fix drop-down marker (form control) size
- Better to don't set hard width or height values via CSS
JS is already setting it initially and updating it when
zoom changes
- Add min width and min height otherwise:
    - The control can become almost impossible to interact with (too
    small if we zoom too far out)
    - The arrow becomes unreadable

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id54f7addbd8899a3e3ca97493e1865aa36b88817
2022-09-26 16:01:21 +02:00
Pedro Pinto Silva
6bf146d4ea Improve drop-down marker cosmetics, form controls
- No need to make it so dark (can be misleading, as if it was
disabled)
- Inherit border radius

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8aaf44758ddea447b2d167d80e73c3a8a8a7e022
2022-09-26 16:01:21 +02:00
Pedro Pinto Silva
3874ab9d81 Fix drop-down marker position, form controls
Before this we were trying to align arrow via bg position
this in turn was leading to problem when the parent control
(drop-down marker) resizes which happens every time we change
document zoom.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iad0479b5db462e5bbe14c8e81f8a41fc024947dc
2022-09-26 16:01:21 +02:00
Gökay Şatır
e200533b5e Remove obsolete css rules for shadow-transparency items.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idd1b71e1b32a1367902a230eb9f43fe18321f856
2022-09-23 14:42:21 +02:00
Pedro Pinto Silva
e1345de673 Fix Online help: buttons are no buttons, also decrease vertical space
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I766076d7819dfb2034134d3cb2a3f67ed0110b2c
2022-09-23 12:24:12 +02:00
Gökay Şatır
9993453714 Make the wrapper's display "fixed" so it doesn't interfere with the window.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I7176a0dbc235f8202cbbd4028ac187293d648d8a
2022-09-21 15:45:50 +02:00
Aron Budea
58cd55efe0 Fix missing delete comment icon on mobile
Regression from 4e075146b9.

Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I72375d5a784f9905f6a36ba805d2368c3d45900d
2022-09-19 15:59:24 +02:00
Pedro Pinto Silva
41495bb602 Fix annotation btns tooltips discrepancies
These tooltips were not getting styled as the other ones.
Annotation btn tooltips were missing:
- padding (as seen in .ui-tooltip)
- font-size and line-height (as seen in the ones that get styles
from jquery ui css by default)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ief46d294e36dfa0926cf668cd9a9f89589c6da40
2022-09-19 13:14:02 +02:00
Pedro Pinto Silva
587674560c Enforce annotation icons' style
currently it was getting styles from generic buttons

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I05e798cc1ba14dcd36607c6b4ec8a27dc33e585a
2022-09-19 13:14:02 +02:00
Pedro Pinto Silva
e66dfb7706 Add icons to save as drop down menu
Reuse download format icons

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic7824159913ae2d4f02413fee000f2e1daf86238
2022-09-19 10:56:08 +02:00
Pedro Pinto Silva
09abc4159d Tabbed view: center document name in the toolbar
Allow tabs container to grow and shrink as needed so
document name is centered in between that container
and the next element

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8d252478a4ddfdb9362555db6797205369dab57f
2022-09-12 17:07:49 +02:00
Pedro Pinto Silva
e6f407075b Add margin to tabbed view: tabs
This seems quite necessary to avoid missed-clicks between save icon and
File tab and also for white-space needs.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2bd0e7bc2478684e1cb920cdb917dd43c9acc8f
2022-09-12 17:07:49 +02:00
Pedro Pinto Silva
d0436fb67c Remove notebookbar tab indicators on tablet
These used to make sense in the past, when we had completely
different look and feel. Plus even back then this was not super
elegant way of showing that the tab container is draggable.
Furthermore, currently, the tab container is quite distinguishable
form its parent making it visible that the notebookbar-tabs-container
has more content to show.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e4c0d5b3bc5e0e21d6cd470446d13b9811846ab
2022-09-12 17:07:49 +02:00
Pedro Pinto Silva
de003ebf08 Add background to all tabs and add space in between them
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I03b8e0dc6298ddc18bad33afa3fef470f8cbe059
2022-09-08 17:10:24 +02:00
Pedro Pinto Silva
ae816b000a Make tabs shorter
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9e787c52c3ea0373eb97453cc7fc3217a87b251b
2022-09-08 17:10:24 +02:00
Pedro Pinto Silva
690be877b4 Remove tab's repositioning
Adding a margin to the first child only when it is selected is not
smart and causes tabs to move horizontally

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I89cb0c0e96cbb990ecdfb633f186ab5ea1c54078
2022-09-08 17:10:24 +02:00
Pedro Pinto Silva
389c747157 Remove hover effect on selected tabs
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3e74899804700f20613597bc48e0669fe09e882a
2022-09-08 17:10:24 +02:00
Pedro Pinto Silva
191a012559 Improve 3btn dialogs: don't allow btn to have 0 height
Particularly visible when on mobile and the conflict
dialog appears. Without this change primary button can shrunk.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id27761b53a425d16ab4bd2ef2a801890d899ee69
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
2e863c37ee Don't load btn hover status CSS rules when on mobile
Better to make sure we only use those on desktop. Otherwise,
a tap can trigger undesirable rules (changing bg etc)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I838328a55ee8943eccbbe8d69b99f76640fb3a69
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
7be4219d3b Add mobile-wizard-titlebar-btn and remove hard coded rules
No need to target #insert_comment solely
- Add generic class so it can be reused
- Do not absolute position etc
  - Use flexbox

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibeb1c517c5fd45b7a7774203cfa5e2a5210678ea
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
45341ab31e Remove master slides sidebar's btn CSS declarations
Better to inherit from button.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4dacfefa1f551c67e1b00910f25393897f7ccae9
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
1a29f1004a Don't use vex btn default btn CSS classes (rename)
By Renaming .vex-dialog-button-primary -> .button-primary and
.vex-dialog-button-secondary -> .button-secondary

- So we can remove duplicity on CSS buttons
- Easier to set vex primary and secondary button to use our css classes
- This way there is no need to hunt those specific cases down.
- Update cypress tests

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82f4b33560367805eeeeb5aec9af8d1abd313788
2022-09-06 17:01:21 +02:00
Pedro Pinto Silva
e2f15a6888 Reduce CSS selectors targeting buttons
You can now, since 1db5e39ef7 got merged,
rely solely on button-primary and button-secondary class.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic0eb08b443ab6c523d69e50df197eb0d3850fbd4
2022-09-06 17:01:21 +02:00
Rash419
3c5cc61fb6 feature locked dialog visual improvements
fixed:
- image overlapping with high res image
- shows empty bullet when highlight text is empty
- no space between bullet points and text

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I0e3bcd11d9132913d69f8a7c74d21cc0b4ab3305
2022-08-24 14:39:09 +05:30
Pedro Pinto Silva
962cc850d4 Don't add hover states to generated jsdialogbuilder td elements
- This is too generic
- If in the beginning this made sense now we have to many elements
and many should not have hover states (invisible, labels etc)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ice27ccb41cff73fa34b89453d99e3bb1fbc03edf
2022-08-22 09:30:37 +02:00
Pedro Pinto Silva
184488b953 Remove jump in impress anim sidebar when adding the first anim
Force placeholder to inherit the same rules as ui-treeview-body

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I61ecde9e35812026683c655f6a2f9ead18e10d02
2022-08-22 06:35:32 +02:00
Mike Kaganski
fa19a32b41 Draw separators in IconView
Depends on core commit 5b6fd1bcdb417e73307885f92c31464fe326ec9e

Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I6093df157dd14bd6035dd7135d95810a8ba64227
2022-08-21 10:51:23 +03:00
Pedro Pinto Silva
1e3d3243f2 Fix jsdialog title background and re-use CSS var
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I393ec7865c8df4123a6fc7f5ac566d02a3ce534f
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
5896d80ba5 Increase jsdialog tab btn text contrast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1a6ac35593c945b832c92af275b759e8be0b8225
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
f42c7a0297 Increase jsdialog tab btn contrast
And make sure first tab get extra padding when selected so to keep
some need space for the edge and to respect same alignment

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I96d8a1d5540336632fe75acb8eeef25bd5c4819f
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
5538f10560 Remove gray block bellow JSDialog tabs
It seems we have inline-block within inline-flex when we could
just have regular block inside of flex

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia242c36ced9908aa07ef09580d3c812f36d437e2
2022-08-19 06:59:23 +02:00
Pedro Pinto Silva
e55812033d Remove sidebar's hardcoded :hover states for unotoolbutton parents
These should not be targeted
- ids can change (e.g. FormatPaintbrush2 ,etc)
- Also unotoolbutton is already inheriting :hover rules

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7149cebfd52b4049a27bd3989fc88d254440df6d
2022-08-17 10:21:26 +02:00
Pedro Pinto Silva
f3c7b59265 Fix sidebar's clear direct formatting hover state
No need to specifically mention unotoolbutton's parent and apply :hover
, unotoolbutton is already been targeted

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iaa92d50f35f63dea4d10cd0906d9dadb700c25f1
2022-08-17 10:21:26 +02:00
Bayram Çiçek
336f7c1664 Add outline to color indicator for classic mode
- In classic mode, toolbar color indicators weren't visible when no
  text is selected. The reason is that color indicators didn't have
  border(outline) color.
- In fact, color indicators were just a box-shadow property. So,
  it was not possible(?) to add properties like border and
  border-radius.
- No need to use box-shadow property. A <div> tag can represent
  color indicators.
- Removed box-shadow property.
- Added <div> tag that has class="selected-color-classic".
- Added UI specifications for mobile. (#toolbar-down)

Signed-off-by: Bayram Çiçek <bayram.cicek@libreoffice.org>
Change-Id: I1b1b68fdc015fd3719d1c59ef7f782036a5934a5
2022-08-16 15:49:49 +02:00
Pedro Pinto Silva
e818d178a0 Fix outdated accepttrackedchanges svg references in CSS files
Follow up on the changes introduced in
4e07514 , update acceptrackedchanges svg

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2902602a546756d1d8e9299fa7e91d2750f5ce8
2022-08-12 14:02:39 +02:00
Pedro Pinto Silva
18f1a763d4 Fix outdated svg references in CSS files
Follow up on the changes introduced in
4e075146b9
- Update toolbar.css with current valid aliases
- Which fixes all a couple of missing SVG console errors

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4eb96175d297b2a6962aa0ec6ab46b82cf060a34
2022-08-10 17:50:26 +03:00
Julius Härtl
c7bdc082b9 browser: Give formulabar a fixed button width to avoid jumping
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Change-Id: Id38951ddc79e99573008c63d4e6c7ed36fcc52a2
2022-08-08 08:54:30 +02:00
Pedro Pinto Silva
a864d41c09 Revert "Add color-scheme-dark.css support"
This reverts commit 08b1d4b1e78fc2560d554b5935452ebb2d025214.

Better to avoid backporting WIP dark mode at least until
issue number #5054 is fixed

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id4fe8582fdebe9ad078ef5eaa7ba6be655cfb941
2022-08-04 15:26:47 +02:00
Szymon Kłos
962e1a9a5a sidebar: show Misc panel with Table Cell Color
It was removed in:
mobile wizard: hide unsupported items in table panel
commit 1aed5ddaa4

but now works

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia9ba8d9c7bad1c2074405617a4443e05df42ac66
2022-08-04 13:17:26 +02:00
Julius Härtl
219e246742 browser: Avoid important property on sidebar border
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Change-Id: Ia9cd8db9dcfa580f049c7212cfb01384d957d5cc
2022-08-04 09:41:49 +02:00
Pedro Pinto Silva
f0f58a2075 Mobile: Make sure all unotoolbutton share padding and margin
and remove unnecessary CSS verbose

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I209ea7d05e7027df8127ff2e49457a9e1d55cd7e
2022-07-29 11:24:51 +02:00
Pedro Pinto Silva
7122440572 Fix non-used automatically generated spans on mobileWizard
This fix the follow issue
https://archive.org/download/mobile-wizard-generating-spans/mobile-wizard-generating-spans.png

but it also removes unnecessary css block related to all those span
elements associated with unotoolbutton. Better to avoid creating
the HTML element instead of creating and then hiding it.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4e9ea01456370f1f7f877de00cf1a57e15337f45
2022-07-29 11:24:51 +02:00
Skyler Grey
b1f3c4b56b Fix the close button on windows without a title
- Previously going into Help > About > View widgets would show a window
  where the close button was rendered slightly out of the top of the
  window
- This was because without the title taking up a line, the title bar
  shrunk to be too small to contain the close button
- This commit makes sure that the title can never take up less than a
  line in height

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I9ead59711e3db3cde6af485ebcccf0b8a3ea57a5
2022-07-27 14:18:41 +02:00