Commit graph

3009 commits

Author SHA1 Message Date
Andreas-Kainz
81c44946d4 Dark Icons: update toggledarktheme to fit other icon styles
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Iee02515870d48adc2dcdd2f44ff76fb4c2cf05e7
2023-07-17 10:19:33 +02:00
Andreas-Kainz
4e5159e77c Dark Icon - Help tab icons update
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I50654f4fc82330e50069761a87e50ada23740ec7
2023-07-17 10:05:18 +02:00
Andreas-Kainz
563ae14953 Dark Icon Update - saved icons
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I966f44bb79ba0252ca662146f1680984a140bc1c
2023-07-17 10:05:18 +02:00
Rash419
55305d0d28 indirection: use Action_Load_Resp to show error msg
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I682973acfe45b9477bb6df9e8a17adf01e3dda65
2023-07-17 12:18:41 +05:30
Rash419
72570b1ea3 fix: media cannot play with indirection server
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I83d39fa4829938e8f217361fec3fbdab79adbac9
2023-07-17 12:18:41 +05:30
Darshan-upadhyay1110
2369bfc0ac Enter shouldn't be a requirement to trigger a tab or a button
No enter key will not be necessary to change tab by accessibility key

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I9ab9e004e9dc883d18b8f750a9a400e1f318240e
2023-07-16 09:16:02 +02:00
Darshan-upadhyay1110
ddef0ef881 Fixed Spellcheck dialog size
Set Minimal width for suggestions list
Added some padding for spell check text box for more readability

Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0fa5bb60ece88e4107408448a17378b526020784
2023-07-14 14:32:22 +02:00
Szymon Kłos
6124d3abd1 notebookbar: tab focus cycle inside tab page
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0daf9a068802470a45cfd203577a2b5f01c7cfc5
2023-07-14 10:32:34 +02:00
Szymon Kłos
a58c802d5b Create util for doing tab focus cycle inside container
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I25b44ebd1954301de4be0a4b4d22286f026a62fe
2023-07-14 10:32:34 +02:00
Pedro Pinto Silva
ee592d97bd Compact view: Add missing InsertObjectStarMath (formula object)
Before this commit this option was only available on tabbed view

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e027f1b84d09e802f7ea6c6fd9e5144cae2eb91
2023-07-14 09:48:20 +02:00
Pranam Lashkari
919db1674f keyboard: show keyboard only when explicitly requested
problem:
on mobile phone keyboard used to flicker when you tap on cell,
even if you were not editing inside cell

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I47d940ef32297fdf846ed4370411743982fcd3b7
2023-07-13 20:17:32 +07:00
Szymon Kłos
4c3be8555f comments: fix hidden comment after lost focus in modification
after commit 51d19dd60e
annotation: avoid saving comments on losing focus

We had regression causing collapsed comment to be completly hidden
if user first opened 'modify mode' and clicked outside comment
area. Then comment was collapsed but when selected again - content
wasn't shown.

This commits makes us sure that when we select comment again
it has visible content.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4fc9f0bb7d6649c0aa88bbb9c4cc69ed5cbf57c9
2023-07-13 10:43:17 +02:00
Michael Meeks
a064fe66ba tile debug: toggle tile debugging mode without bogus invalidation.
Show the existing state as-is to aid debugging, rather than
polluting it with bogus data, also update the screen immediately.

Change-Id: Ia6f0033208a5ad29eca374f24f215ffc5104301c
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-13 08:14:48 +01:00
Michael Meeks
24f0819337 tile debug: render updates as well as deltas in the tile.
re-factor histogram rendering out, remove crufty paths to track
tile metrics and do them unconditionally - some counters should be
small & fast & simple. Simplify debug output of tile/deltas.

Change-Id: I3b615719ae2540f855597e52e6c35594dbe5b3f4
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-13 08:14:48 +01:00
Michael Meeks
8e91eafbf2 Cleanup JS tilecombine generation and reduce copy/paste.
Share sorting tilecombines by part, and de-duplicating on key.
Ensure we build wireID list and send oldwid data to save
bandwidth and avoid re-rendering keyframes un-necessarily.

Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8180fceca22f1369e577bba4de7fd8a6fdbc011f
2023-07-13 08:14:48 +01:00
Michael Meeks
9a29a346d8 Allow tilecombine's to send oldWid information to fetch deltas.
Disable the 'forceKeyFrame' for tilecombine messages from the client,
we have a larger cache now and it makes sense to honor and track these.
forceKeyFrame was signalled with a zero oldWireId - which is the default
if we don't have it set.

Change-Id: If96423e96f8dc578a634ed5093517dfa6702cc1b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-07-13 08:14:48 +01:00
Pranam Lashkari
7cf1e19493 impress: avoid all slide preview context menu in master view
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I9f661df619581aa9d66d98f7e63c3562c6a939b9
2023-07-13 10:08:24 +07:00
Szymon Kłos
0832fb7f99 Avoid using null in notebookbar a11y code
happens for example in Impressi on load

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4d9f8fbb2ba996bdecd33c54bbc198d9ed82ce89
2023-07-12 14:22:54 +02:00
Szymon Kłos
a5bc10185a comments: avoid using undefined
refactor a bit condition introduced in:
commit 51d19dd60e
annotation: avoid saving comments on losing focus

I noticed TypeError here at some point in my browser

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I416088333bb0c87b03c52aff3804fee8f7ada311
2023-07-12 14:22:54 +02:00
Pranam Lashkari
81bfaee859 language: introduce option to change language of only para or selection
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If9086e72f53c3620c9d3e605b9e0415bdebab730
2023-07-12 19:14:44 +07:00
Andreas-Kainz
e90586a098 DarkMode border icons use dark fr0x icons #4592
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: Ia09efa8530e04f571af4b2e1e7599215746be2df
2023-07-12 11:20:44 +02:00
Andreas-Kainz
f84105072b DarkMode checkboxes will be themed
Signed-off-by: Andreas-Kainz <andreas_k@abwesend.de>
Change-Id: I0ffd594ba3e897a36c2caa8a5fe9aace9e04a63d
2023-07-12 10:06:00 +02:00
Darshan-upadhyay1110
e2215c39b2 Fix "Dark Mode" Button Jumps to "Home" Tab
After change to dark mode in notebookbar focus will stays to `view` tab.
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id0df0ded18a5858efa15eb0942b1ec69b6a716c2
2023-07-12 09:25:18 +02:00
Szymon Kłos
d475083f05 jsdialog: close snackbar when action button clicked
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibbdb247a052d8d4c2cca5f26d5bb9f31ced42187
2023-07-11 16:29:48 +02:00
codewithvk
df03cf1ce8 Fix : Wrong context menu in Slides Pane in master view for Impress
Signed-off-by: codewithvk <vivekpatel7202@gmail.com>
Change-Id: Icf19c9db12e0430fca98b0d639be62e2bbf29d37
2023-07-11 18:42:51 +07:00
Szymon Kłos
168f7cde07 jsdialog: field with time format should be simple edit
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id745fc6651b3cab6f080e41abb97d13e444d0c73
2023-07-11 12:48:28 +02:00
Szymon Kłos
83c0f61f82 jsdialog: add disabled state for menubutton
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0b5c8db6015348c9ad7803c08d5ac00b6fff7016
2023-07-11 12:48:28 +02:00
Szymon Kłos
9720311bcd jsdialog: don't ignore menubutton with empty text
build also empty menubuttons, example:
- writer -> review -> manage -> filter
- select 'Date' checkbox
result: end date disappears
expected: menubutton should be recreated with empty string

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I96ba161d209a4f65bd40b4a1efac896e3e172d0c
2023-07-11 12:48:28 +02:00
Szymon Kłos
ee3935a997 jsdialog: calendar control
can be tested in Writer -> Review -> Manage -> Filter (date dropdown)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I63b052ae29ac45b9ded66d1ca75195c58f3d7e13
2023-07-11 12:48:28 +02:00
Szymon Kłos
9187ae99d7 Center IFrameDialog using CSS
instead of using hardcoded pixel distance...

affects eg. feedback dialog which was impossible to
access in very small windows due to position outside window

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2a85defcd2aabf1bdb8ec88d70b6e6a873dec75f
2023-07-11 10:19:40 +02:00
Szymon Kłos
8fb734b52d Make snackbar non-modal
Snackbar shoudn't block user interactions with other
UI components. This fixes regression introduced with
vex rework to JSDialogs where snackbar become modal.

This fixes problem with "send feedback" and "Zotero"
snackbars which block users for ~10s from editing.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I71a2d1654b58a89162679346208409124f24b14e
2023-07-11 10:19:40 +02:00
Pranam Lashkari
8120449cb4 scroll: override any pending scroll for cursor following
problem:
unselecting shape would make document jump to position where
cursor was before selecting the shape

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I4aa75932631de51e84e3aca9b439f1a9a945e2d3
2023-07-11 14:49:04 +07:00
Pranam Lashkari
5d049a2fd3 jsdialog: avoid closing parent dialog if child dialog is open
this patch assumes that dialog ids are incremental,
and no two dialogs are open at the same time unless
one dialog(parent dialog) has triggered another dialog

i.e: calc advance filter dialog triggers warning dialogs,
if entered an invalid range and closing the advance filter dialog
before the warning dialog causes a crash of LOK

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ic4ba3b4553fb0ee089b1ab9b50b1c023801b674a
2023-07-11 14:47:21 +07:00
Rash419
12dbc98395 fix: info level log for exceptions
- hard to find exception if browser logs error at info level

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9f354480e1ee1d2da8a85973acd7b6563df83291
2023-07-11 12:37:34 +05:30
Caolán McNamara
aba5583ca9 drop empty CanvasTileLayer::_viewReset
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I77ac5e2069f86bcb9d2062cdabd9e886fbd34623
2023-07-10 17:50:13 +01:00
Caolán McNamara
42c9f54a98 osCanvasExtraSize is unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I96d74a5a9f6ae86ab4c33f58b60988f62afda417
2023-07-10 17:50:13 +01:00
Caolán McNamara
d5c7306a16 halfExtraSize and extendedOffset are newly unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: Ia2a51478ad674d0b10eeebdfb7e4bc4eb4614984
2023-07-10 17:50:13 +01:00
Caolán McNamara
d842d39cb2 extendedPaneBounds is now unused
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0f1f37ee096f9e0e765effea23139d6a7a6bf456
2023-07-10 17:50:13 +01:00
Caolán McNamara
04acabbe87 oscCtxs and offscreenCanvases are write only
as far as I can see they are only written to, they are
not read from anywhere.

Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I0faf8f2b087c4b4228ac40e6804694be0f83eb54
2023-07-10 17:50:13 +01:00
Pranam Lashkari
f56694ef96 scroll: avoid selecting elements while dragging scroll bar
problem:
In safari and gnome web when you scroll using scroll bar,
DOM elements on the slidebar and documents would get selected

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I222d246148d5d84a5c0b3cfdb1890350f428e696
2023-07-10 23:48:00 +07:00
Marco Cecchetti
d69de71094 remove dup code: A11yTextInput inherits from TextInput
Now A11yTextInput inherits from TextInput.
Added hasAccessibilitySupport to both TI and ATI

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ic296afb840824e7901202c9c089c4025c6bb8ab2
2023-07-10 16:02:18 +02:00
Marco Cecchetti
d5cd0c67e3 TextInput: gecko: fixed not working delete key
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I01ebbfb6c0d64fba044ae211d81b58a2f3ef06f9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
6be9a99c0d remove dup code: A11yTI: _sendKeyEvent uniformed to TI version
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I09dd4d1667c8075cc859a6b96a1da025d5b196ea
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b750d6e93b remove dup code: A11yTI: _onInput mentions part uniformed to TI version
Pulled in changes performed by commit:
24c83b9e Rash419 refactor: consolidate mentions-related code in
TextInput.js

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I37577163ec2a8abf0131e276df83d6710dec4f73
2023-07-10 16:02:18 +02:00
Marco Cecchetti
32298f08f6 remove dup code: A11yTI: _onKeyDown uniformed to TI version
Pulled in changes performed by commits:
847ade24 Szymon Kłos Mention popup focus fix
a006c917 Gökay Şatır Focus on the selected comment with keyboard.
02616ed3 Gökay Şatır Don't auto show the comment on Calc.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Icdc510f6d90af1b6f2379b6cbd4317940f0ac0ad
2023-07-10 16:02:18 +02:00
Marco Cecchetti
24727deee3 remove dup code: TextInput: uniformed code fragments to A11yTextInput
Uniformed code:
  getValueAsCodePoints
  _setupStyles
  _setPos
  _onInput: this._deleteHint
  getValue
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>

Change-Id: I6b5424e0afe3202d65abaf2d5b785b95cc9346c9
2023-07-10 16:02:18 +02:00
Marco Cecchetti
bc782c6b71 remove dup code: TI: _onCommandResult: clear content in desktop case too
TextInput:
undoing something does not trigger any input method
this causes the editable area content not to be a substring
of the document text

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I803c32d243c6331dc21685a6d2ee03919e21a8cf
2023-07-10 16:02:18 +02:00
Marco Cecchetti
b2c8cb32e5 remove dup code: TI: keep _hasWorkingSelectionStart for logging only
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Id8de738846a796be37184ecbc083fbd796620739
2023-07-10 16:02:18 +02:00
Marco Cecchetti
73c10a1d08 remove dup code: A11yTextInput: removed unused code
A11yTextInput:
_tabHint: removed unused property
_isTextContentEmpty: removed unused method
_onComposingContent: removed unused properties
_onCommandResult is no more used since on undoing editable area
content is updated by core through some accessibility message
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ifc31a994661827d4f53891f85c6f7229bea758a5
2023-07-10 16:02:18 +02:00
Marco Cecchetti
abca8e5dd3 Adding support for enabling/disabling a11y support from the ui
Added toggle button/menu entry for enable/disable accessibility support.
This ui feature is available for Online Writer only.
The button/menu entry is added only when accessibility is enabled at
server level.
That allows to enable/disable accessibility per view.
By default, the accessibility support is disabled.
Anyway the accessibility support state is saved to local storage
if available.

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: If5968a47f17922038b9da3d320cbed84ebb7688b
2023-07-10 16:02:18 +02:00