Commit graph

19132 commits

Author SHA1 Message Date
Rash419
737fff0830 docker: added docker file for arch linux to build from source
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I96a3f07e32fe0132be2081db11b62c666097057d
2022-11-03 13:47:57 +01:00
Tor Lillqvist
29ac04159f Fix the iOS app: Can't use %THINGIES% in cool.html.m4
There is no "file server" in the mobile apps that would expand such
percent sequences. The generated cool.html file is used as is.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I046c23c13ade6195f3f4a8b395ede7c42fc46bd2
2022-11-03 12:47:01 +02:00
Ashod Nakashian
9022c1059b wsd: improved UnitWOPILock to avoid race-condition
Change-Id: Ib91f53f4ebbfef8d93cebe24d48fea26df479dfa
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-11-03 05:17:05 -04:00
Pedro Pinto Silva
438b4e9411 Remove insert shape dropdown extra bottom padding
Before this commit the extra space was not used plus
it was making the popup bigger without necessity.

Referenced in https://github.com/CollaboraOnline/online/issues/2015

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6b2ba82b3d522f9673e555fb4f762b563c3a9c99
2022-11-03 11:18:52 +03:00
Pedro Pinto Silva
6d6e49e214 Fix statusbar display discrepancies when in readonly mode
Before this commit the statusbar was not being set with the
.readonly css class (already present in other main parent elements)
this, in turn was resulting in enabled and shown actions not proper
for readonly mode.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ife35a5f15c03681788bd16f007c338a9ddaeea52
2022-11-03 10:47:03 +03:00
Pedro Pinto Silva
01fcf38524 Code refactoring: avoid long statusbar css rules
We can instead, use the existent place for readonly hidden
button on Control.StatusBar.js

Also make use of _updateToolbarsVisibility to show/hide
disable/enable statusbar elements depending on permission mode,
this way changes take affect no only when statusbar is created
but also when we update it.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5f7186f87740156c486d7a870bf2bfff6f828501
2022-11-03 10:47:03 +03:00
Michael Meeks
9a3b1738d7 calc: add InsertCells / DeleteCells to calc row/column context menu.
Thanks to Tracie Fabb for the tip.

Change-Id: I5e8a7cb833e0d9a6257fd73324cd1fa553de1fd9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 15:48:37 +00:00
Pranam Lashkari
88b183bc05 UI: add missing file property setting button in UI
added button in file menu in desktop view in:
calc, impress and draw

added this button in mobile too.

this will allow user to check the property or change it (i.e: password)

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie9b0776e291046231755739a3c0aa48323c67725
2022-11-02 15:37:26 +01:00
Pranam Lashkari
44d0575d57 pdf: fix comment intsert short cut
regression introduced in 47c52b90f3
regression PR: #5274

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I7fc5b16b9d229c732437d921feb0bba7da5e0562
2022-11-02 15:57:43 +03:00
Tor Lillqvist
a3b0eda252 Give an example how to pass the zstd directory options to the configure script
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I23a38265f64d037480cb9b17caa8ce4a660f62a6
2022-11-02 12:12:11 +00:00
Tor Lillqvist
3862efd37e Don't recommend using /opt/libreoffice
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I4cb27eaedf1af6bf2cdf1b21b43cc65d05a344e2
2022-11-02 12:12:11 +00:00
Tor Lillqvist
6656bc8ac3 iOS is only 64-bit since long
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ifa0aa1c1c129a42e8d0c70c34b12c94e371ed484
2022-11-02 12:12:11 +00:00
Michael Meeks
19dff9f281 zstd: decompress blobs for testing using zstd not inflate.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8c2ea8b9cc3561485ec93428c1fe95a20be913fb
2022-11-02 12:09:53 +01:00
Andras Timar
8561b98791 Fix build with libzstd on iOS
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Idb94f5d359593e6098b7386ce0a9d33126d8ec2d
2022-11-02 12:09:53 +01:00
Michael Meeks
4d02d593b5 zstd: build for iOS.
Change-Id: Ifa2df0a0f9cf5bdfad5a513a37b64632b3e0a84f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
ccc2c4beb9 Simplify building multiple zstds for Android.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I58f31f3ff7be19e4770accd88a7520cc112b1e47
2022-11-02 12:09:53 +01:00
Michael Meeks
a8c449642e Android - add --with-zstd-includes and libs and build instructions.
Also reduce cut/paste in configure.ac around checking for files.

Change-Id: I33f789e99ed79f08cb9cfa5ed147b764332adfde
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
abc469466a Clarify delta count updating.
Change-Id: Ie6d507d9aff80b90c97338ce1526a87ae0688394
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Andras Timar
d6b12ab9eb Require libzstd >= 1.4.0
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia2235a89e53c51766b6f23b647d307a4059cccc6
2022-11-02 12:09:53 +01:00
Michael Meeks
b57689a2e8 in-line ZSTD_minCLevel() call as a constant.
Change-Id: Ie0877b4c3cdc3111d3a35f9ed622d8903675b96a
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Andras Timar
203e953796 FreeBSD CI: require zstd
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2cc37caa5b32f637bc15175b730e57a978fe0d7d
2022-11-02 12:09:53 +01:00
Andras Timar
1d4c04e22d add libzstd dependency to rpm and deb
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id55c488d02aa187b3eaff978c3a84e2e12cd8e5a
2022-11-02 12:09:53 +01:00
Michael Meeks
e7b57b2fad delta: optimize away re-fetching of pixel data as we apply.
Avoid fetching and putting pixel data back to the canvas when we
apply a series of deltas to a single keyframe.

Also split high-level from low-level delta debugging.

Change-Id: If4c308b695fb236e0753490d0d20a0fef0a9a470
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
2def6dc3d5 Switch to zstd image compression.
zstd provides for much faster compression server-side, as well
as better decompression.

zstd allows us to de-compress a keyframe and several deltas in a
single call in JS, so it is necessar to add a terminator to the
delta stream so that we can detect when to flush the buffer we
are working on - so the next delta applies to the correct data.

Change-Id: I0e292e3a697b4902d6488b7c04deaba2d1485e94
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Henry Castro
38764966dc browser: add fzstd lib
usage

	var decompressed = fzstd.decompress(compressed);
	// Second argument is optional: custom output buffer
	var outBuf = new Uint8Array(100000);

	// IMPORTANT: fzstd will assume the buffer is sufficiently sized, so it
	// will yield corrupt data if the buffer is too small. It is highly
	// recommended to only specify this if you know the maximum output size.
	window.fzstd.decompress(compressed, outBuf);

Change-Id: I0b378f9395b2442bac9f0790f7633e6a6cb0402e
Signed-off-by: Henry Castro <hcastro@collabora.com>
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Szymon Kłos
0b86e55339 Dont set readonly on non-critical error
When we insert empty/not esiting image - we can continue...

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib52f530d06dc8c5cd2780a08623435c440f9eb0a
2022-11-02 12:47:07 +05:30
Gülşah Köse
6302568c1c Limit the automatic addition of percentage sign.
In mobile view there is no way to select a cell and type something into.
We had to switch edit mode or use formula bar. So automatic percentage
sign addition is useless on mobile view.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ie0fca8121534a53304414d98e6fbdef82a349d89
2022-11-02 07:48:24 +01:00
Gökay Şatır
cf1074b640 Hide "Translate" menu button if deepL is not configured
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I52a02ab8380468b5dc56cb90a4d8edf2fab56c06
2022-11-02 08:56:25 +03:00
Ashod Nakashian
b43544da0f wsd: test: faster UnitInsertDelete::testPasteBlank
Change-Id: I4d58cc4c800a6fdd6b3096fe0f35e3c7c00c9c63
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-31 17:32:34 -04:00
Szymon Kłos
1822ee1121 Dont show error for wrong shape content
This happens when second time embedded video was selected.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ide47c4927b5717a1f631356dd0f183b086f6a77a
2022-10-31 08:29:34 -04:00
Pedro Pinto Silva
8e933d2cab Add read-only mode tooltip when hovering disabled menu items
So user can have yet another visual cue that the current mode
is read-only

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie7862e963603541c04d1b6662fbc7350f6e675a0
2022-10-31 10:48:56 +03:00
Gülşah Köse
847c05adc9 Increase the timeout in case copy-paste whole column.
To copy paste whole column into another document needs more
time to get a reply from server.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I5321b42e321179d541464f8cbdc49fe01502c353
2022-10-31 10:19:11 +03:00
Miklos Vajna
034b37a4a9 wsd: limit memToFreeKb in Admin::triggerMemoryCleanup()
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Idfe4ee00be9f805f5e12c7ece4f890aa2b9d08ed
2022-10-28 11:20:51 +01:00
Szymon Kłos
e1ab6ec1b0 Fix typo
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5c87f9da2f2fb33a78db784e64143b9d5b4df6d1
2022-10-28 07:28:06 +02:00
Andras Timar
bdf0c90761 Bump version to 22.05.8.0
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8e1936ca73e7e299ae042fdc20c969056df97893
2022-10-27 22:09:52 +02:00
Gökay Şatır
fea960c50c Writer: Use page twip coordiantes for switching the pages on read-only mode.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ie7ed6eb6d4f0178ff2f1f514e6e9f9321caf965d
2022-10-27 16:28:47 +02:00
Ashod Nakashian
10aa79f220 wsd: handle embedded video without extension
Change-Id: I4e05dfdbb78744c8d28404b5000fbc701d71ecbd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-27 16:23:27 +02:00
Szymon Kłos
90f5a08d9f masterpage: don't open sidebar on master page switch
it should stay in current state

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I446ffaa7183cdb70e0a924c4ea042e280a72bb70
2022-10-27 13:58:26 +03:00
Szymon Kłos
c441669d20 masterpage: correctly parse invalidatetiles message with mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I80b89629c3930d91a940438c82739c8a145e0024
2022-10-27 13:58:26 +03:00
Henry Castro
16f591c5f7 browser: set the document view only if it is offline
The cursor will hide and the permission will be updated
after the document is re-connected.

Change-Id: Ib0a584371317adabe9898dad8bb0cd96717cefff
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-10-27 11:40:45 +03:00
Szymon Kłos
562a1094d9 Fix alignment panel width in calc
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I119d10f58fdb3159dcd780799042c37f99dd112f
2022-10-27 10:32:50 +03:00
Pedro Pinto Silva
e124c5278b Enable Show Status Bar menu entry in readonly mode
Without this commit if the status bar is hidden, it's impossible
to bring it back and so the user is unable to:
- Search within readonly mode
- View the number of pages
- Zoom in our out via selecting the specific values

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If30a0729862788f7475ce800b643db2b386722f3
2022-10-27 10:27:31 +03:00
Szymon Kłos
f2e841b01f jsdialog: apply edit field type
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7f247333acde5319ef032c11db403b350dc07b44
2022-10-27 08:58:04 +02:00
Szymon Kłos
7f27d29b12 wsd: support embedded video - dont use 2 video tags in edit
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia83923f5af357d0a022db881daa7cd57d3a7c4f7
2022-10-26 19:37:45 +02:00
Ashod Nakashian
fc0b163732 wsd: move svg processing to ClientSession
This helps generate the public URL
easily and unifies the processing
of embedded video.

Change-Id: I07ef7f7722f368957a85e41493fe175de38464f7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-26 16:26:15 +02:00
Ashod Nakashian
7f5d77f1ff wsd: move mediashape handling to ClientSession
And reuse the public URI helper.

Change-Id: I9d56e91c2df571609c575b401c6a4eea958d710a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-26 16:26:15 +02:00
Ashod Nakashian
0124b42077 wsd: reuse getClipboardURI generically
This extracts the sub-path and the tag
as parameters, leaving the rest of the
logic intact.

Change-Id: I4e08537658e14412a1e56b55508ccb9529b00053
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-26 16:26:15 +02:00
Ashod Nakashian
06d7fd1753 wsd: extract URI encoding in a helper
This is compatible with the JavaScript
encodeURIComponent(), which supports
XML embedding.

Change-Id: I38bb64af67789bd5eea3f8f8bdb7f80e313599fb
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-26 16:26:15 +02:00
Tor Lillqvist
c6bd7f6818 Bump IPHONEOS_DEPLOYMENT_TARGET to match core:co-22.05
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I15ba4ac4ccf56a1dbdfd0e7434d883625154c46c
2022-10-26 13:55:40 +02:00
Miklos Vajna
4278b601f6 wsd: fix missing tile cache check in ClientSession::getCommandValues()
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I59d0c4863493a02df7a05b98648eb235840f8060
2022-10-25 16:55:19 +01:00