Commit graph

1370 commits

Author SHA1 Message Date
Szymon Kłos
8bb881bda2 calc: correctly detect complete row was selected
After commit:
change default Calc number of columns to 16384 (tdf#50916)
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4c5f8ccf0a2320432b8fe91add1dcadf54d9fd58

Last column code is 'XFD'

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3414ca2fefe1a3bda17595610ac2aab3a7a41d8e
2022-07-25 09:54:40 +02:00
Szymon Kłos
1c7a051044 calc: handle DoubleClick on AutoFillMarker
This will allow to fill column with formula when data
are present in neighborhood

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3f341b57b0d40251cb10a4f7b628c5c8f438e986
2022-07-22 14:56:58 +03:00
Szymon Kłos
963b7bda4f jsdialog: formulabar: reset shift key state after focus is lost
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I03d080fbe0d99cb5e2f825ac8fb66417b4b0b130
2022-07-21 11:12:00 +02:00
Szymon Kłos
3fe3655c6c formulabar: mobile: reuse TextInput for mobile IME
Fixes typing on Android using GBoard in Chrome
before this patch we didn't get any input due to
lack of keyCode, we need to use 'input' events
which are already handled in TextInput.js

This patch does that only for mobile case, later
we can try to unify it with desktop so we remove
our custom formulabar input even there.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I318840dee78ddf0f803af74236a6c880c3f09329
2022-07-21 10:23:45 +02:00
Szymon Kłos
bda3a2961d mobile: fix TypeError, missing Intl API
this error was shown on socket disconnect on mobile Chrome in older
phone

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I927880ce1848fd1d48776202679ee14a8858e065
2022-07-21 10:23:45 +02:00
Pedro Pinto Silva
9dfedf0003 Tablet: Fix Save icon floating when in presence of changes
The dot above the save icon was not scrolling together
with its parent:
     - Make sure the little dot is always under a parent with
       position set to relative
     - Adjust top position due to that ^ change
     - It also fixes for narrow window on desktop

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5844400cd1a15fe5693bb2b0be880460d974eec1
2022-07-21 09:18:17 +02:00
Pedro Pinto Silva
160467ac96 Don't use automatic generated ids (incremental digit) for save btn
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idaae02ce7c0ea9dab69056654df0bf15c847af3e
2022-07-21 09:18:17 +02:00
Rash419
9bb0b6fabd introduce new options to customize featurelock dialog
- adds two new options
1. localize the dialog
2. change upsell image shown in dialog using proxy handler
- provides all the settings using dynamic configuration

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7e21c1b31c806c88bf54f891de40f02fa342168f
2022-07-20 17:41:19 +05:30
Pedro Pinto Silva
b00961f06a Make view menu entries behave similar across types
- Follow the same order, for generic menu entries:
  - Toggle UI Mode; Show Ruler; Show Status Bar; Sidebar
- Make sure Reset Zoom and all UI toggles are present in all apps
(doc type) when using tablet

Note:
This commit does not change the following because I do agree with
remarks stated in 70f4f8b92e
- Zoom in and Zoom out entries are not needed in tablet
- Zoom also misbehaves, so better to have it out when on a tablet

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I06f1c025dba27ae65229c38406d646da75a59aa6
2022-07-20 13:24:25 +05:30
Pedro Pinto Silva
4901779bf3 Remove unnecessary separator from view menu entries (type: text)
No need to have one item (Resolved Annotations toggle) surrounded by
separators.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie5e560122054fc5904e3b24f984aa682c758d373
2022-07-20 13:24:25 +05:30
Pedro Pinto Silva
898f5181bd Add UI toggles to view menu (compact view) on tablets (type: text)
Building upon 70f4f8b92e
, it makes sense but let's add back in the Reset zoom
and let's make sure all the other UI toggles are available
when using tablet ( otherwise user is not able to
toggle UI mode, ruler or status bar).

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I972a3f6f17306484a266dc3cfa2103540ca4761d
2022-07-20 13:24:25 +05:30
Michael Meeks
80079f708c perf-test: cleanup un-expanded variables.
Change-Id: If2c7c055558a96c401e2be2ce031cd288bbc747e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-19 20:01:08 +01:00
Tor Lillqvist
ba80acc836 On iOS the tile messages arrive with e.data as a string
Now the tiles show up correctly in the iOS app again.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I2b1741ed9f5fc4e4df30cb67addfa45eb0d20b92
2022-07-19 19:25:42 +01:00
Gökay Şatır
66c5386400 Beautify the version string.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I66e2fd6d4331361e36bc31135a45e62149f2c0f9
2022-07-15 16:50:22 +03:00
Henry Castro
c9178b0223 Add home mode option - enabling more configurability for CODE.
Requested by several users and partners - defaults to off/un-changed.
When set it allows optional disabling of welcome/feedback when used
in a homely environment.

Also bump default max doc/conneciton limits in configure to 10k.

Change-Id: I3c917901e02445d45f6f86b554d47a60aa4e575d
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-07-14 18:24:43 +01:00
Pedro Pinto Silva
ed5ab42d38 Calc: Add missing class to toolbar-wrapper when on tabbed view
This is needed so 584aa5b8f6
is also applied on tabbed view.
Until now we were just adding that class when on compact view
(Control.TopToolbar.js)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8c0ac3d909f64025f301651564b3c2b1ae130e1c
2022-07-14 09:16:30 +02:00
Егор Ермаков
ffc5e4f45b Translated using Weblate (Russian)
Currently translated at 62.5% (286 of 457 strings)

Translated using Weblate (Russian)

Currently translated at 100.0% (462 of 462 strings)

Translated using Weblate (Russian)

Currently translated at 99.7% (461 of 462 strings)

Co-authored-by: Егор Ермаков <eg.ermakov2016@yandex.ru>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I821ed266d54f8802e747aa5c558799851d93121e
2022-07-11 19:12:16 +02:00
Rob Pearson
537af141e2 Translated using Weblate (English (South Africa))
Currently translated at 100.0% (462 of 462 strings)

Translated using Weblate (English (New Zealand))

Currently translated at 100.0% (462 of 462 strings)

Translated using Weblate (English (United Kingdom))

Currently translated at 100.0% (462 of 462 strings)

Translated using Weblate (English (Australia))

Currently translated at 100.0% (462 of 462 strings)

Co-authored-by: Rob Pearson <rob.dunedin@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_AU/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_GB/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_NZ/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/en_ZA/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If529c436a314705de45fc5801e7bbcf11ab44ba8
2022-07-11 19:12:16 +02:00
Adolfo Jayme Barrientos
95210c9f16 Translated using Weblate (Spanish)
Currently translated at 100.0% (462 of 462 strings)

Translated using Weblate (Catalan)

Currently translated at 99.3% (459 of 462 strings)

Translated using Weblate (Asturian)

Currently translated at 50.0% (231 of 462 strings)

Co-authored-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ast/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ca/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/es/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If20eeac4c226f519c29c9c910e92e466f6994821
2022-07-11 19:12:16 +02:00
Yaron Shahrabani
7366f21bd3 Translated using Weblate (Hebrew)
Currently translated at 100.0% (462 of 462 strings)

Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5b7c69f8c73a7723bc941ceaba20bb53d1f26411
2022-07-11 19:12:16 +02:00
Henry Castro
63998720f4 browser: ensure if welcome was disabled
Change-Id: I22a90c0dd8e80870699aef12b800c85508b17920
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-07-11 14:19:00 +03:00
Andras Timar
fb25b7d806 If integration theme does not exits, fall back to default theme
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I9939ee243aa81b50969168df2e8bb5c8cbf2a34c
2022-07-11 12:59:05 +02:00
Pedro Pinto Silva
10c70a46a6 Mobile: Do not allow rules from busypopup to affect snackbar
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibb3d964f66ef7f18272207b2738708b451c2e1b0
2022-07-11 07:29:26 +02:00
Pedro Pinto Silva
d09157b412 Snackbar: Fix contrast, remove unnecessary rules
Use a dark solid background color - with a shadow (already existent)
- to stand out against content.

Make sure button is blue similar to test selection handles or some
icons etc. So it is visible at 1st sight what's the action

Remove unnecessary or duplicated rules

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I53a291f762c4ed40f5b39230fad8246fa280d050
2022-07-11 07:29:26 +02:00
Pedro Pinto Silva
a29aeac3c0 Remove snackbar's border
It is not a normal dialog as in jsdialog or lodialog,
no need to add border

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib7a4d3d1a89f1c69df8e7a374d4283d48b66e42b
2022-07-11 07:29:26 +02:00
Pedro Pinto Silva
3000d74e7e jsDialogs: Avoid uncertain border radius
Avoid odd number by stop relying on a division by 2.
Instead, use the same already existent border radius.

-----

In the future if we end up deciding on something else,
we should probably create a new var for that and apply
it to all dialogs

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If0e53f0b2a965587c33156536f74fcc0a223a43a
2022-07-11 07:29:26 +02:00
Pedro Pinto da Silva
e3ed04713c Writer: sidebar (table) fix row height spinner's position
Since the row height spinner is the 1st element in the row,
there is no need for margin.

Note: in the future wuld be good to have the spinner coming from the
builder with additional class or style when they are the first
element being positioned

Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I2396ab662fcb4a12762b4a6e2b38582f1df7c59b
2022-07-10 21:35:34 +02:00
Pedro Pinto da Silva
9e67710e3a Writer: Fix sidebar table btns position shift
Remove unnecessary rules targetting minimalrowheight and
minimalcolumnwidth. These rules were
1. Not being apply always (sometimes jsbuilder was
setting them with different id, e.g.: with suffix 1)
2. Even when apply this rules were forcing these two btns
to go up, looking like they are mere icon for the spinner.
This is wrong. They are buttons that trigger the set to the
minimal sizes of that particular row or columns

Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I53e81c69cdcc3aafd2ca5ab0f8e196d912b86608
2022-07-10 21:35:34 +02:00
Pedro Pinto da Silva
ba8dfa52a9 Writer: remove sidebarbar spinner padding for table row & col
Before this change the spinner were getting unnecessary additional
padding.

Signed-off-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I43b8bffc8bacc13dfc633cee4cd8f7823834d402
2022-07-10 21:35:34 +02:00
Henry Castro
3cdd25c340 browser: add 'dropdown' dialog type
Adjust the drop-down dialog to the #map element
to show the correct position sent by the server.

Change-Id: I74a6d7402438241aae77a18699c3297d64b34098
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-07-08 16:37:47 +03:00
Pedro Pinto Silva
584aa5b8f6 Formulabar: remove bottom padding from toolbar-wrapper
This was affecting how we perceive padding around formulabar
- Making it look uneven (with more space at the bottom)
- Making toolbar-wrapper's bg visible at the bottom

Remove bottom padding when in presence of spreadsheet so to
avoid affecting the other apps

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icce34ecb64781221428130f4a11420b5546003ad
2022-07-08 13:22:08 +02:00
Pedro Pinto Silva
fb83b73587 Fix formulabar's address input vertical pos on mobile
Before item address was getting vertical aligned resulting
in misalignment when in expanded view

![image](https://archive.org/download/formulabar-mobile-addressinput/formulabar-mobile-addressinput.png)

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8f71a99da0d813a367f75023b5ae1230378bb19c
2022-07-08 13:22:08 +02:00
Pedro Pinto Silva
ae4a240fcc Formulabar: no need to use calc for line-height
Using unitless values will be automatically
multiply by the element's font size

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ice4b56c5da7e47aae83347c1bf6b6ac377a51518
2022-07-08 13:22:08 +02:00
Pedro Pinto Silva
db23db6a78 Fix formulabar's item address input field vertical alignment
Make sure every element between item address parent and the
item address itself is place at the top

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib883f6659788f4ec42ae6d953fa2d857038fc815
2022-07-08 13:22:08 +02:00
Pedro Pinto Silva
450d4611a8 Fix formulabar vertical padding and odd numbers
- Set heights to even numbers so we don't end up with uneven
  surrounding vertical spaces
- Remove individual top margins (margin-block-start) from btns
  - Instead fix underlying issue with formulabar
- Fix text-area padding inconsistencies between being expanded
  and collapsed. Problem: text area becomes taller, ending up
  occupying the top and bottom white space left from its parent
  - Leverage new css class added to the main parent #formulabar
    and add vertical padding so text-area forces parent to increase
    in size
  - Remove sub parent's (#tb_formulabar_item_formula)
    individual top padding

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I380af6cf70c0e879224329fbf9093e0778a38d8d
2022-07-08 13:22:08 +02:00
Pedro Pinto Silva
e3210b4c82 Fix horizontal padding around formulabar
Avoid setting elements, located  on the edges, with margin
in the hopes we get an overall padding:
   - Remove it
   - Add instead a true padding to the main parent

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie1690c9cc3c58f59387cb6aa73df20d42f5cc1fb
2022-07-08 13:22:08 +02:00
Szymon Kłos
47130f551e jsdialog: formulabar: fix backward selection using shift+arrow
When editing formulabar using keyboard - try to use shift + arrow
to make selection from the end in backward direction.

This patch makes it possible (visible).

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I48073214545892d98be097b38c60251ff95082f3
2022-07-08 12:32:48 +03:00
Szymon Kłos
b506abad58 jsdialog: formulabar: unify behaviour of Safari/Gnome Web with other browsers
eg. Chrome setups selection only if element has focus
it prevents us from stealing focus by formulabar when
switching cells

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I46cbd4d04615478a95a36dd8bcda22d732e74d3e
2022-07-08 12:32:48 +03:00
Henry Castro
545122e933 infobar: listen 'updateviewlist' event
check infobar data when the server send
the user info data.

Change-Id: I0ba1da488f9b3d03dc7e3f42cea718273e6939b1
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-07-08 11:39:48 +03:00
Henry Castro
c4681a79ba infobar: remove interval timer
Change-Id: Icf948c2f7ecc06ed2ba68224bf3fca7c22842ec0
Signed-off-by: Henry Castro <hcastro@collabora.com>
2022-07-08 11:39:48 +03:00
Pedro Pinto Silva
d552fc07d4 Fix DownloadPopup close btn overlapping popup link
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3294ce292b7921e36cb243f25149375f025e517d
2022-07-07 17:35:10 +03:00
Szymon Kłos
fe62d09c28 jsdialog: formulabar: fix freeze when server sent huge paragraph id
if there is no more paragraphs: exit the loop

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7075ff5454e1ddcc11155867f835e85117bdea15
2022-07-07 15:23:20 +03:00
Michael Meeks
e404ce88bb rows: ensure we don't stray beyond the last row in error.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I04273e6c4ed8ea5b5e4398121f3d97767d7c3a2f
2022-07-07 13:09:47 +01:00
Michael Meeks
9a32c2c27a sheet geometry: build geometry array up to the last row in the range.
Improve performance by not looking up endIdx that may be over the end
of the range. Ensure we still have valid data for the pieces we do
know about.

Playing with a complex 1m row spreadsheet and re-sizing rows by
typing multi-line text into them would provoke row header problems
otherwise.

Change-Id: I5a110137e6d26e2c4b272210cf41883abb02c3af
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-07 13:09:47 +01:00
Szymon Kłos
d1cb42e111 Keep custom buttons when switching the view
When we use API call InsertButton and we add custom buttons
we want to keep them when we switch between compact/tabbed view.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If03520f52422ac41aa40432f068e5bc011ed2596
2022-07-06 12:18:54 +02:00
Rash419
cb080f561e writer: fix: cannot add picture using picture contentcontrol
use sendContentControlEvent to set picture instead of InsertGraphic uno command
since InsertGraphic is not allowed for a protected content control (like picture),
only sendContentControlEvent();

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I5f70919d995c51456056a8be2aa1e596df7bedc2
2022-07-06 14:57:30 +05:30
Pedro Pinto Silva
806dacecc2 Formula bar: Fix formula and sum btns shifting when expanding
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I7a235750513f8375670fa73894964b2a05acab10
2022-07-06 08:35:13 +02:00
Pedro Pinto Silva
7a6f7fd846 Formula bar: Make sure the outline doesn't bleed out
and thus avoid cropping it altogether

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If959c617c6036daa353dc8185668aeb99d515497
2022-07-06 08:35:13 +02:00
Pedro Pinto Silva
cbfe45185d Formula bar: Increase font size of the text area
Before not only it was not vertically aligned but it was difficult
to read

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3790d51f4a90dd9bdb5158cfa16ed92de1ebfca5
2022-07-06 08:35:13 +02:00
Pedro Pinto Silva
4a6c701ae2 Formula bar: improve expander img
Set it to 24px, fix stroke and make it a path
- Result same size, smaller visual indicator

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic41b7a1d8e798998ea9399cd68c9fc6b46e73725
2022-07-06 08:35:13 +02:00