rollbackPastChange function already opens the menu
so don't do it twice
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I930f669589da1f9e18840dae4013d81a49707639
ERR_get_error cleared the returned error,
which meant the subsequent call to print
the error in string form, using
ERR_print_errors_cb, didn't find anything
to report.
Change-Id: If131a8cc0d2c1d8bbf705ed38f144b38abf6c8c6
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
prefer picker id, not palette id with number which is generated
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I52d30c3991b516378e82455fdc104b5d94e94f91
Previously sidebar was always active on launch.
This patch together with core fix changes that so
initially it is off and we don't waste resources
for rendering sidebar which is hidden just after short
time.
We don't know the state of sidebar (which deck is activated)
on the core side so in some cases we need to switch decks
in 2 steps: send SidebarShow, and when we received result
we change deck to other one or we do nothing. This allows us
to switch correctly the decks.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib161cae73fd1344d375cb37712c5e805c4d1eefb
we need this state variable set in more generic place
not only in menubar
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I72e100ef91bbe32987ceb1e2bff5903f15c6134b
Remember them on opening if local storage is enabled.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I0c3e4eb65dfc16807d2a9a654d8e71f64341df67
Since this is the normal and expectd case, there
is no reason to repeatedly log that the address
is an allowed one. We do warn in case of disallowing
anyway, so this isn't necessarily adding value.
Notice that this log is generated not just when
convert-to is requested, but when generating the
capabilities json as well.
Still, we trace it for easier debugging, if necessary.
Change-Id: I08661e09bc6b8eb665c6d99437631c8df45fa8b4
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This was a regression introduced in
14d96957cd.
The result was that multi-part logs were
not flushed and therefore not written to
the output.
Change-Id: Ib22a1da83209b00872d91ca05a940226cbb4552d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Make the possibility to collapse/expand tabs more discoverable
by adding tooltip to the:
- selected notebookbar tab when collapsed
- selected nb tab when expanded
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib75fc15fed6400557f6413a0d21be5c155fe8571
Allow tabs container to grow and shrink as needed so
document name is centered in between that container
and the next element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8d252478a4ddfdb9362555db6797205369dab57f
This seems quite necessary to avoid missed-clicks between save icon and
File tab and also for white-space needs.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2bd0e7bc2478684e1cb920cdb917dd43c9acc8f
These used to make sense in the past, when we had completely
different look and feel. Plus even back then this was not super
elegant way of showing that the tab container is draggable.
Furthermore, currently, the tab container is quite distinguishable
form its parent making it visible that the notebookbar-tabs-container
has more content to show.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e4c0d5b3bc5e0e21d6cd470446d13b9811846ab
canvas module is needed for make check. --disable-werror is
required, because npm canvas module is not available as a
binary package on all target platforms, and it does not
compile without warnings from source.
Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
Change-Id: I03e1d72d96ec0d6863ccd6236223a87ee481eb09
Reuse createIconURL so it runs through the iconURLAliases before
inserting image url
Example: Chart icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia87b064c967df00c796d36fee577f4fd0f260a6f
Adding a margin to the first child only when it is selected is not
smart and causes tabs to move horizontally
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I89cb0c0e96cbb990ecdfb633f186ab5ea1c54078
