Commit graph

9637 commits

Author SHA1 Message Date
Pedro Pinto Silva
814f4e91f5 CSS Files Clean-up: moving rules targeting mobile to specific mobile css files
- mobilewizard rules both from toolbar.css and toolbar-mobile.css to mobilewizard.css
- Hamburger menu rules from menubar.css to menubar-mobile.css
- scrollbar rules from toolbar-mobile.css to scrollBar.css and add media query
- and remove unecessary comments

Change-Id: I5372455ba723d334472b14df556825b1a3734922
Reviewed-on: https://gerrit.libreoffice.org/82298
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-08 14:50:41 +01:00
Jan Holesovsky
07d5f8cf2a killpoco: Remove POCO usage from FileUtil.cpp when C++17 is available.
This introduces basic C++17 support, because the functionality needed
here is easy to implement using std::filesystem.

Adds also the necessary checks to ./configure.  The code still uses POCO
when C++17 is not available in the compiler.

Change-Id: I03353834d10201bf0a13ea72715560b9b9b16265
Reviewed-on: https://gerrit.libreoffice.org/82294
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-08 13:56:09 +01:00
Jan Holesovsky
9d535ca76d Deprecate TemplateSaveAs and document TemplateSource.
Change-Id: Ic9c7bed3ebcf2356470323804bca957acafcbf23
Reviewed-on: https://gerrit.libreoffice.org/82284
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-08 13:53:44 +01:00
Pedro Pinto Silva
3dc6dd3e50 mobilewizard: spinfields:
- hide number of lines icon
- edge case: adjust width of various spinfields to account for inexistent units

Change-Id: Id8bee7731ee888821d95c3f8c423bcca53866d64
Reviewed-on: https://gerrit.libreoffice.org/82268
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-08 10:15:10 +01:00
Andras Timar
617886d09c Ctrl+K should show the new JS hyperlink dialog
Change-Id: If8f210870af9fc4b1d8955ccd1380593ec322611
2019-11-07 23:13:52 +01:00
Michael Meeks
abb79a015e Replace 'includes' with '$.inArray' for IE11
Change-Id: I91c0d392ff9e7e359beb9197a80fa61bfe229a3c
2019-11-07 19:11:28 +00:00
Pedro Pinto Silva
245b3c5779 mobilewizard: shape: add line width icon
Change-Id: Ibf973971efbff7e84d163924131b303217fe1585
Reviewed-on: https://gerrit.libreoffice.org/82240
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-07 17:37:13 +01:00
Pedro Pinto Silva
e403b5a1fa Fix: writer: table properties: spinfields
Change-Id: I49b05b5504d1849b8df6203716e9b32eb25508e2
Reviewed-on: https://gerrit.libreoffice.org/82227
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-07 16:37:44 +01:00
Szymon Kłos
83bda09b91 jsdialogs: send .uno:LineWidth to the core
Change-Id: Ib09c4b8b5f5d22b66330ad96ec917646ff2189e2
2019-11-07 16:08:53 +01:00
Ashod Nakashian
8a28a560f2 leaflet: add sidebar buttons to Impress toolbar
(cherry picked from commit 00b0c3156b5a574f7ee98f4166fd127976ea1b56)

Change-Id: Ib21db9e950cfe828ddff66a8e5bb517331610d04
Reviewed-on: https://gerrit.libreoffice.org/82225
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-07 15:41:40 +01:00
Ashod Nakashian
19ee9f089b leaflet: flag complex selection for graphics
(cherry picked from commit ac5b9907ce36ad5ee6e77ea32dd95f0f1483c97f)

Change-Id: I9b13cdcc7972bc24ba22cba1ff99039bc19aeef8
Reviewed-on: https://gerrit.libreoffice.org/82224
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-07 15:41:28 +01:00
Szymon Kłos
3b7f266c8b jsdialogs: clean value from all non-numeric chars
So spinfields won't be empty due to unexpected characters

Change-Id: Idefaf9d02c43d2cd780a66c375f4ed6d765fc516
2019-11-07 14:52:28 +01:00
Szymon Kłos
27d90f6084 Avoid undefined on saving using menu on mobile
Change-Id: I77602996f2b965fa568faeb219e32602d33c7ef4
2019-11-07 14:37:36 +01:00
Pedro Pinto Silva
e918ce6fe9 mobilewizard: Add missing icons and fix paddings
- writer:shape properties
- calc: cell properties
- calc: chart properties: hide position icons

Change-Id: I228722a260a39552cc9addf97b225e747728557b
Reviewed-on: https://gerrit.libreoffice.org/82195
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-07 14:31:55 +01:00
Andras Timar
d86626c926 Online Help: update Copy & Paste section
Change-Id: I96b7171b1b144093ea1762b3c96a6b2a2ec22bc0
2019-11-07 13:03:07 +01:00
Jan Holesovsky
189cd0e389 killpoco: Get rid of Poco::Process:id() usage.
Change-Id: If060767389f9fa57deba1ceefc872bac03763498
Reviewed-on: https://gerrit.libreoffice.org/82208
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07 12:24:53 +01:00
Jan Holesovsky
5d0d3a4869 killpoco: Get rid of Poco/Thread.h from the rest of the Android-related files.
Change-Id: I724230a4428cab3cc26245ac4aa43a91af2e09ce
Reviewed-on: https://gerrit.libreoffice.org/82204
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07 12:24:26 +01:00
Jan Holesovsky
f0ea9701d8 killpoco: Use std::thread instead of Poco::Thread.
Change-Id: I533429412f269cff8714407f3b99aef0ff133abf
Reviewed-on: https://gerrit.libreoffice.org/82199
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07 12:24:01 +01:00
Jan Holesovsky
5b5e29b430 killpoco: Don't use POCO for app exit values.
Change-Id: I2948ac45a7b4243f7afde08d5245530fdbf9a070
Reviewed-on: https://gerrit.libreoffice.org/82125
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07 12:23:47 +01:00
Ashod Nakashian
58b4734f9e leaflet: focus the editor after loading
This is a combination of 3 commits.
This is the 1st commit:

leaflet: focus the editor after loading

We might not have the input focus after
loading the document, so we make sure we
do grab it so the user can type immediately
into the document without clicking in it.

This is the commit #2:

leaflet: focus the editor after loading - fixing recursion.

Grim recursion causing stack overflow and worse:

_activate (Map.js:1092)
_onGotFocus (Map.js:1253)
(anonymous) (Map.js:256)
fire (Events.js:146)
close (Socket.js:106)
connect (Socket.js:45)
loadDocument (Map.js:261)
_activate (Map.js:1092)

Makes re-connection when server re-cycles work again.

This is the commit #3:

leaflet: focus the editor after loading - fixing madness.
(cherry picked from commit 983005ff5763e78cdd5400df60e3bc9600a3e961)

Change-Id: I875750e85063101853fc65c75f322e82e09c3320
Reviewed-on: https://gerrit.libreoffice.org/82149
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-07 12:13:46 +01:00
Ashod Nakashian
314432fbea leaflet: specify MasterSlidesPanel menu's uno property to handle state change
Even though we don't use the uno command (as the type action, because
this entry doesn't exist in Core), we need it so the statechange
notification updates the check state of the menu.

(cherry picked from commit b536707f1708b24201fdeb721cdd1c83a4326aef)

Change-Id: Ia24d94f146ca4a0a557a2e2557f8cc34cc2dc20e
Reviewed-on: https://gerrit.libreoffice.org/82148
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-07 12:12:11 +01:00
Ashod Nakashian
cd21bedb54 leaflet: toggle between showing master page and closing it
(cherry picked from commit 29146e4224ae00f825a89e8759e5a2c8b5b8767b)

Change-Id: I9ba3d442cea1f3d45d296f1fb1c877cc9a56a3dc
Reviewed-on: https://gerrit.libreoffice.org/82147
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-07 12:11:59 +01:00
Ashod Nakashian
8f682398be leaflet: handle SlideMasterPage state change
Incomplete. This is a stub hinting at what needs to be done.
The menu entry should toggle between Master Slide and
Close Master.

(cherry picked from commit b7cc9a909d5b1d97d6a8f8268ffa8d3e47074f9d)

Change-Id: I1ce7e15e72483eae520bf4914e03609446a6c71d
Reviewed-on: https://gerrit.libreoffice.org/82146
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-07 12:11:45 +01:00
Pedro Pinto Silva
0e4465ca68 mobile: Vex dialogs: Add extra fixes to account for width changes from external css
Change-Id: I3d96b4b24890bf73eb14f2ebc3c6cba9ab54adc1
Reviewed-on: https://gerrit.libreoffice.org/82191
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-07 11:53:16 +01:00
Jan Holesovsky
13df611403 android: Allow specifying the versionCode from ./configure.
Change-Id: If3f618bd836d236e76bd4698321ec7314ebac1a4
Reviewed-on: https://gerrit.libreoffice.org/82177
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-07 09:39:48 +01:00
Tor Lillqvist
6aca28d0f1 Add some more source files to the Xcode project for debugging convenience
(It is, sadly, apparently possible to set breakpoints in advance
(before the code has reached that file) only in files that are listed
in the project.)

Also drop the nonexistent "filter" directory in Resources. (It is
config/filter.)

Change-Id: I96ec9dd8dc4591db9d640b01fb07e807565670cb
2019-11-07 08:45:05 +02:00
Tor Lillqvist
253e3245d1 Make the sidebar show up again in the iOS app on iPad
Reduce confusion between whether to use "jsdialog" (also known as
"mobile wizard") or the sidebar.

Make core's comphelper::LibreOfficeKit::isMobile() equivalent to
window.mode.isMobile(). Decide whether to send the .uno:LOKSetMobile
message using the same condition that the function _inMobileMode()
uses, i.e. (L.Browser.mobile && screen.width < 768).

(window.mode.isMobile() is the same as _inMobileMode().)

Previously, on iPad, comphelper::LibreOfficeKit::isMobile() returned
true so the code in SidebarNotifyIdle::Invoke() in
sfx2/source/sidebar/SidebarDockingWindow.cxx did the jsdialog thing,
but the loleaflet code still did not handle the jsdialog message in
_onJSDialogMsg() in loleaflet/src/layer/tile/TileLayer.js.

Change-Id: Id7633ad3dd2dc79f1d845e07b0bf89f07ddd2625
Reviewed-on: https://gerrit.libreoffice.org/82157
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-07 07:27:25 +01:00
Andras Timar
4c52879a6a loleaflet: l10n of 'Served by:' string
Change-Id: Ifb67af0a15d308baff7242f486077235f79c063a
2019-11-06 23:30:48 +01:00
Henry Castro
555ef04e67 loleaflet: adjust the margin property for the new cursor handler image
Change-Id: I83c83de60cd8b099d157881c63a027493130e5cb
Reviewed-on: https://gerrit.libreoffice.org/82175
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-06 21:01:08 +01:00
Muhammet Kara
94c3896809 Smarter(?) valueset image handling
Instead of adding one entry per image into the
css, just adding the image of a valueset element
into the loleaflet/images directory is enough now.

Change-Id: I5deff7c9537ede713120f581f96bfb2aefb11fa0
Reviewed-on: https://gerrit.libreoffice.org/82162
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-06 18:22:47 +01:00
Pedro Pinto Silva
6a377fa044 Impress:mobilewizard:table and paragraph properties layout
Change-Id: I9eecf18bfff03a7040dd7ca006be77f4d3fb2810
Reviewed-on: https://gerrit.libreoffice.org/82141
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-06 17:12:59 +01:00
Pedro Pinto Silva
f91e1266e2 mobilewizard: table properties:
- detected malformed svgs from colibre theme  (fix metadata)
- add missing icons
- add special styling for Delete Table and merge cells
- arrange elements
- fix spinners

Change-Id: Ie9ec6ebf273ff3a307793b45bb600bf986f1f31c
Reviewed-on: https://gerrit.libreoffice.org/82137
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 17:09:21 +01:00
Muhammet Kara
b74b8e77a9 Add images for chart types
from colibre on cp-6.2

Change-Id: Ibc0599bbbf1245fce72a6257421158ff0521cdb0
Reviewed-on: https://gerrit.libreoffice.org/82156
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
Tested-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-11-06 17:05:56 +01:00
Pedro Pinto Silva
ca4ebc481b Vex: idle: differentiate styles depending on device
Change-Id: I236e64b2688e38c6651563f2c206a7b9276bae50
Reviewed-on: https://gerrit.libreoffice.org/82131
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:41:53 +01:00
Pedro Pinto Silva
79456ef1ff Impress: mobilewizard: hide wizardheader when in landscape
Change-Id: I4105f94351181b61a97d7db9e6caae6d8dfcd891
Reviewed-on: https://gerrit.libreoffice.org/82150
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:41:44 +01:00
Pedro Pinto Silva
8fc3a5bdc4 Vex: input: fix paddings and widths (mobile and desktop)
Change-Id: I0f1882ca785b211ffd18bdbc972c1152cfa3d275
Reviewed-on: https://gerrit.libreoffice.org/82126
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:30:33 +01:00
Pedro Pinto Silva
ae119a4102 impress:mobilewizard:paragraph: fix icon arrangements and hide labels
Change-Id: I5c7d1be30fcbdecefe894c27c46bce29a0f082c2
Reviewed-on: https://gerrit.libreoffice.org/82081
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:30:11 +01:00
Pedro Pinto Silva
526056f630 Fix search on mobile (including in the meadia query)
Change-Id: I4384bc1c29b5081ed5c1b40bad68567c208aa574
Reviewed-on: https://gerrit.libreoffice.org/82080
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-06 16:30:00 +01:00
Andras Timar
88565f3d88 Updated Slovenian translation
Change-Id: I1bd235c872c97058fe33d8aa30b885d649438959
2019-11-06 15:54:56 +01:00
Marco Cecchetti
545b85fb1d loleaflet: color picker: more shades
Change-Id: If231683caa1678f3391429b10762ed800790574a
2019-11-06 15:46:49 +01:00
Ashod Nakashian
d902160dd5 leaflet: use uno command for button id to toggle the buttons when active
(cherry picked from commit 9c2baffc0e20db5e5ff4ba86bb1dc0543b6a4662)

Change-Id: Id48d739d10eac90785ba89a06613b89d3b615300
Reviewed-on: https://gerrit.libreoffice.org/82115
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:49:12 +01:00
Ashod Nakashian
f1398335d8 leaflet: label server-id in the about box and open in new page
This adds a label 'Served by:' before the server-id in the
about box, and opens the discovery page in a new page to
preserve the document page.

Change-Id: I3f934f7e25743e400f9e38f7604b5cc7d0c850ca
Reviewed-on: https://gerrit.libreoffice.org/82022
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:44:06 +01:00
Ashod Nakashian
7a976488f0 wsd: cleanup the global flag accessors
The following flags are affected:
ShutdownRequestFlag
TerminationFlag
DumpGlobalState

Since it's common to grep for all places
that set or reset these global flags, it
makes more sense to have explicit functions
for each operation. Now we have set and reset
accessors where appropriate and get is reserved
for read-only access.

This changes the getters to only return
the boolean value of these flags rather than
a reference to the atomic object, now that
they are read-only.

Also, a few Mobile-specific cases were folded
either with other Mobile-specific sections, or
they were now identical to the non-Mobile case
and therefore deduplicated, making the code
cleaner and more readable.

Change-Id: Icc852aa43e86695d4e7d5962040a9b5086d9d08c
Reviewed-on: https://gerrit.libreoffice.org/81978
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:43:45 +01:00
Ashod Nakashian
887ecdb8d3 wsd: leaflet: Insert background
This adds support for .uno:SelectBackground
which inserts slide background image.

(cherry picked from commit 30a77e7e490e4e83bb6423f41388ee9adbccfae3)

Change-Id: I587b31f67d518aba348ae7e8d058ada23a61e858
Reviewed-on: https://gerrit.libreoffice.org/67500
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:43:02 +01:00
Ashod Nakashian
f86a1cb016 leaflet: add impress menus for sidebars
(cherry picked from commit 3309b8b637488b0b20894f4d16be3e132efa8bee)

Change-Id: Idc51426994cdbf679592c397122c1e4dfc314abe
Reviewed-on: https://gerrit.libreoffice.org/81975
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:42:49 +01:00
Ashod Nakashian
35fdc48e28 wsd: upload to storage when per_document.always_save_on_exit is set
Saving the document on exit is not enough, we also need
to send it to the storage. We now force doing that,
even when there is no modifiction to the document
(i.e. a new version wasn't really saved).

Reviewed-on: https://gerrit.libreoffice.org/81336
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
(cherry picked from commit f2913f20b03e916ce8a70f927ca3f5655a3768a8)

Change-Id: Ic4e1b1424f32d3141e98c936a51e47c9e4b9f753
Reviewed-on: https://gerrit.libreoffice.org/81576
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2019-11-06 03:41:44 +01:00
Michael Meeks
967d3a4156 Mend touch sizing of rows & columns.
Change-Id: I6bcd8a24972845fd37d8c7eafbcc0124fcd1a25c
2019-11-06 01:20:30 +00:00
Michael Meeks
0a8c8d7fc5 Enable spreadsheet pinch to zoom.
Change-Id: If8e4b87a78eeed6bb6a543d9acd532d5e096c540
2019-11-06 00:57:20 +00:00
Michael Meeks
a8924e6e6f avoid crash prior to load when _tileCache is not yet created.
Change-Id: Ic8b3b25af23df7638f0ccf48740f2267612e4e8b
2019-11-06 00:33:37 +00:00
Michael Meeks
80f9017acd calc: repair context menus.
Change-Id: I8efc4bf9d1dee745ddd31167cae3342ff9122d2e
2019-11-05 20:47:07 +00:00