strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
15637 commits 1 branch 0 tags 244 MiB
Commit graph

15637 commits

This branch
This branch
All branches
Author SHA1 Message Date
Gökay Şatır
305ddf001c CommentListSection: Move comments closer to the document. 
When view width is small enough.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I10ad0a55ef4c694bf9e989ed9f1b0b528596b0c4
 2021-07-09 21:05:40 +03:00
Gökay Şatır
7c234a78d5 CommentListSection: Set background color. 
Same with CanvasSectionContainer.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib4002ddb534b0e81d67fd1c1e099c84c093eed4c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9fb8b1951f WriterComments: Remove svg from commented text. 
SVG was still being used for this document type. Now we use canvas for
drawing commented portion of the text.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ibf51b5fbc5862afcbd255a41fe8ec092e12e2531
 2021-07-09 21:05:40 +03:00
Gökay Şatır
db8adee6a0 ScrollSection: Apply windowSection changes. 
Improve sizing.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iad3fbdb82acbaf2b561219fc57b3ac52b0e065f9
 2021-07-09 21:05:40 +03:00
Gökay Şatır
4eec421c0b CommenListSection: Correct view size calculation. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I977282eccb1a6d008f1b33a66cbd623383ba08d7
 2021-07-09 21:05:40 +03:00
Gökay Şatır
733663f077 CanvasSectionContainer: Improve debugging. 
Draw section borders when applicable.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7d8494b3a9f5b0ce38518af2889fb7f5cdb03028
 2021-07-09 21:05:40 +03:00
Gökay Şatır
aeeb3cd512 CommentListSection: Remove unused variable. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I313a48c29ededaab3b39bde7365e220e9856f32c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
2528f4c586 CanvasSectionContainer: Add windowSection property. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib5b5692e2bf57a8bd109c1338caf7b9dad7d6de1

Change-Id: Ib11e0cc7ded6bdc3c07b4431fc69b00fabcee5a9
 2021-07-09 21:05:40 +03:00
Gökay Şatır
cece2c0035 Calc: Comments on different tabs shouldn't prevent each other from being 
shown.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I50c4bf98ef3ba00ffbd77b595aacf2e5f92e5f53
 2021-07-09 21:05:40 +03:00
Gökay Şatır
0e987abcca Impress & Draw: Tablet view improvements for comments. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If25d1262aa849b147782f7a6f547833a702eab27
 2021-07-09 21:05:40 +03:00
Gökay Şatır
213708eece CommentListSection: Cosmetic changes. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ica5f345cb42916f57ba302193c0b8a7669199411
 2021-07-09 21:05:40 +03:00
Gökay Şatır
f0d7cb40ef Calc Comment: Tablet view improvements. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib6fae1b675ac293044e3a829edeaf51648becd73
 2021-07-09 21:05:40 +03:00
Gökay Şatır
63eb3c29bb Comment: Enable click event for touch devices. 
Also, set position of the document object (comment) according to dpiScale.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I276150c4dc6acd05874616082f6baebff1c42666
 2021-07-09 21:05:40 +03:00
Gökay Şatır
5a15a4b827 CommentListSection: Add dpiScale to CSS positions. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2fcc3f3845899dd7cedd042757a144d63ddbdb07
 2021-07-09 21:05:40 +03:00
Gökay Şatır
1cde8cae76 TouchGesture: Add unselect function. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib658e0ccda93498fc2daabfc9d663367eb17649a
 2021-07-09 21:05:40 +03:00
Gökay Şatır
e004ea3e33 CommentSection: Separate writer only part. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I755b37297a6b8db25b9918265c13bebdf1238d84
 2021-07-09 21:05:40 +03:00
Gökay Şatır
248e57eb33 Fixup for unselect function call. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ie40d9a6e32ed5327312d44af93c86acdcc2396ba
 2021-07-09 21:05:40 +03:00
Gökay Şatır
9bc9dcc0f9 Make dpiScale variable global. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3405a4b2d03a7b0bc28cc6d6e2f36f62331003ff
 2021-07-09 21:05:40 +03:00
Gökay Şatır
c8f0e255b0 CommentListSection: Remove unrelated comment. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id222dd2f9889137fe96cd63d575f8f8645940a2b
 2021-07-09 21:05:40 +03:00
Gökay Şatır
507c42364f Impress mobile: Scroll to position when a comment is selected on mobile 
wizard.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic763ee890301c2c006073e08766358f98ae066e0
 2021-07-09 21:05:40 +03:00
Gökay Şatır
7df00fed68 Impress: Select command when marker is clicked. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib687080244194398753ee2effd33686041b7e69d
 2021-07-09 21:05:40 +03:00
Gökay Şatır
478907a883 Map: Remove unselect comment codes. 
Propagation is cancelled by the comment section. No need to handle it
inside map class.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I011982d3d8691f5d6ca47fa56f7c826538909e57
 2021-07-09 21:05:40 +03:00
Gökay Şatır
104bab1da9 PDF view: Don't show previews while comment wizard is open. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7a1ebdb62d16afdd9abe2eb63a566eeee5471a04
 2021-07-09 21:05:40 +03:00
Gökay Şatır
347c857326 FileBasedView: Show all comments. 
Not only of the selected part.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Idb409c447e083cb76f124275e21f5ef4f87e72fa
 2021-07-09 21:05:40 +03:00
Gökay Şatır
34d5f4d519 PDF Scroll: Find most visible part. 
There was a bug in the function.

Also, onLostFocus function's bug is solved.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic793999c58e13c9a42d00a4c19e44285aad8c750
 2021-07-09 21:05:40 +03:00
Gökay Şatır
469b18877e Draw Comments: Run show/hide comments for drawing. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I3a1a85f8623d26f7a195fd2dba9dcc73facc3568
 2021-07-09 21:05:40 +03:00
Gökay Şatır
f65fcce2e1 Impress Comments: Bugs solved. 
Show & hide comments function is improved.
onlostfocusreply function is improved.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ie63dc27a8cf5754a094ce14c2446a758848fb197
 2021-07-09 21:05:40 +03:00
Gökay Şatır
353f866f08 Calc Comments: Improvements. 
Scroll to comment's position.
Solve "content not shown" bug.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id62d7407bc66c5fd17590c37f3fdd01246cbe245
 2021-07-09 21:05:40 +03:00
Gökay Şatır
c7a1adfd44 CommentListSection: Hide when unnecessary. 
When file type is spreadsheet or there or no comments or it is mobile
view.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I54e02b644ae62efeb5bd9917f99e86d3e90f1bea
 2021-07-09 21:05:40 +03:00
Gökay Şatır
eabbb8c553 Calc: Adjus Column header width. 
According to commentList section.

CommentListSection will not be shown on Calc, if it was shown it would
be ok.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I362d2ad490712b3958ed7c6fe3c04816d0e7a48f
 2021-07-09 21:05:40 +03:00
Gökay Şatır
6e16068b1f Writer: Bugs related to comments solved. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ifcf3b53c1fc106cb412f953008aa0666bccaf51c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
a71276fcc4 CanvasTileLayer: Remove unused functions. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I9624c161f667a184bd9fc4b2463a755284a0754b
 2021-07-09 21:05:40 +03:00
Gökay Şatır
036c12e182 Writer: Use the same svg for highlighting. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ife94ce6fb342543552177cb3a22b7f3b8e33e824
 2021-07-09 21:05:40 +03:00
Gökay Şatır
6e83f0ffa8 Remove AnnotationManagerImpress and AnnotationManagerBase files. 
They are replaced by CommentListSection.ts.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I85f9ae49e487fa621376a79812774c1ea2615e9e
 2021-07-09 21:05:40 +03:00
Gökay Şatır
fa6a84bb40 Annotation.js: Remove. 
It is replaced by CommentSection.ts.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I02338b56e788188c55a1254a69f21943624e5d43
 2021-07-09 21:05:40 +03:00
Gökay Şatır
534facef7a Comments: Rename files. 
CommentSection => CommentListSection
Comment => CommentSection

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ib90120059330b6969d608be4f4db2a7fe302adc5
 2021-07-09 21:05:40 +03:00
Gökay Şatır
3a362f68ce Calc: Activate comment section for mobile. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I0dcc6edfd33209d031e1ff20d81aaedaee6f9016
 2021-07-09 21:05:40 +03:00
Gökay Şatır
d77ac3e050 CanvasSectionContainer: Enable opacity for background. 
Sections can set opacity for their background colors.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I04a0d7e84fc66e4757e4f4053effd8b843acaf94
 2021-07-09 21:05:40 +03:00
Gökay Şatır
1e42791ba7 Calc: Activate commentList section for desktop. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I80fab4624770a89fb742c1cffaf96edc24d5963e
 2021-07-09 21:05:40 +03:00
Gökay Şatır
bc54b1d12c Calc: Add cellCursor global variable. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I8314367ed87742cedd02f0c60cee1ad9b748b4ec
 2021-07-09 21:05:40 +03:00
Gökay Şatır
a9472bd06b CommentSection: Disable doLayout for Calc. 
And remove unused variable.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I979cf084fa8169789d4a32684ccc0c7de046b911
 2021-07-09 21:05:40 +03:00
Gökay Şatır
5267a4ba25 CommentSection: Enable mobile view for drawing. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id49b6243a3662dcdb1ba909b86213eb3a3c07a5a
 2021-07-09 21:05:40 +03:00
Gökay Şatır
ac4fec12a4 Comment.ts: Remove commented code. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I75747144e4949de7f1a2e9605d7bfba08bda9e25
 2021-07-09 21:05:40 +03:00
Gökay Şatır
7b471f70fd Mobile wizard: Adjust for flex view. 
Scroll bar wasn't visible on hamburget menu.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I204b8a60d5b813de5735dbe741b861460a039f30
 2021-07-09 21:05:40 +03:00
Gökay Şatır
2bb25ed742 Comments mobile: Hide them while wizard is closed. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2d42a765a106605c5b6b1582ea4929b59aae7d06
 2021-07-09 21:05:40 +03:00
Gökay Şatır
bf9abab883 ImpressTileLayer: Remove unused function. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: If8489bd00924e426179d52a1055b1edf53df4b0a
 2021-07-09 21:05:40 +03:00
Gökay Şatır
2f4e4553b1 Impress: Activate comments on mobile. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Id4faf1f5acecae49854adb6687377b73e70555e6
 2021-07-09 21:05:40 +03:00
Gökay Şatır
78fe4887e1 CanvasTileLayer: Remove redraw call. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I92930e3590ecade0dac3340e5476317b03910d09
 2021-07-09 21:05:40 +03:00
Gökay Şatır
37ef68aa43 FileBasedView: Solve flickering. 
Deciding to remove a tile needs a different approach in file based view.
Because viewed tiles are not sync with core side.

Also, while refreshing a tile, clearing the target part was causing
flickering.

Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I7067fb014fedb571440c545b3b5358922325ed7c
 2021-07-09 21:05:40 +03:00
Gökay Şatır
6f28cf574f CanvasSectionContainer: Remove debugging color. 
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I67d524569208ef124b78d209d168d7e8129083a9
 2021-07-09 21:05:40 +03:00