Use new id for snackbar with progress and style it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I24a1647f0f629b7b079aa65601f4309c339a06e8
Before this, the padding-right was being set to 0 (probably to save up
space) but this is not the way to do it. It looks weird when the focus
is set to that button.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib60b32cd9d0f5f42444cadef121be32c15941483
Reusing progressbar dialog allows us to show it's the
same process for the user. So even if it is instant he
will see 100% progressbar and that button become enabled.
Create new file for functions which manipulate existing
modal dialogs.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I765483b940f47bdfbcf8a488ea7d0ab9569ccda9
We no longer create that w2ui bar and we also have removed any element
with that id or parent from cool.html.m4 with that name. So, this can
be removed.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I26c9e66de44fe8a8f8ad785031c640d32960a350
The scroll indicator set with an absolute position ends up being
positioned in the 0 y coordinate. Since the wrapper has a top padding
of 3 pixel it means the scroll indicator is not 3 pixel off.
Also, and since these measurements are set in the CSS (the height of
the wrapper and the padding of the other wrapper), better to just move
everything to the CSS and avoid unnecessary inline styles.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icc1e51b2590ee27b318f9e4c3d550183b08cb49d
This fixes regression from:
commit 07c3538589
mobile-wizard: create separate window container
The snackbar with action button like "leave feedback | ok"
or "we can reconnect | reload" had buttons below text
what looked bad and it was not possible to click
We introduced separate windows inside main
mobile-wizard-content container which have class
.mobile-wizard-content - let's use the same rules
as before for popups
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I506aaf34741fb1ff879c0c5c44a5958d6be9912c
This fixes regression introduced in:
commit b6c26bee91
Mobile sidebar header layout #6861
- remove additional top border
- make line height regular so text will fit into snackbar
without scrollbar
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I72a1e7121d58a7583bd4efce9728c25231c7d8de
With the recent (and very welcoming) changes to steer away for generic
elements such as div and instead use more appropriate/semantic
elements such as button we ended up applying new rules to main-nav
buttons. These rules were only intended to be apply to classic
buttons (rectangle + text inside). Result:
- userlistheader even if invisible was getting a background
on mouseover
- all <button> elements were getting extra padding and margin
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic774fd342df5483cd7210b85c4847688914b28f2
userListHeader, element present in compact and tabbed view to display
users present in the document (avatars), seems to suffer from a odd
alignment and duplicated usage of white space.
Best to remove any hard coded pixel that seem to come from legacy css
and rely on flex if necessary. Also the surrounding elements (doc name
and sidebar icon) already have save space around so they will never touch
on top of that this was having different result than "expected" when
using a different RTL system (since we were not using logical css properties)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iab0869080231ac734c087afeee97d9cd0243030d
Make tab's size dynamic
- Font-size
Instead of using always a font size that looks nice in a wide screen
but that will look cramped and without space in a narrow window:
- change it's size depending on viewport within a safe range
- new css vars added and respective comment in the code
- Also we use clamp css function but we also add a fallback for old
browser using the generic calc css function
- Padding: allow to get lower levels when the viewport is reduced
Hide document-header when the window is narrower than 800px
- this frees up space and also benefits tablet us case where user uses
2 apps side by side
Document-title bar
- Hide document name if the window is too small. This makes it
possible to fit all buttons without horizontally scrolling the main-nav
- Note user can always access the rename feature by going to File > Rename button
- Remove any hard coded pixel positioning and instead rely solely on
flex layout
Main-nav
- should always occupy (width wise) 100% of the viewport. We want
always the far left icons be always at the end of the viewport
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I58843f40e21d26f955422d6159b5777144b684fd
Before this, when using a narrow window, the top bar wouldn't be
scrollable until we would press the avatar list. Also when switching the
modes it would becomes unscrollable yet again.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I01b2afcb125a2addf9847e2581f9498105b54b00
Before:
"When I use the "clone formatting" tool, I have to point the handle of
the brush icon to the cell I want to clone rather than the
brush. Logically I would expect to point the brush part to the cell I
want to clone, but because the handle seems to be the point at which
cloning occurs, I end up cloning the cell above and not the actual
cell I want to clone."
Fix vertical coordinate so the bottom of the hotspot is in the brush
and change the outdate comment WRT the png in question.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I69e0935542c068016366a26d8100866c23ca17dc
how it is expected to work:
before this patch, whenever comment is saved,
editing comment box(DOM elements) is deleted and
a new comment(DOM elements) is created when we recieve the data from server about saved comment
This commit prevents the deletion of the original comment box which is being edited,
if comment loses focus it is saved. If user explicitly saves the comment then it
follows the routine which were used previously.
Many checks were added to prevent comments from getting unselected(select means it is highliting the text in doc)
or getting collapsed
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: If24ccbcd7a0287b659f790db486ada5d17608a32
we request entries with dpi scale factor to
generate bigger (higher resolution) previews
then entries are scaled down in CSS to keep
relative size to other components constant
but text become smooth thanks to bigger resolution
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I00c59be45a92667768385f7f70c1ccd8248095af
- invert colors of images in dark mode
- don't invert in style previews to show real effect
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2005cd068b3f9a636e24307a3035728f4e139379
Combobox will be real combobox (edit field + dropdown).
Adjust styling from old .select2 rules to our combobox.
Remove old code for select2 comboboxes in notebookbar.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id3ea16bcb004675cb7d5743f394ac432e74918cf
- also fixes the misalignment in cool-annotation-table
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I58db4c6918c3a36a230c6f9317ddf39c3361bb24
A regression in change ID I8551242fc2b987f00c67088caa0ed07ee8526a72
caused the manage changes dialog to continue expanding when new elements
were added, no matter how big it got. This would cause you to be unable
to see all the changes when there were a lot of them because you could
not scroll through the list. This patch fixes the scrolling, without
making the list area very small again.
Change-Id: Ib29fb161522773ea9893b7bc21d06aab19b74c52
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Without it in calc -> insert -> chart treeview
for chart type selection was invisible / 0px width
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaf28c4860adcd00591a638fa10838fe8719bee23
- to show previews we use slide-sorter element
and presentation-controls-wrapper as container
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iaed0892779d5016a565d556955305317129edea4
The input field is already being hidden for mobile. For Tablet and
with the increased amount of UI elements on the top bar best to hide
it also. Renaming the document is a quite rare used action when
compared to any of the other top bar actions (switching tabs, open
sidebar etc). Better to hide the #document-name-input when on tablets
instead of trying to fit everything (and end up obstructing tabs for example)
Tablet user can always:
- Use the integration (already used to do many other file manipulations) to rename the file
- Use the in-app Save as can still be used to save a copy of the current
document with a different name
----
Possible future improvements would be to add the possibility to rename
the file when using a tablet:
- Add menu entry and tabbed view button
- Control.Menubar.js something like {name: _('Rename Document'), id: 'renamedocumentbtn'}
- Control.NotebookbarWriter.js add bigtoolitem Rename Document
- Maybe in Control.UIManager.js add a renameDocumentBtn function that
- Creates a JSDialog with document-name-input element + Cancel btn +
OK btn
- Ideally that input element would re-use the functionality from L.control.documentNameInput() -> Control.DocumentNameInput.js
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I968e806a4a9e0018b38b87fc249a57e5af099c78
- accessibility key features
- focus on tab when press `Alt`.
- move back and forth tab focus by ArrowLeft and ArrowRight
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Id8c8e2a8bcb57c90e0762dd3916b851fff8e0a6f
If we set the initial backgrounds without `!important` then there is
no need to use `!important` for dark-mode (since we are already using
a more specific targe via data-them attribute)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I600629dfc0485edac6ff725f6278de1501e1c9a7
Large Clipboard and document idle modals were being set with tabindex
0 allowing for manual user focus plus were being focused dynamically
for each instance:
- Transfer all that (just once) to showinfomodal instead for the
cases where we have buttons
- This in turn sets the things to the parent (dialog itself)
and not the subcontianer
- Set tabIndex with negative value so, it only allows focus via
code
- This fixes the weird outline (focus) that sometimes would appear
on sub containers of that dialog instances
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If40192e05c4b0e25e2ce71bc612ab64fc54a29ec
With c04c065edc we start to dynamically
set the canvas background. The problem is that for Calc cells do not
have intrinsically a background and thus what we end up to see as the
document background color is actually the canvas color.
- Make sure that when we are in presence of calc we set the
canvas color (clearColor) with the value coming from
documentBackgroundColor
- To make it clear: create a new CSS variable to be used as
background-document
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4c456e4aeea233609ee58684d967984dd8afd63a
Set Minimal width for suggestions list
Added some padding for spell check text box for more readability
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0fa5bb60ece88e4107408448a17378b526020784
