menu is open and the quarter circle became a ellipse. Fix for these.
Change-Id: I0e31f702bc006c2e87705d1d63e3fa939270d5ca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90923
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
They weren't even used consistenly instead of the literals 'INCOMING'
and 'OUTGOING'.
Change-Id: I70da22df669f8eaa5943b460e5b12b3cf100ca8e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91002
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I37b2ca41824e8d0aed7ff03cddb32b1c4ce2949f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90981
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Don't bother with different local names for the window.mode.isMobile()
etc functions. Don't bother storing return values from then in local
variables.
Change-Id: I0bb5b57683ab8007ebb30f8d37213489dcdbdd6b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90977
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This will turn into the HYPERLINK message and make it work to click
them in the mobile apps, too.
Change-Id: Ibf1829a16887db2a6797c08996bd52882b54a657
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90935
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
LOOLWebSocket is used only for tests and a few tools anyway.
Change-Id: I18e04efc2fb3a4cc075f7cefa4ebd0d10fbdb3df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90974
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Potentially cleaning up jails used by other WSD's breaks parallel
unit testing quite badly.
Change-Id: I159b87cc36648beb40eea0e363f924eefdf6ebca
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90942
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
On mobile UI there should be no tunnelled dialogs. But if there are some,
by mistake, at least they should not have a non-working Help button.
Change-Id: I88001f560eefd0ac9163dd6893b7f0c4d8e50c3a
When we opened again it had both 'menuwizard-opened'
and 'menuwizard-closed' classes.
Change-Id: Ia47bff467f55639a7bebb8ba640604b2617a48d7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90934
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This was added in commit 2174206de1 (android:
Don't hang after returning from a hyperlink., 2020-02-14), but the new command
was only handled on Android. Handle HYPERLINK on iOS, too.
Change-Id: I8c942c1a64c8a52462a749989e312d0d9899a841
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90917
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6f295d6c71d225b20a0e696b46d2765ca344db0b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90904
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Apparently this will cause a regression on iOS; OTOH we have disabled
the landscape mode there for now, so hopefully we'll be able to come up
with the real solution there.
Change-Id: Ie39de95a68e34694e53b4034e8db389546515ba8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90907
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Also handle 'NONE' and 'SOLID' style types now emitted as part of
.uno:FillFloatTransparence statechange message.
Without this the mobile wizard does not show the transparency fill
types correctly for these cases.
Change-Id: Iffecc6dbfbac097310c9c5f53ba3b4dfe39e4756
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90879
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Breaks mobile view in Impress.
TypeError: Cannot read property 'length' of undefined
This reverts commit 9db6f855a0.
Change-Id: I839cde8bb683fc0b933da806f4a4771114eb32f5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90785
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
It is prefereable to move it when the document is initializing
rather than the iteration of toolbar items
Change-Id: I6fd856ed8b7e1b4e3224be09d37d2e86b9dce166
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90759
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This approach is preferable rather than iterating the toolbar items
Change-Id: I81107dde1d6c99b3e5af9793c7b2dff517747ff9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90758
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This test sometimes failed on me just because the load was aborted due
to the timeout, doubling the limit makes the problem go away.
Change-Id: Ided724d67a513391b86836065d4e627581857a92
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90771
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
We actually have commands for submenus too, so
we can use them to generate IDs.
Adjust the icon names, which are now generated from
commands.
Change-Id: I76bb69fb8f83cddfb3d36c3ee74739091bc08f2d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90763
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Broken since: b62dcc0255
The issue here cypress sets the window size and not the device size
when tries to emulate mobile view.
https://github.com/cypress-io/cypress/issues/970
For now, let's keep window size media rules too.
[tml: Window size changes depending on orientation. Device size does
not. We need to change each rule that used only max-device-width into
one using two subrules using max-width combined with comma (i.e. the
OR operator), one for portrait using 767px as the limit, one for
landscape using 1023px as the limit.]
We do this in other places of the css code anyway. In a long term, it
would be good to find a better way to emulate mobile view by cypress
or to detect mobile from JS code, so we can enable mobile mode easily
for cypress tests.
Change-Id: Ic7974f44fcbf6ed2883e93acd28153709514c216
While I was debugging Impress, I received unexpected "undefined"
value of the variable "parts"
Change-Id: Id8b6737155516fd0d8cfaa350170e9c631c55dcf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90756
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
I now think that much of our media queries with (max-device-height:
767px) actually should use (max-device-width: 767px) if the intent is
that they detect the case of mobile phones, as opposed to tablets.
Many mobile phones have a screen.height (which is what
max-device-height in CSS refers to) that is clearly larger than 767.
But a screen.width of 768 is what at least my 9.7 iPad has.
Change-Id: I3b44e32ec583837897b4aa390fc0ab92be59d163
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90752
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
We don't have any other information for the submenu
only it's text and it's children, so let's use
the children's command to find out what submenu we have
here.
Change-Id: I188186142fc1dbe483fcce5b5456e0cb1524382e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90750
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This is an improvement of the commit 569b342c20,
It is better to check the cell cursor width instead of spacing to scroll
the view when very large merge cell occurs
Change-Id: I049cda34f886738ce9fbd3776113a219c5bd038f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90751
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
updating css rules according to the latest html structure
Change-Id: I373e185a444e8f5db3096cd05c9f47f470ef73c3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90747
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
To make it work both with release and debug core
build.
Also disable some tests failing with core/cp-6-2.
Change-Id: I5617712e19dc8aaba0c5f9fbdf9c17d9a19fb18b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90725
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
During parallel build.
Change-Id: I18d78250650e5d16ff9a4ff8588a2e955a934f44
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90721
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
