Commit graph

9823 commits

Author SHA1 Message Date
Pranam Lashkari
7349cc1f32 additional URI support added for some broken Implementation
"/hosting/discovery/"  added in addition to "/hosting/discovery"

Change-Id: I33f7fda9981d8d4e95ca5d69d3d6b3da1e4b0eeb
Reviewed-on: https://gerrit.libreoffice.org/83169
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-19 14:51:17 +01:00
Szymon Kłos
1981e02335 jsdialogs: add id to the combobox
Change-Id: Id62efa14c3ef8019d89101d9ed35415024100b4d
2019-11-18 12:50:02 +01:00
Miklos Vajna
703eb28a97 Convert "uno command" tests to a new-style one
So that they are in-process, which means it's easier to debug when they
fail.

Change-Id: I79eaa8014deda25ae31b0ad5ff38a8023ef0ae3e
2019-11-18 08:56:41 +01:00
Ashod Nakashian
4f15d1bd19 wsd: SIGTERM signals clean shutdown now
Change-Id: I8d5bf7232036bb103cd7433cd5b1c7b5021e06d4
Reviewed-on: https://gerrit.libreoffice.org/83052
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-18 06:48:52 +01:00
Ashod Nakashian
1ae9ce8ad2 test: thread-safe common shared test data
This protects against memory corruptions,
and a cascade of issues, such as the following:

 Attaching to process 56245
 [New LWP 56246]
 [New LWP 56252]
 [New LWP 56253]
 [New LWP 56254]
 [New LWP 56362]
 [New LWP 56364]
 [Thread debugging using libthread_db enabled]
 Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
 0x00007fda228f7d2d in __GI___pthread_timedjoin_ex (threadid=140574279595776, thread_return=0x0, abstime=0x0, block=<optimized out>) at pthread_join_common.c:89
 89	pthread_join_common.c: No such file or directory.

 Thread 7 (Thread 0x7fda197fa700 (LWP 56364)):
 #0  __lll_lock_wait () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:135
 #1  0x00007fda228f9023 in __GI___pthread_mutex_lock (mutex=0x55e9937567e0 <SigHandlerTrap>) at ../nptl/pthread_mutex_lock.c:78
 #2  0x000055e9934cd4fe in __gthread_mutex_lock (__mutex=0x55e9937567e0 <SigHandlerTrap>) at /usr/include/x86_64-linux-gnu/c++/7/bits/gthr-default.h:748
 #3  std::mutex::lock (this=0x55e9937567e0 <SigHandlerTrap>) at /usr/include/c++/7/bits/std_mutex.h:103
 #4  std::unique_lock<std::mutex>::lock (this=<synthetic pointer>) at /usr/include/c++/7/bits/std_mutex.h:267
 #5  std::unique_lock<std::mutex>::unique_lock (__m=..., this=<synthetic pointer>) at /usr/include/c++/7/bits/std_mutex.h:197
 #6  SigUtil::handleFatalSignal (signal=11) at common/SigUtil.cpp:214
 #7  <signal handler called>
 #8  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_capacity (this=<optimized out>, __capacity=0) at /usr/include/c++/7/bits/basic_string.h:200
 #9  std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string (__str=..., this=<optimized out>) at /usr/include/c++/7/bits/basic_string.h:542
 #10 std::_Construct<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (
     __p=<optimized out>) at /usr/include/c++/7/bits/stl_construct.h:75
 #11 std::__uninitialized_copy<false>::__uninit_copy<std::move_iterator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*> (__result=0x7fd9f40017b0, __last=..., __first=...) at /usr/include/c++/7/bits/stl_uninitialized.h:83
 #12 std::uninitialized_copy<std::move_iterator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*> (__result=<optimized out>, __last=..., __first=...) at /usr/include/c++/7/bits/stl_uninitialized.h:134
 #13 std::__uninitialized_copy_a<std::move_iterator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > (__result=<optimized out>, __last=..., __first=...)
     at /usr/include/c++/7/bits/stl_uninitialized.h:289
 #14 std::__uninitialized_move_if_noexcept_a<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >*, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > (__alloc=..., __result=<optimized out>, __last=0x55e995662850,
     __first=<optimized out>) at /usr/include/c++/7/bits/stl_uninitialized.h:312
 #15 std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::_M_realloc_insert<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&> (
     this=this@entry=0x55e9937566f0 <FileUtil::getTempFilePath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::fileDeleter>,
     __position=<error: Cannot access memory at address 0x3735003238323a>, __args#0="/tmp/loadTorture_viewcursor.odp_725a6013_viewcursor.odp") at /usr/include/c++/7/bits/vector.tcc:424
 #16 0x000055e9934aa829 in std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::push_back (__x="/tmp/loadTorture_viewcursor.odp_725a6013_viewcursor.odp",
     this=0x55e9937566f0 <FileUtil::getTempFilePath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::fileDeleter>) at /usr/include/c++/7/bits/stl_vector.h:948
 #17 (anonymous namespace)::FileDeleter::registerForDeletion (file="/tmp/loadTorture_viewcursor.odp_725a6013_viewcursor.odp",
     this=0x55e9937566f0 <FileUtil::getTempFilePath(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)::fileDeleter>) at common/FileUtil.cpp:69
 #18 FileUtil::getTempFilePath (srcDir=..., srcFilename=..., dstFilenamePrefix=...) at common/FileUtil.cpp:97
 #19 0x00007fda216b51c9 in helpers::getDocumentPathAndURL (docFilename="viewcursor.odp", documentPath="", documentURL="", prefix="loadTorture_viewcursor.odp_") at ./helpers.hpp:151
 #20 0x00007fda216ad007 in UnitLoadTorture::loadTorture (this=<optimized out>, testname="loadTorture_viewcursor.odp ", docName="viewcursor.odp", thread_count=thread_count@entry=3,
     max_jitter_ms=<optimized out>, max_jitter_ms@entry=75) at UnitLoadTorture.cpp:41
 #21 0x00007fda216ad7dd in UnitLoadTorture::<lambda()>::operator() (__closure=0x55e994dbc758) at UnitLoadTorture.cpp:186
 #22 std::__invoke_impl<void, UnitLoadTorture::testLoadTorture()::<lambda()> > (__f=...) at /usr/include/c++/7/bits/invoke.h:60
 #23 std::__invoke<UnitLoadTorture::testLoadTorture()::<lambda()> > (__fn=...) at /usr/include/c++/7/bits/invoke.h:95
 #24 std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > >::_M_invoke<0> (this=0x55e994dbc758) at /usr/include/c++/7/thread:234
 #25 std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > >::operator() (this=0x55e994dbc758) at /usr/include/c++/7/thread:243
 #26 std:🧵:_State_impl<std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > > >::_M_run(void) (this=0x55e994dbc750) at /usr/include/c++/7/thread:186
 #27 0x00007fda22de366f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
 #28 0x00007fda228f66db in start_thread (arg=0x7fda197fa700) at pthread_create.c:463
 #29 0x00007fda2261f88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

 Thread 6 (Thread 0x7fd9fffff700 (LWP 56362)):
  #0  __lll_lock_wait_private () at ../sysdeps/unix/sysv/linux/x86_64/lowlevellock.S:95
 #1  0x00007fda225952db in __GI___libc_malloc (bytes=bytes@entry=3635) at malloc.c:3063
 #2  0x00007fda2262f364 in __backtrace_symbols (array=array@entry=0x7fd9ffffc540, size=size@entry=26) at backtracesyms.c:69
 #3  0x000055e9934cc439 in SigUtil::dumpBacktrace () at common/SigUtil.cpp:253
 #4  0x000055e9934cd5ae in SigUtil::handleFatalSignal (signal=6) at common/SigUtil.cpp:236
 #5  <signal handler called>
 #6  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
 #7  0x00007fda2253e801 in __GI_abort () at abort.c:79
 #8  0x00007fda22587897 in __libc_message (action=action@entry=do_abort, fmt=fmt@entry=0x7fda226b4b9a "%s
") at ../sysdeps/posix/libc_fatal.c:181
 #9  0x00007fda2258e90a in malloc_printerr (str=str@entry=0x7fda226b2e0e "malloc(): memory corruption") at malloc.c:5350
 #10 0x00007fda22592994 in _int_malloc (av=av@entry=0x7fda00000020, bytes=bytes@entry=32) at malloc.c:3738
 #11 0x00007fda225952ed in __GI___libc_malloc (bytes=32) at malloc.c:3065
 #12 0x00007fda22db9258 in operator new(unsigned long) () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
 #13 0x00007fda244adaae in __gnu_cxx::new_allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >::allocate (this=0x7fd9ffffe740, __n=1)
     at /usr/include/c++/5/ext/new_allocator.h:104
 #14 0x00007fda244ad300 in __gnu_cxx::__alloc_traits<std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::allocate (__a=..., __n=1)
     at /usr/include/c++/5/ext/alloc_traits.h:182
 #15 0x00007fda244ac858 in std::_Vector_base<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::_M_allocate (this=0x7fd9ffffe740, __n=1) at /usr/include/c++/5/bits/stl_vector.h:170
 #16 0x00007fda244ab7c7 in std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::_M_insert_aux (this=0x7fd9ffffe740, __position=non-dereferenceable iterator for std::vector, __x="home") at /usr/include/c++/5/bits/vector.tcc:353
 #17 0x00007fda244aada2 in std::vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::push_back (this=0x7fd9ffffe740, __x="home") at /usr/include/c++/5/bits/stl_vector.h:925
 #18 0x00007fda2350ddcb in Poco::Path::pushDirectory (this=0x7fd9ffffe6c0, dir="home") at src/Path.cpp:471
 #19 0x00007fda2350ea27 in Poco::Path::parseUnix (this=0x7fd9ffffe6c0, path="/home/ash/prj/lo/online/test/") at src/Path.cpp:671
 #20 0x00007fda2350cd6b in Poco::Path::assign (this=0x7fd9ffffe6c0, path="/home/ash/prj/lo/online/test/") at src/Path.cpp:182
 #21 0x00007fda2350c1be in Poco::Path::Path (this=0x7fd9ffffe6c0, path="/home/ash/prj/lo/online/test/") at src/Path.cpp:54
 #22 0x00007fda2350d33a in Poco::Path::makeAbsolute (this=0x7fd9ffffe8f0) at src/Path.cpp:318
 #23 0x00007fda216b52ca in helpers::getDocumentPathAndURL (docFilename="setclientpart.ods", documentPath="/tmp/loadTorture_setclientpart.ods_ae70d2e_setclientpart.ods", documentURL="",
     prefix="loadTorture_setclientpart.ods_") at ./helpers.hpp:153
 #24 0x00007fda216ad007 in UnitLoadTorture::loadTorture (this=<optimized out>, testname="loadTorture_setclientpart.ods ", docName="setclientpart.ods", thread_count=thread_count@entry=3,
     max_jitter_ms=<optimized out>, max_jitter_ms@entry=75) at UnitLoadTorture.cpp:41
 #25 0x00007fda216ad7dd in UnitLoadTorture::<lambda()>::operator() (__closure=0x55e994cffe18) at UnitLoadTorture.cpp:186
 #26 std::__invoke_impl<void, UnitLoadTorture::testLoadTorture()::<lambda()> > (__f=...) at /usr/include/c++/7/bits/invoke.h:60
 #27 std::__invoke<UnitLoadTorture::testLoadTorture()::<lambda()> > (__fn=...) at /usr/include/c++/7/bits/invoke.h:95
 #28 std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > >::_M_invoke<0> (this=0x55e994cffe18) at /usr/include/c++/7/thread:234
 #29 std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > >::operator() (this=0x55e994cffe18) at /usr/include/c++/7/thread:243
 #30 std:🧵:_State_impl<std:🧵:_Invoker<std::tuple<UnitLoadTorture::testLoadTorture()::<lambda()> > > >::_M_run(void) (this=0x55e994cffe10) at /usr/include/c++/7/thread:186
 #31 0x00007fda22de366f in ?? () from /usr/lib/x86_64-linux-gnu/libstdc++.so.6
 #32 0x00007fda228f66db in start_thread (arg=0x7fd9fffff700) at pthread_create.c:463
 #33 0x00007fda2261f88f in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:95

Change-Id: Ib60954e49e692082e686cb3fdc5fc9d5cfbc83c9
Reviewed-on: https://gerrit.libreoffice.org/83047
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-18 06:47:20 +01:00
Henry Castro
0d734b2aae loleaflet: avoid using $.data jquery function
I am personally not agree to use "jquery" functions in src/* source
code, but there are some "jquery" library components (i.e.
"mCustomScrollbar") that it is dependent it, however let's minimize the
use of "jquery" functions.

Change-Id: Ic64c12d966a6215acfa900cdc05e5ddb84026f79
Reviewed-on: https://gerrit.libreoffice.org/82996
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:29:15 +01:00
Henry Castro
acb4f87bd4 loleaflet: defer request preview thumbnail task
When mCustomScrollbar fires onScroll then queue the task to run as soon
as the current synchronizing code.

Change-Id: I761937a0ad181a42b592ad953cc7b83ea73a1b21
Reviewed-on: https://gerrit.libreoffice.org/82990
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:44 +01:00
Henry Castro
2644c113c2 mCustomScrollbar: add event listener to pointer or touch events
Some mobile devices support both pointer and touch events,
so if we add event listener it will fire 2 times.

Change-Id: Ida9862e9ee24e47ccbe3963b5c4ff18a173fffe0
Reviewed-on: https://gerrit.libreoffice.org/82799
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:31 +01:00
Henry Castro
59d3c2d20d mCustomScrollbar: remove unnecessary access to Window top property
When the frame is null, it is referring to a container frame window that
it is always not accessible.

Change-Id: Ie96a05327928b2b72ce5577409e368061b2afa1e
Reviewed-on: https://gerrit.libreoffice.org/82798
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:13 +01:00
Henry Castro
cb7813ef35 mCustomScrollbar: reduce the number of _coordinates function calls
The _coordinates function is called several times to compute
the same coordinate value.

Change-Id: I6e187b74709515ddde77d60649e564cb2b484fb4
Reviewed-on: https://gerrit.libreoffice.org/82797
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-16 19:28:01 +01:00
Michael Meeks
1ab617a3a2 Remove unused _keyHandled
Change-Id: I3bd1e05e33ec976ff44067a8a19b699b523c52a2
2019-11-15 21:42:58 +00:00
Michael Meeks
2d52ddcb60 avoid spamming the JS console with load state messages.
Instead highlight messages received when not fully initialized.

Change-Id: I2ee2c9cf20ceaf3f98f1500add3f56256e65f42d
2019-11-15 18:09:24 +00:00
Michael Meeks
98617e40e2 Enable protocol debugging by default in debug mode.
Also add a config option for logging.protocol - to help catch early
protocol issues during startup.

Change-Id: I6f0cc6dcf14b2797bc6b2bd36c44750d74eb0608
2019-11-15 18:01:02 +00:00
Michael Meeks
946cc5d8e6 Rename misleading ClipboardContainer -> TextInput
Change-Id: Idb5ccb9959e0c77dfcdbb2793330bb048db0f0f8
2019-11-15 16:28:34 +00:00
Henry Castro
3e2ec0854d loleaflet: add missing parameters when early websocket connection
Add some missing parameters when the "websocket" is connected after
loleaflet.html while "bundle.js" is downloading and ready to execute.

Change-Id: I36995a3c82ce17fa5a81923e8d6d785f0c1c7742
Reviewed-on: https://gerrit.libreoffice.org/82546
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-15 15:49:52 +01:00
Henry Castro
d93d9dc59b loleaflet: fix the dragging limits of the dialog box
Change-Id: Id6336ce5bde9567c3a99c4660e8445f65f7545a2
Reviewed-on: https://gerrit.libreoffice.org/82535
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
2019-11-15 15:49:32 +01:00
Pranam Lashkari
e95413d151 killpoco: removed StringTokenizer from common directory
removed use of Poco::StringTokenizer from the common directory
used LOOLProtocol::tokenize and std::vecor<std::string>

regex is used in Authorization.cpp due to limitation of toeknize mathod
regular expression helps to keep the original intention of the code

Change-Id: Ic87597d8b30cb385000f983389a57dc5d2533d98
Reviewed-on: https://gerrit.libreoffice.org/82575
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-15 14:54:29 +01:00
Pedro Pinto Silva
1ed89ae220 mobileWizard: improve focus/active states in all unobuttons using new class and properties
Change-Id: Iaf124c50980d9d53be412e7ffcb1bf666e64f85f
Reviewed-on: https://gerrit.libreoffice.org/82716
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-14 15:58:47 +01:00
Pedro Pinto Silva
6ca05878f3 mobileWizard: style unobutton when selected
Change-Id: I83de024825e9409ae494b5d4b24afa23c54ad604
Reviewed-on: https://gerrit.libreoffice.org/82713
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-14 15:35:35 +01:00
Jan Holesovsky
865c10cfd5 Make Ctrl+f jumping to the search again.
I think better to just fire a new 'focussearch' event and handle all the
Ctrl+<something> at one place.

When at this, fix also a regression that Ctrl+f in the search bar
triggered the browser's search.

Change-Id: I759be9ed3934e14b1e05a37a65ca1ce54d99eb0b
Reviewed-on: https://gerrit.libreoffice.org/82700
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-14 15:03:11 +01:00
merttumer
92f5d74073 Make pressing Ctrl+F twice behave like Desktop
Currently pressing Ctrl+F twice opens up browsers
search bar.
Signed-off-by: merttumer <mert.tumer@collabora.com>

Change-Id: I213d4e4c770a035714abe7bcd0e54c74929ade27
Reviewed-on: https://gerrit.libreoffice.org/82694
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-14 15:02:51 +01:00
Jan Holesovsky
8f86b7e7e7 Take the name of .uno:MasterSlidesPanel directly from the core.
Change-Id: Ia75cf573552e0cf4c7eac378138d1ecbfd3e7b4f
Reviewed-on: https://gerrit.libreoffice.org/82692
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-14 15:02:06 +01:00
Szymon Kłos
f96461558d jsdialog: add uno listener for checkboxes
Change-Id: I207456330503c8900524f746411e0005434beb11
2019-11-14 13:56:59 +01:00
Pedro Pinto Silva
31c5769abd mobile: Toolbar-search: remove .over class that sometimes would appear when using firefox
Change-Id: I0386a05adcf2aae2ca94e186cfcafcba8ff2ad8b
Reviewed-on: https://gerrit.libreoffice.org/82676
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-14 13:39:51 +01:00
Szymon Kłos
6104b20d2b jsdialogs: remove debug printout
Change-Id: I6fb384e848c804f9596b29fff862cf6db82d37f8
2019-11-14 12:33:43 +01:00
Szymon Kłos
51cdf48138 jsdialog: add uno listener for uno toolitems
Change-Id: I5967c847ad0aea4845fdcac67555fb5179161e92
2019-11-14 12:09:05 +01:00
Szymon Kłos
52aab52dd3 jsdialog: add uno listener for spinfields
Change-Id: If61609e55680272661f0ab953cf18907c07f9f07
2019-11-14 12:09:05 +01:00
Pedro Pinto Silva
3319d8334f MobileWizard: spinfields: units: replace 'degree' with its respective sign
Change-Id: Ide40b9a06485960e63dbee9e94c3745b2cd59e3e
Reviewed-on: https://gerrit.libreoffice.org/82666
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-14 11:41:41 +01:00
Jan Holesovsky
cd81d78ccc Add a 'how to debug' to the whitebox unit tests.
Change-Id: I373ae9e7268b108eedcae2805b0c1681845542cb
Reviewed-on: https://gerrit.libreoffice.org/82651
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-14 10:07:17 +01:00
Pedro Pinto Silva
80f7985e03 Mobile: Impress: add visual cue when editing slide master
Change-Id: I3a8882fbb76fb5c1d364381650d1424f140ccbd2
Reviewed-on: https://gerrit.libreoffice.org/82606
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-14 09:47:51 +01:00
Miklos Vajna
ee61bc6fb8 Convert "client session" tests to a new-style one
So that they are in-process, which means it's easier to debug when they
fail.

Change-Id: Ia95b077b46538788c0bbc7cafebfd9019512d2ab
2019-11-14 08:40:59 +01:00
Andras Timar
fd93e11934 build fix after 'killpoco: removed StringTokenizer'
Change-Id: I2f1cb0da199a8dca1cf300955f133f45b8d7ba3b
2019-11-13 22:16:59 +01:00
Michael Meeks
c790eb7d37 loleaflet: calc: on IE11 headers and gridlines are not displayed
Fix merge error with:

The problem was that in CalcGridLine.onUpdate the integer costants
Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER were used.
Unfortunately such constants are not supported by IE11.

Change-Id: I973f232fa48ce5ba1d125325c2ccf5d4e6610935
2019-11-13 18:10:18 +00:00
Michael Meeks
db20596a0a Avoid exceptions on mouse-events while initializing.
Change-Id: I7f25e08edcc7a34b08016211c599774973fd506d
2019-11-13 16:58:15 +00:00
Michael Meeks
9859a5f56b adapt grid and headers to retina scaling
Counter-intuitively, our retina scaling pixel multiplier is a
different integer multiplier than L.Util.dpiScaleFactor() in many
cases, being either 1 or 2.

Change-Id: I18078eca80b86216751738368d9885151a41dde2
2019-11-13 16:58:15 +00:00
Marco Cecchetti
a16da08b2c loleaflet: calc: on IE11 headers and gridlines are not displayed
The problem was that in CalcGridLine.onUpdate the integer costants
Number.MAX_SAFE_INTEGER and Number.MIN_SAFE_INTEGER were used.
Unfortunately such constants are not supported by IE11.

Change-Id: I0a0fba0c1eaa922b925168c16d3afd395c0d38f0
2019-11-13 16:58:15 +00:00
Iván Sánchez Ortega
55ac3da53f loleaflet: Draw column/row grid lines on the background
Based on information from UNO ViewRowColumnHeaders messages, this draws
the grid lines with Leaflet's SVG polylines, in a background pane.

To prevent visual glitches on touchscreens, this also reverts parts of
26aad36771ebd5a304b763912184acd2ea26dfdf - that introduced a regression
that prevented 'dragend' events from being fired when inertia-dragging.
Instead, inertia drag is disabled in the L.Map constructor.

[ Miklos: cherry-pick these early as they prevent automatic merging. ]

Change-Id: I86c68214822a0a2c2f8ced82ccf5a6c201e2cf04
2019-11-13 16:58:15 +00:00
Szymon Kłos
6584e3b8c0 jsdialogs: apply shadow transparency updates
Change-Id: I7e615590f8c3ba5f455cfbec55c3fef8919ab1a1
2019-11-13 16:03:51 +01:00
Szymon Kłos
c447c8fb43 jsdialogs: apply fill transparency updates
Change-Id: I630347002474609736e9d41169e65f8e1608ad04
2019-11-13 16:03:51 +01:00
Szymon Kłos
0937a21f9f jsdialogs: apply line transparency updates
Change-Id: Id222cbdf093fe73655bfda82fd8f41d13b192397
2019-11-13 16:03:51 +01:00
Szymon Kłos
df0bab8ab0 jsdialogs: apply .uno:NumberFormat updates
Change-Id: I141b1c35bbcfce404c1b042ffe9255db31ec180e
2019-11-13 16:03:51 +01:00
Jan Holesovsky
47e9cca4e1 Fix cut off comments in Impress.
We need to force the document size recounting in Impress, because the
document size actually "changes" there on zoom: The annotations are in
absolute pixels, so when you zoom out, it is as if the absolute-sized
annotations grew larger, so we have to extend the document size,
otherwise they are cut off.

But triggering the document size change too early leads to the
sideeffect that the layer with the cursor and the tiles grid get out of
sync.

Let's do the same as in writer - react on the 'updatemaxbounds' event,
and force resize from there.

Change-Id: If84ddf3597be0383ff6ae2271e6ba6ae3bbd5210
Reviewed-on: https://gerrit.libreoffice.org/82604
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-13 15:37:24 +01:00
Jan Holesovsky
d40002ab5f Fix eslint errors.
Change-Id: I3a354f684a08725afb2fac832ed5b6c118670696
Reviewed-on: https://gerrit.libreoffice.org/82594
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-13 15:37:04 +01:00
Jan Holesovsky
1040353fde More reliable way of theming the comment buttons.
Change-Id: I9c8e81a494733ec343b42596a19b1e90fa2b00d5
Reviewed-on: https://gerrit.libreoffice.org/82593
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-13 15:36:47 +01:00
Jan Holesovsky
3496b07e7e Cosmetic change in a memset invocation.
For an array, memset(array, ...) and memset(&array, ...) do the same
thing - but given that there has to be the sizeof(array), the former
is probably more readable / obvious here.

Change-Id: I7e329cb1dcabb564e26857b0c7d9f88431bb4ede
Reviewed-on: https://gerrit.libreoffice.org/82601
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-13 15:12:50 +01:00
Pedro Pinto Silva
575371f0d9 mobile:impress:menu(landscape): enable vertical scroll
mobile:impress:mobilewizard:hide scroll-x

Change-Id: I3faa5cc983e50dcfbd85b7e3e21edc6b9652300d
Reviewed-on: https://gerrit.libreoffice.org/82605
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
2019-11-13 15:08:19 +01:00
Jan Holesovsky
d066c88fea sd menubar: Let's not attempt to change the menu description.
It is not a good UX to change names of items in the menu - we have a
different mean of indicating that the master page view is active: the
tick in the menu.

Change-Id: I53486847b3929d990de6e398df96b04b943998e6
Reviewed-on: https://gerrit.libreoffice.org/82498
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-11-13 11:56:20 +01:00
Michael Meeks
d5d157275d calc: switch row / column / grouping data to pixels.
This simplifies lots of logic, making it trivial to get good row/column
header alignment at any zoom. Ultimately TWIPS were highly misleading
'print-twips', and in that state are ~impossible to map to pixels
accurately unless all data is present back to the origin
(which was not provided previously).

This requires the equivalent patch on master.

Change-Id: I110f6f646e2b52bec4584c193c640df6b41100f8
2019-11-13 10:17:13 +00:00
Szymon Kłos
c8277bb11c jsdialogs: apply table row/column size updates
Change-Id: Id3601c82ce0f7320e9a7f86fe1e589b2edb5ea16
Reviewed-on: https://gerrit.libreoffice.org/82541
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-13 09:51:41 +01:00
Szymon Kłos
c8595eb7e4 jsdialogs: apply .uno:ULSpacing updates
Change-Id: I67e8600738bb380f5652d47b609d4db4c4e670e0
Reviewed-on: https://gerrit.libreoffice.org/82530
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-13 09:51:30 +01:00