With some styles the following text was too large for the chip.
Unfortunately, sizing it to be consistent made it unreadably small. To
solve this, we can show only the first line of the text in the following
chip and show the second as a tooltip instead.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I4b5306370c31f4d0b13e1a91bf17a9d491807c45
This reverts commit e9cf81f29e.
problem:
when comment is being edited, nothing could be copied from the doc
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I34ceacc5d9c7d5eb7d57ec2489a47734b80a044f
Better to use the same height so to fix the misalignment
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If3e76a695a943eee4861479e2ce7b6b1dd287d4f
I did the things necessary for TypeScript to stop complaining, as well
as additional modernizing things such as formatting and removing
L.Class.extend
Here's the full list:
- Update browser/Makefile.am with the new filename
- Fix any typescript errors that prevented compile
- Remove L.Class
- Factor out repeated types
- Tighten types to avoid functions leaking anys
Though not all of those steps are necessary, they are all useful, as
along the way TypeScript helped me to find and fix several times when I
had incorrectly inferred what the type should be
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I20d6580c53337909788b0517353c5852365b871d
This was left around, presumably from before I typed user
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Ie5ff95a04b20fd260ebfb3dc3317c3869ac22b91
- We made some adjustment in core side
- it will now send both property
1."State" = either button is selected or not
2."disabled" = either it is disabled or not
- based on above message made some adjustment and refactiong in update function
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I7aa9bae647252782fcc88bd11b34bf9954741502
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
- reuse MenuButton as base for colorControl
- add only last color indicator and activation on left side button
- make possible to clreate split button from unotoolbutton
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8cd20149cc5bc25bedf4e0b0c56fc93d53339f4b
This is implemented in two cases:
* using a request parameter '&startPresentation=true'
* for ppsx/pps for which the backend sends a startPresentation
stateChange event. This can be overridden passing
'&startPresentation=false' to allow editing the file.
The presentation can only start in present-in-window mode due to browser
gating fullscreen by user activation.
Refactor SlideShow._onFullScreen to better handle the requestFullscreen permission restriction failing case.
Also clean up old references to old restricted implementations.
Signed-off-by: Méven Car <meven.car@collabora.com>
Change-Id: I98fcb1a7da170fa1c6a7de75c680259163233c9d
Move debug toggle to after docloaded message
Move sidebar toggle even later than that
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ib72b5ef4c2c31f7707a384b2d819d5cde57a796d
problem:
when using display scaling/zooming clicking on comment may cause
overlapping on comments if the previous comment from clicked comment is long
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I6e9eec3ba5c3fb9f871ce42bb0a554d7e2cc3c5e
problem:
before this patch innert textarea svg was not updated after changing text,
it was static based on first selection of textbox/shape,
to update the textarea we needed to unselect and reselect shape/textbox
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I11ceaf76867cecf5a356149d2072181e9f10b86e
When you are following someone and start typing, it's a pretty good
indication that you don't want to be following that person, particularly
because if they edit you will then be jumped over to where they are
We also need to stop unfollowAll from always rerendering the user list,
as when we rerendered on every keypress there was a noticable
performance degredation. Instead, we can make it only rerender when
we're following someone, which is a lot better.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I110ca74859b7cee03c6a58c87d3975275f29760d
so it will be also visible in notebookbar mode
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia311e3bff119b202b08b6ba04f75ad795d8a735c
in the past when JSON was generated from core it was needed...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I862bd405f17bd102d9772b0f806aec8bfcca4ac8
Execute the 'prettier' command to check format code style.
Change-Id: I93e4a57e03d26627caa3b2c52ae44669a8723267
Signed-off-by: Henry Castro <hcastro@collabora.com>
The *.ts files in admin are transpiled typescript to *.js
so ignore the file to eslint again.
Change-Id: Icb5edbcc9d782562886c17453921979fd2dbdd2e
Signed-off-by: Henry Castro <hcastro@collabora.com>
- We specifically hide some section or elements in mobile view
- if we go level up or level down in mobile view, we should not change the state of those elements which already hidden using css rules
- this patch will cover that part of issue where we do not consider elements which are hidden by css rules
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I7ffd83c5b74987f74b7e327fd13775a81d02120d
- image path was wrongly assigned
- setImage method will do the work to set image path
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I765f0049d7d607926529df38a202b9ec923584b1
- automatically handle html content
- fix dropdown cropped when close to the screen edge
and content is custom html (fixes#7578)
- automatically handle focus
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I3187971f47295d699a18dbf5b8dd129e3a809991
TODO: checked state for menu entries
TODO: accessibility, shortcuts
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6dc96a4748fd69a75af8a64ed37e5dce24bd9830
Dropdowns are objects in the JS only so don't send
message to the server.
Dropdown is a simple list of entries (menu),
do not confuse it with popup which exists in the
core and message shoult be sent in that case.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iffcd6cac81608841dca969e979298e33182c6595
Have 3 paragraphs in Writer, insert an image in the middle with
(to-char) anchoring. Select all text, copy to trigger the complex copy
codepath. Insert the result to Wrtier, some "text/html" and a number
extra paragraphs appear before the result content in the past result.
Seems the root of the problem is that the clipboard format generated by
ChildSession::getClipboard() is 1) a mime type on its own line 2) size
3) real content; but we just skipped 1) and 2) in the past, but now this
doesn't work, presumably due to a change on the core side.
Fix the problem by just making the header check case-insensitive for
now.
Once I add a html+plain text mode here, I'll probably switch to properly
skipping the first two lines instead, since the plain text won't have a
well-known header to identify the content. No testcase, this complex
download codepath will be Firefox-only in the future, so not easy to
cover with cypress.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ia99e5325188e5a34b56962cf4e3e9b8287e267c0
Prettier is a code formatter for javascript/typescript. It's relatively
common to see complaints about style in pull requests or inconsistent
style getting in to Collabora Online. Also, without a formatter it's
harder for editors to automatically format code in sensible and
consistent ways
Prettier doesn't have many options, but those which it does have I have
set to the closest values to current behavior (e.g. single quotes) in
order to minimize unnecessary changes
This commit doesn't format all existing files. Doing so would cause
blames, cherry-picks and diffs to become much less useful. Instead, we
use browser/.beforeprettier to list all files that would need to be
changed, and this file is ignored. You are encouraged but not required
to set your editor's equivalent of 'editor.formatOnSaveMode' to only
format changed lines
This commit also does format of docstatefunctions.js, previously it did
not in to check that an incorrectly-formatted file could fail CI. Now it
does to make sure that formatting fixes the issue. This file was chosen
because it is very new and very small.
Change-Id: Ie6067f34aa658f887e149a08aebd0180b2354005
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Currently translated at 99.5% (476 of 478 strings)
Translated using Weblate (German)
Currently translated at 99.5% (476 of 478 strings)
Co-authored-by: Andras Timar <andras.timar@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/de/
Translation: Collabora Online/Help
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I8ec860efbb9d8e198e1bc453108fa53e47c5f28f
Currently the current selection is always requested as HTML by the
browser, and then we ask the browser to convert it to plain text.
The problem is that e.g. Writer can produce much better plain text from
its model, compared to the plain text by the browser, e.g. bullet
characters for bullet points.
Fix the problem by:
- CanvasTileLayer.js, _onTextSelectionMsg(): requesting both HTML and
plain text. Use ',' as a separator, as that's already established,
e.g. the HTTP Accept header does that already
- Switching the textselectioncontent protocol message from just HTML to
JSON that contains both HTML and plain text. This is produced in
ChildSession::getTextSelection() and parsed in CanvasTileLayer.js,
_onMessage()
- Clipboard.js, setTextSelectionHTML(): allowing setting both HTML and
plain text.
- ClientSession::postProcessCopyPayload(): knowing if the content to be
processed is HTML-in-JSON or just HTML, do additional escaping in the
JSON / textselectioncontent case, but leave the other clipboardcontent
case unchanged.
So far this only handles the simple case, the behavior for complex
selections are left unchanged for now. The payload is also unchanged
when a single format is requested, as many tests depend on test.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I2fe1378a8d50b7901ac9e808eb78858cd8ff8575
problem:
when pressed page up/down button inside the annotation textarea,
entire view is forcefully pushed upwards to put the cursor at the top of view.
This is a chrome bug reported at: https://issues.chromium.org/issues/41417806
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I30048374e7b8330cd8c865010e3b4237d355391e
It requires to add `Notify: true` in the Action_Export
postmessage. Result will be sent with `Action_Save_Resp`
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Iaeee2e22bf1a2ae934eb657116c1878cb6ed50f6
Replace "The server encountered a xxx error while parsing
the yyy command." with more informative "Document cannot
be exported. Please try again." on export issues.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2683720d043713af95ccc61d46c3da09e6f5092b
You should be able to drag part of a JSDialog offscreen, so long as you
are also dragging another part of them onscreen. This allows you to
access the whole jsdialog even if you have a small device, which
otherwise would not be possible.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I243124bfdc1afbf8e7da84f5932493540beb12b4
When trying to drag a jsdialog offscreen, we previously froze the
dialog. This was frustrating if you dragged a jsdialog to the edge of
the screen, because you then couldn't continue to drag it at all without
moving it away from the edge of the screen, even if the direction you
tried to drag it would not move it offscreen.
An example is if I dragged a jsdialog to the right edge of the screen,
it would be harder to drag it up as it would "stick" to the edge. I
would expect the upwards component of the movement to be honored, even
if the rightwards component could not be.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I865d4ab4833016228c63bab434eb0c6281fed03c
- move freeze options from layput tab to view tab
- options should be consistent for both compact and tabed view
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I9baed9ca50ddfb963dfd555e9fec42b594321902
problem:
when we turn off the option to show the resolved comments,
author image was not hidden and stuck on screen which can't be interacted or scrolled
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id0fb30c787b6e8c288df1142b9f882b7633f3dc9
The URLSearchParams() function was confused in the proxy.php
case, because the global.location.search contained two '?' marks,
like ?req=/browser/dist/cool.html?WOPISrc=...&lang=..&etc...
In the normal case the string started with ?WOPISrc=
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I566935656be6622d698ea2ba3c949455877526f6
Do not send the command ".uno:DeletePrintArea" to server side,
it disables printing range feature.
Change-Id: I8bb1ec9ab01793e6bf3b74b8cb121a5fbad3b8e2
Signed-off-by: Henry Castro <hcastro@collabora.com>
Before this commit, the icon that is placed in the protected spreadsheet's tab
was too big and bulky. Opt for a smaller and more minimal version of
that so it balances better with the accompanying spreadsheet's name.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9ab688262ddaed21a067b904f51569ee87355298
With cbf452b03d all non protected
spreadsheet tabs have their name (tab label) aligned to the top.
- Fix it but making sure we align to the middle on both coordinates
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I24cb61d691f2e9e2b4399a5201dc387d32f45eb2
Currently translated at 100.0% (478 of 478 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (576 of 576 strings)
Translated using Weblate (Turkish)
Currently translated at 98.3% (470 of 478 strings)
Translated using Weblate (Turkish)
Currently translated at 99.8% (575 of 576 strings)
Co-authored-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
Co-authored-by: PhD. Ayhan YALÇINSOY <ayhanyalcinsoy@pisilinux.org>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/tr/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/tr/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I5d3bcfcef9e253af9c8e99f15e7f561b25b94c96
Currently translated at 100.0% (478 of 478 strings)
Translated using Weblate (Slovenian)
Currently translated at 100.0% (576 of 576 strings)
Co-authored-by: Martin Srebotnjak <miles@filmsi.net>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/sl/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/sl/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I7ed0ab34193822113d31a929f6c824195bf5c717
- type="search" for a11y
- spellcheck=false" to avoid red underlines
- localizable placeholder is added programmatically from 34bf81f146/browser/src/control/Toolbar.js (L552)
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I695990a25ccb00821a16738a9388a51001199112
it was introduced in 13bc532
and it was removed from use in 2f77b3a
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Iec401a9505491fe69196cdb1e7192fa499d3d38f
problem:
if a textbox/shape is being edited and try to move it while still in editing,
it was not animated, so user gets illusion that shape was not moved,
but in fact it moved and directly appears at the last moved position without animation
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I830e368e162b3b38edea0d9240cf82800fa8080a
