Commit graph

842 commits

Author SHA1 Message Date
NickWingate
a70415fe7b cypress: add tests for file properties
- test document description
- write test for custom properties
    - text, duration, yes/no types
    - disabled until core implements custom props

Signed-off-by: NickWingate <nick.wingate@collabora.com>
Change-Id: If0205b90d899772ac8f7f98d4eda2cbc23117d0f
2022-08-16 16:04:22 +02:00
Skyler Grey
f182183d6b Rewrite testing of splitting table cells
- This is a followup to 3ce47b0c16
  (https://github.com/CollaboraOnline/online/pull/5106)
- This commit rewrites the split cells test to work with JSDialogs
  (merged in https://gerrit.libreoffice.org/c/core/+/137791) and
  re-enables that test

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I7901cfa1489618d005faffe68af0883e0ca998a1
2022-08-07 08:14:53 +02:00
Skyler Grey
3ce47b0c16 Disable testing of splitting table cells
- The split cells test currently uses tunneled dialogs to make sure that
  we can split table cells
- There is an open gerrit review to switch the split cells dialog to
  JSDialogs (https://gerrit.libreoffice.org/c/core/+/137791) which is
  blocked because the tunneled dialog needs to be removed in it, and
  that fails this test
- This test needs to be temporarily disabled to give coreside a chance
  to merge that review and build a new version of the libreoffice
  archive. Once that has happened, this test should be replaced with a
  rewritten version

Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I0bb51e3cdbc04020e03c8d87696d014a0f693554
2022-08-05 07:57:47 +02:00
Rash419
cff30c51d5 cypress: fix: ui-pushbutton element keeps getting detached
clickonIdle waits for the DOM element to be idle so test doesnot fail due to ui flickering

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I43b0800b23970326a4a6e84bfc662b67fea4f364
2022-08-05 01:06:13 +05:30
Szymon Kłos
3982724e53 cypress: allow correct plain text clipboard formatting 3
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.

see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
I2b17d62398d947fcf1d3fb1ed6005c3063d114f2

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia2d75c75f40dffbe08d1c77e09c2331db18734f4
2022-07-11 11:14:27 +05:30
Szymon Kłos
e3c6ff58f3 cypress: allow correct plain text clipboard formatting 2
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.

see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6adea1250bb4d54713e0a189b89930e82522a571
2022-07-09 10:05:53 +02:00
Szymon Kłos
63f718e35e cypress: allow correct plain text clipboard formatting
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.

see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I70fa8be619a62709d6e5ada32b7a670f90d7b2bf
2022-07-08 18:04:15 +05:30
Pedro Pinto Silva
e1b25c69a8 Cypress: Adjust scrollbarPosition assertion
Since we remove a bottom padding in the toolbar-wrapper
with 3d27de7eb14e77cb4f0a94685b474ec2c42d6229

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icf272e5c29455868cd43cf494935401ec10229e0
2022-07-08 13:22:08 +02:00
Rash419
3667fbc2d8 cypress: NB: update tests to click on arrow to open color picker
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I57cd50a532c0fdb5a6f0ebebf77e97c9e8e990e3
2022-07-05 22:12:30 +05:30
Marco Cecchetti
3f21f15d7a cypress test for fullscreen presentation anim spin, grow and shrink
Added test for 2 emphasis animations:
- spin
- grow and shrink

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I3e5477b327e2d56776258cddf5de84617c1dc0a2
2022-06-27 16:01:30 +02:00
Szymon Kłos
13ef21aa1e notebookbar: unify color control with core
in desktop case color widget should show the latest selected
color not current one. split the button into arrow with dropdown
and "last color" button (icon)

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07fcc94d69e14b030cf9f1bfe3ae50f0df333ec7
2022-06-24 12:45:16 +02:00
Rash419
9d06f8d5cc cypress: re-enable impress/table_operation_spec.js
modify the test to use 2x2 table when testing 'insert column before/after' tests
no idea why we don't get svg when there is 3x2 table

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id927fede691c4483206fa2b65c450f11cc980581
2022-06-06 15:48:08 +03:00
Rash419
82eacd26bc cypress: skipping columns test in impress/table_operation_spec.js
cannot reproduce locally temporarily skipping the test

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I2007a2dc643306551be859b1bdcf48982fe4a33d
2022-05-19 13:33:20 +05:30
Rash419
f90fbe23bb cypress: added new function selectCellsInRange
after the jumbo sheet patch selecting entire row and merging all the cells becomes costly and cypress timeouts
therefore select first 100 cells and test the merging functionality

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8568bbdbabdccc55c2938f886619a1d178ae7d22
2022-05-18 19:14:07 +05:30
Luboš Luňák
b999f12500 make cypress tests work also with 16384 columns
Some places tested for AMJ being the last column, but with 16k
columns it's XFD. Without this those tests run in an endless
loop when run with Calc set to 16k columns.

Signed-off-by: Luboš Luňák <l.lunak@centrum.cz>
Change-Id: I6249e0ec975634b60aaf3291e021b74b4aa3cc5d
2022-05-18 06:59:08 +02:00
Rash419
0a203ad91e cypress: added desktop calc/autofilter_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I48f4ceb591cbdf178b08b44ad1f833b52d5c004d
2022-05-10 22:31:16 +05:30
Rash419
3e095928aa fix:cypress: abort without error in CI
Identified the faulty test, on heavy load the test gets stuck on waitUntil command
skipped the test for now

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia4b7ca081098e7e5b6f15135304131521629e524
2022-05-04 11:13:14 +05:30
Szymon Kłos
256b50e926 cypress: fix after formulabar conversion to jsdialogs
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0792e2b1e044220dc44ae8155ac7b30b47a7ea8d
2022-04-23 10:58:55 +02:00
Szymon Kłos
cbde6f324a cypress: tunneled formulabar was removed
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I040bbc8c9a5c76a367de046acf2a05e6dfb88920
2022-04-23 10:58:55 +02:00
Szymon Kłos
c4f5d2735f formulabar: move buttons to jsdialog implementation
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2ad2c345435453456ad69c036b7d7e5a73a27550
2022-04-23 10:58:55 +02:00
Szymon Kłos
496256a96b jsdialog: remove table- prefix hack
so we will not have problem with updates not catching
widgets with modified name - not needed not

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifa29d3971120482c3dae4ede3db5bcf31ea1af95
2022-04-23 10:58:55 +02:00
Andras Timar
4c7332f44f Fix cypress test after InsertZWNBSP->InsertWJ
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia21c27e80507d7be4b44935e0a7dc225ad0f7776
2022-04-21 15:01:57 +02:00
Mert Tumer
4d5cd2b54b cypress: modify writer/annotation_spec test
now we dont need to click on the collapsed comment
because now after insert comment they will be selected
already.

Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ica69e5a092f29896c1d872deb384d31b867dddc6
2022-04-18 10:22:31 +03:00
Rash419
4dc39241f0 cypress: fix:ui-expander-label getting detached from dom
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I471d220cd15b66693b6e43bcf5ee83276921ff9c
2022-04-14 13:23:21 +05:30
Pedro Pinto Silva
83b13fd454 Cypress: Do not hard target buttons based on their position
No need to specify if it's first or second button as there is always
only one primary button. On top of that this avoids maintenance work
whenever for some reason the button is not the first in line.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd3ef60023e88d1a9a8fd6f465dc4c63c068debd
2022-04-03 19:29:49 +02:00
Pedro Pinto Silva
8d9317daa8 Fix button order on HyperlinkDialog
Follow the same order as anywhere else such as annotations, JSdialog or
even tunneled dialogs:
primary action aligned to the left

Also update cypress test: Do not target button position related classes
instead, rely solely on main classes

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac209aa343f22ddfdbd5662eba43d7adaa3f0892
2022-03-28 14:15:44 +02:00
Szymon Kłos
ff7e4a8b3b co-22.05: mobile writer/table_properties_spec.js
- use .unoXXX class instead of id
- check only if height was changed on Optimal Row Height command

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibfa93076237b15e16ae1851e3a66b4b239c42a2d
2022-03-21 09:35:49 +01:00
Szymon Kłos
7e6f3d5590 co-22.05: mobile writer/insert_formatting_mark_spec.js
- add possibility to specify UNO command alias for newer
  version of core so we will call all the versions for
  compatibility of online with many versions of core

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I380fb1d2fd7f63bac297745401fa9d619f693348
2022-03-21 09:35:49 +01:00
Rash419
23f0790413 cypress: change template files tests to assert readOnly
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib557424de7407346ca947bfe06289b772ec46d10
2022-03-15 14:05:12 +01:00
Rash419
42204db587 cypress: removed repeated tests and enabled notebookbar tests
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I2c31b7433559d776dbde179c2659e23d8b104d59
2022-03-15 15:57:18 +05:30
Rash419
4853e46428 cypress:fix: writer/undo_redo_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I03d1f0ded1c177838bd493f11778ee1d4d8c542e
2022-03-10 16:11:05 +05:30
Rash419
3efcffb192 cypress: added open different LO files test for impress, writer and calc
impress: ppt, pptm, pot, potx, potm, ppsx, fodp
calc: xls, xla, xltx, xltm, xlsb, xlsm, fods
writer: doc, dot, dotx, dotm, docm, fodt

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib695e3f235acafd203c7041aecce319cd6efb285
2022-03-08 20:01:45 +05:30
Rash419
25ca214ea8 cypress:fix: coordinate based test failing
writer/shape_properties_spec.js
impress/scrolling_spec.js

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib576e9f4d90ec53dc21c2955d61e8ee85bd3e2ca
2022-03-08 18:29:15 +05:30
Rash419
820d135329 cypress: fix: mobile/writer/shape_properties_spec.js failure
changed defaultStartPoint

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I5a6947d233b7fb95052722a921becbd162c6a6ae
2022-02-23 16:46:03 +05:30
Marco Cecchetti
a217a6fbaa cypress test for fullscreen presentation white spaces
Google chrome doesn't render white spaces correctly

This is a set of tests for the core fix

Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I7edb0490f1b56ac2c5ab2d60fa5cf25ab7946745
2022-02-22 16:25:09 +01:00
Pedro Pinto Silva
1c61762b70 cypress: fix: impress scrolling_spec range for assertion
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id1efc7086a03d742d883a66607e713e6db861b7c
2022-02-11 20:25:55 +01:00
Rash419
4f0c84f70d cypress: removed explicit wait from row_column_operation_spec.js tests
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ib3a869cd65c80a6dffa2992284cbf46aa3fc30bf
2022-02-08 15:00:41 +05:30
Mert Tumer
924e22635a new mobile-back button cypress modifications
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I3e67bdc84d190edf2819b88dfe7d7630c7b89aba
2022-02-07 18:18:29 +03:00
Rash419
8a83e5c2a8 cypress: fix: input element getting detached
*waitUntilIdle make sure that element remains attached to the DOM
*removed a specific configuration for multiuser tests in makefile and
 now it follows cypress.json config

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I2bfd22ef0b4d8306b944d772e3536206a207e00c
2022-01-26 19:19:03 +05:30
Rash419
3f350c6817 cypress: added new tests
for desktop:
added split cell test in table_operation_spec.js for writer, impress
added Image Resize test for writer, impress, calc
added Page break test in top_toolbar_spec.js
added NB support to the image_operation_spec.js

for mobile:
added merge row/column test in impress/table_operation_spec.js

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9b3ccf124f49a2c33f2c1ca3c7c9106d09710bb4
2022-01-26 16:51:13 +05:30
Ashod Nakashian
9e5b9d6d37 wsd: support PDF comment saving during unload with test
PDFs are view_comment type documents where
editing is not supported, but adding comments
are. This means that we do get ModifiedStatus=true
but we never get ModifiedStatus=false after
.uno:Save. This is because the save command is
handled in a special way in Core by invoking
save-as instead, which doesn't reset the
ModifiedStatus.

The issue with this was that DocBroker was
stuck on trying to save the document
before unloading, thinking it was modified
due to the stuck ModifiedStatus. Here,
we change the definition of isPossiblyModified()
to ignore the ModifiedStatus for such documents.
Instead, we rely on the last save being successful
and that no new user input exists past the last
save request.

In addition, we now have a new Cypress test
that reproduced the failure without the fix
and now passes with the fix.

Change-Id: Ida9d486ac93a588b9007c5e4583d8bf3c090a62d
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-01-26 15:33:15 +05:30
Rash419
111d5f5483 cypress: fix: inconsistent text wrapping tests in calc
removed unnecessary 'retries' parameters from the tests we already
have default global value for retries no need for specific tests
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Idc78831ce240d4d840f3dbc785e66165c6e07d3d
2022-01-25 09:58:35 +05:30
Rash419
53a4c4502d cypress: fix: delete column test fail
mobile/wrtier/table_properties_spec.js

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I50cc1381f6d1c93e25d4b26b30c3f8c309e1b3f3
2022-01-11 20:09:53 +05:30
Rash419
c926b81f69 cypress: enable 'Apply font name' test for NB
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7b28eca0663a4187777320cc483d89966b62a5e3
2022-01-11 10:13:36 +01:00
Rash419
0bc12a5409 cypress: give each multiuser test unique document
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia46d0538430010e30649af76cb46846c90de8c1f
2022-01-11 09:28:03 +01:00
Ashod Nakashian
de74eae245 cypress: give each test a unique test document
We copy each test document into the work-dir
and now we also give them a random prefix.
This is critical to ensure that parallel runs
do not re-use the same document.

Also, when closing a document, we wait for the
document-name to disappear from the admin
console. Sharing the same document, or even the
name, means we are likely to see random results.

Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit d998f2c1c8a163c3ef870bbe8581a364df3905bb)

Change-Id: I2f41566952c49c9c63ee206bcba6a4dd49cdd6d0
2022-01-11 09:28:03 +01:00
Ashod Nakashian
4a559a6ff1 cypress: close the test document before reloading
The test document wasn't properly closed before
reopening. This went unnoticed until the 'unload'
phase grew longer such that the new load command
basically added a view on the existing document,
instead of create a new instance altogether.

This clearly was an issue that caused timing-based
instabilities. Now we properly close and wait
until we confirm the document is closed before
opening a new instance.

Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
(cherry picked from commit 54999291e95d75626426e2f306afa55b7a4f6fa3)

Change-Id: Icda6d7870c1352cc90002ced3c74e692fa849444
2022-01-11 09:28:03 +01:00
Rash419
95fc85e54b cypress: fix: NB writer/top_toolbar_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I2ef0bcbffbc3644d88a86eb00d61dde548704072
2022-01-10 15:53:49 +05:30
Rash419
fdd2973aa4 cypress: fix: updated all scrolling_spec.js to use range for assertion
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I9de24d4e0477ed6263370c331c42e791ea347045
2022-01-05 08:32:42 +01:00
Rash419
9b6f5226e1 cypress: changed defaultStartPoint in writer/shape_properties_spec.js
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id2cdc03005c4f57f31368e1a94388f1ca6511ee2
2021-12-17 15:28:43 +01:00