Change-Id: Ia29bce6ab4e26c63d7f3bf25bb3750d680e7c022
Reviewed-on: https://gerrit.libreoffice.org/84607
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
The app's WKWebView is not configured to allow opening web pages, so
it won't work anyway. When clicking the link the app will crash with
"Terminating app due to uncaught exception
'NSInternalInconsistencyException', reason: 'Returned WKWebView was
not created with the given configuration.'"
Change-Id: Iac05b74087331d6f3a0405e76f4323316af4729a
Reviewed-on: https://gerrit.libreoffice.org/84595
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Thus no "served by" information to display in Help>About.
Change-Id: Ia4f91431536f5261c6cb0ee26398b9c33c0d0ea3
Reviewed-on: https://gerrit.libreoffice.org/84596
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
The failing scenario was reproducible on my old phone:
* start editing the document from the shell
* add a word
* leave the editing using the '<' in the top left
* start editing the document again => boom!
In the normali, non-crashing case, the order of destruction is that
~ChildSession is called first (and calls ChildSession::disconnect() that
consequently calls Document::onUnload() via _docManager->onUnLoad(...).
The Document::onUnload() then deregisters callbacks and all is fine.
The in the above described crashing case, the Document is destroyed
before ChildSession and calls resetDocManager() for all sessions.
Before this patch, this meant that the _docManager was set to nullptr,
leading to situation that later, in the ~ChildSession, the call of
onUnload() was avoided, the callbacks were not unregistered, and later,
on the next document load, the app crashed because it called stale
callbacks.
I suspect the change might be useful even for the non-mobile case, but
not 100% sure, so rather do it MOBILEAPP-only.
Change-Id: I279a160ccaab3080e84fe0437ed72684331b6e13
Reviewed-on: https://gerrit.libreoffice.org/84588
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
So that they are in-process, which means it's easier to debug when they
fail.
Also, in UnitLoad, give up on trying to avoid the sleep after
disconnecting, it seems the old condition was not reliable.
Change-Id: I972a3319887a70eeea2585104ed1e762830ca505
Change-Id: If2547d8065d4158cffa8bee62ae78fc020e0b2b6
Reviewed-on: https://gerrit.libreoffice.org/84567
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Depending on timing, this failed with the following error:
wsd-14400-14411 [ docbroker_001 ] WRN Will not load document marked to destroy. DocKey: [/tmp/connectNoLoad_27c61e41_hello.odt].| wsd/DocumentBroker.cpp:520
Make sure we don't try to load the same document again when the cleanup
for the previous session is not done yet.
Change-Id: I354999fa934df665b48dca314d2b77ab95c84ec0
Before other content was still visible after user entered color picker.
But still we will need container with id for updates of colorpicker
later.
Change-Id: Id7cb9d3a77afa6e2a226250f10917fcd454d15dc
Change-Id: If338b10ce3e117a8f43b9bb920820c3d1de324af
Reviewed-on: https://gerrit.libreoffice.org/84415
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
NextCloud Android Application is detected with the JavaScript Interface
"RichDocumentsMobileInterface" and the slideShow() is called when the
full screen slideshow is applied
Change-Id: I2559a1cdf452e77147892eddcde21ca472ef632e
Reviewed-on: https://gerrit.libreoffice.org/84118
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
I hate when apps make it hard to exit them.
Change-Id: I31c73a70fff6a87512debc95cbd31ef0ba8c1f62
Reviewed-on: https://gerrit.libreoffice.org/84354
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
It's the spelling context menu which have that so far.
For example
".uno:SpellCheckApplySuggestion?ApplyRule:string=Spelling_worldliness"
where worldliness is generated dynamically.
Change-Id: Id54b9053eb53fc435b501a05bf519e15e4eba37c
Reviewed-on: https://gerrit.libreoffice.org/84324
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
In desktop shift + enter is used for inserting a new line (multiline
formula input box).
This patch makes that works for tunneled formula bar too.
Change-Id: Ib1b3fd6593b6361c725cff606925d110c8ac1c83
Reviewed-on: https://gerrit.libreoffice.org/84170
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
lok clients can request to complete a function name partially typed in
the formula input box.
Change-Id: If8e4485c5ed9f91a594dfcec04e0c0b10becdcd0
Reviewed-on: https://gerrit.libreoffice.org/83985
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
We need to re-create the sidebar, so we need to
reuse the create portion and separate it from the
in-pace update logic. Similarly, the post-launch
logic is common and re-usable, so we isolate it too.
Change-Id: I5c72d19fd6e7f0f05c32b7bed186a562d19a8f24
Reviewed-on: https://gerrit.libreoffice.org/84178
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
No reason to set these properties as soon as possible.
Change-Id: Iee1f108c628f4e6ada640cde0c698246fe33729c
Reviewed-on: https://gerrit.libreoffice.org/84177
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
View switching should not cause the sidebar UX to re-build at all. So
pass the view-id into the render call so we can avoid this.
Change-Id: I194c1841df2cedfcdf82defb2712d20715d7ff1d
Reviewed-on: https://gerrit.libreoffice.org/84131
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
