problem:
when a user modifies a comment and its autosaved,
if user then cancels the modification they were still added
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I26c872f0957f0815882c4b1aedae83fe6736b7a2
select and unselect usually updates the layout but,
in case if it failed we manually do the layout update
problem:
when already selected comment try to modify,
it will not rearrange replies in the thread this caused
overlapping of the comments and bad user experience
fixes: #7527
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Id56a5c35795e1ff75e8c3a92032afce6b8585fcb
When opening a menu as in Calc > Home > Conditional menu and then
press tab: we can successfully cycle through the elements but for some
elements user cannot see the focus.
- The focus was being set but under the separator. So, better to
assure that the immediate separator neighbor is set to transparent.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icb87b3173144356efad101f5e2b9b77e0e8dcd06
Chevron (Arrow)
- Use existing icon and re-use it instead of a text character
- sing text depending on font size and the width we were giving
- could be dangerous
- Fix alignment: before this commit the chevron was almost glued to
the edge
- Make the hover state less dark so the chevron is visible at all times
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I3b79c6b9df324727fd0c217f869d9bb8a4df2d72
Before this commit separators were being rendered in quite dark color
and thickens make them standout more than the actual interactive
controls surrounding them
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I96c3eaf476cd947f804d855e0fd242a5ab42ee9b
otherwise generated:
| int
| main ()
| {
| return dlopen ();
wasm-ld: warning: function signature mismatch: dlopen
>>> defined as () -> i32 in /tmp/emscripten_temp_6nz4f0ww/conftest_0.o
>>> defined as (i32, i32) -> i32 in /home/builder/emsdk/upstream/emscripten/cache/sysroot/lib/wasm32-emscripten/libc.a(dynlink.o)
em++: error: running limited binaryen optimizations because DWARF info requested (or indirectly required) [-Wlimited-postlink-optimizations] [-Werror]
and erroneously claims that dlopen is not present, and
configure fails.
Change-Id: Ie54db7c2099787a0b63b76b0b6e3e44750c9046e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
This patch is a temporary workaround for fixing CI failures.
In fact on CI with a11y enabled cypress fails to load spreadsheets.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: Ic661358cd47600ec9c3a329bef361b8087483017
problem:
filename textbox will revert to original name after user confirms the name
and then again changes to new name after its processed
fixes: #6131
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ibb1645e5e6517b391d475add7b7d421a260e0ba8
problem:
After entering the comment modify mode and clicking somewhere else,
to lose comment focus, comment cannot be closed by clicking cancel.
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I05ce2b4f6dcba47d40095bb16fdb56ce5b9c20cf
which is done by addLayer, otherwise its possible to handle a
onViewInfoMsg before map is set
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If6e6d15c90de129614bcc2b64705d0b51b5c4e83
We now have a new nice separator widget in online so we can render
separators that are coming from core. However in some cases, such as
mobile, we don't want to clutter the mobile wizard. On top of that we
already have separators.
Also: add comment to the jssidebar.css so it can be found when using
grep, blame etc
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I02a5831eff566367664ed022687ffeea6d7d3a81
This fixes regression from commit c77f1041a5
jsdialog: implement horizontal separator
Where horizontal separator widget was implemented
and now it appears in the sidebar, but as we have grid
layout there - it occupies only half of the sidebar
because we have 2 columns.
Previously there was no separator - hide it.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie65626011f98ded52e57306fc41d94fc58829d8f
Avoid screen reader to wrongly report text when a shape or image is
selected:
- Got editable area to be made empty when user is not editing text
- Got default for any input to be prevented (except for some special
cases) when user is not editing text so editable area is kept empty
The selection action and the selected object name (e.g. "Rectangle",
"Presentation Title", etc.) are sent to the client.
That allows screen reader to report: "Presentation Title selected" or
"Rectangle unselected", according to the action type.
Selection text content is reported too when available.
Something alike is reported on cell navigation in a spreadsheet.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I75a8b66ef8cb7b24b28d749f0b24afe2587de45e
submenus should be opened next to the previous level
on the right side in LTR mode. without that change
we had submenus just under previously selected entry.
anchors "top" and "end" were implemented
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5b3b677c2347664f4ab97aab3a04da5fe72e3bff
It is possible to make submenus:
{text: _('Condition...'), items: [
.... sub-menu entries ....
]}
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0a6687c0a6bc19b4cd6616005571b75ad41eb444
it is used in dropdowns eg. conditional formatting in Calc
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I19554c74de2fa861686469acbf2c3025633d0687
Don't count dropdowns to the number of opened dialogs.
Use special type to indicate that "dialog" is a dropdown.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I38fa3c303d24601fc76606b994b7398f12dc7d38
w2menu in our version doesn't have submenus...
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I788a214c71ed880fdbc51dc026f00b82549c3361
but entries have to be max-content to not wrap,
only main container has no width set to be automatically
resized to the needs
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I0dc2487b56700b1cc87f5f7ce1fcda8e91855269
problem:
rename dialog sometimes flickered in Firefox
it flickered when the button label was clicked,
it made the event bubble and triggered the click event multiple times.
trying to open dialog when already opened makes it flicker intentionally
fixes: #7479
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I290c905ac321650bd7979495c78de7d66f188ffd
override error messages
- send App_LoadingStatus msg with Intialized status once map is
initialized so that integrator can start to send postmessages
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I96e0c1471cbabe15b0e61711defe15f4e5298ab3
