Some tests were relying the cursor position for checking the document
dimensions. Those code lines are removed from the tests.
Document size is not able to checked from html elements. Instead, a unit
test may be prepared for that task.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Idd4fd52656b2969bf0bfa9534a807a7a8bd3f987
php-proxy slows down things and make it visible, that
cellA1Bounds and cellC3Bounds can be initialized to the same
value. So let's wait fo the cell cursor to be updated before
we set the cellC3Bounds value. Changed the toString() function
to exactly match with the json in the overlay items' text attribute.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Idde0f516ff568cb14b5d53224fd75ebc6167abe9
We always have a cell selected, so we can move the cell
cursor left and right anyway.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I11c255bd38fb927652c9afd2f111ce9e2acce103
Using autofill marker as an indicator is not that reliable,
because it's missing by document load. The cell cursor overlay
however is always there.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I87e92efe78d492b3c66fb04e3b2ca25d4f122584
Currently only the cell-cursor and document selections are part of the
canvas overlay. The others are still part of svg layer.
For now only the bounds of the canvas-overlay items are asserted. The
canvas overlay items update their bounds data as JSON text on cypress
only divs inside the overlay section div every time there is any change.
Unlike cell cursors, the selections need not be always a single
rectangle. To add tests for the more general cases, the json format of
test data is helpful.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I70e6328116c44317f31deb9c8bea62e781d8c421
To make workdir structure easier to understand.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1d0d8a16bd12cf9fc9abf9d350509f20ad322a7a
This assertion is triggered by interference testing:
make check-interfer-desktop spec=calc/tunneled_dialog_spec.js
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib16c97d7c45192a493720d028f38eb5efba4346f
To avoid issues coming from the delayed autosave.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib98b35396efb4fdfdf84846dd23619c666accbdb
So we have separate canvasShouldBeFullWhite() and
canvasShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I0932a7615c84c35293c2cc8dade0db6468de8224
So we have separate imageShouldBeFullWhite() and
imageShouldNotBeFullWhite() methods, which might make
the code more readable, then having it controlled by
a bool parameter.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I2ada6b9e6f6d93b8a48e9ddd3c851ef3e6fcd632
By now, we don't run the same online branch against more
core branches, so this code is obsolete.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I90768d16628e735129880cc4cf823bf0b7d9ad1e
We use this method in various contexts, where it's not
necessary that we have the cursor of the focus. Focus can
be tested in focus related tests.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic27de45917657d4ac1734565d81d5bbf190ad333
It's not necessary to have any text in the first cell, so
double click won't work for every test document. However the
spreadsheet is always there so we can move the cursor through
the different cells.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icea63a971fb77d915e027569a80c9a8a8b855a01
This reverts commit 129ae61684.
This is actually undefined, whether the cell cursor would be there
or not. We get cell cursor messages after loading the document,
so if we step into editing mode before these messages, then we
will have the cell cursor, but if we wait some seconds after
opening the document, then the cell cursor won't be displayed.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I7a4e9e5adbbbe312f21789fe872726bbf67565e6
There is no more span inside the HTML representation
of a text field. After this commit:
b982d0e6f94ca70765231ff4242c829f5bec5def
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ic64a20dcb0534876af062a1fb40cb0e39fd27f10
CanvasSectionContainer has now capability of creating divs below sections, for testing.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ia735758ce27af558718da50935502723112e838e
It causes an issue for calc to use cypress's dblclick() method
and it will select the wrong cell. In the log, I see only a
double click when we simulate user events with cypress, however
when I do double click manually, first I see a single click and
then a double click in the log. So let's do the same with cypress
simulation too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I18e92fc354558e09bb5cb3a12e45cbb669ac97bc
Visibility of the blinking cursor is not good enough
on dekstop, beacuse it changes position after it is
displayed. So let's wait some time to step cell editing
mode.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I86fe7fd5be68f36126ba3d390b29740b33cf3d8e
So we can specify which cursor we need here. The default is
the document cursor, but this methods can be used for
formulabar cursor or dialog cursor too. More cursors might
exists at the same time, that's why simple '.blinking-cursor'
selector does not work.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1fd04e188ab53e70d0e8303fd7502f183c18bef3
We have a dummy spreadsheet document with a column of cells each in a
different font size. The font size of the current cell is displayed in
the sidebar.
In the test we step through the cells first downwards and then back.
Thus the sidebar image that contains the font size will be updated as
we step through the cells. At first nothing will be found in cache,
but when returning, the images should be found in the cache. If the
cache in the JS client is not consistent with that in the server we
will throw an exception.
Change-Id: I439263c7923d985679fafa0125cd2d7f635e0995
Signed-off-by: Tor Lillqvist <tml@collabora.com>
In master view, the 'Master Slide' list should be empty and so it's
not shown on mobile wizard. No, I disable this test, because
it needs the core code to be updated.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I12562c453673ac85e050303ebb5803fee6f1892a
