I have the following error in the console log:
Control.Toolbar.js:1541 Uncaught TypeError: Cannot read property 'show'
of undefined
at NewClass.onDocLayerInit (Control.Toolbar.js:1541)
at NewClass.fire (Events.js:146)
at NewClass._onStatusMsg (Socket.js:886)
at NewClass._onMessage (Socket.js:777)
Change-Id: I83f07bd5bfcfde484156c2719065f4418f6fd4b3
Reviewed-on: https://gerrit.libreoffice.org/81534
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
The loleaflet/admin folder was created to separate the source files
that it is related specifically to admin console stuff. It contains
the build script, source files and now the appropriately debug files.
*TODO: fix the relative paths.
Change-Id: I0b26208e1ceff28ac5c7b2a9b2f1ff424d87e6a5
Reviewed-on: https://gerrit.libreoffice.org/81505
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
We need to add a delay to the processing of viewinfo message
to make sure it is processed by the _docLayer.
See also this commit:
b0317d0ff461100ce9f0ba805cb18e5d829947e2
The above commit adds a delay to the status message processing
which is a dependency of handling the viewinfo correctly, so
I added a similar delay here too.
This is needed after core.git's
f68a36b62ed327eb67efdfea0ac46645b4d90877, without it the native code
crashes:
E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.collabora.libreoffice.debug, PID: 25358
java.lang.UnsatisfiedLinkError: dlopen failed: library "libc++_shared.so" not found
at java.lang.Runtime.loadLibrary0(Runtime.java:1071)
at java.lang.Runtime.loadLibrary0(Runtime.java:1007)
at java.lang.System.loadLibrary(System.java:1667)
at org.libreoffice.androidlib.LOActivity.<clinit>(LOActivity.java:467)
at java.lang.Class.newInstance(Native Method)
at android.app.AppComponentFactory.instantiateActivity(AppComponentFactory.java:95)
...
Change-Id: If0d0f3ade3d2a5a8692dcc3d79edbfb51cd7e2ed
Reviewed-on: https://gerrit.libreoffice.org/81499
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
... because lotuswordpro filter is not present in MPLv2-only core builds
Change-Id: I100e886273f8b7fd38887576c2d29fad4c69b2e7
Reviewed-on: https://gerrit.libreoffice.org/79683
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit d7813989913e95cefc8484d6d2af965ed5752588)
Omitting Draw...
[Here in the master branch, all this change does is to add the sidebar
button to the toolbar for presentation documents.]
Change-Id: I1b97757629bf93795e0fe4f4d5681f9e31354df6
Reviewed-on: https://gerrit.libreoffice.org/80024
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
They are needed since commit
c1e04e4069
("scripts/unocommands.py: Switch to python3"),
so add a corresponding check to configure.ac.
Change-Id: If0f1d2b474c3edb3fc63dc54292acd54f096b822
Reviewed-on: https://gerrit.libreoffice.org/81473
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
Files not explicitly opened in binary mode are text files and thus
expect a 'str' arg for their write() method.
Python 2 is nearing its EOL and e.g. Debian has already
removed the python2-based 'python-polib' package previously
used here from its testing distribution.
I checked that running the commands
./scripts/unocommands.py --update . ../libreoffice
./scripts/unocommands.py --translate . ../libreoffice/translations
./scripts/unocommands.py --check .
still yields the same results as previously.
Change-Id: I39e1785d3c78416009420dd4c2be58bd1c3647c3
Reviewed-on: https://gerrit.libreoffice.org/81422
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
Tested-by: Michael Stahl <michael.stahl@cib.de>
When the user selects an item (touch), the LO server updates and send
selected data to apply border styles.
Change-Id: Ic6f877712514806b822d70342738ee04ae2ea0a8
Reviewed-on: https://gerrit.libreoffice.org/81419
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
sidebar of the impress document
The client side sends the JSON string:
{
id: "sd::LayoutMenu", // control id in sidebar LayoutMenu
cmd: "selected", // Selection action
data: "3" // item id,
}
The LO core server receives the data and execute actions to the
correspond control child.
Change-Id: I066b804a63f48fe04e9c691da928e186b573f8c2
Reviewed-on: https://gerrit.libreoffice.org/81168
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
74ce4a9261 introduced a
different order than in core.
Change-Id: I4d601e1fcd3028c7bbe9d0119c15193fe1db1f35
Reviewed-on: https://gerrit.libreoffice.org/81270
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Aron Budea <aron.budea@collabora.com>
This patch fixes the following problems:
1)
- create a document with several comments
- pan so that the comments are visible and the commented text is not
- tap on a comment box: no scroll action is performed for getting the
commented text visible
2)
Writer: in a document with a single page and a few comments,
clicking/tapping on a comment box doesn't align it with the commented
text since it is not possible to scroll the document (it is already
fully visible - it's made by a single page) and the comments are not
scrolled up/down.
Change-Id: Iaedbe9a89b5f45c322c5f9405960017cd7054e8e
This patch mitigates but does not solve completely a problem that
seems to affect especially iOS devices when the user performs a pinch
to zoom the comments layout is not updated.
Change-Id: I04a0e91c11d07744653b6a25ffb553d22249bcb3
The selected comment can be placed far away from not selected comments
so the intersection could be empty, better to check for the y
coordinate only.
Change-Id: I2f649521bc5de44c89cbb61f76e6930aa5ccfe96
extraSize is fixed because the comments are never
scaled themselves, so we shouldn't scale the extraSize.
This fixes the issue with not being able to see the
comment boxes fully, even when scrolling to the far right,
when the screen width is too small.
What happened with small screens is that the document
zoom factor (and hence the dimensions scaling) kicked
in and zoomed the document out (< 1 scaling factor).
So when we scaled the extraSize needed by the comments,
we reduced their available width and since the
comment boxes aren't scaled they were left outside
the document and outside the reach of the user.
Change-Id: I57df55963b6119d5dde878bf3e1c3ffe984b7c43
