replacing 'Select...' to 'Select Table'
to it be consistent with the pattern.
Change-Id: I2724db65242588aa5d7aa6d375690ac3f478f209
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102048
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Use hash to identify download and pass that to the client.
This allows us to reduce parameters for download requests.
DocBroker maps download ids to URL in the file system.
Change-Id: I254d4f0ccaf3cff9f038a817c8162510ae228bc5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101992
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
problems:
the main menu obscures the submenu,
the file name box / pencil obscures the submenu,
the submenu is hidden behind the status bar.
Change-Id: I8c3d08c9291c76c5b487e248ccbaf58410e3b54c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101302
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
fix the transparent background on hover state for the menu entries
introduced in https://gerrit.libreoffice.org/c/online/+/101833 by
making sure that the style is just applied to the top level anchor
Change-Id: I48d9d1cd22b618566d131c14d2cd2a345d21b85e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102047
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
.flex-fullwidth
This was causing elements (without arrow) in the insert mobilewizard
to have its labels misaligned
Change-Id: I0472a5d39a2691b48d7920a75821447622cc1801
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101937
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
for the context menu of header be in sync
with the context menu of the cells.
Change-Id: I3f228e57375b10671b98de1a1444af87e8b2ed38
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101924
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
problem:
In the mobile view taping on the selected slide preview would open the wizard
but when some object is selected on the slide
wizard would open for that object
this patch helps us to set the Page as selection and as result
mobile wizard opens for the slide even when some object on slide is selected
Change-Id: Ia4f0d5fe6a4d82d101ee26b75f557a44e0627704
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101422
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Problems:
1: Browsers hard-code ctrl+shift+v as "paste without formatting" - ie. plain text
We need access to the clipboard to get the rich data needed for paste-special,
which we can only get security context / access to with a ctrl-v keypress
2: we cannot directly access the clipboard data with ctrl+shift+alt+v
Solution:
Externally copied data could not be pasted directly with paste special
and unformatted paste due to no access to the clipboard data
To access the data copied externally we rely on user to trigger paste event
We use default browser shortcut for unformatted paste(ctrl+shift+v)
this triggers a paste event
for paste special we ask user to press ctrl+v with a popup and then
if that popup is open and paste event is triggered we trigger paste special
New shortcuts:
Paste: ctrl+v
unformatted Paste: ctrl+shift+v
Paste special: ctrl+shift+alt+v
Change-Id: Ib15c701f5e03123cb91e36d1c1d64f0c12aa9cfb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100927
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
This is a quite complicated change that should both fix tdf#133284
(cursor keys on a hardware keyboard do not work in a spreadsheet
document) and also improve the interaction with
CollaboraOnlineWebViewKeyboardManager that manages the on-screen
keyboard. We need to jump through complicated hoops in order to get
the hardware cursor keys handled right after loading a spreadsheet
document.
In the CollaboraOnlineWebViewKeyboardManager case we try harder to
keep loleaflet's _textArea buffer in sync with what the UITextView in
CollaboraOnlineWebViewKeyboardManager uses to provide suggestions
above the on-screen keyboard.
Also merges in related changes from today to
CollaboraOnlineWebViewKeyboardManager.
Change-Id: Ic4acb54bd4e815aa8bfb2bf40b08493446ae5ab0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101878
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
When a dialog is rendered the hamburger menu appears to have
a different color and thus, it stands out in the background.
Change-Id: I35766d083fc342f1d7bcbdca1ad9723057b70cd3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101833
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
This change prevents user from creating multiple instances
of dialogs eg. by using sidebar. Dialogs are modal now.
Child dialogs still can be created from existing dialog and used.
Change-Id: I388006d8857d0196d2884598e150f7bf5948ed47
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100598
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101821
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
and blink active dialog to inform user that he needs
to close dialog first...
Change-Id: I6c9ee662ae2ab935f03ee8fdd0cf7327703e2170
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100457
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101820
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
- Add lc_tableautofitmenu.svg
(used in the context menu when inside of a cell)
- Sometimes headers do not get properly set from JS:
missing "justify-content: space-between;" and so set it in the CSS side
Change-Id: If383b15fc5920f1074c6eb88dd45bd2667095d66
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101481
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
"Private" and "public" have no meaning in JavaScript as far as I know,
there are only naming conventions. And we keep using properties and
functions intended to be "private" (have names that start with an
underscore) quite freely across source files and classes anyway.
Also, the names in the comments were wrong.
Change-Id: Ib5172c26be8818cb261dbe7d08d1c3245ff64af8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101699
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This reverts commit 0cc4977abd.
Reason for revert: after Pranam's fixes viewing/hiding/modifying comments
work as expected, therefore we can have this option back.
Change-Id: I299f33552ae26d29ea2078c286bc5c785ebdb7a9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101517
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
in IE/Edge:
- not working var()
- color with opacity must be used in rgba() format
- width: max-content not working, use nowrap
Change-Id: I771b2b8d58821144f5704d67126b5490a5f75c7a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101399
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
- make sure avatar container is set to content-box instead of border-box
Change-Id: I342f01136bee99a0154527f34703b323cd62aeb5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101381
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
* convert var colors to rgb
* use the var colors for shadow + alpha (rgba)
* .document-title container: remove table display and add min width
Change-Id: Id4289af91562790edd23c83d4e70a16688e44fe3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101048
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
This solves issues with positioning in Chrome
using non standard zoom levels
Change-Id: I14987f6c9e50f2d1c8a1170c489f69471cb9f807
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101307
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
text cursor only if cursor is visible
appropriate cursor for drag markers
move cursor for selected object
Change-Id: If750ac91fc870a0d730d4455c51bde0423c55e4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98425
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Shows only for users which are present in the session
as oly for them we have available data.
Change-Id: I26b7c7f4358873216dba9fbf69a2608b1bf0803f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100430
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101019
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
If loleaflet is embedded in an iOS app that uses
CollaboraOnlineWebViewKeyboardManager, then we can use that to
reliably display and hide the on-screen keyboard. (Such iOS apps are
Collabora Office or Nextcloud.)
This is optional as we can't be sure whether the version of the iOS
app we are embedded in uses CollaboraOnlineWebViewKeyboardManager or
not. If not, work as before. I.e. hope that calling the focus()/blur()
methods of a textarea object will show/hide the on-screen keyboard.
Change-Id: Idddedcb4a83588c622067cdbeadb02ecdbd4fc72
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100980
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
TextInput.js sends keyboard events to the right dialog window now
by referring to Map.js - rather than needing several different places
that can be focuses.
Change-Id: I044bc858a80379b68838d64d1987a1dbd9007195
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100955
Reviewed-by: Ashod Nakashian <ash@collabora.com>
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Ashod Nakashian <ash@collabora.com>
When the toobar buttons to the left of the first splitter
are hidden, we start the toolbar with a splitter, which
is aesthetically unpleasant.
Here we special case for the desktop only, because
tablets and mobiles have a slightly different toolbar.
Although we should have a similar logic for them too.
Change-Id: I9869433f3ca3391d7ee899a77bb1466fe456f9f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100832
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ash@collabora.com>
There has apparently been confusion with the unrelated
Window.postMessage() method.
Do it for the iOS app case but presumably the same can be done for the
Android app case, too.
Change-Id: Iabb259b618426cbbb9f4ed2a9a97ad907bc09c39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100773
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This patch is for preventing sidebar from being launched when:
* Document is on read only mode (No need for an editor bar when doc is read-only).
* Also the main reason for this patch was to hide Sidebar when revision history is open (NC).
Change-Id: I4d78c65a7e8f39b0827b9e23ecc24fcd9520fef8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100601
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Our focus and blur back-and-forth dance does not seem to work on iOS
like it does on Android. So for now, never call the textarea element's
blur() function explicitly on iPhone.
Also don't play with the readonly attribute on iPhone.
Probably whether the calls to the textarea's focus() and blur()
functions actually do anything or not might depend on whether the call
stack originates in a user input event handler or not, for security
reasons.
Change-Id: I442f0c26ae5b36913235a7ef96820bff83535b76
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100611
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
When notebookbar is created calc-input-win is moved down.
This change takes into account that change and allows
us to handle click position correctly.
Change-Id: I7dd6f3ec7d65cd293721321b080626c61a84daf7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100649
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
When mobile wizard is opened and then we open the
hamburger menu without closing the mobile wizard the
showSidebar flag is not set to false. So when a
sidebar update comes from core then the hamburger
menu is replaced with the sidebar content.
Change-Id: I38601b3bf09309a62b2c3404f9ad27323c61cba1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100612
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This is no longer need it because the orientation is manual
changed, adding or removing class styles and the patches
below were added to adapt the new changes
This reverts commit 69c21d5bb4d084cb8abc38b4176c8b40f12c8490.
Change-Id: I70aee6b569f78795487cbff736130e0e74165432
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100564
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100592
Tested-by: Jenkins
by resizing the canvas only when the width/height of the map increases.
A canvas resize causes horrible flickering especially when the dpiScale
is not 1. This problem is more prevalent in mobile due to the on-screen
keyboard.
Change-Id: I10135d91f122eb751f16791476e09a45dbe09752
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100490
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
This should have been cleaned away when Map.Tap.js was removed in
a89d122479 "remove obsolete Map.Tap
handler".
Change-Id: Ic3946da8097089af1fb51e7b7a5f1c2e1b82c98b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100576
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
... if there is an active/visible cursor *and* it is out of the visible
map-area. The map position is so adjusted that the cursor will in the
center of the visible map area. This is needed for mobile(at least
android) because of the on-screen keyboard.
Note: We already do this for every 'invalidatecursor' message.
Change-Id: I3342a165ad47fe1b32715f3a6bf35486ba2f287c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100489
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
so that they do not get out of sync with the canvas on mobile/tablet
swipe/pan.
Note: This does not update the contents(path nodes) of the svg's. Note:
In the long term we can get rid of the map-pane scrolling and avoid all
this but right now only Calc is using canvas based tile layer.
Change-Id: Iaf6894b0fc39a2a32ac19d0e9acd6abb14336785
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100487
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
with updateInterval throttle like we do for desktop. This is necessary
for the inertia based scrolling on swipe especially when doing it
rapidly.
Change-Id: I870740c9b6cacfe56fce283f092cc68243fed1a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100486
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
with full support and optimizations for split-panes. This includes some
refactors, for instance the prefetcher implementation is taken out of
the doc-layer methods as a L.TilesPrefetcher class.
Note: This only affects Calc as Writer/Impress are still using
L.TileLayer.
Change-Id: I0e43b58bad0a97d44cbffd1ee0d90d94a9426e29
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100485
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
... and also move the 'statusindicator' event generation code.
Change-Id: Ifdd9eb26d58986ce5fea8ea19f7dc7576d12743e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100484
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Fixes canvas update issues when browser window is resized (esp. when
making it larger) and also during sidebar switching.
Change-Id: I4870e5294b355c1bd0c4ca74b22383207ed9d060
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100483
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
... because the hammerjs swipe handler already uses a
requestAnimationFrame loop to fire move/drag events. Using
L.CanvasTilePainter's own requestAnimationFrame loop to do the updates
in that case results in poor UX/performance.
Change-Id: I2e31fb190b62f57bcb0bd00bec8b7ff4b7119aa1
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100482
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
in containerPointToLayerPoint() and layerPointToContainerPoint() and
hence avoid its side-effects.
Note: L.point() does not copy-construct if the argument is already a
L.Point, so we need to call .clone()
This fixes unwanted scrolling of the map when drag-selecting cells.
Change-Id: If59852fa448c662b11a96d8b5681c59b673403b7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100481
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
... for the canvas to get the mouse-move+drag events and the various
touch events. This is needed because the canvas element (created by
L.CanvasTileLayer) is a sibling of the map-pane div and not a decendant.
Any change in canvas-size is also applied on the tile-container. Also if
there is a move event, counter adjust the tile-container position so
that it is precisely over the canvas at all times.
Change-Id: I5d5bc070c0063c5f24c4b1cb1448db0ce19841bd
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100480
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Set _updatesRunning flag back to false after the loop is stopped.
Change-Id: I413d5beac4133326a4bc0b3d6729d03f77b20227
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100479
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
(and not just for 'moveend').
Change-Id: I487d22fff5e55741baa1a1d7f99798371fa3d284
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100478
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
Leftover from hacking that lead to its addition?
Change-Id: Ic033ffc625613908ff57d27c10ffbba087ff03c4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100575
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
This fixes the mouse wheel - now it works on the chromebooks.
Change-Id: I5bf2a7e1ae397ef171221ac58172940bb43cbb3c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100227
Tested-by: Jenkins
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
there were some problems before, particullary with bigtoolitem types
Change-Id: Iee9816977d782221290e641527eb422291768e6a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100257
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
In other apps than Calc there was an error when trying
to resume after idle:
Uncaught TypeError: Cannot set property 'id' of null
at HTMLDivElement.restartConnectionFn (Socket.js:490)
Change-Id: I0b3c8d907aa220a3b9504ff62b0437c121bd3619
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100241
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 8409f1ce2f6585aa82b0b21c7e9bb791f48b6a1b)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100220
Tested-by: Jenkins
This was introduced in a59076e1ca
Change-Id: I79b3281c41b16afc73625cc48b2996e2438209e3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100149
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
When the pane element translation3D is modifying
the "moveend" is fired, which is required to compute
the ruler offset.
Change-Id: I1388b44c041563a504de9a47011bfac2b3138679
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99908
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The ruler is created only when the document writer layer is initialized
Change-Id: Ie8ea5b466ccb2aca0c91f5c09402bc9028bbdeb8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99905
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
It happens when the ruler call "fixOffset" function
Change-Id: I3a61147bd9b0d9bc705d9f6a70c06bd5345d660a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99907
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
There is no item matches with this selector.
It's actually '#spreadsheet-tab'. Since this line
of code has no effect on the behavior, I just
remove it.
Change-Id: Ib7cb611cbae209a17035e7b228cd31d8e38cf5b6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99978
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
to impress and calc plus group it with separators
Change-Id: I1ef0cc04adb1a74c5c8211fd3cd72a96cf8259fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99991
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Since a59076e1ca there is no '_path'
member in L.Path and the DOM node(s) of L.Path are managed by
L.Path.PathNodeCollection.
In this case, provide a public L.Path method to set its DOM node(s)
cursor.
Change-Id: I3b96fd38c1484b7b00a84697987c5522a9b2ce3d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99982
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
when removing the Path object from the renderer via
Map.removeLayer() -> Path.onRemove()
This is because, some L.Path specializations like L.PathTransform.Handle
expects that its node objects are retained even after removing itself
from the Map/renderer. (Possibly there are more specializations where
this is expected).
Note: The removal of node object(s) was introduced as part of
a59076e1ca
Change-Id: I398a6035271da725852cf29104438b47c516c187
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99981
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
If tab is marked with context, show it only in that context.
Exception: tab with 'default' is shown always
Change-Id: Id3ae82cc9188c0e5050d5e78629ce4dea98049c4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99864
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
This fixes bug in Android app where progressbar
was added without any condition.
Change-Id: I535001fce4ae37da4f5dc87031d9c15db043d655
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99731
Tested-by: Jenkins
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Changed the gestures:
1st tap to select the slide
2nd tap will open the mobile wizard
long press and then drag and drop the slides
Change-Id: I44a874f69eed4586667f7fbe825d5da943565071
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97345
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>