in IE/Edge:
- not working var()
- color with opacity must be used in rgba() format
- width: max-content not working, use nowrap
Change-Id: I771b2b8d58821144f5704d67126b5490a5f75c7a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101399
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
- make sure avatar container is set to content-box instead of border-box
Change-Id: I342f01136bee99a0154527f34703b323cd62aeb5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101381
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
For now, just copy its source files here. When/if I figure out what is
the appropriate way to package that framework for use in other
products (like the Collabora Office iOS app) I will use that instead.
Change-Id: If808f96b6a72c80e54dc84fce80a551503c96335
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101268
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
* convert var colors to rgb
* use the var colors for shadow + alpha (rgba)
* .document-title container: remove table display and add min width
Change-Id: Id4289af91562790edd23c83d4e70a16688e44fe3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101048
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
This solves issues with positioning in Chrome
using non standard zoom levels
Change-Id: I14987f6c9e50f2d1c8a1170c489f69471cb9f807
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101307
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
We now gracefully fallback to copying when/if systemplate
is readonly.
The bulk of the change is to support proper cleanup in
both cases.
First, we had to move as much of the jail bootstrapping
into the loolwsd-systemplate-setup script, so systemplate
will be as complete as possible before it is locked down.
Next, we needed to update the jail with graceful fallback
to linking/copying upon failure. For that, the jail setup
logic in Kit.cpp has been reworked to support not just
update failures, but also more comprehensive mounting
failures as well.
Finally, jail cleanup now is seamless. To support proper
cleanup when we had mounting enabled but had to fallback,
we mark jails that aren't mounted so we can 'rm -rf' the
contents safely and without fear or causing undue damage
(as unlikely as that is, technically we wouldn't want to
rm systemplate files, if mounting read-only had failed).
There are a few minor refactorings of JailUtil to make
it cleaner and more robust.
Change-Id: Iac34869cb84f45acf64fbbc46d46898367b496d2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101260
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
This reverts commit e83e36bd9b.
Unit test failure was fixed
Change-Id: I2176368278725c1711df3b23eef95de6526c68d5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100859
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
text cursor only if cursor is visible
appropriate cursor for drag markers
move cursor for selected object
Change-Id: If750ac91fc870a0d730d4455c51bde0423c55e4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98425
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Shows only for users which are present in the session
as oly for them we have available data.
Change-Id: I26b7c7f4358873216dba9fbf69a2608b1bf0803f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100430
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101019
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
If loleaflet is embedded in an iOS app that uses
CollaboraOnlineWebViewKeyboardManager, then we can use that to
reliably display and hide the on-screen keyboard. (Such iOS apps are
Collabora Office or Nextcloud.)
This is optional as we can't be sure whether the version of the iOS
app we are embedded in uses CollaboraOnlineWebViewKeyboardManager or
not. If not, work as before. I.e. hope that calling the focus()/blur()
methods of a textarea object will show/hide the on-screen keyboard.
Change-Id: Idddedcb4a83588c622067cdbeadb02ecdbd4fc72
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100980
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
TextInput.js sends keyboard events to the right dialog window now
by referring to Map.js - rather than needing several different places
that can be focuses.
Change-Id: I044bc858a80379b68838d64d1987a1dbd9007195
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100955
Reviewed-by: Ashod Nakashian <ash@collabora.com>
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Ashod Nakashian <ash@collabora.com>
When the toobar buttons to the left of the first splitter
are hidden, we start the toolbar with a splitter, which
is aesthetically unpleasant.
Here we special case for the desktop only, because
tablets and mobiles have a slightly different toolbar.
Although we should have a similar logic for them too.
Change-Id: I9869433f3ca3391d7ee899a77bb1466fe456f9f2
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100832
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ash@collabora.com>
For various reasons, systemplate may be read-only
or under a different owner and therefore impossible
to update the dynamic files in it.
To support such a scenario, we first link the
eight dynamic files in /etc when creating systemplate.
If this fails, we copy the files.
When creating jails, we always check that all the
dynamic files are up-to-date. If they are, nothing
further is necessary and we bind-mount, if enabled
and possible.
However, if the dynamic files are not up-to-date,
we disable bind-mounting and force linking
the files in the jails. Failing that, we copy them,
which is not ideal, but allows us to ensure the
dynamic files are up-to-date as we copy them too.
Ideally, the dynamic files in question would be
hard-link (or at least soft-linked) in systemplate
at creation. From then on we would bind-mount
the jails and everything would work perfectly and
no files would need updating. This patch is fallback
for when this scheme fails, which should be exceedingly
rare anyway, but which still ensures correct operation.
Change-Id: I09c6f057c49396579aaddb1b8bf4af0930dd4247
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100834
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
There has apparently been confusion with the unrelated
Window.postMessage() method.
Do it for the iOS app case but presumably the same can be done for the
Android app case, too.
Change-Id: Iabb259b618426cbbb9f4ed2a9a97ad907bc09c39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100773
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Instead of using a click() and a dblclick() method, do
click() repeatedly, until selection is actually removed.
For example, it takes ony click when the shape is selected,
but no text is selected inside it. It takes two clicks when
a text also selected and sometimes when selection stucks it
takes even more click.
Change-Id: Ic017d0f5b623de29343cf171a8f4d64988fdb721
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100756
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Sometimes double clicking inside the shape does
not makes the shape to step into text editing mode.
To avoid this kind of issue, we can click more times
until we get the cursor.
Change-Id: I4a9671c299144bd8ca250b575665538ab14758ad
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100755
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
A bug occures when we remove a column selcetion.
The document freezes for seconds before it is
updated. Let's workaround it in cypress tests,
until it's fixed.
Change-Id: I5436c969655260d377d4ce47c86270ef15a15c2f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100740
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
