When the pane element translation3D is modifying
the "moveend" is fired, which is required to compute
the ruler offset.
Change-Id: I1388b44c041563a504de9a47011bfac2b3138679
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99908
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
The ruler is created only when the document writer layer is initialized
Change-Id: Ie8ea5b466ccb2aca0c91f5c09402bc9028bbdeb8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99905
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
It happens when the ruler call "fixOffset" function
Change-Id: I3a61147bd9b0d9bc705d9f6a70c06bd5345d660a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99907
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
There is no item matches with this selector.
It's actually '#spreadsheet-tab'. Since this line
of code has no effect on the behavior, I just
remove it.
Change-Id: Ib7cb611cbae209a17035e7b228cd31d8e38cf5b6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99978
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
to impress and calc plus group it with separators
Change-Id: I1ef0cc04adb1a74c5c8211fd3cd72a96cf8259fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99991
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Since a59076e1ca there is no '_path'
member in L.Path and the DOM node(s) of L.Path are managed by
L.Path.PathNodeCollection.
In this case, provide a public L.Path method to set its DOM node(s)
cursor.
Change-Id: I3b96fd38c1484b7b00a84697987c5522a9b2ce3d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99982
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
when removing the Path object from the renderer via
Map.removeLayer() -> Path.onRemove()
This is because, some L.Path specializations like L.PathTransform.Handle
expects that its node objects are retained even after removing itself
from the Map/renderer. (Possibly there are more specializations where
this is expected).
Note: The removal of node object(s) was introduced as part of
a59076e1ca
Change-Id: I398a6035271da725852cf29104438b47c516c187
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99981
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
We don't need an explicit parameter indicating the platform
type (e.g. mobile, desktop). We can check the userAgent to
get that information.
Change-Id: Ibbc041c4a389cff92203d245f55268ec4e93b0a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99889
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Fix 'detached from DOM' error. In Calc we have a small
flickering of the bottom toolbar, because we have also
the formula bar appearing after editing is enabled.
Change-Id: If642d6ae0aae0fcc761382567a2d2e37ad3bf486
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99888
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
If tab is marked with context, show it only in that context.
Exception: tab with 'default' is shown always
Change-Id: Id3ae82cc9188c0e5050d5e78629ce4dea98049c4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99864
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Test less which might make this test more stable.
Change-Id: Icf11af96bc5d21a14f0a74a641ffed3f91b6e482
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99783
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
This fixes bug in Android app where progressbar
was added without any condition.
Change-Id: I535001fce4ae37da4f5dc87031d9c15db043d655
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99731
Tested-by: Jenkins
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
We can enable video recording with this flag,
during a headless test run, so we can see what
happend on the UI.
Change-Id: I4558563a3de71742d8d6b1ca67f0c518d543afc7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99787
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
We need to introduce separate rules to dump
the log and to dump out the error message.
Otherwise GNU make evaluation breaks the workflow.
It evaluates $(wildcard $(ERROR_LOG)) before the
test were actually executed. So first run the tests,
then dump the error output and then go into error state.
Change-Id: I0f8e5de6800f0691cca14019819972437a741382
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99781
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Sometimes this text contains an additional end line character.
Change-Id: Id58eab9ea3b082781cdd8ec341fa2b058ba3b17e
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99770
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Changed the gestures:
1st tap to select the slide
2nd tap will open the mobile wizard
long press and then drag and drop the slides
Change-Id: I44a874f69eed4586667f7fbe825d5da943565071
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97345
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
To run multi-user tests only.
- make check-multi runs all multi-user tests.
- make check-multi spec=sidebar_visibility runs
only the test pair with the specified name.
Change-Id: Idada04960a6a2d33c7f36ef57bc1d6a1d1cffa99
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99682
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
if there are things to be save change class from save icon
Change-Id: Iaacc48a62d7626b8cfc489efd80141b209039b2a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99677
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
Code update allows to search in all toolbars not
only main one like in the past.
Change-Id: I76c9cdbbdade287748ec19d537b564206d52eab5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99671
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
touch screen will ask for tap instead of click to resume
Change-Id: Ie5cb3db33de606beba9e9f1841f9171647aa02ac
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99122
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
