This guarantees that any early failure results
in the status to also be invalid. That is,
only when we do get 200 OK from the host do
we set it in the StatusLine, never by default.
Change-Id: I4e31cb48cce0ed8962a737c4784fd6453b9a48cf
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Otherwise the LOK_CALLBACK_STATUS_INDICATOR_FINISH
message is lost, and client side does not receive
it when Macro Security dialog popup.
Change-Id: Ife52c77078160b8cc1075eff9137de2d26b87b55
Signed-off-by: Henry Castro <hcastro@collabora.com>
Normally the client session waits for a message
"status:" when the document has loaded to forward
to client side. However, when the document has macros
embedded, and a Macro Warning Security dialog popup
it will never receive the "status:" message.
So it is added "statusindicatorfinish:" to formally set that
the document has loaded.
Change-Id: Id40b853c002403577d7664c4f8206cb5a01403b6
Signed-off-by: Henry Castro <hcastro@collabora.com>
```
wsd/DocumentBroker.cpp:772:57: error: constexpr variable cannot have non-literal type 'const std::chrono::system_clock::time_point' (aka 'const time_point<std::__1::chrono::system_clock>')
constexpr std::chrono::system_clock::time_point Zero;
^
/usr/include/c++/v1/chrono:1355:28: note: 'time_point<std::__1::chrono::system_clock, std::__1::chrono::duration<long long, std::__1::ratio<1, 1000000>>>' is not literal because it is not an aggregate and has no constexpr constructors other than copy or move con
class _LIBCPP_TEMPLATE_VIS time_point
^
```
Signed-off-by: Gleb Popov <6yearold@gmail.com>
Change-Id: I88c5466b8ad104178cf7fa4101f5f5265ccf5e86
We always have a cell selected, so we can move the cell
cursor left and right anyway.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I11c255bd38fb927652c9afd2f111ce9e2acce103
Using autofill marker as an indicator is not that reliable,
because it's missing by document load. The cell cursor overlay
however is always there.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I87e92efe78d492b3c66fb04e3b2ca25d4f122584
Otherwise this will break badly in the collaborative editing (multiple
views) case.
Change-Id: I63d391cb5a7d118c34564c4e1a4df7710b13e90e
Signed-off-by: Tor Lillqvist <tml@collabora.com>
cypress video recoring does not work when we have two cypress
instances at the same time.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Ib807a001aa497ec9c7ef98df4f8f40236890879c
Now, bound sections propagate events to the sections those are beneath
them. StopPropagation feature is also implemented.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I54c886fea0e254d4b97c4d06585db8ed28d40ab9
Consistent with names elsewhere and less confusing.
Change-Id: Ia72cdef0f6d6cd9589ce54028472e10008cf882c
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The download operation itself is done
after reading the response from the Poco
object. Therefore, the time duration that
was captured for the GetFile operation
was inaccurate. Luckily, we only need
to time the download API of the Storage
object, which actually is simpler, and
more accurate.
Change-Id: I05c94a29fa59d5efae215f2daea17672abc6efc7
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
For some reason, the duration of the CheckFileInfo
request was not set/updated, and therefore it was
always 0. This fixes this oversight and also
moves the duration variable locally, since
the request is synchronous anyway and there is
hardly any reason to store it elsewhere.
Change-Id: I613b24311bc5c8ee9ab98d675057f354990226e8
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
use original names as it is required for pulling translations
Change-Id: I0b679d0802afcfacc7db8cb56a08254749811bc1
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
from nav when in edit mode (keep margins when on readonly mode)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I83923bbb34e34c20daa81e80c5832778faab8e1b
- Fix#1395
- This was also affecting iPad
- Overflow property doesn't apply to some table elements like table grouping and containers by default.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2e12c3cb1e5e2ced16748e79063774502c670946
Currently only the cell-cursor and document selections are part of the
canvas overlay. The others are still part of svg layer.
For now only the bounds of the canvas-overlay items are asserted. The
canvas overlay items update their bounds data as JSON text on cypress
only divs inside the overlay section div every time there is any change.
Unlike cell cursors, the selections need not be always a single
rectangle. To add tests for the more general cases, the json format of
test data is helpful.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I70e6328116c44317f31deb9c8bea62e781d8c421
Workdir folder is for the build system, and for copies
of data files. cypress folder it for output of tests, like
videos, screenshots, cypress logs. So let's put wsd related
logs here too.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icdb757d50d3c2bfef6013b92055b49ba222193e2
To make workdir structure easier to understand.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I1d0d8a16bd12cf9fc9abf9d350509f20ad322a7a
Now, sections can be anchored to other sections's edges.
One does not need to set approximated initial positions for expandable sections any more.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Ic012960dedbd937c19c7442cefefdfebdaffafd3
It can be confusing to have the same error message twice.
This reverts commit 6786f563f8.
Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I66f0495262fc5e5c0a228fdfc417e2e3301ad03e
We use download/upload in the storage
and load/save elsewhere, to avoid confusion.
This renames 'save' to 'upload' in the storage
for consistency.
Change-Id: I9ac991c2b52e2586b97c58db02110ff04bfd17d3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Templates were downloaded by Core
upon loading. This works fine, as
long as there is no special network
setup in loolwsd. However, when
loolwsd has a complex network setup,
such as when using reverse proxies,
Core wouldn't know about the details
and would likely fail to download
the template.
Luckily, there is no reason to rely
on Core for downloading templates.
Instead, we download it in loolwsd,
just like any other document, and
load it in Core as normal. The
remaining post-load saving of
templates remain unchanged.
Change-Id: Ib22ada4ae469863d5e5c8baeee27f667f7cd40ff
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
