Adding or removing class selected looks incorrect even though it
works this way because of sending the event before we change its visibility
but the correct way should be sending it after we change its visibilty
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ibe7b48d6c4b421bd914f833883e866894366f022
We must send additional ruler state when we read
the ui defaults also class selected must be added or removed the other
way around. The rulerchanged event was sent before the correct
place and that was why it was made the opposite now it is sent
after we change the visibility.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I8e59003fef433e6692f02e144223c4e0ee833330
The cell Appearance in calc sidebar show the following commands:
- background color
- border arrange with border width
- border color
in master there is a lot of vertical space used
without additional feature
so the height was shrinked to one row only
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I0831995ccfc18bc6625304d8faeb65fae0fea9f2
In the writer Sidebar at the Table Panel
the items from the second row will be left
aligned so no flex-end is needed.
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I315115d4776d8431cf6df2112970651f9f36bbd3
Currently translated at 81.7% (362 of 443 strings)
Co-authored-by: Simon T <simonpmt@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/da/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: If725530fe9fdc8f8c52c668bad50d9488d991afc
When saving and/or uploading fails, we have
to give up after a certain number of retries.
A new config entry, per_document.limit_store_failures,
controls the number of consecutive failures
before giving up. This prevents locking-up
documents while uploading.
Includes a new unit-test.
Change-Id: I1296df1691fcaa982df9e861d34cb946a2eda860
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Refactor UnitWOPIDocumentConflict.cpp into
WOPIUploadConflictCommon.hpp and reuse for both
DocumentConflict and SaveOnExit tests.
Change-Id: I54ec1e37e5e9c6298b12a2b2e596363683fb2e34
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Now we have multiple document conflict scenarios
that exercise different states of DocBroker and
verify correct behavior in all cases.
Change-Id: Ia1a65be686a0899776799c82c1ebfd405c92dcab
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When the last client connection is closed,
there is UI (or user) to provide input
on the document conflict dialog. In this
case, we detect that the situation is final
and unresolvable and we simply give up.
We log a warning and dump the document state
before terminating.
Change-Id: I111a446b8743a0d16b7ed8b39751a419036c927f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
When the document has been changed in storage,
we should be extra careful not to inadvertently
clobber it because we needed to force the
upload for some unrelated reason.
When in conflict, only a user can force clobbering.
Change-Id: I498a6d1c86242b059ac722d3e48c31a04a79591b
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Since we track active sessions in removeSession,
it's possible that the last session is not active.
In that case, we should set the unload flag while
saving. If we've removed it, we should mark to
destroy. And finally, we should only assert
that mark to destroy is set with active session,
not when we are left with disconnected ones.
Change-Id: I275aeafe67875fa75e0fad5438928f2f77b79a9a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
By waiting at most 2 seconds, we improve the chances
of getting the ModifiedStatus=false before we termiante
the document. This minimizes the noise of warning
of potentially lost data on exit and similarly reduces
the test failures, which test for clear termination.
Change-Id: I284693d1cdd91b1224581fdc29e6e5438ab4c0b2
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
We no store the origina modified time of the document
as we receive from the storage server in string
form and send it back as-is. This avoids any
potential issues with the roundtrip of conversion
to and from a timestamp.
Change-Id: I524bea8f36c3ce62dcd00c4fe6a1e7e083287ed1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The expected shortcuts are documented in
https://support.apple.com/en-us/HT201236 . This patch handles a small
subset of those:
Command–Up Arrow: Move the insertion point to the beginning of the
document.
Command–Down Arrow: Move the insertion point to the end of the
document.
Command–Left Arrow: Move the insertion point to the beginning of the
current line.
Command–Right Arrow: Move the insertion point to the end of the
current line.
Option–Left Arrow: Move the insertion point to the beginning of the
previous word.
Option–Right Arrow: This should move the insertion point to the end of
the next word. But I don't think LO has such a shortcut so we move to
the beginning of the next word instead.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6b0d36b0842388f0d49adf9b75fa9480df79c805
on ios case, there is no device back button available
so it is impossible to go back before the document load
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ifce5e4777b8dd014cbdc527fb65f0d0be21f2cd2
So it's easy to create ideas for GSoC projects
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I465f7b8876a4f43262fae52cf88ceacd89248517
There was a bug:
1. insert very big image
2. rotate and quickly after that rotate again but hold
mouse click so you will still see the preview
result: before patch preview was disappearing
after patch preview is updated
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ieb343a371816fe14e4c65f862abf1e55bf36de1b
Uncaught TypeError: Cannot read properties of null (reading 'getMaxZoom')
at NewClass._transformPoints (Path.Transform.js:577:18)
at NewClass._transformGeometries (Path.Transform.js:513:9)
at NewClass._apply (Path.Transform.js:419:8)
at NewClass._onRotateEnd (Path.Transform.js:1145:8)
at NewClass.fire (Events.js:152:22)
at NewClass._propagateEvent (Events.js:215:27)
at NewClass.fire (Events.js:158:9)
at NewClass._fireDOMEvent (Map.js:1719:10)
at NewClass._handleDOMEvent (Map.js:1689:8)
at HTMLDivElement.handler (DomEvent.js:51:14)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic6f0c808c744636f7b8b4b6a683307b74824d2fa
Probably the last remaining incorrectly labelled
helper that checks for in-progress uploads, but
had retained the old and misleading label of 'save'.
Change-Id: I693275b1559f3dae4e9e3ab2408d997f56ff86e3
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This reduces some logs from debug to trace,
especially in Socket where the amount of
activity is high, but the logs in question
don't add value in debug level.
Also supressed an error when superfluous.
This makes debug-level logs much more readable
and relevant to the main events.
Change-Id: Ie2698b56f320d15a09060cf2877477d9da0e1582
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
