Due to recent changes on the color palette mobile wizard has changed
color from white to gray which causes the hamburger menu to appear not
going full height:
https://archive.org/download/cool-bug-mobile-hamburger-bg/cool-bug-mobile-hamburger-bg.png
Make sure hamburger menu uses the right color
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4263ebf8f92979ffd5a5657fceb76843594d4d54
Save icon (blue tick) should not be visible at all when the hamburger
menu is open
On Calc and it is also needed to hide formularbar while hamburger menu
is open because otherwise the it affects the size of the toolbar-wrapper
and consequently affect the flex box and how the hamburger menu gets
aligned
before: https://archive.org/download/cool-bug-mobile-save-above-back/cool-bug-mobile-save-above-back.png
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ifa5406a5a5c31172cde82e843949671fa95c6596
fix: in regex, escaping special character fails to find host of the alias
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I19bfacc5e45af26832cb8c6a7d249e0c7de56624
- first host is by default allowed without any condition
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Iacca38868f06a417cbb99984e2dac1eef727df6e
the state is explicitly set by the first view but on makeRenderParams
function we dont check if the spellonline is empty or not, if empty
we should not change the state. It is only empty for views after the
first one
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ief5754bdae2eb952c2df9485fa323fc957da40a6
Running command in /home/runner/work/online/online: [/opt/hostedtoolcache/CodeQL/0.0.0-20220311/x64/codeql/javascript/tools/autobuild.sh]
[2022-04-05 08:02:27] [build-stderr] Skipping path /home/runner/work/online/online/**/*w2ui-1.5.rc1.js, which does not exist.
[2022-04-05 08:02:27] [build-stderr] Skipping path /loleaflet, which does not exist.
[2022-04-05 08:02:27] [build-stderr] Illegal '//' in exclude path
Error: 4-05 08:02:27] [ERROR] Spawned process exited abnormally (code 1; tried to run: [/opt/hostedtoolcache/CodeQL/0.0.0-20220311/x64/codeql/javascript/tools/autobuild.sh])
A fatal error occurred: Exit status 1 from command: [/opt/hostedtoolcache/CodeQL/0.0.0-20220311/x64/codeql/javascript/tools/autobuild.sh]
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
Change-Id: I3bcaba31d24e9010af7d4736722cd2413d9e2ce9
Ensure that rendersearchresult: is terminated, and identified as binary.
Change-Id: I84e83c63351cd0aac0923bf7c833b14c1be2c051
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
most of them don't have the text where they need to have
otherwise the text is defaulted to id. We can use hint prop
to text because it has the same output due to the uno command
name convention.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I0dd38ebdaaa95c41225c49e02d7615007e8a4049
Add to elements that should be hidden on mobile
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I16a39b81ec969bc847b92708486b729baddc0c5e
It should not be visible:
- Update id (it now has img as sufix)
- Add to display none elements
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I112cc52423a8862f6a4fb4d9ccaaf79298193721
Some elements were being on purposed set to be hidden but the ids have
changed and now the sufix img was added and so the CSS were not taking
affect anymore:
https://archive.org/download/cool-bug-mwizard-base64images/cool-bug-mwizard-base64images.png
Add sufix, update rules
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0adf33dc64db70138e3530441137bf74275424ce
This reverts commit 32f5c874e7.
The text alignment is causing some problems both on the sidebar and in
the mobile wizard:
- Sidebar arrows (from dropdown menus) position are affected due to this
- Mobilewizard: content is getting wrongly aligned to the right
- On top of that we should preffer start and end due to RTL instead of
right or left
https://archive.org/details/cool-txt-align-bug
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I02f22da0b14b02e7431ea26c16930554e3c13aa2
... and make Welcome dialog optional for COOL
config: add welome url parameter
Signed-off-by: Henry Castro <hcastro@collabora.com>
config: add feedback url parameter
Signed-off-by: Henry Castro <hcastro@collabora.com>
config: add infobar-url parameter
Signed-off-by: Henry Castro <hcastro@collabora.com>
welcome: fix unhandled exceptions
Signed-off-by: Henry Castro <hcastro@collabora.com>
welcome: preprocess welcome file
added welcome-message.html
Signed-off-by: Henry Castro <hcastro@collabora.com>
welcome: clean up code related to vex welcome
Signed-off-by: Henry Castro <hcastro@collabora.com>
--enable-welcome-message is not necessary, when we specify a welcome URL, then it is enabled, otherwise it's user configurable
Signed-off-by: Andras Timar <andras.timar@collabora.com>
remove the unused welcome config settings
Signed-off-by: Andras Timar <andras.timar@collabora.com>
remove unused define ENABLE_FEEDBACK
Signed-off-by: Andras Timar <andras.timar@collabora.com>
do not install/package fallback welcome dialog, when welcome feature is not configured
Signed-off-by: Andras Timar <andras.timar@collabora.com>
remove welcome-message.html
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I20aa6220362018b63aaebd114b2b661561823fbb
We can't test SSL when SSL is disabled.
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I231a3c7d32f848870e90594e2d1151d3a0911f9a
No need to specify if it's first or second button as there is always
only one primary button. On top of that this avoids maintenance work
whenever for some reason the button is not the first in line.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd3ef60023e88d1a9a8fd6f465dc4c63c068debd
now, it uses a css theme variable for the color
but it is a kind of light grayish and it is harder
to see in a crowded document.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Iec5a7efdb4cb385512226841b036eba3b3212427
==4544==ERROR: AddressSanitizer: odr-violation (0x000002c40140):
[1] size=104 'HostUtil::WopiHosts' ../wsd/HostUtil.cpp:12:34
[2] size=104 'HostUtil::WopiHosts' wsd/HostUtil.cpp:12:34
These globals were registered at these points:
[1]:
#0 0x71f618 in __asan_register_globals.part.13 /home/vmiklos/git/libreoffice/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_globals.cc:362
#1 0x7f00cb0f3d7b in asan.module_ctor (/home/vmiklos/git/libreoffice/online-san/test/../test/.libs/unit-base.so+0x10e0d7b)
[2]:
#0 0x71f618 in __asan_register_globals.part.13 /home/vmiklos/git/libreoffice/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/asan_globals.cc:362
#1 0x120e2ae in asan.module_ctor (/home/vmiklos/git/libreoffice/online-san/coolwsd+0x120e2ae)
==4544==HINT: if you don't care about these errors you may set ASAN_OPTIONS=detect_odr_violation=0
SUMMARY: AddressSanitizer: odr-violation: global 'HostUtil::WopiHosts' at ../wsd/HostUtil.cpp:12:34
==4544==ABORTING
All of HostUtil was duplicated between the test shared objects and
coolwsd, so remove it from the test objects and rather exclude
RequestDetails::getDocKey() from the test objects instead, which was
linked in but was not used in practice.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: Ia2147c89cf4230df97a8f45ac7d509aa11cdca97
With the reorganization of Calc tabs:
584e139bbd both Define and Manage names
disappear form the notebookbar. Add it back following the same new
organization.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I06740e225090407117e8b5a6aff54b476368e358
- now widgets are accessible using tab key
- can close all dialogs with ESC key
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4dcafb90f61bd05a91048ec1631d6eb851986c20
Currently translated at 50.3% (230 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (438 of 438 strings)
Translated using Weblate (Russian)
Currently translated at 50.1% (229 of 457 strings)
Translated using Weblate (Russian)
Currently translated at 86.7% (380 of 438 strings)
Co-authored-by: Егор Ермаков <eg.ermakov2016@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/ru/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/ru/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Currently translated at 99.7% (437 of 438 strings)
Co-authored-by: Elisa de Castro Guerra <elisa.dcg@collabora.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/fr/
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I404b68f82b4d192fb20ce77e3fbc9425703fb16e
When the Kit dies and there is no data saved to
disk to upload, there is nothing to do but unload
DocBroker and log the fact.
With unit-test that simulates the situation by
killing the Kit of a modified document.
Change-Id: I7dcc0583c053d7166935d15d045fcf6624e43b4e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
