Commit graph

22395 commits

Author SHA1 Message Date
Darshan-upadhyay1110
f798be095c modified the setImage method for icon
- now setImage method will handle the refresh of icons when theme change to Light/Dark
- added listner to setImage method
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I0529588487c2436d53585e63a2467fe0a917adee
2023-12-01 13:32:37 +01:00
Darshan-upadhyay1110
9769a0f97d Make icon structure consistent
- All Icon HTML structure shoulb be same as other icons
- Most of the places we have this way to add icon in DOM
  - <Button> <img/> <Button>
- This patch is to change for some icon with drop down which is not consistent with above structure
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>

Change-Id: I1a82bc4b3dfbca15f62bfe111e36804c754da539
2023-12-01 13:32:37 +01:00
Pedro Pinto Silva
414b8b5f09 menuItemHandler: add additional identifier as css class to ui-header
Before it was impossible to correctly target one dimensional menu
entries such as Help, About, Feedback and Latest updates.

This affects places such as Mobile: hamburger menu where now menu entries
get automatically assign an additional css class based on its data.id.

Note: we could also employ the same thing within explorableEntry if
needed. But that's outside of the scope of this change.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib50cf1e29f4fae072b8739c76e7facaa540c0ad5
2023-12-01 13:24:57 +01:00
Szymon Kłos
30ccc1ef2e Avoid duplicated / in paths
Also use some allowed path for HOME and XDG_CONFIG_HOME so we start correctly.
Setup Work path for pdf/epub export.
Enable osl allowed paths for nocap only.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4fa058fe5fabc5eafdff7630dfcc72dedfe22e4a
2023-12-01 12:31:33 +01:00
Michael Meeks
f11cad502b Use the OSL sandbox as well: belt + braces.
Also move the nocaps TMPDIR into the jail folder, to sandbox better.

Change-Id: I161695b4585a2c6003779caa88152b744d36266b
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2023-12-01 12:31:33 +01:00
Miklos Vajna
dc149702ae doc broker: handle no _storage in uploadToStorageInternal()
Similar to commit eb5c86a4d3
(DocumentBroker::saveToStorage: guard against nullptr _storage,
2020-10-26), with the same input.

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I17ac2bc12ba086d16ccbf3d5c758e081a32cbf5a
2023-12-01 09:17:36 +01:00
Rash419
67aac9424b indirection: change request interval from 10s -> 3s
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I43c3bc5e1725f9d364c44638364f836e94f38290
2023-12-01 13:04:40 +05:30
Gülşah Köse
aa6fdeaa55 Fix the thickness dialog is shown cut
Thickness dialog has an image in. When the image render is delayed we
are getting image size 0x0. That wrong size caused wrong resizing of the
parent containers. To show better result, we need to get image's actual
size from core.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: I207fd2fcca63deee21f51ef34c1ad670e15afd87
2023-11-30 20:04:23 +01:00
Hubert Figuière
44b92e18af postmessage: don't send ready message unecessarily
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: Ia57d19298615fe4cd5b95c60c6b097631d54e4b4
2023-11-30 11:49:39 -05:00
Rash419
2c78023630 Revert "wsd: disable ctrl+s when HideSaveOption is true"
- fix: disabled 'Action_Save' postmessage when HideSaveOption is true

This reverts commit 34f3dd4a62.

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I5e6425621550153547278a61a936ba9dc7e4aad1
2023-11-30 14:00:03 +01:00
Caolán McNamara
48002c5d40 allow testing wasm in non-debug mode
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I583a8104f590e26a76837bef00814684e2015c7a
2023-11-30 12:58:42 +00:00
Gökay Şatır
bb2df24d1b Initialize parent for red lines.
Lack of "parent" property was causing inconsistent behaviour for redlines.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Iaa2424aeee160a9b28d6b0a29b456ddbc3a1b620
2023-11-30 17:16:19 +05:30
Gökay Şatır
13db34021d Refactor some parts in commentListSection.
Use new functions for querying the properties of comments.

Added new functions like setAsRootComment, getChildrenLength etc.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I9b655f0e6d50050f9e509ba4f822e1d8681a4a69
2023-11-30 17:15:38 +05:30
Gökay Şatır
25b01762fa When a parent comment is removed, child comment is disabled.
* When a parent comment is removed, the children of that comment are not informed.
* We have adjustParentRemove function.
** Function wasn't handling the "parent is removed" case.
** Function was handling the "child is removed" case in a wrong way. Children list has pointers, not indexes.

* When a parent is removed, child wasn't shown. Now we re-set the display property in case it was set to 'none' before.

* getSubRootIndexOf function was trying to continue with index=-1.

On mobile, a reply was added twice, fixed.

Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Id8f95bbe1cb78bf93bf35fe73a6e86203455691c
2023-11-30 17:15:38 +05:30
Miklos Vajna
07db53bb6e wsd: handle Poco::URISyntaxException in AdminSocketHandler::handleMessage()
terminate called after throwing an instance of 'Poco::URISyntaxException'
    #8 0x7f014e70dc86 in std::terminate() (/usr/lib64/libstdc++.so.6+0xb7c86) (BuildId: c74eca671e2dd0f063706372d103f8acef88f1e3)
    #9 0x7f014e70dee7 in __cxa_throw (/usr/lib64/libstdc++.so.6+0xb7ee7) (BuildId: c74eca671e2dd0f063706372d103f8acef88f1e3)
    #10 0x7f014dcea45b in Poco::URI::decode(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>&, bool) (/usr/lib64/libPocoFoundation.so.92+0x15145b) (BuildId: 32601204eb877c998d0122c4bef1c7c08c8d0285)
    #11 0x56496c48320b in Util::decodeURIComponent(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>> const&) /home/vmiklos/git/collaboraonline/online-fuzz/common/Util.cpp:800:9
    #12 0x56496bb21ec0 in AdminSocketHandler::handleMessage(std::vector<char, std::allocator<char>> const&) /home/vmiklos/git/collaboraonline/online-fuzz/wsd/Admin.cpp:84:20

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I07551d92be5ae677d1cf63f0f0092fb838583337
2023-11-29 15:41:00 +00:00
Miklos Vajna
1e125c7bdc Fix fuzzers build
- the HttpEcho build broke with commit
  08d9081280 (net: don't try to set
  TCP_NODELAY on local Unix sockets., 2023-10-30)

- fix an unused variable error from commit
  0631593c96 (wasm: proxy wopi documents,
  2023-11-06).

- the undefined reference to COOLWSD::ForKitProcId probably went wrong
  in commit 3f46c1db44 (kit-in-process:
  pure re-factor to a run-time function to flag this., 2023-11-20)

Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I0cf06d188860bdb2f795485a91c7634b596255aa
2023-11-29 15:41:00 +00:00
Hubert Figuière
2afa6db0ca postmessage: Added Show_StatusBar and Hide_StatusBar
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I86d507f6aad7f3acbc69e82f366e14b4ea78824a
2023-11-29 09:27:52 +00:00
Hubert Figuière
c1f9da92a1 framed.doc postmessage: Hide/Show the ruler
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I1b2f7c4ee0e4faebad4050167ce7aabb6adce275
2023-11-29 09:27:52 +00:00
Henry Castro
60e4552ca4 cypress: add unit test to check slide pane height
Change-Id: I9aacf3dcf123348e9e2b6308695a44bd14cd079b
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-11-29 09:22:47 +00:00
Henry Castro
439ed9ee14 browser: fix slide pane height container
The container '#presentation-controls-wrapper' element should
adjust height value when '#presentation-toolbar' is shown.

Change-Id: Ia44006e5b99f0ec08632cc171a8e23e9b6f67614
Signed-off-by: Henry Castro <hcastro@collabora.com>
2023-11-29 09:22:47 +00:00
Hubert Figuière
1ef0ffeb76 framed.doc postmessage: Hide/Show Save work with the notebookbar
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: Ie0b58528d1545948fbf50d095093fd837ef913cd
2023-11-28 16:03:33 +00:00
Hubert Figuière
79e33ab76c framed.doc: Relayout the post message test harness
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: Idbd1b5d89ea53d4f9925b727e8db2854ac23b17f
2023-11-28 16:03:33 +00:00
Skyler Grey
fbb756075c Unrevert "Stop onscreen keyboard when panning calc on tablet"
This reverts commit 9b3e115fb5. It was
meant to have been dropped without being merged, but #7619 was merged
with it in

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I698c7a0aa680a1b8155c08c8d292f609522fe347
2023-11-27 13:00:55 +00:00
Szymon Kłos
a0f36adf41 jsdialog: close dropdown properly
Make sure we don't expect response from server for online-only component: dropdown which doesn't have corresponding widget in the core

fixes regression on close from:
commit a23adac78c
browser: fix undefined property 'isPopup'

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I005647c77da3a866cec88a78f03dd409a098a469
2023-11-27 12:53:39 +01:00
Caolán McNamara
74b9c72814 need this even if we want to not serve wasm if the headers exist in richdocuments
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I310894e5a72002406eff77b07af76c2b048ffacc
2023-11-27 10:48:44 +00:00
Caolán McNamara
afc28b9e69 we want %ACCESS_TOKEN%, etc to exist for wasm
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I58f187c28c158e80fbe97290bb802b3481a44de9
2023-11-27 10:48:44 +00:00
Caolán McNamara
5232e3d735 hack to get this up and working
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I6d3d273f59f58a0c3b2027039dcc7de95ad971b9
2023-11-27 10:48:44 +00:00
Ashod Nakashian
0631593c96 wasm: proxy wopi documents
Change-Id: I3104ac9a6fd180f11aef06b9d4f516a392e021a9
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
7abeb96cd1 wsd: add StorageConnectionManager::createHttpRequest
Change-Id: Ie690e9c4ea33ae8cea8355d414ed137e7d5130ba
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
a624a704ac wsd: add StorageConnectionManager
StorageConnectionManager centralizes the
connection creation and management of
Storage sockets and related bits.
This is needed as we move to a more async
model of communicating with the Storage.

Change-Id: I7a44c95c113bbc536e922b5aa3f7cf9b71917c22
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
a7d6d1debc wasm: pass the docURL to the wasm app
Change-Id: Ie0933d2def50370cfd43cb7e7b70d9408bedb25a
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
94d213c39e wsd: cache files that need no compression separately
Change-Id: I7b46becd330a7a09a05b7973b18c92679104f597
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Skyler Grey
9b3e115fb5 non-calc: Revert "Stop onscreen keyboard when panning calc on tablet"
This ignores the hints from commit
f62f365a0ed26b21e1f86b0e028cf80fc6b2b9df when not using calc. This is
because they were causing an undefined reference in WASM.
(window.keyboard.guessOnscreenKeyboard). To me, this looks like a bug in
our WASM implementation, as I think WASM should get window globals, but
as it's blocking us we're partially rolling this commit back.

I expect to revert this revert as soon as it no longer breaks WASM.

Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I91bab273d400bf7925e338631e74dabc8a01e529
2023-11-27 10:48:44 +00:00
Ashod Nakashian
c2c0fe6f51 wasm: accept url as command-line argument
Change-Id: I005cd45ed0c6bfbf20bf74c84c670d2f9a0b289e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
3a0a4c1225 wasm: readme update
Change-Id: Ie3f1fb3800597f719f2764ec1ee2cad0ba48e62f
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Ashod Nakashian
b045c2a7b4 wsd: fix compiler warnings
Change-Id: I9ffa81d97c3b04b4c0608466892f9b59a896e509
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2023-11-27 10:48:44 +00:00
Jan Holesovsky
9d8e00312d Kill some copy/paste
Signed-off-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 1ca42964447b6f25acaa63d754f5f42320bea047)

Change-Id: I30fe4421c2305af0da677ebc3731c682e21dae22
2023-11-27 10:48:44 +00:00
Darshan-upadhyay1110
578dd1e780 Add rename document icon for dark mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I6fd72056ffee0d060c3b6d66b4ce70d0ec4bce08
2023-11-25 11:50:25 +05:30
Subham Jena
601352b1f0 Translated using Weblate (Odia)
Currently translated at 11.8% (13 of 110 strings)

Co-authored-by: Subham Jena <subhamjena8465@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/android-app/or/
Translation: Collabora Online/Android app
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I922df944b00c8be79157b25e079e9a22c7923171
2023-11-24 19:24:20 +01:00
Andras Timar
0ec3b7dae7 Update l10n files for Weblate
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I413eb3ece54d09f4a3defe6eb013e20aa88a84d2
2023-11-24 19:21:53 +01:00
Pranam Lashkari
a2b2b1f9a8 formulabar: select formulas on mouseleave event
problem:
In a spreadsheet, click on a cell with content,
In the formula bar, select the content in a way that the mouse key is lifted outside the edit field
Note how the formula bar doesn't get into edit mode, but you can still edit the content

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ib4f193b897d57e0ffa9c3bfdd598e0c3c4201195
2023-11-24 20:22:50 +05:30
Pranam Lashkari
87a55af7b1 calc: select whole row/column on mouse drag
problem:
In Calc click on a row header and drag the mouse. The selection does not follow the mouse,
selection only appears when you release the mouse button

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I510f35d9f61fca63a619e83c04ff340f9578f5d2
2023-11-24 20:21:48 +05:30
Pranam Lashkari
cfc6874c22 cypress: refector mismatching parameter in function call
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I8fa8e4b1e20de0af16368cb23ca641b8d7186bfc
2023-11-24 18:36:26 +05:30
Rash419
ccdedbaab1 chart-releaser: fix 422 Validation Failed
- from the logs Error: error creating GitHub release
helm-collabora-online-1.1.5: POST https://api.github.com/repos/CollaboraOnline/online/releases:
422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I7b10e972564eae2cd6ad2146470d16fd05401361
2023-11-24 12:14:12 +01:00
Rash419
851ef435cf browser: don't show socket error message if we are reconnecting
- specifically a case where coolwsd is cleaning up the document
  we don't want to give up on clientside and show the error message to
  user

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ie75fa3e19f97ca18acc8e881813d6c617fc9f7b7
2023-11-24 15:51:02 +05:30
Darshan-upadhyay1110
de4fe0dfd8 Fix downlaod options in read only mode
- Allowed downlaod options for PDF/PDF as /EPUB
- PDf/PDF as/EPUB will be downlaod in read only mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ic6e0c4a16fa5dffc61e61fd4ece9aeeaec1450b9
2023-11-24 09:26:59 +01:00
Rash419
a398569025 fix helm chart releaser
- from the logs Error: error creating GitHub release
helm-collabora-online-1.1.5: POST https://api.github.com/repos/CollaboraOnline/online/releases:
422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]

Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I16d0fa54c0dd9ef5bd96b96366c93037ed7de56e
2023-11-24 11:45:43 +05:30
aarsh21
85e5ba4807 fix:navigator hyperlinks line-breaking on chrome and firefox
Signed-off-by: aarsh21 <aarshpersonal21@gmail.com>
Change-Id: Ic91e1cb017b82fd21ba942d54ddc277c9cc7d3cc
2023-11-24 10:21:09 +05:30
Andras Timar
d7a65fb050 welcome: remove version number from image
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I3890f0ca051d200c9c557a17930b4745ed29f78b
2023-11-23 17:44:00 +01:00
Hubert Figuière
c56451ee6c notebookbar: handle show/hide button
- We now have a state for hidden buttons in UIManager
- Shortcut bar makes use of it instead of maintaining its own.

https: //github.com/CollaboraOnline/online/issues/5957
https: //github.com/CollaboraOnline/online/issues/7517

Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I719f27063f01e4d76742358189b080087881ab7c
2023-11-23 09:36:17 -05:00