- Fixes map z-index so annotation can be have higher z-index
- Now map and due to the latest changes introduced in:
8ca57fad3344f6da1b42158944bf9903f0ac528b we cannot use
container's border-top as our bezel divider
- Elements such as annotation need to go under
- So Fix toolbar-wrapper to use bottom border
- Notebookbar: Fix toolbar-wrapper background-Color which
was being set as transparent and thus elements passing under
were being visible
- Ruler: fix cropped ruler (was not going full width)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8778619da43c51d1994dbb12d1112d4f1d42ff43
- Fix Borders
- Make sure the borders that divide the document container and its
surroundings are always visible at all times not matter what is open
(sidebar) or what is visible (status bar, ruler)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idea765f4438981af66bb760f25f7c553be7da728
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".
Tested on mobile, desktop, tablet views with & without notebookbar.
The problem was:
On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
Instead, i tried to use CSS rules with flexbox.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20
There is an additional fixup for master branch included.
Use flex for document-container, so now it automatically resizes itself.
Remove absolute positioning from row elements.
This patch is for desktop view.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2807794da268fe0f3d7f2c54ad19a728f4c6f981
We now position the map element according to TilesSection.
This change required document-container to be positioned too.
To make it a little easier, we now use css rules for document-container.
Css rules for desktop view is done with this patch.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I68f11a081f62b4a8cecd8c0d7529795c07756d1b
unless we are in presence of a presentation or drawing.
- Hide it by default
- Use UIManager to show element
Fixes the glitch responsible by presentation-controls-wrapper
being shown right at the initialization time no matter the doc type
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I74c8ac615282774a7fdb35f5e79e5bec329ad774
The mobile-edit-button space from bottom to the icon has in impress/draw an different space compare to writer/calc. The reason is that in impress/draw there is the sorter toolbar.
This patch will remove the impress/draw specific case. There is no reason that the space is different compare to writer/calc
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I0c8155429052851d082e847b2f59ec5efe04e3c8
move loleaflet.css .root color varaibles into a separate color-palette.css file so all var colors are at a dedicated file and branding is easier.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I6fe879fbb09e2d5170c028820974bdda0466805d
add --white-bg-color so that there will be also a dark notebookbar background possible
use as much var as possible. some values are still fixed, but when I don't know where the color was used, I didn't change anything.
Signed-off-by: Andreas-Kainz <kainz.a@gmail.com>
Change-Id: I1e7f95021e687329560b5df1d0fd17bf0d391d0a
text, spreadsheet and presentation use branding colors
with this PR also drawing use the branding color
compare to yellow1 drawing use yellow0 for better contrast
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ie3e3862bdc868c060d631b677ebe014adbc76a38
- Do not use big rectangles as markers
- it hides surrounding content
- too intrusive (since it appears every time we select a table)
- Use smaller discreeter elements WHILE maintaining the existing
active zone size (so it's still easy to click it, no need to be precise)
- Add missing hover status
- Create new SVG plus add rounded corners
- Treat column and row marker as different elements
- Use one generic class + add another for each type (element modifier)
- So we can target each one and have a nice center line
no matter the disposition (vertical, horizontal)
note: motivated by the reported issue:
https://github.com/CollaboraOnline/online/issues/1297
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4d997864e99582f74411a12c33381a926fd47a05
- Make sure width doesn't get above the available space
- Do not force scrollbar when there is no content to scroll
- use visible (default): implicitly compute to auto
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib7b6b15dcf093d6172a35346679a7985584f4ef9
- Fix positions and backgrounds
- Draw: no need to hide presentation controls anymore (was affecting position)
- Make sure scroll bar is not getting different styles from browser thus affecting position
- happening on FF
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I479cf7d01023ffc611a3cfa6a5fb90fb0dbda1d7
IE11 doesn't support custom css vars so we values
were not read. use standard properties instead.
Change-Id: I3d1ccd74cc54a048e30431d162b5b80a49b5e06f
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- Position the number of replies near to the chevron to indicate what
that is supposed to do.
- Reply counter gets the same color as its icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd692f40f5f3420d7577147e8ca7bcf306e59899
When it was based on CPolyline and using lineWidth (weight) we get semi
transparent pixels on the edges of the line. By using a rectangle and
relying on just the fill (and not on stroke) we get sharp pixels.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: Icddb8e37cdb2e30ac9e7e11305bb2c534069b295
Canvas element's drawings will include part of UI outside of map area. Its size should be larger than tilelayer's and map's sizes.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I89bf79ccfe0240abdb031b937626b0bb81f3ed6f
- set a fixed bottom position only when on calc (due to tabs)
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I9f98cdc65e83c06da814fe7b89b43ebbe6760f40
E.g.: right click; paste (single entry with action) was not changing color
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib3889859f4210ac01a1c308ac15e383a511aa067
use similar asset as the icon that triggers it:
- so we have a paintbrush icon that triggers also a paintbrush cursor (instead of a bucket)
- and adjust position accordingly
Change-Id: I2fa84f0a961e5a98de6fe8fc34c14ccac63344d0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102382
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
- Fix duplicated properties (ignore cases where it's needed
for browser compatibility);
- Fix space inconsistencies before !
- Fix space inconsistencies after colon
- Fix space inconsistencies after and before combinator (>, +, ~)
- Invalid calc
- Many rules added to json, namely no-extra-semicolons
Change-Id: I78af6bc546aeb1d7d7090e2ef278c895f0393a07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
- Detected many duplicated selectors within the same file (squashed them)
- Detected inconsistency (sometimes spaces sometimes tabs). Tabify as in JS.
- Detected quotes' inconsistency (sometimes none, sometimes '', sometimes ""). Use '' as in JS
- Avoid touching on files from 3rd party sources (jquery, w2ui), ignore files
Change-Id: Idd82945f29ac6c5c9f522e5d5df4a783a367654d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102009
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
and blink active dialog to inform user that he needs
to close dialog first...
Change-Id: I6c9ee662ae2ab935f03ee8fdd0cf7327703e2170
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100457
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101820
Tested-by: Jenkins
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
* convert var colors to rgb
* use the var colors for shadow + alpha (rgba)
* .document-title container: remove table display and add min width
Change-Id: Id4289af91562790edd23c83d4e70a16688e44fe3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101048
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
text cursor only if cursor is visible
appropriate cursor for drag markers
move cursor for selected object
Change-Id: If750ac91fc870a0d730d4455c51bde0423c55e4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98425
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
* increase distinction between disabled and enabled buttons,
* make the Selected buttons to use the same main blue color
* make the Selected buttons with text to change their text color as well
* Use --gray-bg-color across all files
Change-Id: I50b8ab86216211de37ef6c4d2b2c6baddc783ae7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99349
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
- Overall styling
- Fix tab’ alignment and paddings
- Fix tabs’ states
- Make use of text-shadow to emphasize instead of changing font-weight in order to avoid changes in size
- Add document-type class in notebookbar (similar to what I did for menubar)
- Style jquery-ui tooltips
- Style .unolabel
- Start to use css --var for font and colors (still no changes in the code per sea [like reducing the values etc] just start using it)
-- add comments
-- Use it depending on doc-type for notebookbar tab unolabel
- Add missing icons
- Fix extra border (toolbar-wrapper)
- Add document-header
Change-Id: I24552b118657d8ead47a74a6d189bd2448aac808
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98721
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
