There is an important distinction between
internally saving a document and uploading
the latest saved version to storage.
Core reports the modified state, which was
at some point used to flag the modified state
in the admin console. This state is misleading
if uploading failed.
This patch makes this distinction even more
explicit than it was. We now always update
the modified flag given by Core, and flag
the document as modified in the admin console
too. But we only update the admin console to
unmodfied when we successfully upload and the
document is not modified at that point (which
it might very well be modified again by the
time we finish uploading).
Without this patch, we stop updating the
modified flag when uploading fails. This
is problematic when said failure occures
right before closing the document, because
the document will have no modification
but we will be stuck thinking it is modified.
This combines two commits:
8c602e179e
and
9db39ce741
Change-Id: I31c72aa2491b8e98597075cd35b6a809fab560a1
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This reverts commit a701f7c9094227422457d05cc5d90e9d1a9a7fc0.
I approved this one but it doesn't seem to work well, unfortunately.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: Iafc10a15dcf07aae661e7dd2562c6555f6b83596
issue wrt busypopup sending string id for dialogEvent
was already fixed on JS side.
remove unnecessary comment from commit 48f7449
Ignore conversion error from std::stoull for "busypopup"
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7640b4f693d9d018ae17acb3a9eb292a2423bb68
Some of the folders we setup from the system are:
dr-xr-xr-x 1 michael users 2824 Jun 9 21:05 systemplate/usr/share/fonts/
before adjustment, and resist removal.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8e5a96264b98d8091b205f7469bc46c401f47ab1
Hide comment on scroll.
Don't show another while one is being edited.
Remove section properly, it was hanging on the background.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Id0f85d4c84d3741a5120e24055061c2fe183b98a
Open new comments directly in the cell's position, without animation.
Focus on the comment box.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I0dda23baaa9c8cdd940fc9d429e0e72e5464b854
When used 120% zoom and selected any row after 50
there were multiple rows highlighted.
Change-Id: I4bc5f4272bf65fb0f9d00d96527890281377c0a8
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- when we receive any notification - mark notebookbar as initialized
- if we haven't received any information eg. in impress - warn
reduce importance of this from error to warn as it is not important
probably there is no widget which sends updates (correct for draw and
impress)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I88ae3a090014dd25e59e04993c0c244d8830435e
now it's possible to pass parameters
typing_speed, typing_duration, single_view, node_inspect
also replaced the old perf-test with new-perf-test
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I03f1f14db4ddd9afb9d4a9a60a87c135497db70c
In a scenario where onee has several parallel PRs, one needs to use
several local branches, and when updating PRs, _needs to provide PR
branch name explicitly_ each time (my-PR-name-* in the example):
git checkout featureFoo
[ edit session ]
git commit
./g review my-PR-name-1
git checkout featureBar
[ edit session ]
git commit
./g review my-PR-name-2
This changes the processing, so that when the user's local branch name
is different from the tracked branch name, it is treated as if user
used that name explicitly in a call:
git checkout -b featureFoo origin/master
git checkout -b featureBar origin/distro/collabora/co-6-4
[ ... ]
git checkout featureFoo
[ edit session ]
git commit
./g review # this uses "featureFoo" as implicit second argument
git checkout featureBar
[ edit session ]
git commit
./g review # this uses "featureBar" as implicit second argument
so no need to remember which PR name was used where.
This only works for local branch names that are not equal to a remote
branch name, or to the last part (after last /) of any distro branch.
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I8b95f92f6e205e3c93ef30f4813f3549c2315872
This way both notebookbar and classic toolbar will have the select2
styling
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I9b8294cb1c0308fcfeeed8f9e886e3075c2eb3a1
The LO Core server will send the label of the status
indicator start.
Change-Id: Ie33aa56fcf2bb87362ad91c79498292c51bd32a8
Signed-off-by: Henry Castro <hcastro@collabora.com>
We cannot rely on wsd being slower than the kit. The rename
has to happen before wsd / DocumentBroker gets to trying to access
the filename. fixes#2874.
Change-Id: Ie1e67cd059fb6a663048967c47759238c067172d
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Thanks to cypress tests. It was being called in Impress document.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I4681486cdd0930429f824c5636a2becb26700ff6
we receive that information by welding updates
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9ff7f5d26740b1f13d1f1cccd88793ca35a4ee76
User can pause drawing before adding multiple sections.
When resumeDrawing is called, reNewAllSections function will be called automatically.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ie83265b5a57c11bd828a980c1797d6bfa3d6e287
if any of explorable toolitems was opened - open it also
after update
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: If98f68befb1b0e7283564c2bda3f18524e498977
we need to force proper closing of popup to avoid empty popup
when it will be opened next time
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I8e6b3164dc0d828bcb10c37c657d403664f0395a
we need it because toolboxes are sometimes hidden dynamically
and we need the DOM element with correct id for hiding.
example: colorbar_others / colorbar_writer in Characters Panel.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Idccb9cd46feda34c3093b61354a4352677bb582b
When update occurs and explorable entry was opened eg. color picker
in shape effects panel we need to rebuild it as opened.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7a564bb32c8e7ee075a2ac32235088bdda19130e
Records the uno commands from different instances of ChildSession and
dumps the last 4 uno commands into the crashlog during a fatal crash
Signed-off-by: Gopi Krishna Menon <krishnagopi487.github@outlook.com>
Change-Id: I838f71769dc08df7076c040f3d72c15f7607e9d3
