We emit lots of 'keyup' events that don't match any keydown
event like this:
OUTGOING: textinput id=0 text=a
OUTGOING: textinput id=0 text=l
OUTGOING: key type=up char=0 key=517
OUTGOING: key type=up char=0 key=523
since we emit a textinput instead. So just emit events
when we have modifiers, or already sent an input event.
Change-Id: I0f86438d093497668bb5b749ff63ecd87d9b7636
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Return proper HTTP code when disconnecting and log
to make the communication more effective.
Change-Id: I4da9d5a7fe4c09d6fcd44b1f31b439180d7012bd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
+ this will allow to perform internal paste
+ will inform user when trying to paste outside app that copying is
disabled
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I92d1a69bb6ea55703a419fa15461d98125a59b09
When async save was started but we want to stop DocumentBroker
- we shouldn't kill the socket which listens to save result.
Because when we kill socket we will destroy DocumentBroker
before saving is completed, this allows for a minimal time
to connect again to the document and receive old content
from the WOPI storage. When we wait for async save result
we will keep DocumentBroker alive and next session can be
connected and receive correct content.
fixes: https://github.com/CollaboraOnline/online/issues/2747
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I5505a5ccc1f3d6928c723bddfea16bf5c5798d1e
From our API description:
DisableCopy
Disables copying from the document in libreoffice online backend.
Pasting into the document would still be possible.
Change-Id: I1f7e272ad3b04208b534eff990fed895951b4751
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
- be sure overlay will be removed
- show fadout effect also when closing old popup and showing new one
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6565c96d664a2a289a9950cc2a6b60677872a3a9
* Scrolling was not smooth.
* Scroll bar was not visible in large files.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I036d3699997ee3b88c2cfc6e8bc5d0e67399f522
So user can see which page they are scrolling before tiles are loaded.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I1fc92eef8ac4de97a7cdc6f8a214f94afd51044c
- Inherit as much as we can from desktop
- Remove unnecessary styles
- Tab container: fix position
- No need to add left padding instead let the
plus icon fix to deal with that
- Increase plus icon touchable area (was quite
small)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic8269e5da63406b7f19f0d92ff50f1258f460d7a
While scrolling, user can see which page is being scrolled before tiles are loaded.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I0d06a3402fdb9166a7df8e45594f5caf189be37b
I added it to use for PDF view but didn't need, let's remove what's unused.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I7d052ad5297e3a52c3ac52b9cd7aeb6270d32d6b
Update tabs and its parent after:
9f3b72aa6f2577342e1b
- Fix padding and margins
- Use border-top instead of faking it via shadow
- border shadow was not being displayed full width
- Make sire spreadsheet-tabs-container is transparent
- Avoid hiding any element or border
- Gave up on trying to have selected tab looking like a tab
and thus without border top and taller. The code around is
proven to be changing constantly plus we are not gaining
that much of a benefit there. On top of that by keeping it
with same shape as the other tabs we avoid possible problems
with the top of the border of its parent.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I45ce6ed534afe4b264ae5aa0ef8f40f606ff5523
toolbars. Make listbox (combo box drop-down list) similar
with the same: bg and add CSS var.
Also on classic mode: Fix listbox height on toolbar up
- Keep it at 24px so to be the same as the neighboring items
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib4deaa5beec6cebf8d966f15a9e091a298d8b749
Removes offset and this the need to get SidebarWidth
- now due to flex element does not need offset
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ief2f93909b070e4a2883b7599b94457bd9e0d4c5
- Makes sure sidebar is always the same width (when selecting objects
etc sidebar was changing)
- Fix mobile glitch: on load and even during readonly mode sidebar
was first flashing and then appearing
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9ebf306d27430a2c9a6c7105a0dc178020ef12cc
Adds margin to toolbutton and not its child:
- A margin was being added to the img element which in turn
was being visible when hovering it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9e668260a53d7239c00b8786803245f30ea7f83b
- Adjust left position and
- Makes sure option is not getting weird values from web browser
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia753baf8066914543388c80827b2fe4c8ed26c3b
Fix inconsistency between ui-treeview-expander and ui-expander
- Expanded: pointing down
- Collapsed: pointing to the right
- Also make sure the width doesn't change between states
(use 'V' in both)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib4b72d6f8acca33fcb67981ff9b6fd8095012ead
- Fix Borders
- Make sure the borders that divide the document container and its
surroundings are always visible at all times not matter what is open
(sidebar) or what is visible (status bar, ruler)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idea765f4438981af66bb760f25f7c553be7da728
- Dropdown (select element aka listbox) Do not use min or max widths
- Use CSS vars for text colours
- Add hover status to buttons
- Force to also add id references since these lack the unotoolbutton
class
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I480deb651a83b44a8a5e4170e105b4dc2e900ec5
Plus make it start from the top and ending at the bottom
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If8c89a248c467e50186a82bc191200a60e2823e1
Via CSS var to make sure we use them consistently throughout
jscomponents. In some browsers it was being set with serif specimen
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I418ad3a313c394e526b6e4e1c46ebe3616212d40
Toolbar-down was being covered by #map
- Set toolbar-down with the same z-index and ruler since both should be
above map
- Update readme
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic358fb5f7bd722806cf22fdad0289f8a54fa6e1e
- Sidebar parents: be sure it's container childern is always full width
- Sidebar parent: Fix margins vs paddings
- Expander: Decrease color contrast so to avoid to be in the way of the
actual components
- Fix expanders (arrow) position and paddings
- Use CSS vars
- Fix and style listbox and spinfield to be slimmer and more compact
than the regular ones (crucial here to effectivly use space)
- Some of these things should be ported top the general jsdialog css
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I50def4b41144d56a3cc2de41b3ed00ed550fa74d
- Add lateral animation so the users understands that it is in fact a
sidebar
- Also that animation should help with the way toolbars and sidebar
appear, each on on their own time causing the sidebar to appear first
and abruptly (appearing to be floating for a couple of milliseconds)
It would be good to have a longer animation time when loading the page
then when simply pressing the button so something like :
- Currently the default 1000 is somehow skipped
- this.map.sidebar = L.control.sidebar({animSpeed: 200});
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I95b6bf51900449e85c24cee6d5d47f8af9a0f134
So it can be easy to analyze the backtrace of the
failing assertion.
Change-Id: Icdcf55b1404f858eba1d499bd65719a0e2da21db
Signed-off-by: Henry Castro <hcastro@collabora.com>
when calling hasTableSelection(). Do not depend on stray/duplicate
tableselection messages that can ensure a valid _currentTableData
member of TileLayer.
Signed-off-by: Dennis Francis <dennis.francis@collabora.com>
Change-Id: I957fdfc43c1435ca98eb204dcb3ec1e76b85ce89
