Without --enable-bundle, --enable-debug works as before: Individual JS
and CSS files are sourced in loleaflet.html.
But with both --enable-debug and --enable-bundle, a non-empty
bundle.js and bundle.css is produced and that is used instead. It is
important for developers to be able to test also the use of bundle.js
because there can be significant differences in behaviour. Developers
typically have to use --enable-debug because otherwise there are
various stict run-time checks in the C++ code that you don't want to
bother with when developing, like having a separate login for COOL.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: If7d0220b7910fe0f7a2f391b856cd0dedc788152
New container which builds the same structure as mobile-wizard.
It will be used in case of smaller screens on desktop and tablets.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I4631750963bb7daec2659b7af021a4b7bc55f033
External apps load loolwsd inside the iframe
and loolwsd makes postmessages to parent window.
We receive the postMessageOrigin from checkfileInfo yet
we still send some messages before we even go to the WOPI Api
in that case, if parent window runs on a different domain, we
end up with CORS blocking by the browser. To prevent that we can
allow safely passing the origin inside the first post like access_token
and sanitize it with Poco::URI::encode.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: I5724f2d103603a599d45b7f61da81fb30834ef0e
Define the "feedbackLocation" variable only if it is enabled
Change-Id: I75ab9eec9f2f074eefe8551e876bb7dc07a30b4c
Signed-off-by: Henry Castro <hcastro@collabora.com>
Set min-height property to prevent exceeding the available size.
slide-sorter: Set max-height to prevent over-sizing relative its parent.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib8c50bc9f6f6ac4311cefa3b0e016da728efe95b
So, we no longer need to set positions of HTML elements using margins or absolute positioning or attributes like "left: 30px".
Tested on mobile, desktop, tablet views with & without notebookbar.
The problem was:
On an unbranded build, side bar's width is different. So pre-assumed pixel based positioning would need to be changed according to existence of branding.
Instead, i tried to use CSS rules with flexbox.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: Ib301dfa8c06a9cf12acd33caf1b6a852a2faab20
There is an additional fixup for master branch included.
Do not use external html file and instead use input attribute from vex
so we can send html while being able to use variables (those variables
should then be overwritten by integrator)
Also Fix styling and DOM elements creation:
- Avoid to many elements and messy notebookbar with multiple (states)
- Replace disabled feature icon with lock icon
- Also style it properly and make it similar in other properties as
the existent disable status
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9c2a07ef1fe5f089d5e63cb53d2d6b7f0b5083a8
- Add html file where structure can be changed
- Add illustration as default (in the case integrator doesn't
have one). Avoid any purple so to do not confuse the user about
who is requesting the subscription
- Set custom vex button text (to do: translations)
- Add custom class to vex so we can target it better in CSS
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a4c0232f3728ba88f650ce28905ebfe2f6d9bfc
Use flex for document-container, so now it automatically resizes itself.
Remove absolute positioning from row elements.
This patch is for desktop view.
Signed-off-by: Gökay Şatır <gokay.satir@collabora.com>
Change-Id: I2807794da268fe0f3d7f2c54ad19a728f4c6f981
Sadly I had to use a global variable to access the actual contents of
the Help>About window as being displayed in its key event handler. If
somebody can figure out the correct clean way to do it, be my
guest. (Look for the app.ExpertlyTrickForLOAbout.)
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I88582e490d566d127d60226e045535e12c172e9c
Initially we had only a simple text label with an outline but due to
user feedback we end up increasing its contrast and displaying the input
field outline as a box plus adding an icon so to emphasize that it's
possible to edit the document. See this for context:
https://github.com/CollaboraOnline/online/issues/2310
Since this feature is not new to our user base:
This change aims to
- Fix some quirkiness of that component (too heavy element floating
in the toolbar)
- Getting rid of pencil icon inside of input field
- Which avoid problems in responsive mode (cropping pencil icon) and
- helps to use the space more efficiently
- Helps users understanding that we are still in presence of something
more than a simple static label
- by keep it with a white background and with a hover state
- Improves look and feel
- Use the same size as used for tabs
- Use app color
- Use rounded corners so to appear less bulky
- and so it looks like the title of the window (text centered aligned)
- on hover shows shadow (is clickable)
- on focus text is left aligned and outline appears, showing that
is ready for accepting key strokes
- Also changes on device-tablet.css fixes
- cropped or juxtaposition of document name and close button
- easier to interact with the document name input field on a tablet
- This affects both Notebookbar and Classic mode
- When in classic mode use the same font-size as the neighboring
elements (10pt)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iff17b32bf9cf95968fdb387de856b377a23a116a
We cannot use jQuery.get (a.k.a. $.get) in the mobile apps as that
uses some XMLHttpRequest thing that obviously won't work when there is
no web server involved, but loleaflet.html has been loaded from a
file: URL. Simply store the help file into a global variable and use
that instead.
A small refactoring of the showHelp function was needed to factor out
the call of vex.open into a separate function. That is called directly
from showHelp in the mobile app case. Otherwise, it is called from a
short function passed to $.get, as before.
Note that in the mobile apps we cannot use window.open (which in the
mobile apps has been redefined to send a "HYPERLINK <url>" message to
the native app code) to open the help file, because the HYPERLINK
message is for opening a web page in a browser, completely separately
from the app. It is used to display the commit log for the Help>About
functionality.
And anyway, the old idea (that didn't work) to take a shortcut in the
mobile app case and just display the help file in showHelp will not
work anyway as we need the code that edits the contents before it is
displayed, and handles the close button in the help file.
This fixes https://github.com/CollaboraOnline/online/issues/400
This fixes https://github.com/CollaboraOnline/online/issues/401
Change-Id: I16dc960f26af7e6e89663c3ac0523ce5c3d41c34
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Remove "spreadsheet-row-column-frame" div. Since row & column headers and groups are drawn onto the same canvas with tiles, that div shouldn't exist.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
This will enable notebookbar for tables
smaller devices will continue on classic mode
Change-Id: Ib74b8a0ad161d83300d807fff1fd8b3ffba11399
Signed-off-by: mert <mert.tumer@collabora.com>
Often loleaflet.html is loaded via POST requests. This
new sample demonstrates and exercises this approach and
is a handy way to load documents.
Change-Id: I065a946413ab08d399ac5704c67f6f1ba37bdd9e
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This should make this sample much more useful by documenting
the proper usage and helping the user avoid common pitfalls.
Change-Id: I965bed0e4ab685dd2a68f7b246dd9a409d296337
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
3rd party cookies or localstorage can be blocked
on the browser settings, especially is on chrome incognito
mode. This causes the document fail to load.
Change-Id: Ia2a182262a754c76aec58cbbce60a0298320df33
Signed-off-by: mert <mert.tumer@collabora.com>
This adds the infrastructure to be able to pass the info which elements
like the statusbar / ruler / sidebar are supposed to be shown or hidden
on startup of the editor.
Change-Id: I188264dec6961074444934ff5fd7088e23b170d4
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/103169
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tumer <mert.tumer@collabora.com>
- to be displayed after the toolbar appears
- only when it's possible to edit the name of the document
- only when not in presence of android app and hidden (display: none) by default so it does show up before input field
Change-Id: I5c78593b1229da1682832a46e6fc8f1b09b31e12
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102675
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
This is a quite complicated change that should both fix tdf#133284
(cursor keys on a hardware keyboard do not work in a spreadsheet
document) and also improve the interaction with
CollaboraOnlineWebViewKeyboardManager that manages the on-screen
keyboard. We need to jump through complicated hoops in order to get
the hardware cursor keys handled right after loading a spreadsheet
document.
In the CollaboraOnlineWebViewKeyboardManager case we try harder to
keep loleaflet's _textArea buffer in sync with what the UITextView in
CollaboraOnlineWebViewKeyboardManager uses to provide suggestions
above the on-screen keyboard.
Also merges in related changes from today to
CollaboraOnlineWebViewKeyboardManager.
Change-Id: Ic4acb54bd4e815aa8bfb2bf40b08493446ae5ab0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101878
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
* convert var colors to rgb
* use the var colors for shadow + alpha (rgba)
* .document-title container: remove table display and add min width
Change-Id: Id4289af91562790edd23c83d4e70a16688e44fe3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101048
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
There has apparently been confusion with the unrelated
Window.postMessage() method.
Do it for the iOS app case but presumably the same can be done for the
Android app case, too.
Change-Id: Iabb259b618426cbbb9f4ed2a9a97ad907bc09c39
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/100773
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Instead, set brandProductName from the MOBILEAPPNAME. Now the mobile
app name shows up in the progress bar.
This reverts commit 24a0c7c3dc.
Change-Id: I91c7ea3d21f5362fc6a4d777b041089413e921ee
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98205
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Can be changed:
* configure --with-app-name
* brandProductName in loleaflet/dist/branding.js
When there is no brandProductName defined, this message will
appear in About box:
"The Personal edition is supported by volunteers and
intended for individual use."
Change-Id: Iec5aa2df7e734bdbc1dd8037656334f0016a7a82
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97837
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
