cypress: updated the test with respect to changes
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I31c5d93260551986d43722ab606c4b9eee1de913
I added it to use for PDF view but didn't need, let's remove what's unused.
Signed-off-by: Gökay ŞATIR <gokaysatir@gmail.com>
Change-Id: I7d052ad5297e3a52c3ac52b9cd7aeb6270d32d6b
ResizeObserver is not defined for JSDOM as well
Better to check that not only for IE11.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Idb080f1a320c291dca71a73e76b8d754a76e1108
Makes unit-rendering-options fail reliably.
This reverts commit 175c9c5b2a.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Id05c911991baaae0dbc52678a192fc01639352e0
By passing a traceevent=yes query parameter in the URL. Note that if
Trace Event generation is not enabled in loolwsd.xml this will have no
effect.
It is a bit silly to notice this query parameter only in loleaflet and
then send the information back to the server. Would be better if the
server noticed it itself before sending the URL to loleaflet.
While at it, let's not bother ever enabling Trace Event generation in
the WSD process. That is not what we are interested in.
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I985bfd1e2dbd14aa5a55b386b4762fb64bcb4008
I had missed that we can send it from two different spots in the code.
Change-Id: Ic67a041ad2156df5f720ca9bc695870e43d60568
Signed-off-by: Tor Lillqvist <tml@collabora.com>
- Fix#2343
- Do not crop contents
- Centered message (vertically and horizontally)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icc40a09d1690f683135ac16b274d237c81aab827
URLs from host may already contain a query, like
http://server.tld/foo/wopi/files/bar?desktop=baz
Previously, we simply appended '?' and then our parameters, resulting in
http://server.tld/foo/wopi/files/bar?desktop=baz?access_token=...
which later was processed as if the question mark and following parameter
were part of previous parameter's value, so proper 'access_token' parameter
was missing.
This checks if the URL contains '?', and uses proper separator accordingly.
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I1a237c0e47e1eea3704ef7d4a8a596283ea2a241
Instead of requiring that information in the query string of the loleaflet.html URL.
Change-Id: I8c41e87c7f561561adeb03ec34ce0c19fe9d7fa5
Signed-off-by: Tor Lillqvist <tml@collabora.com>
It enables turning Trace Event recording on (and off again). The
option is passed down to the client through loleaflet.html, and to the
KIT processes. If the option is not used, the new JS functions that
send trace events to the server turn into no-ops to avoid wasting
bandwidth.
It is always on in a "make run".
Change-Id: Iafe1919ccba7c376137d3e0568b857e20780bbc8
Signed-off-by: Tor Lillqvist <tml@collabora.com>
The UTF-8 decoder here was buggy, and additionally it tried to feed
the Unicode codepoints it had constructed directly to
String.fromCharCode() even if that function takes UTF-16 units, not
Unicode codepoints.
The function in question is used only on IE11, apparently, so
presumably the problems had not been noticed.
Change-Id: I78f8ecea6ce6349e4121066774ae5c3fcfa87363
Signed-off-by: Tor Lillqvist <tml@collabora.com>
This resolves a dependency on userName
(a.k.a. UserFriendlyName) that was a source
of issues when missing.
It turns out that when it's missing but
spellOnline is set, an edge-case caused
an exception that failed loading.
The spellOnline value, in its turn, was
incorrectly set to "null" when in fact
it was missing. This resulted in online
spell-checking being active by default.
Perhaps this was intentional, but here
we don't change this behavior at all.
Instead, we avoid sending "null" when
it's missing, and by default we always
enable online spell-checking, unless
it is explicitly set to "false".
This way, the exception is not thrown
and spellOnline doesn't have invalid
values, while preserving the current
behavior.
Change-Id: I4a09ac44ff5d6147c715afa0fb34af9650da4afd
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
The "extends": "eslint:recommended" property in a configuration file enables this rule.
In ECMAScript 5.1, Object.create was added, which enables the creation of objects
with a specified [[Prototype]]. Object.create(null) is a common pattern used to create
objects that will be used as a Map. This can lead to errors when it is assumed that
objects will have properties from Object.prototype. This rule prevents calling some
Object.prototype methods directly from an object.
Additionally, objects can have properties that shadow the builtins on Object.prototype,
potentially causing unintended behavior or denial-of-service security vulnerabilities.
For example, it would be unsafe for a webserver to parse JSON input from a client and
call hasOwnProperty directly on the resulting object, because a malicious client could
send a JSON value like {"hasOwnProperty": 1} and cause the server to crash.
To avoid subtle bugs like this, it's better to always call these methods from Object.prototype.
For example, foo.hasOwnProperty("bar") should be replaced with Object.prototype.hasOwnProperty.call(foo, "bar").
See: https://eslint.org/docs/rules/no-prototype-builtins
Change-Id: Id7723f0f0ed81e074f56955f80eda3d70241294e
Signed-off-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
