Increased wait before inserting comment
Wait was added in a5e6a81cdd
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ia2aa4c901fc57d6700b43c7e0db0380055877081
If we have cell selected on the bottom of the sheet and
we scroll up to watch something else so we don't see the
cursor: if other user will add row above - we will jump
to our own cursor. It's because it changed the address:
like A500 to A5001.
Let's use "following off" mode to avoid that.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I7908dba5c3ae8d18d9f9478d038212eaf91187cf
- according to previous change(commit) we need to adjust ID in cypress test files
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ic5510392b101ff7c7daa28719a60963c7bb2c743
which may kick in at an arbitrary point. We shouldn't invalidate if
there is no change, but that's a TODO.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I910c96f2c2a0efab393ccea52c9f25d5804cd967
New helpers setupDocument, loadDocument, reloadDocument
Clean up beforeEach functions
Replace most calls to beforeAll with setupAndLoadDocument
Replace calls to reload with reloadDocument
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I12307f93c8a418e6f55bb36b8afe340d7841b726
Replace beforeAll in most tests with new helper function
Tests that need to close or reopen test files cannot use
the new function and will be updated later
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I372280e55993123fc26f83cb2e6e6e78665a6846
Cypress recommends NOT cleaning up after tests
https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks
Open documents should not affect other tests
Files will be closed automatically by the server anyways
Tests with more strict requirements can explicitly close
documents before, during, or after those tests
This is necessary to support beforeAll cleanup
Half of tests were verifying the wrong filename was closed anyways
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Iab458963a3fbfe87f732dc97140704c2d0ef53d4
now reply count node multipurpose, it also indicates
if a comment which was being edited is collapsed
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I18a676885deea0afa30eb20505a76239e11c5493
Fixes for several sporadic issues, each uncovering the next
Sidebar was not getting hidden because the button was pressed too soon
- Wait for sidebar to show before hiding it
Comment text area was disabled
- Wait for disabled attribute to go away
Second half of comment text was getting sent to document instead of comment
- Wait after typing in document before inserting comment
Also add wrapper describe block to share setup/teardown
- Fixes copy/paste errors in one block, which was missing
calls to selectZoomLevel and setActiveFrame
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: I13ef1189cfacc4beac0b2c3363c70aa1e8583db3
error is:
1) Joining a document should not trigger an invalidation
Join after document save and modify:
CypressError: Timed out retrying after 10050ms: `cy.click()` failed because this element:
`<div class="leaflet-layer" style="position: absolute; width: 642px; height: 484px;"></div>`
is being covered by another element:
`<div class="jsdialog ui-button-box end" id="">...</div>`
Fix this problem, or use {force: true} to disable error checking.
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: I8b0dde030b2aadf554db75872facb6c5c96a321c
- move plain html controls into HTMLContent widget
- reuse scrollable bar from notebookbar
- use dynamically loaded menu entries in MenuButton
- allow to update MenuButton which contains menu id in the id
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I2b77479520c03420fefeb32dd09d6b34279e5686
On switching tab not clear other view messages saved for replay.
Added cypress unit tests for checking the cell view cursor bounds.
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I788828783a86038bb9d7f26648925b0e03bd560a
Replace four helper functions (insertMultipleComment setupUIforCommentInsert
createComment saveComment) with one (insertComment)
Simplify code flow
Remove unneeded docType conditionals
Remove unneded identical arguments from every call
Add more relevant assertions
Use force click to remove extra toolbar clicks
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ia4bc4ac964fd0ee754a481843d55682b87b63086
There are now two .avatar-img elements after recent user list changes
Signed-off-by: Neil Guertin <neil.guertin@collabora.com>
Change-Id: Ia229422b4dc3e90ede240e36927b4615091cb97d
Added Desktop, and Multiuser tests for writer.
Signed-off-by: Attila Szűcs <attila.szucs@collabora.com>
Change-Id: I1bbb32303c66eb499cb837289a51caafdf2055a8
- The repair document dialog is a leaflet dialog
- As this dialog is online-side only, I'll use the JSDialog builder
directly rather than writing a UI file
- Most of the code to build the dialogs is already very adaptable from
looking at the protocol of existing JSDialogs that come from the
server & where the code goes, however a small change had to be made to
dialog modifications to allow us a callback function, as otherwise we
would send off to the server whenever we pressed on a list item
- Finally, if there's no list to show, we'll show a bit of text saying
that there's nothing, as otherwise it looks like an empty/broken dialog
- If we're on mobile, we'll need to use the alternative helper (the one
that handles mobile wizard building)
- Fix a cypress test for writer (although impress and calc seem to have
tests for this too that aren't implemented: this should be handled in
a follow-up PR)
- Fix mobile tests
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Iab9e943a428e66b05e28819c2ee1001a2deffd2c
By Renaming .vex-dialog-button-primary -> .button-primary and
.vex-dialog-button-secondary -> .button-secondary
- So we can remove duplicity on CSS buttons
- Easier to set vex primary and secondary button to use our css classes
- This way there is no need to hunt those specific cases down.
- Update cypress tests
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82f4b33560367805eeeeb5aec9af8d1abd313788
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I70fa8be619a62709d6e5ada32b7a670f90d7b2bf
removed unnecessary 'retries' parameters from the tests we already
have default global value for retries no need for specific tests
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Idc78831ce240d4d840f3dbc785e66165c6e07d3d
Undo/redo behavior changed in core so that text editing has its
own undo/redo stack and the change is applied to the document
stack when text edit mode ends. This test has been changed to
reflect the undo/redo behavior change in the core.
Signed-off-by: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Change-Id: I6cf427a279aefb79f2f331357731a32c0296c0cd
