Before this commit, in both cases we were not using tooltip
method (which is used everywhere) thus, resulting in inconsistent
tooltip styles, sizes and no animation (these ones were just native
browser tooltips)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: If7f6213f507f5c439ceaaeb1c713c7680cf563d5
Before this commit buttons such as bold (in the notebookbar) or
sidebar button (in the top toolbar) would not change the cursor on hover
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ief075b4f4d187f6a5d87458d02077c0deaf69fe6
The code is old and it is not used anymore by
new changes did it.
..
Change-Id: Id163cba7f586e3a083bff4cbb169a5d16e4b0cce
Signed-off-by: Henry Castro <hcastro@collabora.com>
- We allow the slide menu and the few presentation commands
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: If2533450a3b2af365a89f780dca32daf87c0758a
Currently translated at 53.1% (254 of 478 strings)
Translated using Weblate (Hebrew)
Currently translated at 52.9% (253 of 478 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (585 of 585 strings)
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/collabora-online/help/he/
Translate-URL: https://hosted.weblate.org/projects/collabora-online/ui/he/
Translation: Collabora Online/Help
Translation: Collabora Online/UI
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I45cf1906cca418011e62178e2d6064949707c63b
problem:
if comment thread is very long and some action is
performed to the last comments which puts root comment out of view,
entering modify or reply mode will make scroll to root comment.
This makes editing comment/reply go out of view
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I99f8df6886a69242b3db92674516678a61d2904f
- Make the Insert tab : insert annotation in similar place between
apps
- Use the same accesskey (accessibility, shortcut) in between apps and
the same as the one used inside of Home tab
- Writer: Insert tab
- Insert annotation: Add missing DE accesskey
- Insert remotelink: Add missing accesskey
- Make both insert tabs more compact by making sure hyperlink and
remotelink stacked on both apps
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icb8c512d437a8c328e6acf2cc41fc335d660af26
- Promote to big button
- Use the same from the previous position to make the whole tab more
- compact by changing the insert image to a simple toolitem
- Change location in the home tab so it's easier to reach and it's
more consistent between writer and impress
- Use the same accesskey (accessibility, aka shortcut) between both apps
Cypress top_toolbar_spec.js needed to be updated to make sure scroll
indicator do not cover when attempting to access it
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I0b3f3b83772317263c9d5d3d0e7f35d831eaa1ed
In 79028c6f881dd19ecbffa2c0653634879dd35496 I replaced an instance of
using this.map._docLayer._viewId as if the user is not in the document
this becomes your own view ID and shows the wrong avatar. Unfortunately
I missed CommentListSection which has the same code.
As we already have a viewId fetched a little later down, I opted to use
it rather than get another myself
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Ieda06e03902effe9be8fef3623b73d3caeef6f65
Trying to paste from the notebookbar in a setup which is not localhost
but uses http resulted in a JS exception:
> Clipboard.js:863 Uncaught TypeError: Cannot read properties of undefined (reading 'read')
We assumed that navigator.clipboard is always defined, but then its
'read' and 'write' properties may be undefined.
Fix the problem by abstracting this, and check for navigator.clipboard
as well in global.js.
Can be tested by disabling https in coolwsd.xml and changing localhost
to the real local IP in the make run URL.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I1dab14e311066fa640dbba65dfcc35526a6886d7
Previously the following issues were present when columns were frozen
- The frozen column was allowed to move, this was exacurbated when I
made it easier to move in my 'calc: pinch-zoom:' commits,
(3ba8257c64 to
b378a0fd77). This is now fixed
- A regression was also introduced in that range where the selected cell
marker would become offset if you placed it in a frozen section then
pinched to zoom. This is also fixed
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I07f70a32e5cb68aeb759fd6cad626b2d4c0eed72
problem:
if calc->view tab-> dark theme button is clicked,
if button is clicked from icon it works fine,
but if button is clicked on label event is triggered twice,
which means theme would be restored to first
reproducible only in firefox
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie645df86651a7507582de44147885a2b62384ddb
problem:
could not insert more than one comment in calc
regression from fcb6367
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I30b52569a48d5f1d0bb2a3fe9f6f6e7c6bd43c80
- Hide `Set outline format` uno button
- we will add this option again after fixing the dialog issue on mobile view for Outline option in `Bullets and numbering`
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: I270b78b7b9f00fd7b0f12c348794e3d3da3e653e
a problem since:
commit 72b2ce4bb6
Author: Caolán McNamara <caolan.mcnamara@collabora.com>
Date: Wed Oct 25 19:19:08 2023 +0100
we don't need to round-trip through core to reposition notes
Signed-off-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Change-Id: If00ae17a8e80ca3f8d2a530efa6cdba90207be56
Fix getViewRectangles function - it's used now.
Remove "_cellCursor" usage from CalcTileLayer.
Modify tests for the new changes.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Ia5ec5a6e89d7d64df2041112936a16ec06c4da93
Add CellCursorSection - not used yet.
Start using app.canvasSize variable.
Use simpleRectangle more.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I2cd4e23897c918679a0a385e1ca2d04117fd71c6
with cbf452b03d drop
indicator was not shown if the cursor is over the <div> elements
that inside the tabs
- fix by using e.currentTarget instead of e.target
and do some checks while on _handleDragLeave
Signed-off-by: Bayram Çiçek <bayram.cicek@collabora.com>
Change-Id: Iec8e246f18e553487b0eb0d9264cff8bb37b6305
Statusbar items which are not active previously were grey.
Recover that styling and do cleanup to not specify CSS in the
JS code.
We use that only for items which are active/inactive - not
for just labels
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic5beb7b2fa398d594cfa035d4cbcfe6f40cae787
problem:
in writer when comment is added at the end of document,
it may go out of view and covered by the status bar and can't scroll any further
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ia40ea128cd36a904ee5030bb7399da183e21f44d
In e855aa6114bda90fdd64fbcbb32a77adcf7938f4 a regression was introduced
where a comment avatar was set to your avatar if the user was not in the
document
This commit returns it to the previous behavior, which had a "default"
avatar instead. It might instead be nice to embed avatars in the
document to avoid the avatars being missing, however the previous
behavior is far less confusing than the regressed behavior and is far
easier to get to than embedding avatars in the document
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I82834089062b1e7c2570d9fd78c7e1a3077f4c96
- it might happen viewinfo message arrives before status message,
viewinfo message update view list with old _viewId because new _viewId
after reconnection is not avaialable yet
- this patch fixes this by reseting the _viewId on socket close and call
updateviewlist event after client gets new _viewId from status message
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: I88a6ade574faa1368b1635db891fe87f89fa080e
- also might fix the duplicate user on reconnect
Signed-off-by: Rashesh Padia <rashesh.padia@collabora.com>
Change-Id: Id302d79dd664d2e4efd6b4ba49972b3634b19569
In PR https://github.com/CollaboraOnline/online/pull/8700
We renamed some variables and removed usages of cellCursorXY.
One was forgotten and causing null ptr reference.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I840cc711076e4473dee8b6a1b823a362e0eecd84
Ensure all preview tiles array is equal length of preview queue
to be processed.
Change-Id: I37a8109a1d02d7dd761c9fbd36a7d0aa8102f7c3
Signed-off-by: Henry Castro <hcastro@collabora.com>
The function '_processPreviewQueue' it request only
visible preview parts, it was an old code that it
needs to be updated.
Change-Id: I56519c328fb3bec70ca1fce2730f5146dc254fa5
Signed-off-by: Henry Castro <hcastro@collabora.com>
If wopi.UserCanWrite tells us we can't write the file no reason to show the edit button
that would do nothing anyway.
Fix https://github.com/CollaboraOnline/online/issues/8686
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I4f6d1f8d8be520e422e260f2e532cb86541e8d0f
Don't allow separator and spacer (placeolder which expands)
to be target of a focus when we use tab key.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I724604eb299c65e4709d3e7708f514c312188393
At least on iOS, the new paste handler needs to send an uno message to
the LibreOffice code.
Also, completely remove fix for GitHub issue #5839. It no longer worked
and will be handled in a patch to LibreOffice's native iOS clipboard
handling code. Ultimately, GitHub issue #5839 was caused by the iOS
clipboard code's failure to never fire a "clipboard content changed"
event. So, the LibreOffice application layers never updated their
pasting enabled state.
Signed-off-by: Patrick Luby <guibomacdev@gmail.com>
Change-Id: I4e198a45d863e3ecaf1dd04e85ce9d0d9b1a0894
It didn't work: prettier still used double quotes as a standard
so it was not possible to pass make check
This reverts commit 7c5c5bd47b.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ic04f1591dc39bbfe522ed2b840c543ec42b3ffa3
