Commit graph

6095 commits

Author SHA1 Message Date
Henry Castro
226a3116e0 loleaflet: sort the packages in package.json
I am using the "npm" version 7.0.12, and after
bundling the "loleaflet", the "package.json" is modified.

Let's sort permanently so I cannot get contaminated with
something that I did not touch in my source directory files.

Change-Id: I6a1e6d6b3f1b2898288f06de85fc0307b62cbbeb
Signed-off-by: Henry Castro <hcastro@collabora.com>
2020-12-04 15:54:04 -04:00
Gökay Şatır
19fed3e255 CalcTileLayer: Rename _corePixelsPerCssPixel to _dpiScale
Remove unused CanvasDPIScale functions.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I46eb68494a956f4d3696b769a5e513b24251bfad
2020-12-04 20:03:18 +03:00
Gökay Şatır
9253f96a6c CalcTileLayer: DPIScale is set everywhere, used only once.
Remove unnecessary usages.

Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ifd3d9a668a0553fe171d96b20bb4d2cc6674c3a2
2020-12-04 20:03:18 +03:00
Gökay Şatır
14b1e5a277 CanvasTileLayer: Refactor debugging grid.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I245ad2b5a39b329c4a02e04f926a4b75470b6654
2020-12-04 20:03:18 +03:00
Gökay Şatır
37fb84754f Calc: Remove canvas scaling from header entry drawings.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I8b858f73cff33889c08f6d312a93cc0bc8d1a6ba
2020-12-04 20:03:18 +03:00
Gökay Şatır
4e5b178feb Calc: Remove scaling from corner canvas.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Iba16ec7aeca977af890a841ad445de688fa84e52
2020-12-04 20:03:18 +03:00
Gökay Şatır
67cbe36e7c Calc: Remove CanvasDPIScale function. Introduce _dpiScale variable.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Idbe569b3a7c3144bab960f6eb9a9bd32b4477b2b
2020-12-04 20:03:18 +03:00
Gökay Şatır
84b1b8b531 Calc: use pixel coordinates for pane sizing.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I7442f69d7653b2eb95ec60b281d4b61533dbf2ff
2020-12-04 20:03:18 +03:00
Tamás Zolnai
4502711166 Fix 'Cannot read property 'project' of null' error.
Triggered by cypress tests.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: Icb8b859547b907eb9b742121a7a06833026d7966
2020-12-04 16:33:26 +01:00
Pedro Silva
582f4c3568 Update colibre icons (jsdialog, autofilter)
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Iaf6d259aa6e0372bc5344388a03494848e2cb722
2020-12-04 15:22:59 +01:00
Szymon Kłos
2819b72dd5 autofilter: hide submenu if created before main window
Change-Id: I314b1ba8bd45e6b8c5b75085b7292ce112efd53f
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04 15:16:22 +01:00
Szymon Kłos
25816601bc Add Pivot Table entries in menu/notebookbar
Change-Id: If989a7ed3f894750497d7145fd31a0feb1e99b53
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04 15:16:22 +01:00
Szymon Kłos
86ca920692 jsdialog: close dialog handler
Change-Id: I88eaf1e6f7f393307e2c5963cb7c6cd45aa8f816
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04 15:16:22 +01:00
Szymon Kłos
699d560a9b jsdialog: limit listbox height
Change-Id: Id507cebd9694de85b0b5ba6988cc32ad303e87d2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-04 15:16:22 +01:00
Pedro Silva
b349f30d20 Mobile: make sure no box-shadow is ever applied to w2ui-button
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Id9778057c5b0db070a987e0286aff977cb01b2cc
2020-12-04 12:08:19 +01:00
Pedro Silva
29d2d38c69 Tablet: Notebookbar: Tabs: hide scrollbar
following addendum form:
35c93f06d2 (diff-9d59bc00285529dcd71cc9eecc071f54e3a854ebf558848482dd9c5a3e381dccR69)

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I04d92ac9398504f3bd0a2f7d47dcf267ede18966
2020-12-04 11:33:51 +01:00
Ayhan Yalçınsoy
613026a54a Calc:recalculate command is added at Data menu
Signed-off-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org>
Change-Id: Ic2fc1720eceaebff87197c27b16c93a51bf65dbb
2020-12-04 10:17:47 +01:00
Pranam Lashkari
a5306c488e leaflet: fixed image background not being inserted
inserting image background in impress did not work in first try

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Iaa4134626a20b8852f26d00b4386380ffbb5d259
2020-12-03 22:22:12 -05:00
Szymon Kłos
066ddefd4d pivot table dialog: ref button icon
Change-Id: Icfb7a82e92c951f4d71943fa36e4edc01012c030
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Szymon Kłos
79ca0a82e2 jsdialog: don't show empty expander name
Change-Id: Ie2d7f5b3073d6975c8c085a178d6617d62925e96
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Szymon Kłos
7f03b6067f jsdialog: action for listbox selection
Change-Id: Ica6153574f2d821721a3824d2ef0b344307530ce
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Szymon Kłos
7cd2713893 jsdialog: use real table in grid layout
Change-Id: I128d88788cacd71b4fb83f5bb1d47854a176a4e4
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Szymon Kłos
068884a762 jsdialog: show also empty listbox on desktop
Change-Id: Id08a242055c006c8166ec3effdc91919bac0a49d
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Szymon Kłos
a522f13dc8 jsdialog: split checkbox impl for desktop and mobile
Change-Id: I05f4fc51b23187b2b6191a498e994323405ef738
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 10:24:31 +01:00
Pedro Silva
6e475482ab notebookbar-shortcuts-bar: overlays vex dialogs on small screens
- or ipad
- vex dialogs examples: shortcuts and help

Reset z-index to be the same as in `main-menu(desktop-only)`:loleaflet/README

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Ib9bf635c03312e4302b14d99fc5c461bc0f7fb0d
2020-12-03 09:45:03 +01:00
Szymon Kłos
609d8748ae notebookbar: fix custom tabs
grid -> container,
for grid handler there were 'top' and 'left' properties missing.
issue appeared when I implemented real grid handler based on positions.

Change-Id: I90d63188b77ec6590123648f8833a387d1463622
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 09:43:27 +01:00
Pedro Silva
20d94a58e5 Spreadsheet tabs glitch when opening Help dialog
- Tabs get restyled due to inline button rules
- Improve positions and sizes
- Remove redundant declarations

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I65dfdafd0db359ffaeea76e41fa82bb7fd8defe5
2020-12-03 09:43:07 +01:00
Szymon Kłos
392c4ffb19 notebookbar: add select background for impress
Change-Id: Icfc511b8da029fee4f4f773c5900e2452808fb59
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 08:44:38 +01:00
Szymon Kłos
328c3323d3 Autofilter css fixes
Change-Id: Ib83c62032c45b3d4e4cf9d92be8d4c4acaa55d80
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 08:44:38 +01:00
Szymon Kłos
6986695ca7 jsdialog: fix close button for JSDialog
Change-Id: Icce0b0a88b4fedf9ec77b2aa7d49e3568bcc68c9
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 08:44:38 +01:00
Szymon Kłos
2c0e7887d0 autofilter: avoid undefined usage
Change-Id: I6cfde7de355dc4e506a1f53c05728ed9b9144483
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-12-03 08:44:38 +01:00
andreas kainz
df925222a2 TopToolbar better arrangement of breaks
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I102f9cf2212e9e022aac107e03cbdb7e3ba8759d
2020-12-02 23:53:01 +01:00
Gökay Şatır
e8a4de8479 CanvasTileLayer for Impress and Writer.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I9cec45f281b4f7195b333006bc0aa80dc8f28b32
2020-12-02 20:02:30 +00:00
Gökay Şatır
7a8e030736 Add new debugging layer for canvasTileLayer.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I2d7a91fbb696fff77b29143593066db781eba2dc
2020-12-02 17:11:45 +00:00
Pedro Silva
23f6932ded About-dialog: Add product name as a CSS class
Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: Iebf631b35ea1a0741e1356dfccb385dda915a9ce
2020-12-02 14:03:57 +01:00
Ezinne Nnamani
a6cadbcba3 Impress: A fix on Clear Direct Formatting command
Impress: A fix on Clear Direct Formatting attribute

In Impress, the Clear Direct format button sends an uno:SetDefault command while in writer and Calc, the Clear Direct Format button sends an uno:ResetAttribute command.
The bug existed because the uno:SetDefault command was not captured in the Control.TopToolbar.js file.
I added the uno:SetDefault command and set the hidden attribute to true. I also set the hidden attribute of the uno:ResetAttribute to true.
This is to create these Clear Direct Formatting buttons as hidden and show them for their respective documents.

Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
Change-Id: I37439a902684f015ffcc8d0a9acde40fec3603d5
Signed-off-by: Ezinne Nnamani <nnamani.ezinne@collabora.com>
2020-11-30 18:46:02 -05:00
Tamás Zolnai
dc18239d07 Fix missing text cursor after stepping into editing mode (mobile).
The expected behavior on mobile in Writer is to have
the text cursor visible after pushing the editing button.
The issue is that the _docLayer is not created before
the initial `invalidatecursor` arrives and it was dropped
because of that. Without the data of this message, the
client code does not display the cursor.

Found by cypress tests, where the timing is bit different.

Signed-off-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: If3d7e3d62f1a7996d016654160ffac7153360d3e
2020-11-30 15:23:18 +01:00
Szymon Kłos
4c6c4ffbf0 jsdialog: separate desktop & mobile impl for listbox
Change-Id: I4cdb455a05fce36e623e20145eb8b647649b3f39
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30 15:00:10 +01:00
Szymon Kłos
aa15b9a45d jsdialog: assign correct frame handlers
- mobile case: explorable entry
- desktop case: title and build content

Change-Id: Ib41c61d33d5013688f5578d8ddd32d12e18fa2bb
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-30 15:00:10 +01:00
Pranam Lashkari
9f19059022 leaflet: now comments are displayed in wizard
Change-Id: I18fc2ab823e257993247d94d878b5b00599a4508
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
2020-11-30 06:31:15 +01:00
Pranam Lashkari
b2ac03730a leaflet: added support to display comments in wizard
Change-Id: Icc4eb1256bf0639be2b3e45a0cef5c34d8e65ff9
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
2020-11-30 06:31:15 +01:00
Andras Timar
470497abd6 l10n update
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I461223ee5ebfffdbb8623eb1f002d9f0c4125c90
2020-11-29 19:27:49 +01:00
Pranam Lashkari
5dc8b2635c leaflet: "table" in "Insert table" should start with capital T
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I185d5f731a00f2f7065e998c9e7ee87714384cc7
2020-11-29 18:39:26 +01:00
Pranam Lashkari
5cbc226cbc leaflet: avoid wrong column resizing in mobile
problem: in mobile we could resize the column from anywhere in entier header

This caused problem because of the small size we may resize adjacent column

now allow user only to resize from resizing area even if resizing handler are invisible

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I12a071877548dda02a5c6199ade570c74f8dc7ee
2020-11-29 14:59:44 +05:30
Tor Lillqvist
353b7e93c1 Fix various problems in handling of non-BMP code points
Our existing function getValueAsCodePoints() returns an array of
integers that are Unicode code points, as its name says. (Code points
can be larger than 65535, especially for emojis and interesting
scripts). It does not return an array of UTF-16 code units (which are
always less than 65536).

Still, the code used the JavaScript function String.fromCharCode() on
the elements of the returned array. That function expects UTF-16 code
units, and it simply truncates the argument to 16 bits. This obviously
leads to very wrong results.

There is a function String.fromCodePoint() that would work, but it
isn't present in MSIE so we can't use it. Instead, introduce a new
function codePointsToString() that works properly, producing surrogate
pairs as necessary.

Additionally, the code in getValueAsCodePoints() that combines a
surrogate pair to a code point used 0x100000 instead of 0x10000. Had
this code been tested at all, one wonders.

Also, add some more debug output to the affected functions, bypassed
with if (false).

Fixes https://github.com/CollaboraOnline/online/issues/733

Change-Id: Id50d05ac95285edc93f1e3f5a2538a0732186476
Signed-off-by: Tor Lillqvist <tml@collabora.com>
2020-11-27 11:34:37 +02:00
Tor Lillqvist
702519549e Attempt to fix the "Copy Hyperlink Location" for desktop and Android browsers
This undoes the plumbing change in
0752631deac1e427294ebec932be6624df220452 for desktop and non-iOS mobile browsers.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I3452f18ec005a44c06ec7e4d17ede111c7c7e4c0
2020-11-27 11:33:23 +02:00
Pedro Silva
e6a54cf5cb Toolbar-down: menu: display scroll only when necessary
- do not use horizontal scroll

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I1ed11035188c93f7539eb2c031c5d180d6587977
2020-11-26 17:10:02 +01:00
Pedro Silva
56e2b1dc28 Sidebar: avoid using two sidebars by fixing bottom position
- set a fixed bottom position only when on calc (due to tabs)

Signed-off-by: Pedro Silva <pedro.silva@collabora.com>
Change-Id: I9f98cdc65e83c06da814fe7b89b43ebbe6760f40
2020-11-26 16:12:51 +01:00
Henry Castro
b6cdaa9284 loleaflet: update the document container when the size changes
Always call resize update when sidebar modifies the document
the size values, this will cause internal events to update the
document bounds, zoom, etc.

Change-Id: If8efce4b08b96e6156a87f69fe6188cf9d75f5d5
Signed-off-by: Henry Castro <hcastro@collabora.com>
2020-11-26 10:13:30 -04:00
Pranam Lashkari
af01832b82 leaflet: correct grammatical error
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Iad1cb19b68399e33cb852ceef4f5639ff2b52cab
2020-11-26 19:25:19 +05:30