Commit graph

19152 commits

Author SHA1 Message Date
Szymon Kłos
932543250b Extend scrollbar range when goes outside data
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9c80d74cab22076ea3fa4f65fa79ff0822a9bfe5
2022-11-10 12:12:10 +03:00
Szymon Kłos
48ec2f5925 Limit scrollbar range to used area in the spreadsheet
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I44ae52809b2f7ea9ac687f2b4c9f10f0592fbfd2
2022-11-10 12:12:10 +03:00
Szymon Kłos
96aa69a2fd Don't process status message two times
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Id1f0f76e8e0624aa322ffb9d8263295b44d73903
2022-11-10 12:12:10 +03:00
Szymon Kłos
eb4743a648 Introduce getDataArea in Calc
It will share information about real size of a data inside
spreadsheet so we can easily check where data ends.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I67137a4471f7eb4faaeeb680977872ccda8e9411
2022-11-10 12:12:10 +03:00
Tor Lillqvist
b65c82031a RequestDetails::_isMobile is unused
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ib2a6bb69b09776dbaf48216330f1c260299d9cac
2022-11-09 09:09:55 +01:00
Pedro Pinto Silva
162c7624bd Show not-allowed cursor when user mouseovers disabled items
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ie9f02a9d453ca269305f6c7e382d9dacf532dcc0
2022-11-09 08:56:26 +01:00
Rizal Muttaqin
76c47c0922 Signed-off-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
Change-Id: Icf386e7deef067c728d0b0d18438d4823918714b
2022-11-08 14:07:45 +01:00
Tor Lillqvist
be4dc66e00 Add a cross-referencing comment
Signed-off-by: Tor Lillqvist <tml@iki.fi>
2022-11-08 14:42:51 +02:00
Andras Timar
01bfc2bb66 do not explicitly require libzstd package in CentOS
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ic1aed2516f69d3ce2e65d28201d03c4fb65a4f0a
2022-11-08 11:27:30 +01:00
Andras Timar
a4b9c7479d Bump version to 22.05.8.2
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I94b9c70859d68ca2b8bc2c4ad4f39d9a8653cdde
2022-11-08 11:16:28 +01:00
Pedro Pinto Silva
b55f07a91e Don't use the same icon for online help and send feedback
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I2ca83fdde484d6db733e41cc15cd42245505e628
2022-11-07 15:39:02 +01:00
Pedro Pinto Silva
b7e0ca73da Duplicate and place Accessibility Check in the Help tab
Accessibility checker seems hard to discover. Users tend
to look for such feature in the Help tab (near to Keyboard shortcuts)
and after all we have plenty of space to place it in the help tab.

Better to duplicate instead of moving the icon altogether since it has
been there and we might already have a user base that expects to see
it there. On top of that it makes sense to be together with other
review related action.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibb5fa8b681faa5a16267f8a23cdbff0ee0d42ec2
2022-11-07 14:10:03 +01:00
Tor Lillqvist
e2cda4f15a Fix crash for LOK_CALLBACK_FONTS_MISSING in the mobile apps
We should just ignore that callback in the mobile apps for now.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ic1e2f79b23d75433a1f4c491bc31e43d4ebbe3c2
2022-11-07 14:29:22 +02:00
Ashod Nakashian
829ad12045 systemplate: include /lib/*/nss
It seems the location of the NSS dynamic
libraries have changed recently. This is
true on Ubuntu 22.04 and it seems on
Clear Linux.

We expected to find them in /usr/lib but
they are now in /lib. We support both
now, so the systemplate should work on
both new and old systems.

The symptom of not having the NSS libs
is failure to open password-protected
documents. The tests failed, which
helped to reproduce and debug.

Change-Id: Ifb4cbc4e2c852464ffcdcc19801689ea60355042
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-11-05 21:45:24 +00:00
Andras Timar
1cc374c9fa Do not require libzstd-devel for rpm building, because CentOS7 base repos do not have libzstd
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I41c5efcb02487914840ae6027b2b26f5c8d6711e
2022-11-05 18:59:18 +01:00
Pedro Pinto Silva
db3d429124 Fix missing icon for Line Spacing: 1.5
With the following commit
4e075146b9
we need to update css to use the same lc_linespacing.svg

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibd7131a69765b29d69de6d2bb53d1407df363345
2022-11-04 16:37:26 +01:00
Gökay Şatır
403e9739cf Enable print dialogue on FireFox browser.
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: Ib1a22ce30c9b84692c673196642cf0522035d5ea
2022-11-04 14:53:55 +03:00
Andras Timar
de16f8aef6 Bump version to 22.05.8.1
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I0f1431215742cb64a2a4599b059118111b8b045b
2022-11-04 09:27:37 +01:00
Tor Lillqvist
cc3d1ef721 Avoid the Send Feedback functionality in the mobile apps
That is only for web-based COOL. The mobile app stores have their own
feedback and rating mechanisms.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I6f28e27abdf204c7b77247136cc88924639efbd7
2022-11-03 16:04:35 +01:00
Tor Lillqvist
3fe40c13d0 Bump CFBundleShortVersionString to match configure.ac
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I76e35aad4115ad4dd7ddcd60b579d16ee3aa58d2
2022-11-03 16:41:12 +02:00
Rash419
737fff0830 docker: added docker file for arch linux to build from source
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I96a3f07e32fe0132be2081db11b62c666097057d
2022-11-03 13:47:57 +01:00
Tor Lillqvist
29ac04159f Fix the iOS app: Can't use %THINGIES% in cool.html.m4
There is no "file server" in the mobile apps that would expand such
percent sequences. The generated cool.html file is used as is.

Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I046c23c13ade6195f3f4a8b395ede7c42fc46bd2
2022-11-03 12:47:01 +02:00
Ashod Nakashian
9022c1059b wsd: improved UnitWOPILock to avoid race-condition
Change-Id: Ib91f53f4ebbfef8d93cebe24d48fea26df479dfa
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-11-03 05:17:05 -04:00
Pedro Pinto Silva
438b4e9411 Remove insert shape dropdown extra bottom padding
Before this commit the extra space was not used plus
it was making the popup bigger without necessity.

Referenced in https://github.com/CollaboraOnline/online/issues/2015

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6b2ba82b3d522f9673e555fb4f762b563c3a9c99
2022-11-03 11:18:52 +03:00
Pedro Pinto Silva
6d6e49e214 Fix statusbar display discrepancies when in readonly mode
Before this commit the statusbar was not being set with the
.readonly css class (already present in other main parent elements)
this, in turn was resulting in enabled and shown actions not proper
for readonly mode.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ife35a5f15c03681788bd16f007c338a9ddaeea52
2022-11-03 10:47:03 +03:00
Pedro Pinto Silva
01fcf38524 Code refactoring: avoid long statusbar css rules
We can instead, use the existent place for readonly hidden
button on Control.StatusBar.js

Also make use of _updateToolbarsVisibility to show/hide
disable/enable statusbar elements depending on permission mode,
this way changes take affect no only when statusbar is created
but also when we update it.

Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I5f7186f87740156c486d7a870bf2bfff6f828501
2022-11-03 10:47:03 +03:00
Michael Meeks
9a3b1738d7 calc: add InsertCells / DeleteCells to calc row/column context menu.
Thanks to Tracie Fabb for the tip.

Change-Id: I5e8a7cb833e0d9a6257fd73324cd1fa553de1fd9
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 15:48:37 +00:00
Pranam Lashkari
88b183bc05 UI: add missing file property setting button in UI
added button in file menu in desktop view in:
calc, impress and draw

added this button in mobile too.

this will allow user to check the property or change it (i.e: password)

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ie9b0776e291046231755739a3c0aa48323c67725
2022-11-02 15:37:26 +01:00
Pranam Lashkari
44d0575d57 pdf: fix comment intsert short cut
regression introduced in 47c52b90f3
regression PR: #5274

Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I7fc5b16b9d229c732437d921feb0bba7da5e0562
2022-11-02 15:57:43 +03:00
Tor Lillqvist
a3b0eda252 Give an example how to pass the zstd directory options to the configure script
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I23a38265f64d037480cb9b17caa8ce4a660f62a6
2022-11-02 12:12:11 +00:00
Tor Lillqvist
3862efd37e Don't recommend using /opt/libreoffice
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: I4cb27eaedf1af6bf2cdf1b21b43cc65d05a344e2
2022-11-02 12:12:11 +00:00
Tor Lillqvist
6656bc8ac3 iOS is only 64-bit since long
Signed-off-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ifa0aa1c1c129a42e8d0c70c34b12c94e371ed484
2022-11-02 12:12:11 +00:00
Michael Meeks
19dff9f281 zstd: decompress blobs for testing using zstd not inflate.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I8c2ea8b9cc3561485ec93428c1fe95a20be913fb
2022-11-02 12:09:53 +01:00
Andras Timar
8561b98791 Fix build with libzstd on iOS
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Idb94f5d359593e6098b7386ce0a9d33126d8ec2d
2022-11-02 12:09:53 +01:00
Michael Meeks
4d02d593b5 zstd: build for iOS.
Change-Id: Ifa2df0a0f9cf5bdfad5a513a37b64632b3e0a84f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
ccc2c4beb9 Simplify building multiple zstds for Android.
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Change-Id: I58f31f3ff7be19e4770accd88a7520cc112b1e47
2022-11-02 12:09:53 +01:00
Michael Meeks
a8c449642e Android - add --with-zstd-includes and libs and build instructions.
Also reduce cut/paste in configure.ac around checking for files.

Change-Id: I33f789e99ed79f08cb9cfa5ed147b764332adfde
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
abc469466a Clarify delta count updating.
Change-Id: Ie6d507d9aff80b90c97338ce1526a87ae0688394
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Andras Timar
d6b12ab9eb Require libzstd >= 1.4.0
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Ia2235a89e53c51766b6f23b647d307a4059cccc6
2022-11-02 12:09:53 +01:00
Michael Meeks
b57689a2e8 in-line ZSTD_minCLevel() call as a constant.
Change-Id: Ie0877b4c3cdc3111d3a35f9ed622d8903675b96a
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Andras Timar
203e953796 FreeBSD CI: require zstd
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: I2cc37caa5b32f637bc15175b730e57a978fe0d7d
2022-11-02 12:09:53 +01:00
Andras Timar
1d4c04e22d add libzstd dependency to rpm and deb
Signed-off-by: Andras Timar <andras.timar@collabora.com>
Change-Id: Id55c488d02aa187b3eaff978c3a84e2e12cd8e5a
2022-11-02 12:09:53 +01:00
Michael Meeks
e7b57b2fad delta: optimize away re-fetching of pixel data as we apply.
Avoid fetching and putting pixel data back to the canvas when we
apply a series of deltas to a single keyframe.

Also split high-level from low-level delta debugging.

Change-Id: If4c308b695fb236e0753490d0d20a0fef0a9a470
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Michael Meeks
2def6dc3d5 Switch to zstd image compression.
zstd provides for much faster compression server-side, as well
as better decompression.

zstd allows us to de-compress a keyframe and several deltas in a
single call in JS, so it is necessar to add a terminator to the
delta stream so that we can detect when to flush the buffer we
are working on - so the next delta applies to the correct data.

Change-Id: I0e292e3a697b4902d6488b7c04deaba2d1485e94
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Henry Castro
38764966dc browser: add fzstd lib
usage

	var decompressed = fzstd.decompress(compressed);
	// Second argument is optional: custom output buffer
	var outBuf = new Uint8Array(100000);

	// IMPORTANT: fzstd will assume the buffer is sufficiently sized, so it
	// will yield corrupt data if the buffer is too small. It is highly
	// recommended to only specify this if you know the maximum output size.
	window.fzstd.decompress(compressed, outBuf);

Change-Id: I0b378f9395b2442bac9f0790f7633e6a6cb0402e
Signed-off-by: Henry Castro <hcastro@collabora.com>
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
2022-11-02 12:09:53 +01:00
Szymon Kłos
0b86e55339 Dont set readonly on non-critical error
When we insert empty/not esiting image - we can continue...

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ib52f530d06dc8c5cd2780a08623435c440f9eb0a
2022-11-02 12:47:07 +05:30
Gülşah Köse
6302568c1c Limit the automatic addition of percentage sign.
In mobile view there is no way to select a cell and type something into.
We had to switch edit mode or use formula bar. So automatic percentage
sign addition is useless on mobile view.

Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com>
Change-Id: Ie0fca8121534a53304414d98e6fbdef82a349d89
2022-11-02 07:48:24 +01:00
Gökay Şatır
cf1074b640 Hide "Translate" menu button if deepL is not configured
Signed-off-by: Gökay Şatır <gokaysatir@collabora.com>
Change-Id: I52a02ab8380468b5dc56cb90a4d8edf2fab56c06
2022-11-02 08:56:25 +03:00
Ashod Nakashian
b43544da0f wsd: test: faster UnitInsertDelete::testPasteBlank
Change-Id: I4d58cc4c800a6fdd6b3096fe0f35e3c7c00c9c63
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
2022-10-31 17:32:34 -04:00
Szymon Kłos
1822ee1121 Dont show error for wrong shape content
This happens when second time embedded video was selected.

Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ide47c4927b5717a1f631356dd0f183b086f6a77a
2022-10-31 08:29:34 -04:00