Make the possibility to collapse/expand tabs more discoverable
by adding tooltip to the:
- selected notebookbar tab when collapsed
- selected nb tab when expanded
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ib75fc15fed6400557f6413a0d21be5c155fe8571
Allow tabs container to grow and shrink as needed so
document name is centered in between that container
and the next element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I8d252478a4ddfdb9362555db6797205369dab57f
This seems quite necessary to avoid missed-clicks between save icon and
File tab and also for white-space needs.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id2bd0e7bc2478684e1cb920cdb917dd43c9acc8f
These used to make sense in the past, when we had completely
different look and feel. Plus even back then this was not super
elegant way of showing that the tab container is draggable.
Furthermore, currently, the tab container is quite distinguishable
form its parent making it visible that the notebookbar-tabs-container
has more content to show.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e4c0d5b3bc5e0e21d6cd470446d13b9811846ab
canvas module is needed for make check. --disable-werror is
required, because npm canvas module is not available as a
binary package on all target platforms, and it does not
compile without warnings from source.
Signed-off-by: Yunusemre Şentürk <yunusemre@collabora.com>
Change-Id: I03e1d72d96ec0d6863ccd6236223a87ee481eb09
Reuse createIconURL so it runs through the iconURLAliases before
inserting image url
Example: Chart icon
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ia87b064c967df00c796d36fee577f4fd0f260a6f
Adding a margin to the first child only when it is selected is not
smart and causes tabs to move horizontally
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I89cb0c0e96cbb990ecdfb633f186ab5ea1c54078
- The repair document dialog is a leaflet dialog
- As this dialog is online-side only, I'll use the JSDialog builder
directly rather than writing a UI file
- Most of the code to build the dialogs is already very adaptable from
looking at the protocol of existing JSDialogs that come from the
server & where the code goes, however a small change had to be made to
dialog modifications to allow us a callback function, as otherwise we
would send off to the server whenever we pressed on a list item
- Finally, if there's no list to show, we'll show a bit of text saying
that there's nothing, as otherwise it looks like an empty/broken dialog
- If we're on mobile, we'll need to use the alternative helper (the one
that handles mobile wizard building)
- Fix a cypress test for writer (although impress and calc seem to have
tests for this too that aren't implemented: this should be handled in
a follow-up PR)
- Fix mobile tests
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Iab9e943a428e66b05e28819c2ee1001a2deffd2c
...when it's requested.
Previously always an empty string was returned on subsequent
calls, and the error message was only shown once.
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: I7645c7770e3e1712c8ef1b3ad145daec14530fb0
The event object in onContextChange has oldContext
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: Ic405edad4c52e51294d5fdfa5e91afa858d0bba7
Math is activated in-place, so we need to replace current elements with
Math-specific ones temporarily, on context switch. Application ID is
required for that.
Having previous context in the event itself would allow to drop storing
it in Control.Notebookbar eventually.
For now, only have Elements deck exposed for Math, because Options deck
needs either re-implementation to host everything in itself, or JS-weld
of Math dialogs.
lc_sidebar.svg images were used for .uno:SidebarDeck.ElementsDeck as a
temporary icon, until there's a dedicated image. See also tdf#149144.
Signed-off-by: Mike Kaganski <mike.kaganski@collabora.com>
Change-Id: I37dcda962a2a6ff60e301182033384c56615a24e
continue to use the pid as a short-ish label to disambiguate metrics,
but also define the pid with more labels in the 1st instance.
doc_pid{host="localhost",key="https://localhost:9980/.../hello-world.odt",filename="hello-world.odt"} 1261609
doc_views{pid=1261609} 2
doc_views_active{pid=1261609} 2
doc_is_modified{pid=1261609} 1
...
Change-Id: I573f6d5c8ceb9a7daee83d1f2ee9f42b8e0cd089
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
core.git supports both since commit
4063dcdc7305177b167bd20b009b1dfede8b25ec (Revert naming back to lool to
fix break with LibreOffice Online, 2022-08-26), let's go with the API
name, not with the product name.
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I204c4728628579edeb23d5ba76af4bb878130203
Particularly visible when on mobile and the conflict
dialog appears. Without this change primary button can shrunk.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id27761b53a425d16ab4bd2ef2a801890d899ee69
Form tests seems to be a bit unreliable due to toolbar down items
- Not be visible sometimes
- And when the zoom check up is too fast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4319db1a833335300780d052555f33afc976f33a
Before scrollbar-right would get in the way making it impossible
to click in the desired element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a00dfe8cddf503d39d8e7207b46bba1588f9b96
Better to make sure we only use those on desktop. Otherwise,
a tap can trigger undesirable rules (changing bg etc)
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I838328a55ee8943eccbbe8d69b99f76640fb3a69
Submit button should be last so to conform with the current order
used anywhere else.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Id794a608621b88076a80cc7ae8dda1e69512ca4f
No need to target #insert_comment solely
- Add generic class so it can be reused
- Do not absolute position etc
- Use flexbox
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ibeb1c517c5fd45b7a7774203cfa5e2a5210678ea
By Renaming .vex-dialog-button-primary -> .button-primary and
.vex-dialog-button-secondary -> .button-secondary
- So we can remove duplicity on CSS buttons
- Easier to set vex primary and secondary button to use our css classes
- This way there is no need to hunt those specific cases down.
- Update cypress tests
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82f4b33560367805eeeeb5aec9af8d1abd313788
You can now, since 1db5e39ef7 got merged,
rely solely on button-primary and button-secondary class.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Ic0eb08b443ab6c523d69e50df197eb0d3850fbd4
There are now too many download options to have each format as
an individual icon on the tabbed view. Plus with improvements
introduced in cbf5f1ad71
we can now safely set group_download_as to true as the default
value. Of course, it can still be switched to false if so
desired.
Notes:
Ideally, and if no one objects to it, we can later on and after
a period of testing remove this option and have only one way of
implementing/showing download options (as dropdown).
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1130684ec2ec54832f5a13648754d29ac71b9d35
Due to this error:
[ coolwsd ] TST testTileProcessed [testTileProcessed] (+12566ms):
ERROR: Assertion failure: Expected exactly the requested number of
tiles Expected arrivedTile == [25] but got [28]
| TileCacheTests.cpp:1580
Probably since 2cc955f9109c0fc8443c9f93c1bf6bd317043cb5 (core)
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: Ie854a57e4241f2c8fbf8e3d769aba8a19981feb1
Eg. if only the version was changed, config.h was updated, and
everything was recompiled.
New structure, maintain these manually:
config.h.in - for configured variables that are stable if
configuration parameters are unchanged
config_version.h.in - for version/hash related variables
----
config_unused.h.in - still generated by autoheader with all
variables, don't use it
Signed-off-by: Aron Budea <aron.budea@collabora.com>
Change-Id: Id9a50a9f1e798a3b3814778d8683b7d7cb57bb29
This should perform and still be reasonably compact even
for large numbers of documents.
Change-Id: I3820af6c23806d569c23a893bd8db040dfb351e8
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
