Apparently this will cause a regression on iOS; OTOH we have disabled
the landscape mode there for now, so hopefully we'll be able to come up
with the real solution there.
Change-Id: Ie39de95a68e34694e53b4034e8db389546515ba8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90907
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Broken since: b62dcc0255
The issue here cypress sets the window size and not the device size
when tries to emulate mobile view.
https://github.com/cypress-io/cypress/issues/970
For now, let's keep window size media rules too.
[tml: Window size changes depending on orientation. Device size does
not. We need to change each rule that used only max-device-width into
one using two subrules using max-width combined with comma (i.e. the
OR operator), one for portrait using 767px as the limit, one for
landscape using 1023px as the limit.]
We do this in other places of the css code anyway. In a long term, it
would be good to find a better way to emulate mobile view by cypress
or to detect mobile from JS code, so we can enable mobile mode easily
for cypress tests.
Change-Id: Ic7974f44fcbf6ed2883e93acd28153709514c216
I now think that much of our media queries with (max-device-height:
767px) actually should use (max-device-width: 767px) if the intent is
that they detect the case of mobile phones, as opposed to tablets.
Many mobile phones have a screen.height (which is what
max-device-height in CSS refers to) that is clearly larger than 767.
But a screen.width of 768 is what at least my 9.7 iPad has.
Change-Id: I3b44e32ec583837897b4aa390fc0ab92be59d163
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90752
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
updating css rules according to the latest html structure
Change-Id: I373e185a444e8f5db3096cd05c9f47f470ef73c3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90747
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I7652a5382b4a828ae21e8ce1cf6da21b7ce78b91
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90652
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I5208a74d4806b7b661e213db0a314b944be797de
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90684
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
This makes it easier to compare them.
Change-Id: If25f4c4dd3ee8a2a9d88d21521df6308857703a5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90674
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Change-Id: Ib57a926ea6597d8d8bdd26f9abf1e3d43f4afdf3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90606
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- Remove default gray elements for submenus
- Fix some icon sizes from 32 pc to 24 px
- Add new delete icons
- Add icon for data > group outline etc
Change-Id: I62e234d995fc6e875c5344715661dfd3202ef6a6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90557
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
to respect the height of toolbar-up as well as the main-nav element; Set 0 vertical paddings for the toolbar-up.
Change-Id: I4951b47a5c8b4fb34285c45b2ef9765245068b4a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90253
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Ibe9743fe7fe476c8d561b301ca82faea89dbccc6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/90078
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
In desktop-browser-online-calc, when the sidebar is shown, the
tabs/sheets bar is partly covered by it. This is a problem when there
are many sheets in the calc document because it is impossible to
switch to last few sheets because sidebar covers those entries in
the tabs-bar.
This patch adjusts the tab-bar container's width according to sidebar
width changes just like how formula-input canvas width is adjusted.
This also includes some css adjustments neccessary to hide the ugly
browser induced vertical-scrollbar for the child of tabs container
when adjusting the width of the container.
Change-Id: Iea3a658926d6f563a970bb9b6da9807818d36c26
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89897
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
In mobile vertical view impress slide previews were not visible
Change-Id: I24420577769e1124f9c7004ced54786522aa4bce
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89758
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
Change-Id: I1f419d485cefa387c35a9c42c9ac6671df909434
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89639
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I2b6a96865f770315d5a0b990ecc24b839271f763
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89547
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Ib10f93b66ab2f3f5f50e8ae520ec8755361ae0cf
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89534
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I27be9917d5f0df77bfdde9a8aeac129c934d58de
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89212
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I542aca8c98312bf32209625cc9acce68abc5280c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89210
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
It should be 'screen and ...', but since the other rules don't have
this additional screen condition, I just remove it.
Change-Id: Idabf28fbee303e19f1a5f5c75f3eb5e7387ac3fa
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89170
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I16e239bc132d779e63d60229472103720eec7500
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89051
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I4b3b6cd6f8fe99d7de5987dfea0013639bad946a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89042
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I7502de057122843d040ef1469c40815ce19e7178
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89022
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- Impress top position
- images position
Change-Id: Id3a5abc1c423169cb9f3d1bcb912171d1101c559
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89019
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: Ic2472ffd8e03463f56d7850d05d3ef5564093202
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89004
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I6c8d196952765c3018c8d00595d3fef9a93c23f7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89000
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- mobileWizard: force row elements to be full width and adjust accordingly
- edit FAButon: add press state and transition
- mobileWizard: fix white space that sometimes appears between header and content
- mobilewizard: make better use of space
- mobilewizard [non tab layout]: make use of flex to place content full width and aligned to the center
- Calc: mobileWizard: remove unecessary labels (format: NumberFormatCurrency, NumberFormatPercent, numberFormatDecimal)
- Calc mobileWizard: Fix placement of NumberFormat buttons
- Hamburger Menu: Fix positions
- Hamburger Menu: add missing icons under download as
- mobileWizard: make sure some labels do not wrap into a second line
- mobileWizard: make use of percentages instead of px regarding margins
- reduce svg size
Change-Id: I10e46a88cf04afe02cafa6d10931daee119be27b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88970
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Restore the media rules we used earlier for mobiles.
So for mobiles it's enough to have a small screen size,
for tablet we allow bigger screen size, but only with
special pointer properties.
Change-Id: Ic45f05c516ec44cd39c58463d8bf1907ec63c25a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88922
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Change-Id: I3e2022acd313a2d429220ae2c539c08e233b6317
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88865
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- Include phablet size
- Ensure that the mobile css rules do not kick in when on Desktop (900px window)
-- Detect if the primary input mechanism cannot hover at all or cannot conveniently hover (hover:none)
-- Detect if at least one input mechanism includes a pointing device of limited accuracy (any-pointer:coarse)
Change-Id: Idf1494acbd52ecd40e9082c8cf6f4ce88ecf9ac6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88862
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
- Percentage sometimes appears sometimes it doesn't. Removed percentage from values and instead added as suffix (via css)
- Content width changes. Fixed by setting a default minimum width
Change-Id: I4c2017ceaa98c97f06c7bba4dfe0f3aded9d605c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88608
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Change-Id: I894bb25a9198a74bf1fa43d6c958e23878e0a0fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88525
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
when document type is Impress
Change-Id: I33af9c10827f50be25a8490b7de8fe5504b06352
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88216
Reviewed-by: Henry Castro <hcastro@collabora.com>
Tested-by: Henry Castro <hcastro@collabora.com>
Still work in progress. The new UNO command is "MoveTabstop" with two
arguments: Tabstop (the index of the tabsetop) and Amount (in twips,
left (negative) or right).
The intent is that moving a tabstop in core will cause a callback that
will redraw the ruler, like moving a paragraph margin does.
Change-Id: Ic6b8b11811d2a7f6510c505fff421e1796300c70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/87868
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
