The input field is already being hidden for mobile. For Tablet and
with the increased amount of UI elements on the top bar best to hide
it also. Renaming the document is a quite rare used action when
compared to any of the other top bar actions (switching tabs, open
sidebar etc). Better to hide the #document-name-input when on tablets
instead of trying to fit everything (and end up obstructing tabs for example)
Tablet user can always:
- Use the integration (already used to do many other file manipulations) to rename the file
- Use the in-app Save as can still be used to save a copy of the current
document with a different name
----
Possible future improvements would be to add the possibility to rename
the file when using a tablet:
- Add menu entry and tabbed view button
- Control.Menubar.js something like {name: _('Rename Document'), id: 'renamedocumentbtn'}
- Control.NotebookbarWriter.js add bigtoolitem Rename Document
- Maybe in Control.UIManager.js add a renameDocumentBtn function that
- Creates a JSDialog with document-name-input element + Cancel btn +
OK btn
- Ideally that input element would re-use the functionality from L.control.documentNameInput() -> Control.DocumentNameInput.js
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I968e806a4a9e0018b38b87fc249a57e5af099c78
These used to make sense in the past, when we had completely
different look and feel. Plus even back then this was not super
elegant way of showing that the tab container is draggable.
Furthermore, currently, the tab container is quite distinguishable
form its parent making it visible that the notebookbar-tabs-container
has more content to show.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6e4c0d5b3bc5e0e21d6cd470446d13b9811846ab
Remove the now necessary max-width from tablets
- We now have those parent elements being set as flex box
and thus we have now no need to limit the max width of this container
- Plus by limiting the max-width we were hiding more of the tabs while
not gaining anything useful in return
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I1ef477902fd95a4751009f8bf08350b6ce88aa97
simplify the notebookbar.tabs-container:after and :before
use box-shadow similar to toolbar-up scroll-left and scroll-right
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: I236ae45f2418bb10be0ac76d4c1a406e487e759e
the following vars are not needed anymore
--gray-light-txt--color
--gray-light-bg-color
--gray-color
Signed-off-by: andreas kainz <kainz.a@gmail.com>
Change-Id: Ia23954e50629b60d3df50ea778c57de4e26bea88
In the wsd version git hash was getting set right after the previous
word (completely adjacent and without space and brackets)
- Fix outdated "loolwsd-*" class name and make sure the CSS rules does
get applied
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I77ea5ac19a5dbaa798437ec70489a1aee1051b1f
Those spaces and brackets are also needed when using tables
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I9af86ecddc335e212ad76700ce66531453db2274
