Commit graph

8 commits

Author SHA1 Message Date
Pedro Pinto Silva
bef32043d6 CSS lint: add more rules and fix problems
- Fix duplicated properties (ignore cases where it's needed
for browser compatibility);
- Fix space inconsistencies before !
- Fix space inconsistencies after colon
- Fix space inconsistencies after and before combinator (>, +, ~)
- Invalid calc
- Many rules added to json, namely no-extra-semicolons

Change-Id: I78af6bc546aeb1d7d7090e2ef278c895f0393a07
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102289
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-09 11:48:31 +02:00
Pedro Pinto Silva
175ac6e740 CSS lint: Code refactoring
- Detected many duplicated selectors within the same file (squashed them)
- Detected inconsistency (sometimes spaces sometimes tabs). Tabify as in JS.
- Detected quotes' inconsistency (sometimes none, sometimes '', sometimes ""). Use '' as in JS
- Avoid touching on files from 3rd party sources (jquery, w2ui), ignore files

Change-Id: Idd82945f29ac6c5c9f522e5d5df4a783a367654d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/102009
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-09-08 17:02:30 +02:00
Pedro Pinto Silva
1cbb871336 Mobile: Fix misalignment due to vex sizing
- make sure avatar container is set to content-box instead of border-box

Change-Id: I342f01136bee99a0154527f34703b323cd62aeb5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/101381
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-26 10:02:35 +02:00
Pedro Pinto Silva
dd9a70e1b2 Notebookbar: tablet: make tabs scrollable
Change-Id: I19a4667a08df3b75e71dd71763dca3ceef9f689a
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/99807
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Pedro Silva <pedro.silva@collabora.com>
2020-07-30 17:43:47 +02:00
Jan Holesovsky
0f96ad6569 tablet: Avoid gap between menu and the upper toolbar.
Change-Id: I25845dbe6ddae8f35885b94a9d01902f3a4daa9c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91649
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-04-06 12:06:55 +02:00
Jan Holesovsky
9af7932213 tablet: Make the upper toolbar scrollable with swiping as on phones.
Change-Id: I2118900f0f37fe6714691d1a9c054898cdac8a95
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91647
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-04-06 12:06:29 +02:00
Jan Holesovsky
351b231d22 mobile, tablet: Disable tooltips when on touch devices.
Change-Id: Ic5cebdcb8c3244643f09131c079a19d8ffd4e701
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91628
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-04-06 10:36:56 +02:00
Jan Holesovsky
9978752258 mobile detection: Create a separate device-*.css for the phone/tablet/desktop.
The problem is that the @media-based detection often disagrees with the
JS-based detection which then leads to many problems - most notably that
part of the UI behaves as if it was a tablet, and the other part as if
was a mobile phone, leading to a terrible user experience.

This commit changes it so that there is only one way how to detect if
we are on mobile phone, tablet or desktop: using the JavaScript, and we
will load the appropriate css accordingly.

Only one @media-based rule is converted as an example, the rest will
follow.

Change-Id: Id7bfb58ca12264904b3329db1542ae6b54893f11
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/91416
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2020-03-31 20:31:49 +02:00