rollbackPastChange function already opens the menu
so don't do it twice
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I930f669589da1f9e18840dae4013d81a49707639
prefer picker id, not palette id with number which is generated
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I52d30c3991b516378e82455fdc104b5d94e94f91
- The repair document dialog is a leaflet dialog
- As this dialog is online-side only, I'll use the JSDialog builder
directly rather than writing a UI file
- Most of the code to build the dialogs is already very adaptable from
looking at the protocol of existing JSDialogs that come from the
server & where the code goes, however a small change had to be made to
dialog modifications to allow us a callback function, as otherwise we
would send off to the server whenever we pressed on a list item
- Finally, if there's no list to show, we'll show a bit of text saying
that there's nothing, as otherwise it looks like an empty/broken dialog
- If we're on mobile, we'll need to use the alternative helper (the one
that handles mobile wizard building)
- Fix a cypress test for writer (although impress and calc seem to have
tests for this too that aren't implemented: this should be handled in
a follow-up PR)
- Fix mobile tests
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: Iab9e943a428e66b05e28819c2ee1001a2deffd2c
Form tests seems to be a bit unreliable due to toolbar down items
- Not be visible sometimes
- And when the zoom check up is too fast
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I4319db1a833335300780d052555f33afc976f33a
Before scrollbar-right would get in the way making it impossible
to click in the desired element
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I6a00dfe8cddf503d39d8e7207b46bba1588f9b96
By Renaming .vex-dialog-button-primary -> .button-primary and
.vex-dialog-button-secondary -> .button-secondary
- So we can remove duplicity on CSS buttons
- Easier to set vex primary and secondary button to use our css classes
- This way there is no need to hunt those specific cases down.
- Update cypress tests
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: I82f4b33560367805eeeeb5aec9af8d1abd313788
Adding attribute by jQuery and testing in cypress was
not working: visible value was correct after change but
in DOM we had original value which was tested by cypress.
Use val() to setup value and have.value for cypress to test.
Unify inputs so we don't use attributes but always props.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I1b3acccbd6d4ba493f867044b9b3c1f17b16873e
problem: when we click on checkbox to filter the data in autofilter dialog the checkbox itself disappear
if that is expected behaviour then cypress test needs to modified if not bug needs to be fixed first before
enabling this test
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I4dbfcf8abebe1c65e27c8c090bfce3ed0c59d086
- The test contains coordinate ranges for where the scrollbar must be
- As PR #5131 moves the scrollbars, we need to adjust these coordinates
so the test passes
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I6d037a304cc86553c47e81acbc63643742db2f66
Now it is merged on core side.
This reverts commit 4e3b34d6dd.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ie8f7e8f3e8d269af186e0a3d82aed73f63577789
There is no reason for custom handler.
Thanks to that we don't need special css.
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I9b576d4a6ef5668ec281c4e1348335d3b93bbac0
- The split cells test currently uses tunneled dialogs to make sure that
we can split table cells
- There is an open gerrit review to switch the split cells dialog to
JSDialogs (https://gerrit.libreoffice.org/c/core/+/137791) which is
blocked because the tunneled dialog needs to be removed in it, and
that fails this test
- This test needs to be temporarily disabled to give coreside a chance
to merge that review and build a new version of the libreoffice
archive. Once that has happened, this test should be replaced with a
rewritten version
Signed-off-by: Skyler Grey <skyler3665@gmail.com>
Change-Id: I0bb51e3cdbc04020e03c8d87696d014a0f693554
clickonIdle waits for the DOM element to be idle so test doesnot fail due to ui flickering
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I43b0800b23970326a4a6e84bfc662b67fea4f364
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ia2d75c75f40dffbe08d1c77e09c2331db18734f4
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I6adea1250bb4d54713e0a189b89930e82522a571
Our plain text clipboard output generated additional newlines
at the beginning of every paragraph. To fix that we need
fix in core side which now fails due to expected bad format in cypress.
This is interim state where we accept both old and new format.
see for reference: https://gerrit.libreoffice.org/c/core/+/136893
lok: don't pretty print html for online
Change-Id: I2b17d62398d947fcf1d3fb1ed6005c3063d114f2
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I70fa8be619a62709d6e5ada32b7a670f90d7b2bf
Since we remove a bottom padding in the toolbar-wrapper
with 3d27de7eb14e77cb4f0a94685b474ec2c42d6229
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Icf272e5c29455868cd43cf494935401ec10229e0
Added test for 2 emphasis animations:
- spin
- grow and shrink
Signed-off-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Change-Id: I3e5477b327e2d56776258cddf5de84617c1dc0a2
in desktop case color widget should show the latest selected
color not current one. split the button into arrow with dropdown
and "last color" button (icon)
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I07fcc94d69e14b030cf9f1bfe3ae50f0df333ec7
modify the test to use 2x2 table when testing 'insert column before/after' tests
no idea why we don't get svg when there is 3x2 table
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Id927fede691c4483206fa2b65c450f11cc980581
after the jumbo sheet patch selecting entire row and merging all the cells becomes costly and cypress timeouts
therefore select first 100 cells and test the merging functionality
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: I8568bbdbabdccc55c2938f886619a1d178ae7d22
Some places tested for AMJ being the last column, but with 16k
columns it's XFD. Without this those tests run in an endless
loop when run with Calc set to 16k columns.
Signed-off-by: Luboš Luňák <l.lunak@centrum.cz>
Change-Id: I6249e0ec975634b60aaf3291e021b74b4aa3cc5d
Identified the faulty test, on heavy load the test gets stuck on waitUntil command
skipped the test for now
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ia4b7ca081098e7e5b6f15135304131521629e524
so we will not have problem with updates not catching
widgets with modified name - not needed not
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ifa29d3971120482c3dae4ede3db5bcf31ea1af95
now we dont need to click on the collapsed comment
because now after insert comment they will be selected
already.
Signed-off-by: Mert Tumer <mert.tumer@collabora.com>
Change-Id: Ica69e5a092f29896c1d872deb384d31b867dddc6
No need to specify if it's first or second button as there is always
only one primary button. On top of that this avoids maintenance work
whenever for some reason the button is not the first in line.
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Idd3ef60023e88d1a9a8fd6f465dc4c63c068debd
Follow the same order as anywhere else such as annotations, JSdialog or
even tunneled dialogs:
primary action aligned to the left
Also update cypress test: Do not target button position related classes
instead, rely solely on main classes
Signed-off-by: Pedro Pinto Silva <pedro.silva@collabora.com>
Change-Id: Iac209aa343f22ddfdbd5662eba43d7adaa3f0892
- use .unoXXX class instead of id
- check only if height was changed on Optimal Row Height command
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: Ibfa93076237b15e16ae1851e3a66b4b239c42a2d
- add possibility to specify UNO command alias for newer
version of core so we will call all the versions for
compatibility of online with many versions of core
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I380fb1d2fd7f63bac297745401fa9d619f693348
