Commit graph

7557 commits

Author SHA1 Message Date
Samuel Mehrbrodt
40f80ea149 Change url to work in any version
Change-Id: Ie11c91d36d39b3a3ecc8eda01f556d25d3ef847a
2018-11-29 09:34:37 +01:00
Samuel Mehrbrodt
2e7f67f33b Show "Insert footnote" toolbar button only in Writer
Change-Id: I542a43b27f8d3beddad4c932a79812b404da63b8
2018-11-29 09:34:37 +01:00
Miklos Vajna
dc4712c3f9 wsd: limit_load_secs is not interesting for the mobile case, either
Change-Id: I92ad4bea80c261cc802ccdbebc1ce2990260853e
2018-11-29 08:52:57 +01:00
Miklos Vajna
0e312f9016 Fix gtk build: -Werror=unused-but-set-variable 2018-11-29 08:51:26 +01:00
Miklos Vajna
ae3fec55d4 StorageBase::FileInfo: make members private
Which shows that the _size member was unused.

Change-Id: Ic6e74659050b86cd9057971ec21623fad75f0c39
2018-11-29 08:43:02 +01:00
Tor Lillqvist
b4e3110d7b Truncate for logging at a bit higher limit
Change-Id: I352ef6476a9cde767b4076ad9a2ab8cf3c9bdf2b
2018-11-29 01:07:03 +02:00
Tor Lillqvist
235c9b8a60 Use getAbbreviatedMessage() for its intended purpose
Don't log a potentially very long message in its entirety.

Change-Id: I01fbf76465d99bbab117d1dcacc6c7239a1da518
2018-11-29 01:07:03 +02:00
Tor Lillqvist
efb883b21c Truncate received message string for logging if necessary
Change-Id: Id71968227236993e4d181370e68523f2bf6118a7
2018-11-29 01:07:03 +02:00
Tor Lillqvist
d361c00937 Append an ellipsis if the JS string was truncated for logging
Change-Id: I0bc2efff31e5c8d448e07e2457588fc638fb7a8f
2018-11-29 01:02:28 +02:00
Tor Lillqvist
0998cabbe7 Fix mis-merge (?), remove duplicated function definition
Change-Id: I7652515241f156d1722d2f626ec627d166d7b4ca
2018-11-28 23:13:54 +02:00
Thorsten Behrens
5eaaeb5bb2 loleaflet: remove TextWrap menu from toolbar
Since it's available already from the context menu.

Change-Id: Ia79a5f21b2d757621a3cb8d7114b90617c6c2acf
Reviewed-on: https://gerrit.libreoffice.org/64181
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-28 21:20:33 +01:00
Tor Lillqvist
3ad5ca0167 Bump CFBundleVersion
Change-Id: I0f7aada06d3161abb012292d54d326128411e233
2018-11-28 19:07:04 +02:00
Samuel Mehrbrodt
1dd1865286 framed.html: Use better defaults for URL
so that only the hash code needs to be changed (in normal setups)

Change-Id: Idde78ecc030573612128f0ee8d50ad95333fa72b
2018-11-28 16:46:24 +01:00
Samuel Mehrbrodt
46f318c358 resizeToolbar is undefined
But it inserting buttons seems to work fine even without that call,
so just remove it.

Change-Id: I831b171c57feed82e1ca778ba5a16a382f1786ee
2018-11-28 16:46:24 +01:00
Samuel Mehrbrodt
a9008c844d Display image url for buttons inserted with postMessage 'Insert_Button'
There was no <style> element in the <head>.
So we need to create it when it's not there.

Change-Id: Id0202b194e1438bd96401851d35e1f1630a78d8e
2018-11-28 16:46:24 +01:00
Samuel Mehrbrodt
c583195d62 Add clang-format config from core repo
Not enforced at the moment

Change-Id: I5e2b0def768e7b887425b6b0adc2c790565e42ea
Reviewed-on: https://gerrit.libreoffice.org/64148
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-28 16:46:11 +01:00
Michael Meeks
ff31b2cd81 Nasty hack to disable red-lining via config setting and the environment.
Change-Id: I67303fa9593c53a4575b4b45e2b2c879ae8ee890
Reviewed-on: https://gerrit.libreoffice.org/63137
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 2ff64d81ed3188994b755c0533526cc776f5c8c4)
2018-11-28 16:44:27 +01:00
Michael Meeks
c3f2cf88bb Avoid synchronous re-layout of comments / red-lines on each modification.
Change-Id: I698c6d47a58cfab2096900e01d19c8f4d4693fc4
(cherry picked from commit c48054f18a1c34d5460a2b9ec74fe57c122ef0a6)
2018-11-28 16:36:16 +01:00
Tor Lillqvist
b9694c305b Adapt after ed9c756c9e
Change-Id: Ide7ab1544039d11d478c30cc8fd9c09b1d1f6894
2018-11-28 12:41:43 +02:00
Samuel Mehrbrodt
8f1abe4839 Only add the host to frame-ancestors
not the whole URL with all parameters

Change-Id: I42e3a6a4c05410284afea51bb13ac3f692b243ef
Reviewed-on: https://gerrit.libreoffice.org/64147
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-28 09:53:35 +01:00
Miklos Vajna
ed9c756c9e StorageBase: make members private
Rename getUri() to getUriString(), so getUri() can expose a const
reference to _uri.

Change-Id: I0cd0faf08ba31bdf6a605be657e7ca2cf5fb33a6
2018-11-28 09:07:35 +01:00
Tor Lillqvist
192677b34f Don't hide the font and font size widgets in a mobile app
Once the Format>Character... dialog works better in a mobile app we
might revert this. But for now the font selection feature in that
dialog is sadly practically unusable.

Change-Id: I60ae6469a588b50b5e2acb5a6a04a04271b1ca47
2018-11-27 18:48:59 +02:00
Tor Lillqvist
3c046b0548 Add --with-iosapp-fonts option to bundle some 3rd-party fonts in the app
Propagate the font files found in that folder to Info.plist and to the
app bundle.

Change-Id: I2c38b0d7d21dbdf3b7ffd3b4ae98e47b9ad74758
2018-11-27 17:06:22 +02:00
Tor Lillqvist
4f37dcaa81 Include the Liberation fonts
Change-Id: I016e158c650a8ae57b7e0b17a763f997d5532abc
2018-11-27 15:33:29 +02:00
Tor Lillqvist
a2e1f383b9 Implement document saving properly to make saving to NextCloud work
Even if the LO core code, as called by the Online code, already has
saved the document back to the file from which it was loaded, in order
for a file provider extension like NextCloud to notice that, it is
essential to call saveToURL:forSaveOperation:completionHandler:. The
contentsForType:error: method can just return a NSFileWrapper for the
same, already saved, file, though.

Change-Id: Ic063c8603ca38930083866d973e500336cad517e
2018-11-27 13:55:39 +02:00
Tor Lillqvist
ab67cb58f9 Fix m4 problem introduced by me a month ago
MOBILEAPP does of course not expand to empty if it is not defined as
an m4 macro, it stays as is.

Thanks to samuel_m for noticing.

Change-Id: Ia76062b347627289adab0c1d6635f03850a0f2b3
2018-11-27 13:28:58 +02:00
Miklos Vajna
0f2fa202c0 LocalStorage::LocalFileInfo: make members private
Change-Id: Ibdbf35275e2b2f0b935a301fe77a54aef51e4514
2018-11-27 09:09:29 +01:00
Tor Lillqvist
8dee781542 Use the right version name and git hash for the iOS app
Propagate the information to the otherwise pre-canned iOS version of
config.h, too.

Change-Id: Ia459a20b529e2ea02b4e00894521a085a8806d57
2018-11-27 01:05:04 +02:00
Tor Lillqvist
ec23c39687 Don't create a link in the Help>About for LOOLWSD either in the iOS app
Change-Id: Ifa10bf0996258edf32108bde1b922fb6d097c0de
2018-11-27 01:01:02 +02:00
Tor Lillqvist
fe3832f3c6 Use --with-iosapp-name to set the name displayed in the Help>About dialog
Change-Id: I04b0e7c152ee69b038ec30549c203a54eecf4780
2018-11-27 00:35:57 +02:00
Tor Lillqvist
191d7bfa35 Don't create a link to the git log in Help:About in the iOS app
We don't want to bother with creating a new view showing the link for
now.

Change-Id: I917a7646af4b472d3a2d32389ed5bc63a4157b7a
2018-11-27 00:18:53 +02:00
Tor Lillqvist
b0673178b8 Bump CFBundleVersion
Change-Id: Ie2e9349c99bd9f6f3e87191469c6ee39f3fb92ca
2018-11-26 19:47:32 +02:00
Tor Lillqvist
24e09f4edd Bump CFBundleVersion
Change-Id: I0ca058c14a78074eafaf585373694f36164146e0
2018-11-26 19:07:33 +02:00
Tor Lillqvist
823a4bf88e Fix further fallout from e27ae38beb
One more special case where we do want to do the whileScrolling
callback from the onUpdate callback: When selecting another sheet of a
multi-sheet Calc document. Handle it by adding an optional parameter
to setPart() in Parts.js from _serPart() in Control.Tabs.js, that
eventually gets passed down as the "scroll" parameter to
_onUpdateCursor() in TileLayer.js, which turns on the special
handling.

Change-Id: I44772912a0598b78bef182f1b6147ff91d6c88e9
2018-11-26 13:47:28 +02:00
Miklos Vajna
54e4147887 httpwstest: 'emplace_back' is called inside a loop
Pre-allocate the vector capacity before the loop to avoid realloc waste.

Change-Id: I78370d79728ae66446d2b979d376cb50ba3ae864
2018-11-26 09:43:17 +01:00
Michael Meeks
d34f0d5b7f Show cursor, even with a selected graphic / shape. 2018-11-24 21:22:46 +00:00
Samuel Mehrbrodt
296aba1bea Improve allowed frame-ancestors
Beforehand, any host could embed the iframe as the Referer was always allowed.

Now, only the loolwsd and the WOPI host are allowed to do that.
Additionally, a config option has been added to add more allowed hosts.

X-Frame-Options supports has been removed as it supports only one host
and CSP is meanwhile supported in ~all major browsers.

Change-Id: I222720e1220116102708c50edaf08e2a4a0aebda
Reviewed-on: https://gerrit.libreoffice.org/63864
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-23 16:33:55 +01:00
Tor Lillqvist
df5d96efa8 Fix scrolling when moving the cell cursor outside view in a spreadsheet
Follow-up to the touch pinch zooming fixes in
e27ae38beb. Need to pass the special
calledFromInvalidateCursorMsg property to the scrollto handler here,
too.

The calledFromInvalidateCursorMsg property is now slightly
misleadingly named. Should rename it to something that covers both use
cases.

Change-Id: I232b6a40708c7635fcebef37ff5640e1ba9eaac5
2018-11-23 11:43:07 +02:00
Tor Lillqvist
a9f6d57222 Correct a few leftover mentions of "Mobile/Mobile" to "ios/Mobile"
Change-Id: Ie2e44bda495f3a08fc91c8d9fe40f9d1d9607283
2018-11-23 11:26:57 +02:00
Tor Lillqvist
a6eadf4e81 Move the iOS app to the ios folder
Change-Id: I46e0722b027e93f90b5cd6a74cd7dc46f6c8cea2
2018-11-22 16:50:57 +02:00
Michael Meeks
d967a33308 Don't squash dialogs into just the area of the map. 2018-11-22 14:11:59 +00:00
Michael Meeks
4618b6c9c3 mobile: use more generic names to share with Android.
Change-Id: I747c6d384071d3a43d43c3c3f801efdfac0a1825
2018-11-22 14:11:59 +00:00
Michael Meeks
4440a99504 Android build readme.
Change-Id: Ic82a3d7eb6148a5117d393f5fcb8d5413ef9f41b
2018-11-22 14:11:59 +00:00
Andras Timar
052c033e92 tdf#121429 PDF writing needs NSS libs in systemplate (2)
Change-Id: I3724114867986a7ff2494b6b360b1680d7661bcc
2018-11-22 14:28:21 +01:00
Tor Lillqvist
e27ae38beb Fix jumping after touch zooming also for mobile clients of normal Online
Don't check window.ThisIsAMobileApp but instead use a much more
convoluted test to catch only the cases where we do want the document
to be scrolled, and ignore the case that causes the irritating
jumping.

In _onUpdateCursor() in TileLayer.js, we know that the scroll
parameter is not undefined when and only when _onUpdateCursor() is
called from _onInvalidateCursorMsg(). We pass that information down to
the onUpdate callback handler passed to the _tweenTo() function in the
_scrollTo() function in jquery.mCustomScrollbar.js where it shows up
as property of the options object.

In that location we also make use of the incidental fact that
options.timeout==1 only when that code is called from mouse-wheel scrolling.

Quite possibly all this could be done much cleaner.

Change-Id: Iefa257bceb54137f25534ccb6786c1d2e315931c
2018-11-22 14:58:56 +02:00
Andras Timar
9606c29d64 tdf#121429 PDF writing needs NSS libs in systemplate
Change-Id: I478058168d8288a1e9bced66ba58b1bb26e556bb
Reviewed-on: https://gerrit.libreoffice.org/63721
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
2018-11-21 21:59:40 +01:00
Rene Engelhard
f4dc010395 add net/FakeSocket.hpp to Makefile.am, otherwise missing in the tarball 2018-11-21 20:43:10 +01:00
Jan Holesovsky
ef828372c2 mobile menu: Fix the z-index to cover the document's custom scrollbars.
Change-Id: Idc29cfaa12f5bbf3971e29c49aecb8c5bed5f49d
2018-11-21 20:23:23 +01:00
Tor Lillqvist
e7523c9888 Factor out tile pixel size to a global setting
For now the same as before, 256, for both normal Online and mobile
app. If you want to experiment with another value, you only need to
change it in loleaflet.html.m4. I hope.

Note the FIXME in loleaflet/src/core/Socket.js.

Change-Id: Ic881758d7fa70bbfebcf932b7ed6a1da352e375d
2018-11-21 19:42:27 +02:00
Tor Lillqvist
0656ed4990 Brown paper bag fix
My previous commit broke scrolling for normal Online with touchpad
(and presumably wheel mouse). So do it only in the mobile app case.

Change-Id: Ia085549b66ed4584c75d5efb78948f19a33c7907
2018-11-21 19:28:20 +02:00