Incoming message are stored and handled as soon as the js bundle is
loaded and the ui is ready.
At present this solution has been selectively enabled for the
following types of incoming messages: 'window', 'statechanged',
'celladdress'.
Change-Id: I22e98ff11c67140deb639295273be9533560536b
Reviewed-on: https://gerrit.libreoffice.org/85028
Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com>
Was a problem introduced by c6f36965cf.
Change-Id: I8fbc722ed73af19a6462c87242d431eea118f1a2
Reviewed-on: https://gerrit.libreoffice.org/85020
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Now the Hamburger works and the sidebar updates
are more accurate.
Change-Id: I2f8df05801297d8ec29bf1d966624f06df685d31
Reviewed-on: https://gerrit.libreoffice.org/85010
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Because we can't control the sidebar when in Chart edit
mode, we must have it active before we start Chart editing.
Besides that, on mobile we show/hide the sidebar quite
frequently, and there is no point in activating/deactivating
the sidebar on every tap.
So we have the sidebar enabled in the background at all times.
We then track whether it's visible or not (window.mobileWizard)
and show/hide it. Furthermore, we now handle the sidebar
close notification from Core, which we don't expect, really,
now that we don't close it. However, we need to have a way
to re-activate the sidebar when it is closed. Something
we don't do right now, and we need to tack the Core
sidebar state as we can only toggle the sidebar.
Change-Id: Id7774b84cd0604055c708eb0912e17988f5823d2
Reviewed-on: https://gerrit.libreoffice.org/84974
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Makes no sense to have an own language switching mechanism in the app...
Change-Id: Ic19bf36e35d1d011a1cd96c17b713e41577c512e
Reviewed-on: https://gerrit.libreoffice.org/84980
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Thanks Tobi for the hint!
Change-Id: I00b7ef4aaef7ced1d26d3d5636189e239897ecea
Reviewed-on: https://gerrit.libreoffice.org/84979
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
The document should have the focus after
closing the hyperlink dialog
Change-Id: I5f4cf4f2cabe92b97e60a4d118ba67255f598c0b
Reviewed-on: https://gerrit.libreoffice.org/84933
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Mert Tümer <mert.tumer@collabora.com>
Change-Id: If2fa4caab1b5d1f43fb28e4ab806e09140a54cb3
Reviewed-on: https://gerrit.libreoffice.org/84955
Reviewed-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
Tested-by: Pedro Pinto da Silva <pedro.silva@collabora.com>
To have the menu translated.
Change-Id: I8d4d90d260aa3fcd80a8eb68515b22c58c9b3e18
Reviewed-on: https://gerrit.libreoffice.org/84931
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
After commit 3dce52c307, this is the right
thing to do again.
Change-Id: I3c34ee258677af59bfc7a55abcb09c4b7f3611a2
Reviewed-on: https://gerrit.libreoffice.org/84903
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Don't clear selection unconditionally. _clearSearchResults() method
is called by mouse click and we don't want to clear selection
during opening a context menu.
If there is any search term then we can clear the selection,
otherwise don't change it.
Change-Id: I8f672e4d6d30e9bb3828a39e591a64598a7a8722
Reviewed-on: https://gerrit.libreoffice.org/84885
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
disappears, also fixed language selection
does not work at all
Change-Id: I1349e6ccc786f4c17130f14ff95e44f4ea858550
Reviewed-on: https://gerrit.libreoffice.org/84845
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
while rename sheet popup is focused and same document is opened where else
popup used to lose the focus and document is focused.
So the name used to get typed in document instead of popup
Change-Id: I18aa3ba9d5485fd9f5928635aa611d7db5771495
Reviewed-on: https://gerrit.libreoffice.org/84794
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Currently it can open files both from the ownCloud and Nextcloud
storage, but so far it seems that it cannot save back to ownCloud.
Unfortunately both the libraries have the same namespace, so to have
both the ownCloud's and Nextcloud's library in the same .apk, we'll need
to use some additional tricks.
Change-Id: I7fd647a42d3bd90b6268017ae392d61f67f548c0
Reviewed-on: https://gerrit.libreoffice.org/84874
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Many reports said it was broken, so let's disable before anybody
actually tests it & fixes.
Change-Id: I179de3774c0fb4be018e59cd629936a9d565dc15
Reviewed-on: https://gerrit.libreoffice.org/84873
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
All these cases should be covered:
* user's explicit save via File -> Save
* autosave
* autosave on exit
Implemented via IntentFilter magic, we can call back from one activity
to the other to perform the actual saving in the shell.
Change-Id: I97d6e94028a9600a71f030af7146ee01163d09b8
Reviewed-on: https://gerrit.libreoffice.org/84872
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
The library bundled in the LibreOffice sources didn't work for me
neither with ownCloud nor with Nextcloud.
Change-Id: I88ee06bdffeed3229643575ffb274432582eaab8
Reviewed-on: https://gerrit.libreoffice.org/84869
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Gosh that was painful. But now they seem to be correct.
Some other clarifications and improvements. Also start trying to
handle touch device dragging in the tab stop area, but that handler
doesn't get invoked yet, and anyway any code to actually move the
nearest tab stop is missing.
Change-Id: I187bca84da70f03f5dcf032b997e43b5e54d7879
Reviewed-on: https://gerrit.libreoffice.org/84574
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 4b48ee682cf65fb3a7024e9a6e2cebe046847194)
Reviewed-on: https://gerrit.libreoffice.org/84797
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Draw only the user-edited/able ones. Draw all four kinds (left, right,
center, and decimal) the same for now, as a small triangle pointing
up. (Drawn using a CSS trick to get a triangle.) The tab stop
positions aren't actually editable yet, nor is there a way to add a
new tab stop or delete one. Later.
The code uses a CSS custom property, yay, to avoid duplication of a
magic value for the half-width of the triangle.
Change-Id: I862b09091bad03ad63425cc6e6759f3f13174579
Reviewed-on: https://gerrit.libreoffice.org/84474
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 5e6976f6eb23d742db7e8f9b334b521a299f2418)
Reviewed-on: https://gerrit.libreoffice.org/84764
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
No reason to make the code even harder to understand by using
variables that don't vary but hold a constant value. Especially when
the variable names don't match their constant value.
No changes in what the code does.
Change-Id: If98ef6cdd741e76e8b4e383d005486736bf227a3
Reviewed-on: https://gerrit.libreoffice.org/84763
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
There is too much state that isn't necessarily in sync. Get rid of
some of the coupling.
Instead of turning on the catching of touchstart events in the
_changeInteractions function, which does not work if you tap the
make-editable button before the document has been loaded completely,
start catching them right away after creation, but in the handler, the
_initiateDrag function, ignore the event if the "map" is not yet
marked as editable.
Change-Id: Ief7a98e9b6ffa4db9d41f558d1081687032c4bcc
Reviewed-on: https://gerrit.libreoffice.org/84235
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit 4e42bae4a73fe8342921f4d695e9c84e723e3f33)
Reviewed-on: https://gerrit.libreoffice.org/84762
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Fire the 'scrolloffset' event also in
L.Control.Scroll._onUpdateScrollOffset(), which gets called when
panning a text document on a touch device.
There are still glitches in updating the ruler when one uses a pinch
gesture to zoom the document. But usually after a short moment the
ruler snaps into correct state.
Change-Id: Ic8dd5139ff49f6fe7961096552f1c7e6cf35356c
Reviewed-on: https://gerrit.libreoffice.org/83996
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/84048
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Note that in this branch it seems even harder to touch a margin handle
in the ruler exactly in the right spot to be able to drag it. You will
have to use your smallest finger and point very exactly. And still it
works only sometimes. (But I did get it to work once, honestly, so
ship it!) This obviously needs to be fixed, but cherry-picking this
commit as is for now.
Several changes:
On iOS, use touch events instead of mouse ones. One difference between
touch and mouse events is that the touchend event naturally does not
carry any position information (as the finger has been lifted from the
screen). So we need to keep track of where the last touchmove event
happened separately in _lastPosition.
Letting go of a margin handle after dragging it did not actually move
the coresponding margin in the document. The fix for this was to catch
the touchend event for the this._rFace element instead of for the
this._map element.
Once a margin had been moved, it could not be moved another time. The
reason for this was that because the document initially is readonly,
the this.options.interactive was set to false (see the
L.control.ruler() call in loleaflet/src/map/Map.js) and never changed
after that. This caused _updateBreakPoints() to pass {perm:'readonly'}
in the call to this._changeInteractions(). The fix was to set
this.options.interactive to true when turning on the interaction.
In theory this same problem probably would happen also in web-based
Online on "mobile" (i.e. phones), but we don't show the ruler there at
all, so the sitaution where a document would be initially read-only
and the ruler would show up doesn't happen.
Reviewed-on: https://gerrit.libreoffice.org/83807
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
(cherry picked from commit caf37fb293a666b0a82ac8bd31df35b18b45fc01)
Change-Id: I0393704d02a2989b4ea3358dc4bee17e48c16ae6
Reviewed-on: https://gerrit.libreoffice.org/84047
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
