strepsirrhini/libreoffice-online
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
6569 commits 1 branch 0 tags 244 MiB
Commit graph

230 commits

Author SHA1 Message Date
Miklos Vajna
eedfe0add4 UnitHTTP: make sure function defined in header is inline to avoid ODR violation 
Change-Id: If81ecbe1a73a73c093614f0ad5285558302e13d0
 2018-05-22 09:12:40 +02:00
Jan Holesovsky
088acf5e98 Before we kill the child, check it exists, ie. kill(pid, 0) == 0. 
Also warn when anything was left out.

Without this, we leave abandoned children around.

Change-Id: I293a530ffceeb7f6bdc0cc775335c782945de6e7
 2018-05-18 15:16:40 +02:00
Michael Meeks
071079a6a9 seccomp: allow socket shutdown in kit process. 
Change-Id: Ie11f5eb278bcba8dcf13d6f095de2ffd6d23fcb3
 2018-05-18 15:16:40 +02:00
Jan Holesovsky
6996139e5f Use correct path in the client websockets. 
Change-Id: Ie0bf6646ff3f6e6cf99b505143a416c86a3a33b8
 2018-05-18 15:16:40 +02:00
Ashod Nakashian
b59f5c2c65 wsd: log proper ISO date in YYYY-MM-DD format 
Change-Id: I8851c044bad43a03a99f7471be97ea77c58f7be8
Reviewed-on: https://gerrit.libreoffice.org/53266
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/53316
(cherry picked from commit d50850337b1cad5ce93678079085a97316f1f48e)
Reviewed-on: https://gerrit.libreoffice.org/53318
 2018-04-23 11:53:23 +02:00
Michael Meeks
81fd84cf4e Move UnitHTTP code to header to avoid linking trouble. 
Change-Id: I430110e840fa8b3862c21c1d4e02288ed704e0a3
 2018-04-17 16:50:48 +01:00
Michael Meeks
03bbe52665 Ensure the forkit does not have lingering threads after preinit. 
Change-Id: I216a03a0ada628189355ebfd4016bf6033430eef
 2018-04-16 20:04:23 +01:00
Jan Holesovsky
c8ef63253a Sanity-check the scheme and host for frame ancestor, POCO does not do that. 
Change-Id: Ieea9532ccd2a11e74f370a340e68f46122469848
 2018-04-04 12:50:53 +02:00
Miklos Vajna
5736f4c307 common: mark parseJSON() as inline explicitly 
Otherwise this can lead to an ODR violation.

Change-Id: I1b195cb57d37a050755d7d3f6c922950ef8738c4
 2018-03-19 11:58:18 +01:00
Michael Meeks
6803ee4087 Use a hard random /tmp directory for document intermediates. 
Requires a lok tweak to reset the tmpdir globals on init.

Change-Id: I602705f20fa016ef415088be8d1ada6d465d2a8d
 2018-03-15 11:01:51 +00:00
Rene Engelhard
abf489991f fix --disable-seccomp build 
Change-Id: I32008de7745e106e4a633fb587f2837c59cdd541
Reviewed-on: https://gerrit.libreoffice.org/50652
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2018-03-03 12:07:07 +01:00
Ashod Nakashian
5befd0803a wsd: improved wopi info parsing 
Better logging during wopi info parsing,
especially upon failures.
Refactored the code from Storage.cpp into
JsonUtil.hpp.
Minor optimizations.

Add unit-tests for the parsing logic.

Change-Id: Ifebc3f6b7030a6c7b3b399786633f6b5e8737478
Reviewed-on: https://gerrit.libreoffice.org/49927
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-02-23 16:54:39 +01:00
Ashod Nakashian
7be98efd93 ut: log timestamp to track timeouts better 
And improve the logging support in unit-tests to
help troubleshoot issues faster and more accurately.
Also makes the code more readable (hopefully).

Change-Id: I4f8aafb5245e2f774b03231591a74544f9ec84aa
Reviewed-on: https://gerrit.libreoffice.org/48645
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-02-11 19:21:15 +01:00
Pranav Kant
39f11ab4f7 document conflict: unit test 
Change-Id: I4ea310fe5adb198bc7b5e083f6bd4b0431c0cdef
 2018-02-09 00:22:57 +05:30
Pranav Kant
ad1da235d3 IME support 
Dialogs still need to be adapted to this. Only works for documents as of
now.

Change-Id: I0fb1114e279a9e563943f3f65dd5a577523e9841
 2018-02-08 14:16:34 +05:30
Miklos Vajna
9eacfe4fcb common: spell out non-trivial autos to improve readability 
Change-Id: Id13bc0e48cec845f5b05171128be5b4efc05c6bc
 2018-02-07 10:18:12 +01:00
Henry Castro
f269a9321c follow up, avoid logging when closing file descriptors 
Change-Id: I38432ae1d042094551d22c2512a416c3b345556b
 2018-01-31 17:53:58 -04:00
Henry Castro
b1f1500b56 util: avoid logging when closing file descriptors 
eventually the log file descriptor will be closed and unhandled exception it will throw it

"terminate called after throwing an instance of 'Poco::WriteFileException'
  what():  Cannot write file"

Change-Id: I1d6ae3a4d4d4910f2ed2cdc80b162c27f93d55d9
Reviewed-on: https://gerrit.libreoffice.org/49055
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2018-01-31 22:06:57 +01:00
Miklos Vajna
222399e99a common: avoid pointless copy in Util 
Change-Id: I40097203eba6fede78a17caf057452f4704b2bd4
 2018-01-30 16:09:33 +01:00
Michael Meeks
d3c17510ed Implement an improved fork/exec wrapper. 
* logs helpful messages for various error corner-cases.
* optimized file descriptor closing for large fd counts.

Change-Id: I8cba9ecb3d71ddc6e22e20d89368d8c6b9b5097f
 2018-01-29 15:20:10 +00:00
Pranav Kant
c16d198560 Print humanized bytes in the logs 
Change-Id: I2ebdea0c3a360be1573ae13fa9cbe6f432436f29
 2018-01-26 20:03:22 +05:30
Ashod Nakashian
c06376cc1d wsd: cleanup logging and remove unused helpers 
Now all logging is done after checking if the
level in question is enabled or not (thanks to
the macros LOG_XXX), which saves unnecessary
conversions and stringification when said level
is disabled.

Change-Id: Icde31e067f60269563896f04f8b0d65643720766
Reviewed-on: https://gerrit.libreoffice.org/47885
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2018-01-19 00:33:40 +01:00
Tor Lillqvist
e834526983 Add FIXME 2018-01-15 14:22:56 +02:00
Tor Lillqvist
7bf59d8f64 Add Util::startsWith() to check whether a std::string starts with another 
Odd that we have managed without such a helper for so long, or did I
just not find it?
 2018-01-15 13:39:48 +02:00
Ashod Nakashian
5f175c5120 wsd: save documents before recycling 
Change-Id: I24afc5c1bceca272f23a129609f73fc5a8d3caf2
Reviewed-on: https://gerrit.libreoffice.org/47739
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-11 08:13:16 +01:00
Ashod Nakashian
59398af621 wsd: simpler and more efficient OOM killing 
Change-Id: I118abdffba4e7ab57fe6a29a3a9fc420d871bdc0
Reviewed-on: https://gerrit.libreoffice.org/47738
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-01-11 08:12:09 +01:00
Pranav Kant
1353408999 loplugin:includeform 
Some files weren't rewritten from the last run.

Change-Id: I8c5beadaf2cf9b367158abe6f0a5460fa3054521
 2017-12-21 20:09:03 +05:30
Pranav Kant
f63858433b loplugin:includeform 
Change-Id: Ib62a7aa61062f00698aa3e8a144438de5c57e53d
 2017-12-20 21:21:05 +05:30
Michael Meeks
864b07f5b3 Annotate string pointers in hex dumps to make sense of memory. 
Change-Id: I7934ccf379dbca9862ddb911865aaeff692261bf
 2017-12-15 22:45:04 +00:00
Pranav Kant
849eb0d500 lokdialog: Adapt to LOK dialog API changes 
Change-Id: I653304e71573eb253e09a72bc87d54b8554ba7ff
 2017-12-04 22:13:50 +05:30
Michael Meeks
26876e6165 loolmap - read the parent's page data for unshared pages too. 
Change-Id: I23bb319fa4694638efc82c7af86224d2e041160c
 2017-11-30 13:33:25 +00:00
Michael Meeks
0778b72697 Dump hex contents of un-shared memory. 
Change-Id: I47dfa8a0b48d0ba34b7462301b83e2721617814d
 2017-11-29 03:33:16 +00:00
Aron Budea
f6ec965dff rlimits: Friendlier and more precise logging of numbers 
Unlimited settings were logged as huge numbers.
In two cases settings were logged via LOG_SYS (and as errors)
instead of LOG_INF.

Change-Id: I1da493c0126ecf9d2382956ac1e60e57988696ee
Reviewed-on: https://gerrit.libreoffice.org/44731
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2017-11-23 21:15:39 +01:00
Rene Engelhard
623b45a533 fix build with poco 1.8.0(.1) 2017-11-13 20:21:22 +01:00
Miklos Vajna
bb7ac21d44 Make sure that loop index type is never narrower than the length type 
Change-Id: I19aac80850c0371085ca6364412d5ac9207220d0
 2017-11-06 09:14:38 +01:00
Miklos Vajna
a3d6dee503 Remove unused strings 
Change-Id: I621c462bca38222dcf26dfa1e414cf27e1a3e088
 2017-11-03 15:25:09 +01:00
Jan Holesovsky
343c5bc690 tdf#99744 SaveAs: Extend test to check that the Save As result was sent. 
Change-Id: I3788b87d2599c01000af97f496ee2b840c0cae3e
 2017-10-26 11:11:38 +02:00
Tor Lillqvist
73d77a9f67 More -Werror=implicit-fallthrough= 
Change-Id: I62164eef3a4f95bfe505b3b1a866495bde6c19b1
 2017-10-26 11:51:53 +03:00
Pranav Kant
e9e162b35e lokdialog: Mouse/key events, canvas use & child window impl. 
Change-Id: If8ae5c284e7166d4a01bd664644134f11197f988
 2017-10-25 00:39:03 -07:00
Pranav Kant
de780f8253 lokdialog: wsd: first cut at lok dialog rendering api 
Change-Id: Id522e0796428ed0a15ea3496e6726f51ed232e75
 2017-10-25 00:37:41 -07:00
Miklos Vajna
7ab856b196 common, wsd: clean up redundant casts 
Change-Id: Iad7e2417c6b1a154f6ad21839b841ca452e835c5
 2017-10-24 09:23:54 +02:00
Jan Holesovsky
262916363d rlimits: The fsize and nofile need more tweaking... 
Change-Id: Ifdb4d24f103f54fd286b8ffa715c0a61c2cff94f
 2017-10-06 15:42:53 +02:00
Jan Holesovsky
92aca7f2dd Compile the support key in (when configured to use one). 
Change-Id: Iffff0b95b245b91d9732a774a6026a3cec2b2222
Reviewed-on: https://gerrit.libreoffice.org/43185
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Andras Timar <andras.timar@collabora.com>
 2017-10-06 11:39:29 +02:00
Jan Holesovsky
783e3552c0 Support key logic in loolws + improvements in loolconfig. 
To be able to set the support key directly from the command line, and to show
the option, etc.

Change-Id: Iac93bc47a6f4b9d5a5ad0ac8b06bda978e01b760
Reviewed-on: https://gerrit.libreoffice.org/43098
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2017-10-06 11:37:18 +02:00
Michael Meeks
79053911fc Support key logic and verification. 
Change-Id: Ie55150b99df3e80239236571af185502196ad3e9
Reviewed-on: https://gerrit.libreoffice.org/43097
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
(cherry picked from commit 56385cb8ac2a57af4eb70bc8bc7313a9299533c3)
Reviewed-on: https://gerrit.libreoffice.org/43099
 2017-10-03 21:52:45 +02:00
Jan Holesovsky
7f49b1eba6 PutFile ext: X-LOOL-WOPI-IsAutosave header to indicate autosave + unit test. 
Change-Id: I65ed711dae5100467fe6ed9902bd7bad8c7f8d68
Reviewed-on: https://gerrit.libreoffice.org/43074
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
 2017-10-03 12:04:18 +02:00
Marco Cecchetti
e015c83957 fixed wrong logging text 
Change-Id: Ife3bdf05e15a9f11227c37eec6af0719cd8b2e5a
Reviewed-on: https://gerrit.libreoffice.org/43033
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
(cherry picked from commit 8f9cff124763285e0bb7cc98d96770b98367eafb)
Reviewed-on: https://gerrit.libreoffice.org/43034
 2017-10-02 10:55:27 +02:00
Marco Cecchetti
ee6e64528d wsd: support for FSIZE and NOFILE system limits 
The routine for handling the configuration for the max file size
limit, was wrongly using NOFILE. Now we handle both limits correctly.

Change-Id: Ie8b63617286f66af6d4eb1b35b9e4f4b28f3c2a6
Reviewed-on: https://gerrit.libreoffice.org/42803
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
Tested-by: Jan Holesovsky <kendy@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/42811
Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
Tested-by: Marco Cecchetti <mrcekets@gmail.com>
 2017-09-26 17:40:31 +02:00
Michael Meeks
be228a160d Allow unit tests to avoid handleInput. 
Change-Id: Ib4accd6bbfdc1fc55c45365df275edfa8a68bc59
 2017-09-19 21:13:58 +01:00
Michael Meeks
5c879a17b2 Count key-strokes, and report per session. 
Change-Id: Id661fc15d4a75e322024ce62d24b2d7dae8f256a
 2017-09-11 19:00:10 +01:00