Commit graph

133 commits

Author SHA1 Message Date
Pedro Pinto Silva
f401f1f714 Hamburger menu: adding ids (so it uses the respective icon) and adjusting cypress file
Change-Id: I33ad1671cc859ea1af1350f3e3d3a83b33c355c5
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89532
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-26 12:41:57 +01:00
Pedro Pinto Silva
f3b8455aaa Mobile: Insert: Add missing icons, add missing ids, create missing icons, also add sub level icns for footerandheader and formattingmark (fixing cypress)
Change-Id: Id3ca33095b5eae7d13129f4b9629e2c0faf302fb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89371
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-25 12:06:31 +01:00
Tamás Zolnai
907a23bf0c cypress: mobile: improve shape geometry tests.
Change-Id: I46b2384da6c406c66e3f5d19838df1e87804b2a9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89390
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-25 00:37:42 +01:00
Tamás Zolnai
b77cd954e0 cypress: use different test files for different test suits.
Change-Id: I29ad09ce99128fe6700070e23cf66dfc0c553b70
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89389
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-25 00:33:32 +01:00
Tamás Zolnai
ca2fe5fa91 cypress: mobile: disable an unstable focus related tests.
It's unstable now, how focus behaves with shape.

Change-Id: If429420852599315bff5d71f33f263f1d79a356c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89380
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 22:14:25 +01:00
Tamás Zolnai
4f864162e4 cypress: mobile: update table related tests.
Change-Id: Idd65edc8d3c007afec9e93e0a103379c579a178c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89379
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 22:10:38 +01:00
Tamás Zolnai
5ff34b20c5 cypress: let's make the pid file under workdir.
Change-Id: Ib927b7d4c29c623de8cd4bf083843a7a6a7c9c2f
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89374
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 19:43:23 +01:00
Tamás Zolnai
a7da409624 cypress: make sure that npm packages are not installed more times.
When we build with more jobs.

Change-Id: I1051825ec8db4ccc7e10bd4a599480a97334538d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89373
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 19:40:24 +01:00
Tamás Zolnai
131f4c340c cypress: mobile: this test has an unexpected side-effect on other tests.
No idea why is that. Maybe cypress has an issue in it somewhere
or loolwsd is doing something. Adding a small wait avoid the
failure.

Change-Id: Ic1b29c34f9990fc4937105925872655a98793f79
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89372
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 19:35:55 +01:00
Tamás Zolnai
55b4fb9ec7 cypress: mobile: simplify this test.
Change-Id: Iaf076f35eeabd7609da024a4f3236a52e69bb543
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89362
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 17:16:26 +01:00
Tamás Zolnai
48bca31c9e cypress: mobile: make selectAllMobile() more stable.
Change-Id: Id8b919e3e0a18b28746541ee2a65e52f85458fa9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89353
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 16:05:13 +01:00
Tamás Zolnai
2a6dd836c3 cypress: mobile: update shape related tests.
After:
11b7270acd

Default zoom changed -> shape is insert to different
position -> geometry changed.

Change-Id: Ibeed3a57b3b64962951f11054f6aa3410a0e673d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89345
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 15:00:56 +01:00
Tamás Zolnai
a1eaa97954 Revert "cypress: mobile: split this test case."
This reverts commit c692487acc.

Pushed accidentally.
2020-02-24 11:54:47 +01:00
Tamás Zolnai
c692487acc cypress: mobile: split this test case.
So it might be more stable.

Change-Id: Ie8b8a13ebfe9b681a8e9a456f24f6322ce9cc8a6
2020-02-24 11:36:43 +01:00
Tamás Zolnai
9484ec73d1 cypress: disable an unstable check here.
Focus is not consistent around double taping.
Enable this check again when something is improved here.

Change-Id: I448d57a9fd053d1680352b6d6175f38f3dda33d9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89331
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-24 11:16:27 +01:00
Tamás Zolnai
75451d9fb6 cypress: use parentheses consistently in the make file.
Change-Id: I3d679fe99749222a6ab56c952d5d3fa09a6dd3d7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89238
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-21 20:25:43 +01:00
Tamás Zolnai
3f0afa9cfa cypress: better handling of npm package dependencies
For incremental builds, it's not enough to check the node_modules
folder, we also need to check whether all used binaries are in
place.

Change-Id: I9c5f380f3845195bfa2dbfb03ab269ce4659c4ae
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89233
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-21 19:47:22 +01:00
Tamás Zolnai
fdcdcedbfa cypress: don't wait on loolwsd server forever.
Use one minutes timeout.

Change-Id: Ia4e351088d7bd152b4c7f47c66dce2a88f14970c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89232
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-21 19:43:27 +01:00
Tamás Zolnai
f6a5b90612 cypress: remove obsolete comment.
Change-Id: I9d8293ed27cb756325ffde48f3bcf37f390a1651
2020-02-20 17:10:24 +01:00
Tamás Zolnai
389720d948 cypress: mobile: make mobile wizard navigation more stable.
When we open a new panel in the mobile wizard the new
content appears after a short animation.
I suspect that this animation makes tests to fail sometimes
with 'detached from DOM' error. Waiting the end of the animation
seems help on this issue.

Change-Id: Ie9cc322ff9bd9a6287b4d57126e6afab91a98713
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89107
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 17:08:05 +01:00
Tamás Zolnai
7810825e6b cypress: mobile: make paragraph panel related tests more stable.
Change-Id: I6d6d9e8f2f6d14406327ae074f1e82e411f508cc
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89091
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 13:41:29 +01:00
Tamás Zolnai
c211ce95e2 cypress: mobile: enable some shape related test which are stable now.
First issue was rendering the mobile wizard twice by
opening. I added a workaround for this issue:
20b5825ce5

The second issue was with the animation when moving
one level down in the mobile wizard. Checking the next
level content makes these tests more stable.

Change-Id: I3f3c90e5975747f833e9560140cabb6c310dfe57
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89087
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 13:14:38 +01:00
Tamás Zolnai
be9333bf5b cypress: try harder to kill loolwsd server.
pkill uses SIGTERM signal by default, which is good because
using that makes loolwsd to clean up things before shut down.
For example it removes the pid file.
However, when loolwsd stuck for any reason, then SIGTERM might
not be effective. In this case use SIGKILL.

Change-Id: I3ed4bd24d6e73169b4d04dd7c9b4ac03bee8fdd1
2020-02-20 13:13:52 +01:00
Tamás Zolnai
bde5059f19 cypress: mobile: update test title.
Change-Id: I01751b3f3f25391fd6d846e133dc4fc3e5ff84df
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89076
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 12:00:18 +01:00
Tamás Zolnai
9eaecc1b06 cypress: mobile: Fix-up hidden style items test.
Without waiting for the mobile wizard to be opened
the not exist check will allways pass no matter
whether the items are actually hidden or not.
First we need an indicator that the mobile wizard
is opened and then we can check whether the removed
styles items are not there.

Change-Id: I00c1aaf6e11351cf8714be3ed6d5b9d2ff000324
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89074
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 10:19:38 +01:00
Tamás Zolnai
eb4f5abf52 cypress: kill only our own loolwsd process.
Change-Id: I9c6f71571183c7583bd3c4c122c3c3e2c04696ea
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89070
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:45:25 +01:00
Tamás Zolnai
39150fca06 cypress: better way to generate allowed port numbers.
Change-Id: I1900df07f1fe76d39a35ab8cab0d62c0c53a35f9
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89069
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:44:57 +01:00
Michael Meeks
c07f45e4e5 wizard: hide styleupdate as well as stylenew.
Also hide calc style panel for now: incomplete.

Change-Id: I46fee97f5d029860a12e5f7215d830091c5f9bf0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89068
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-20 05:21:51 +01:00
Tamás Zolnai
16578f0353 cypress: mobile: Disable spellchecking tests for now.
There is no an obvious reason for this issue and also
I can't reproduce this issue locally.

Change-Id: I6860fa878ebafd9deab92b2662c352a99ab85b52
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89071
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 05:02:22 +01:00
Tamás Zolnai
eb53dd5a8c cypress: Always search for an available port number.
Change-Id: Ibfb80d43cd7f7d4c8cab8e3621bebfc2201d4b2d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/89066
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-20 04:49:38 +01:00
Tamás Zolnai
0a7e3bf30f cypress: mobile: Test whether the line width spin button is readonly.
Change-Id: I628594902b87dbc904628b8815c520fdb01478c6
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88976
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-19 11:05:05 +01:00
Tamás Zolnai
2e9f59280c cypress: mobile: Test that the arrow style item are hidden.
Change-Id: I958357acb912176070e45ac331b38d42ba24cd15
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88975
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-19 11:03:22 +01:00
Tamás Zolnai
08d801b7d6 cypress: mobile: Disable this test for now.
Recently fails randomly with core/master.

Change-Id: Ib8003c2b82b773a2851b251cba838533d040b3e5
2020-02-19 10:33:48 +01:00
Tamás Zolnai
eeadcb5a40 cypress: mobile: Disable shape related tests for core/master
Will investigate the issue which causes to fail these tests.

Change-Id: Ic71d0fccb200a3c51d927be62d9d39301c0c3064
2020-02-19 10:33:48 +01:00
Tamás Zolnai
248fa4f21f cypress: mobile: Introduce a method to workaround wrong mobile wizard content.
Change-Id: I59ceb56f049378c3e236822b0059d0413e107b95
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88973
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 18:33:57 +01:00
Tamás Zolnai
28029dce14 cypress: mobile: Add more tests for changing shape line properties.
Change-Id: I7eb2132b591f081087dca1999ce81e002ccd5101
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88972
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 18:33:46 +01:00
Tamás Zolnai
7de5068426 cypress: mobile: Update table reated tests.
There is no focus any more after selecting the
table, so we need to use a different method for
moving the cursor in the first cell.

Change-Id: I9d03337d7cb710224a892472f0989896d2e03024
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88971
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 18:27:32 +01:00
Tamás Zolnai
23d1adcbcf cypress: mobile: Add some tests for changing shape properties.
Change-Id: Ibd437591c9b32af242416aadcbe5683ddfeb04c3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88874
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-18 16:15:19 +01:00
Tamás Zolnai
dfd44336b0 cypress: desktop: Fix-up copy-paste test.
Change-Id: I936315ae60e0f1bcd245fa8c361a511a690809a8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88877
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-17 18:06:57 +01:00
Henry Castro
cefcfcfe19 loleaflet: mobile: use hyperlink tag for context menus
Change-Id: Iac83687794c90ff3439e7a5c833d24007ec52ec3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88545
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-17 15:58:11 +01:00
Tamás Zolnai
466eedabb0 cypress: mobile: Add some basic tests for spellchecking context menu.
Change-Id: I9ff2ce361670e407e8823f08c253e60bde3e8657
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88719
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-14 16:23:49 +01:00
Tamás Zolnai
f7d232d758 cypress: Create workdir in the builddir.
Change-Id: Ief5a74412b7e12350d83b3af4345bf813288065c
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88628
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-13 20:14:18 +01:00
Tamás Zolnai
3b500642d4 cypress: Fix build failure related to field insertion.
Use en-US locale. In the tests of date / time fields
the date format contains the locale, which was set to en-US
originally.

Change-Id: Ida56dd8a3e64b0c81d70d010f3aabf40da7d73a0
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88620
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-13 18:53:34 +01:00
Henry Castro
a420aef10d cypress: makefile: fix running specific test
buildir != srcdir

Change-Id: If3f33b546d9c6a95ba214d2d26213ca95fe52e2d
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88605
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-13 15:31:04 +01:00
Henry Castro
ff7cd32ba2 cypress: ensure English locale
My browser is Spanish by default

Change-Id: I2f3a2aaf7a6b0856c778dc9b943e23f8c168a394
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88568
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-13 15:30:29 +01:00
Henry Castro
c2de19b368 cypress: makefile: fix build dir expansion
builddir != srcdir

Change-Id: I8243fb28782bbe123b65ec86a36770323092b9f8
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88561
Tested-by: Henry Castro <hcastro@collabora.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-02-13 15:29:51 +01:00
Tamás Zolnai
5d41b930e6 cypress: mobile: Organize tests based on component.
Change-Id: I49f6e76b219e4c55add05b5a8489e51c518625ab
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88553
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-12 19:14:42 +01:00
Tamás Zolnai
f8116809f7 cypress: mobile: Fix up calc focus test.
Change-Id: I674f7b6945b367f9c7a9541681a56f4c556c1cb7
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88552
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-12 19:14:25 +01:00
Tamás Zolnai
f93e3a4eda cypress: mobile: font size combobox works now with core/master.
Fixed in:
18dd0254a38ca91d0d325aaecc4227724c035d87

Change-Id: I1e74d8f031cd5bfe1c74ab06693b2c39e97cc866
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88551
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-12 19:14:10 +01:00
Tamás Zolnai
8f4143dd74 cypress: mobile: Update shape related focus test.
One tap on a shape does not move the focus on the document
since this commit:
9fcd4d3777

Change-Id: I5d176be7c5dd8296c642c41b8d1e2fcf5945ab27
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/88521
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-12 13:26:33 +01:00