Ashod Nakashian
fae850189d
loolwsd: include cleanup and organization
...
A source file (.cpp) must include its own header first.
This insures that the header is self-contained and
doesn't depend on arbitrary (and accidental) includes
before it to compile.
Furthermore, system headers should go next, followed by
C then C++ headers, then libraries (Poco, etc) and, finally,
project headers come last.
This makes sure that headers and included in the same dependency
order to avoid side-effects. For example, Poco should never rely on
anything from our project in the same way that a C header should
never rely on anything in C++, Poco, or project headers.
Also, includes ought to be sorted where possible, to improve
readability and avoid accidental duplicates (of which there
were a few).
Change-Id: I62cc1343e4a091d69195e37ed659dba20cfcb1ef
Reviewed-on: https://gerrit.libreoffice.org/25262
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-21 15:52:54 +00:00
Miklos Vajna
b0b9648e28
Remove unused 'using' decls
...
Change-Id: Ibdcf0a0fe2390712059e6e70c47bd60f6416c6be
2016-05-19 16:42:41 +02:00
Jan Holesovsky
1166fff924
Fix non-https build.
2016-05-10 11:48:12 +02:00
Miklos Vajna
c2fc95ac23
Drop unused using declarations
...
Change-Id: Iee778833781c6f00c1fb0b8fc1975acfe4fb0cd9
2016-05-10 09:14:22 +02:00
Jan Holesovsky
a27a22b563
Add purpose comments.
2016-05-02 18:03:09 +02:00
Miklos Vajna
78308db763
loolwsd: remaining 'unnecessary copy' fixes
...
Change-Id: I138e8473a002a15aae7752136950bb905a21fb1f
2016-04-27 14:58:33 +02:00
Tor Lillqvist
842525c25c
Guard against mixing up cout output from separate threads
2016-04-20 18:54:18 +03:00
Tor Lillqvist
5c0788254b
Add "exit" command and comment syntax to input files for the 'connect' program
2016-04-18 21:31:57 +03:00
Tor Lillqvist
fe5f238c08
Exit when receiving an *unexpected* CLOSE frame
...
Otherwise we will just keep waiting for a line on input from stdin,
which is unhelpful.
2016-04-14 17:45:51 +03:00
Tor Lillqvist
0140b1cd43
Always define ENABLE_DEBUG and _SSL in config.h, as 1 or 0
...
Correspondingly always use #if, not #ifdef, to test.
2016-04-14 13:43:31 +03:00
Tor Lillqvist
26ceda2f15
More specific message
2016-04-13 11:49:00 +03:00
Ashod Nakashian
435b706f9a
loolwsd: must include Poco/Version.h to define POCO_VERSION
...
Change-Id: I7dbabff60a9fe100caff2af357b8539126c3c003
Reviewed-on: https://gerrit.libreoffice.org/23940
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-04-09 19:55:18 +00:00
Tor Lillqvist
407f688cb6
Include config.h to get ENABLE_SSL
2016-04-08 14:49:33 +03:00
Andras Timar
f75a27e3db
loolwsd: --disable-ssl option
2016-04-08 13:16:49 +02:00
Tor Lillqvist
d379ed2113
Improve logging and orderly shutdown
2016-04-01 18:57:07 +03:00
Tor Lillqvist
418fc3f203
Use SSL here, too
2016-03-22 20:06:44 +02:00
Tor Lillqvist
9d655cbcc0
Don't pretend this will work on anything except Linux
2016-02-29 14:25:12 +02:00
Tor Lillqvist
32dc0a3c87
Don't ever attempt to handle the payload of CLOSE frames
2016-02-23 20:03:52 +02:00
Ashod Nakashian
291b0aac67
loolwsd: don't ignore the last few bytes of a closed socket
...
Change-Id: Id6332857e49ccbacfa6e63b87a1ed570e9598147
Reviewed-on: https://gerrit.libreoffice.org/21680
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-21 16:03:29 +00:00
Ashod Nakashian
88b76fe9d4
loolwsd: removed dead code
...
Variables and options lingering from previous iterations removed.
Standardizing static member names.
Header inclusion cleanups.
Change-Id: I65182ad4d100e0077f1b450be50cf95d7b8f0fc7
Reviewed-on: https://gerrit.libreoffice.org/20997
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-28 23:36:55 +00:00
Ashod Nakashian
d273057488
loolwsd: moved config values into common header
...
Change-Id: Ib88379e453f207a6a5e6223045a393c769082be4
Reviewed-on: https://gerrit.libreoffice.org/20978
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-28 04:09:50 +00:00
Tor Lillqvist
86b846d137
Accept URI on the command line
2015-05-27 16:27:52 +03:00
Tor Lillqvist
3e9c4d4bf3
Use a separate HTTPServer listening for child processes connnecting
...
Otherwise, if we use the same port number and same HTTPServer, if enough
clients try to contact us and, we won't be able to accept child processes
having been spawned.
Also add some temporary debugging output here and there to debug lifecycle
management issues.
2015-05-08 21:30:32 +03:00
Tor Lillqvist
e9f3e815fe
Don't try to run the 'display' program if there is no $DISPLAY
2015-04-24 18:18:56 +03:00
Tor Lillqvist
4f9739854a
s/localhost/127.0.0.1/
...
Makes the chrooted child process more reliable on diverse distros/versions.
Let's use 127.0.0.1 in all cases for consistency.
2015-04-23 18:52:19 +03:00
Tor Lillqvist
3abb6d0307
Now the chroot etc re-work is getting closer to working
...
Works now for the trivial 'connect' test program. Still need to add
pre-spawning of a new child process as soon as an existing one from the pool
has been taking into use. And need to test with the actual JS client.
2015-04-22 21:44:17 +03:00
Tor Lillqvist
a4480e2a8e
Add "sleep <n>" pseudo-request
2015-04-22 21:43:32 +03:00
Tor Lillqvist
0a60ea9dcc
Bump Emacs fill-column to 100
...
The default 70 is so last century.
2015-04-22 21:43:11 +03:00
Tor Lillqvist
cec37456ef
Set no receive timeout
2015-03-27 16:53:51 +02:00
Tor Lillqvist
bb162a6ba7
Add trivial test program for sending commands to the LOOL server
2015-03-27 16:23:20 +02:00