Use new functions for querying the properties of comments.
Added new functions like setAsRootComment, getChildrenLength etc.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: I9b655f0e6d50050f9e509ba4f822e1d8681a4a69
* When a parent comment is removed, the children of that comment are not informed.
* We have adjustParentRemove function.
** Function wasn't handling the "parent is removed" case.
** Function was handling the "child is removed" case in a wrong way. Children list has pointers, not indexes.
* When a parent is removed, child wasn't shown. Now we re-set the display property in case it was set to 'none' before.
* getSubRootIndexOf function was trying to continue with index=-1.
On mobile, a reply was added twice, fixed.
Signed-off-by: Gökay Şatır <gokaysatir@gmail.com>
Change-Id: Id8f95bbe1cb78bf93bf35fe73a6e86203455691c
- the HttpEcho build broke with commit
08d9081280 (net: don't try to set
TCP_NODELAY on local Unix sockets., 2023-10-30)
- fix an unused variable error from commit
0631593c96 (wasm: proxy wopi documents,
2023-11-06).
- the undefined reference to COOLWSD::ForKitProcId probably went wrong
in commit 3f46c1db44 (kit-in-process:
pure re-factor to a run-time function to flag this., 2023-11-20)
Signed-off-by: Miklos Vajna <vmiklos@collabora.com>
Change-Id: I0cf06d188860bdb2f795485a91c7634b596255aa
The container '#presentation-controls-wrapper' element should
adjust height value when '#presentation-toolbar' is shown.
Change-Id: Ia44006e5b99f0ec08632cc171a8e23e9b6f67614
Signed-off-by: Henry Castro <hcastro@collabora.com>
This reverts commit 9b3e115fb5. It was
meant to have been dropped without being merged, but #7619 was merged
with it in
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I698c7a0aa680a1b8155c08c8d292f609522fe347
Make sure we don't expect response from server for online-only component: dropdown which doesn't have corresponding widget in the core
fixes regression on close from:
commit a23adac78c
browser: fix undefined property 'isPopup'
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Change-Id: I005647c77da3a866cec88a78f03dd409a098a469
StorageConnectionManager centralizes the
connection creation and management of
Storage sockets and related bits.
This is needed as we move to a more async
model of communicating with the Storage.
Change-Id: I7a44c95c113bbc536e922b5aa3f7cf9b71917c22
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
This ignores the hints from commit
f62f365a0ed26b21e1f86b0e028cf80fc6b2b9df when not using calc. This is
because they were causing an undefined reference in WASM.
(window.keyboard.guessOnscreenKeyboard). To me, this looks like a bug in
our WASM implementation, as I think WASM should get window globals, but
as it's blocking us we're partially rolling this commit back.
I expect to revert this revert as soon as it no longer breaks WASM.
Signed-off-by: Skyler Grey <skyler.grey@collabora.com>
Change-Id: I91bab273d400bf7925e338631e74dabc8a01e529
problem:
In a spreadsheet, click on a cell with content,
In the formula bar, select the content in a way that the mouse key is lifted outside the edit field
Note how the formula bar doesn't get into edit mode, but you can still edit the content
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: Ib4f193b897d57e0ffa9c3bfdd598e0c3c4201195
problem:
In Calc click on a row header and drag the mouse. The selection does not follow the mouse,
selection only appears when you release the mouse button
Signed-off-by: Pranam Lashkari <lpranam@collabora.com>
Change-Id: I510f35d9f61fca63a619e83c04ff340f9578f5d2
- specifically a case where coolwsd is cleaning up the document
we don't want to give up on clientside and show the error message to
user
Signed-off-by: Rash419 <rashesh.padia@collabora.com>
Change-Id: Ie75fa3e19f97ca18acc8e881813d6c617fc9f7b7
- Allowed downlaod options for PDF/PDF as /EPUB
- PDf/PDF as/EPUB will be downlaod in read only mode
Signed-off-by: Darshan-upadhyay1110 <darshan.upadhyay@collabora.com>
Change-Id: Ic6e0c4a16fa5dffc61e61fd4ece9aeeaec1450b9
- We now have a state for hidden buttons in UIManager
- Shortcut bar makes use of it instead of maintaining its own.
https: //github.com/CollaboraOnline/online/issues/5957
https: //github.com/CollaboraOnline/online/issues/7517
Signed-off-by: Hubert Figuière <hub@collabora.com>
Change-Id: I719f27063f01e4d76742358189b080087881ab7c
